0785c2f6fc
This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```
148 lines
3.0 KiB
Go
148 lines
3.0 KiB
Go
package docker
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func testConfig() map[string]interface{} {
|
|
return map[string]interface{}{
|
|
"export_path": "foo",
|
|
"image": "bar",
|
|
}
|
|
}
|
|
|
|
func testConfigStruct(t *testing.T) *Config {
|
|
var c Config
|
|
warns, errs := c.Prepare(testConfig())
|
|
if len(warns) > 0 {
|
|
t.Fatalf("bad: %#v", len(warns))
|
|
}
|
|
if errs != nil {
|
|
t.Fatalf("bad: %#v", errs)
|
|
}
|
|
|
|
return &c
|
|
}
|
|
|
|
func testConfigErr(t *testing.T, warns []string, err error) {
|
|
if len(warns) > 0 {
|
|
t.Fatalf("bad: %#v", warns)
|
|
}
|
|
if err == nil {
|
|
t.Fatal("should error")
|
|
}
|
|
}
|
|
|
|
func testConfigOk(t *testing.T, warns []string, err error) {
|
|
if len(warns) > 0 {
|
|
t.Fatalf("bad: %#v", warns)
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("bad: %s", err)
|
|
}
|
|
}
|
|
|
|
func TestConfigPrepare_exportPath(t *testing.T) {
|
|
td, err := ioutil.TempDir("", "packer")
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
defer os.RemoveAll(td)
|
|
|
|
raw := testConfig()
|
|
|
|
// No export path. This is invalid. Previously this would not error during
|
|
// validation and as a result the failure would happen at build time.
|
|
delete(raw, "export_path")
|
|
var c Config
|
|
warns, errs := c.Prepare(raw)
|
|
testConfigErr(t, warns, errs)
|
|
|
|
// Good export path
|
|
raw["export_path"] = "good"
|
|
warns, errs = c.Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
|
|
// Bad export path (directory)
|
|
raw["export_path"] = td
|
|
warns, errs = c.Prepare(raw)
|
|
testConfigErr(t, warns, errs)
|
|
}
|
|
|
|
func TestConfigPrepare_exportPathAndCommit(t *testing.T) {
|
|
raw := testConfig()
|
|
|
|
// Export but no commit (explicit default)
|
|
raw["commit"] = false
|
|
warns, errs := (&Config{}).Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
|
|
// Commit AND export specified (invalid)
|
|
raw["commit"] = true
|
|
warns, errs = (&Config{}).Prepare(raw)
|
|
testConfigErr(t, warns, errs)
|
|
|
|
// Commit but no export
|
|
delete(raw, "export_path")
|
|
warns, errs = (&Config{}).Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
}
|
|
|
|
func TestConfigPrepare_exportDiscard(t *testing.T) {
|
|
raw := testConfig()
|
|
|
|
// Export but no discard (explicit default)
|
|
raw["discard"] = false
|
|
warns, errs := (&Config{}).Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
|
|
// Discard AND export (invalid)
|
|
raw["discard"] = true
|
|
warns, errs = (&Config{}).Prepare(raw)
|
|
testConfigErr(t, warns, errs)
|
|
|
|
// Discard but no export
|
|
raw["discard"] = true
|
|
delete(raw, "export_path")
|
|
warns, errs = (&Config{}).Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
}
|
|
|
|
func TestConfigPrepare_image(t *testing.T) {
|
|
raw := testConfig()
|
|
|
|
// No image
|
|
delete(raw, "image")
|
|
var c Config
|
|
warns, errs := c.Prepare(raw)
|
|
testConfigErr(t, warns, errs)
|
|
|
|
// Good image
|
|
raw["image"] = "path"
|
|
warns, errs = c.Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
}
|
|
|
|
func TestConfigPrepare_pull(t *testing.T) {
|
|
raw := testConfig()
|
|
|
|
// No pull set
|
|
delete(raw, "pull")
|
|
var c Config
|
|
warns, errs := c.Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
if !c.Pull {
|
|
t.Fatal("should pull by default")
|
|
}
|
|
|
|
// Pull set
|
|
raw["pull"] = false
|
|
warns, errs = c.Prepare(raw)
|
|
testConfigOk(t, warns, errs)
|
|
if c.Pull {
|
|
t.Fatal("should not pull")
|
|
}
|
|
}
|