0785c2f6fc
This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```
140 lines
3.0 KiB
Go
140 lines
3.0 KiB
Go
package rpc
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/hcl/v2/hcldec"
|
|
"github.com/hashicorp/packer/packer"
|
|
)
|
|
|
|
var testPostProcessorArtifact = new(packer.MockArtifact)
|
|
|
|
type TestPostProcessor struct {
|
|
configCalled bool
|
|
configVal []interface{}
|
|
ppCalled bool
|
|
ppArtifact packer.Artifact
|
|
ppArtifactId string
|
|
ppUi packer.Ui
|
|
|
|
postProcessFn func(context.Context) error
|
|
}
|
|
|
|
func (*TestPostProcessor) ConfigSpec() hcldec.ObjectSpec { return nil }
|
|
|
|
func (pp *TestPostProcessor) Configure(v ...interface{}) error {
|
|
pp.configCalled = true
|
|
pp.configVal = v
|
|
return nil
|
|
}
|
|
|
|
func (pp *TestPostProcessor) PostProcess(ctx context.Context, ui packer.Ui, a packer.Artifact) (packer.Artifact, bool, bool, error) {
|
|
pp.ppCalled = true
|
|
pp.ppArtifact = a
|
|
pp.ppArtifactId = a.Id()
|
|
pp.ppUi = ui
|
|
if pp.postProcessFn != nil {
|
|
return testPostProcessorArtifact, false, false, pp.postProcessFn(ctx)
|
|
}
|
|
return testPostProcessorArtifact, false, false, nil
|
|
}
|
|
|
|
func TestPostProcessorRPC(t *testing.T) {
|
|
// Create the interface to test
|
|
p := new(TestPostProcessor)
|
|
|
|
// Start the server
|
|
client, server := testClientServer(t)
|
|
defer client.Close()
|
|
defer server.Close()
|
|
server.RegisterPostProcessor(p)
|
|
|
|
ppClient := client.PostProcessor()
|
|
|
|
// Test Configure
|
|
config := 42
|
|
err := ppClient.Configure(config)
|
|
if err != nil {
|
|
t.Fatalf("error: %s", err)
|
|
}
|
|
|
|
if !p.configCalled {
|
|
t.Fatal("config should be called")
|
|
}
|
|
|
|
expected := []interface{}{int64(42)}
|
|
if !reflect.DeepEqual(p.configVal, expected) {
|
|
t.Fatalf("unknown config value: %#v", p.configVal)
|
|
}
|
|
|
|
// Test PostProcess
|
|
a := &packer.MockArtifact{
|
|
IdValue: "ppTestId",
|
|
}
|
|
ui := new(testUi)
|
|
artifact, _, _, err := ppClient.PostProcess(context.Background(), ui, a)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
if !p.ppCalled {
|
|
t.Fatal("postprocess should be called")
|
|
}
|
|
|
|
if p.ppArtifactId != "ppTestId" {
|
|
t.Fatalf("unknown artifact: '%s'", p.ppArtifact.Id())
|
|
}
|
|
|
|
if artifact.Id() != "id" {
|
|
t.Fatalf("unknown artifact: %s", artifact.Id())
|
|
}
|
|
}
|
|
|
|
func TestPostProcessorRPC_cancel(t *testing.T) {
|
|
topCtx, cancelTopCtx := context.WithCancel(context.Background())
|
|
|
|
p := new(TestPostProcessor)
|
|
p.postProcessFn = func(ctx context.Context) error {
|
|
cancelTopCtx()
|
|
<-ctx.Done()
|
|
return ctx.Err()
|
|
}
|
|
|
|
// Start the server
|
|
client, server := testClientServer(t)
|
|
defer client.Close()
|
|
defer server.Close()
|
|
if err := server.RegisterPostProcessor(p); err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
ppClient := client.PostProcessor()
|
|
|
|
// Test Configure
|
|
config := 42
|
|
err := ppClient.Configure(config)
|
|
if err != nil {
|
|
t.Fatalf("error configuring post-processor client: %s", err)
|
|
}
|
|
|
|
// Test PostProcess
|
|
a := &packer.MockArtifact{
|
|
IdValue: "ppTestId",
|
|
}
|
|
ui := new(testUi)
|
|
_, _, _, err = ppClient.PostProcess(topCtx, ui, a)
|
|
if err == nil {
|
|
t.Fatalf("should err")
|
|
}
|
|
}
|
|
|
|
func TestPostProcessor_Implements(t *testing.T) {
|
|
var raw interface{}
|
|
raw = new(postProcessor)
|
|
if _, ok := raw.(packer.PostProcessor); !ok {
|
|
t.Fatal("not a postprocessor")
|
|
}
|
|
}
|