2019-12-20 10:12:44 -05:00
|
|
|
|
PEP: 612
|
|
|
|
|
Title: Parameter Specification Variables
|
|
|
|
|
Author: Mark Mendoza <mendoza.mark.a@gmail.com>
|
2020-02-07 00:18:37 -05:00
|
|
|
|
Sponsor: Guido van Rossum <guido@python.org>
|
2020-08-10 14:56:30 -04:00
|
|
|
|
BDFL-Delegate: Guido van Rossum <guido@python.org>
|
2019-12-20 10:12:44 -05:00
|
|
|
|
Discussions-To: Typing-Sig <typing-sig@python.org>
|
2020-08-11 15:17:19 -04:00
|
|
|
|
Status: Accepted
|
2019-12-20 10:12:44 -05:00
|
|
|
|
Type: Standards Track
|
|
|
|
|
Content-Type: text/x-rst
|
|
|
|
|
Created: 18-Dec-2019
|
2020-07-29 15:22:34 -04:00
|
|
|
|
Python-Version: 3.10
|
|
|
|
|
Post-History: 18-Dec-2019, 13-Jul-2020
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Parameter Specification Variables
|
|
|
|
|
=================================
|
|
|
|
|
|
|
|
|
|
Abstract
|
|
|
|
|
--------
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
There currently are two ways to specify the type of a callable, the
|
2020-06-25 23:47:44 -04:00
|
|
|
|
``Callable[[int, str], bool]`` syntax defined in `PEP 484
|
2019-12-20 16:12:00 -05:00
|
|
|
|
<https://www.python.org/dev/peps/pep-0484>`_\ , and callback protocols from `PEP
|
|
|
|
|
544 <https://www.python.org/dev/peps/pep-0544/#callback-protocols>`_. Neither of
|
|
|
|
|
these support forwarding the parameter types of one callable over to another
|
|
|
|
|
callable, making it difficult to annotate function decorators. This PEP proposes
|
2020-07-31 22:59:17 -04:00
|
|
|
|
``typing.ParamSpec`` and ``typing.Concatenate`` to
|
2020-06-25 23:47:44 -04:00
|
|
|
|
support expressing these kinds of relationships.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Motivation
|
|
|
|
|
----------
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
The existing standards for annotating higher order functions don’t give us the
|
|
|
|
|
tools to annotate the following common decorator pattern satisfactorily:
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
from typing import Awaitable, Callable, TypeVar
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
R = TypeVar("R")
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def add_logging(f: Callable[..., R]) -> Callable[..., Awaitable[R]]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
async def inner(*args: object, **kwargs: object) -> R:
|
|
|
|
|
await log_to_database()
|
2020-08-10 22:47:05 -04:00
|
|
|
|
return f(*args, **kwargs)
|
2020-07-13 16:11:38 -04:00
|
|
|
|
return inner
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
@add_logging
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def takes_int_str(x: int, y: str) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
return x + 7
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
await takes_int_str(1, "A")
|
|
|
|
|
await takes_int_str("B", 2) # fails at runtime
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
``add_logging``\ , a decorator which logs before each entry into the decorated
|
|
|
|
|
function, is an instance of the Python idiom of one function passing all
|
2020-06-25 23:47:44 -04:00
|
|
|
|
arguments given to it over to another function. This is done through the
|
|
|
|
|
combination of the ``*args`` and ``**kwargs`` features in both parameters and in
|
|
|
|
|
arguments. When one defines a function (like ``inner``\ ) that takes ``(*args,
|
|
|
|
|
**kwargs)`` and goes on to call another function with ``(*args, **kwargs)``\
|
|
|
|
|
, the wrapping function can only be safely called in all of the ways that the
|
|
|
|
|
wrapped function could be safely called. To type this decorator, we’d like to be
|
|
|
|
|
able to place a dependency between the parameters of the callable ``f`` and the
|
|
|
|
|
parameters of the returned function. `PEP 484
|
|
|
|
|
<https://www.python.org/dev/peps/pep-0484>`_ supports dependencies between
|
|
|
|
|
single types, as in ``def append(l: typing.List[T], e: T) -> typing.List[T]:
|
|
|
|
|
...``\ , but there is no existing way to do so with a complicated entity like
|
|
|
|
|
the parameters of a function.
|
2019-12-20 16:12:00 -05:00
|
|
|
|
|
|
|
|
|
Due to the limitations of the status quo, the ``add_logging`` example will type
|
2020-06-25 23:47:44 -04:00
|
|
|
|
check but will fail at runtime. ``inner`` will pass the string “B” into
|
|
|
|
|
``takes_int_str``\, which will try to add 7 to it, triggering a type error.
|
|
|
|
|
This was not caught by the type checker because the decorated ``takes_int_str``
|
|
|
|
|
was given the type ``Callable[..., Awaitable[int]]`` (an ellipsis in place of
|
|
|
|
|
parameter types is specified to mean that we do no validation on arguments).
|
2019-12-20 16:12:00 -05:00
|
|
|
|
|
|
|
|
|
Without the ability to define dependencies between the parameters of different
|
|
|
|
|
callable types, there is no way, at present, to make ``add_logging`` compatible
|
|
|
|
|
with all functions, while still preserving the enforcement of the parameters of
|
2020-06-25 23:47:44 -04:00
|
|
|
|
the decorated function.
|
2019-12-20 16:12:00 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
With the addition of the ``ParamSpec`` variables proposed by this
|
2019-12-20 16:12:00 -05:00
|
|
|
|
PEP, we can rewrite the previous example in a way that keeps the flexibility of
|
|
|
|
|
the decorator and the parameter enforcement of the decorated function.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
from typing import Awaitable, Callable, ParamSpec, TypeVar
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
P = ParamSpec("P")
|
2020-01-29 18:21:31 -05:00
|
|
|
|
R = TypeVar("R")
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def add_logging(f: Callable[P, R]) -> Callable[P, Awaitable[R]]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
async def inner(*args: P.args, **kwargs: P.kwargs) -> R:
|
|
|
|
|
await log_to_database()
|
|
|
|
|
return f(*args, **kwargs)
|
|
|
|
|
return inner
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
@add_logging
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def takes_int_str(x: int, y: str) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
return x + 7
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
await takes_int_str(1, "A") # Accepted
|
|
|
|
|
await takes_int_str("B", 2) # Correctly rejected by the type checker
|
|
|
|
|
|
|
|
|
|
Another common decorator pattern that has previously been impossible to type is
|
|
|
|
|
the practice of adding or removing arguments from the decorated function. For
|
|
|
|
|
example:
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
class Request:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
...
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def with_request(f: Callable[..., R]) -> Callable[..., R]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(*args: object, **kwargs: object) -> R:
|
|
|
|
|
return f(Request(), *args, **kwargs)
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
@with_request
|
|
|
|
|
def takes_int_str(request: Request, x: int, y: str) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
# use request
|
|
|
|
|
return x + 7
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
takes_int_str(1, "A")
|
|
|
|
|
takes_int_str("B", 2) # fails at runtime
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
With the addition of the ``Concatenate`` operator from this PEP, we can even
|
|
|
|
|
type this more complex decorator.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-07-31 22:59:17 -04:00
|
|
|
|
from typing import Concatenate
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def with_request(f: Callable[Concatenate[Request, P], R]) -> Callable[P, R]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(*args: P.args, **kwargs: P.kwargs) -> R:
|
|
|
|
|
return f(Request(), *args, **kwargs)
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
@with_request
|
|
|
|
|
def takes_int_str(request: Request, x: int, y: str) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
# use request
|
|
|
|
|
return x + 7
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
takes_int_str(1, "A") # Accepted
|
|
|
|
|
takes_int_str("B", 2) # Correctly rejected by the type checker
|
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Specification
|
|
|
|
|
-------------
|
|
|
|
|
|
2020-07-13 16:11:38 -04:00
|
|
|
|
``ParamSpec`` Variables
|
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
|
Declaration
|
|
|
|
|
````````````
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
A parameter specification variable is defined in a similar manner to how a
|
|
|
|
|
normal type variable is defined with ``typing.TypeVar``.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
from typing import ParamSpec
|
|
|
|
|
P = ParamSpec("P") # Accepted
|
|
|
|
|
P = ParamSpec("WrongName") # Rejected because P =/= WrongName
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
The runtime should accept ``bound``\ s and ``covariant`` and ``contravariant``
|
|
|
|
|
arguments in the declaration just as ``typing.TypeVar`` does, but for now we
|
|
|
|
|
will defer the standardization of the semantics of those options to a later PEP.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Valid use locations
|
2020-07-13 16:11:38 -04:00
|
|
|
|
```````````````````
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
Previously only a list of parameter arguments (``[A, B, C]``) or an ellipsis
|
|
|
|
|
(signifying "undefined parameters") were acceptable as the first "argument" to
|
|
|
|
|
``typing.Callable`` . We now augment that with two new options: a parameter
|
|
|
|
|
specification variable (``Callable[P, int]``\ ) or a concatenation on a
|
|
|
|
|
parameter specification variable (``Callable[Concatenate[int, P], int]``\ ).
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
callable ::= Callable "[" parameters_expression, type_expression "]"
|
|
|
|
|
|
|
|
|
|
parameters_expression ::=
|
|
|
|
|
| "..."
|
2020-07-13 16:11:38 -04:00
|
|
|
|
| "[" [ type_expression ("," type_expression)* ] "]"
|
2020-06-25 23:47:44 -04:00
|
|
|
|
| parameter_specification_variable
|
|
|
|
|
| concatenate "["
|
2020-07-13 16:11:38 -04:00
|
|
|
|
type_expression ("," type_expression)* ","
|
2020-06-25 23:47:44 -04:00
|
|
|
|
parameter_specification_variable
|
|
|
|
|
"]"
|
|
|
|
|
|
|
|
|
|
where ``parameter_specification_variable`` is a ``typing.ParamSpec`` variable,
|
|
|
|
|
declared in the manner as defined above, and ``concatenate`` is
|
2020-07-31 22:59:17 -04:00
|
|
|
|
``typing.Concatenate``.
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
As before, ``parameters_expression``\ s by themselves are not acceptable in
|
|
|
|
|
places where a type is expected
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def foo(x: P) -> P: ... # Rejected
|
|
|
|
|
def foo(x: Concatenate[int, P]) -> int: ... # Rejected
|
|
|
|
|
def foo(x: typing.List[P]) -> None: ... # Rejected
|
|
|
|
|
def foo(x: Callable[[int, str], P]) -> None: ... # Rejected
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
User-Defined Generic Classes
|
|
|
|
|
````````````````````````````
|
|
|
|
|
|
|
|
|
|
Just as defining a class as inheriting from ``Generic[T]`` makes a class generic
|
|
|
|
|
for a single parameter (when ``T`` is a ``TypeVar``\ ), defining a class as
|
|
|
|
|
inheriting from ``Generic[P]`` makes a class generic on
|
|
|
|
|
``parameters_expression``\ s (when ``P`` is a ``ParamSpec``).
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
T = TypeVar("T")
|
|
|
|
|
P_2 = ParamSpec("P_2")
|
|
|
|
|
|
|
|
|
|
class X(Generic[T, P]):
|
2020-07-13 16:11:38 -04:00
|
|
|
|
f: Callable[P, int]
|
|
|
|
|
x: T
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def f(x: X[int, P_2]) -> str: ... # Accepted
|
|
|
|
|
def f(x: X[int, Concatenate[int, P_2]]) -> str: ... # Accepted
|
|
|
|
|
def f(x: X[int, [int, bool]]) -> str: ... # Accepted
|
|
|
|
|
def f(x: X[int, ...]) -> str: ... # Accepted
|
|
|
|
|
def f(x: X[int, int]) -> str: ... # Rejected
|
|
|
|
|
|
2020-07-29 19:08:00 -04:00
|
|
|
|
By the rules defined above, spelling a concrete instance of a class generic
|
2020-06-25 23:47:44 -04:00
|
|
|
|
with respect to only a single ``ParamSpec`` would require unsightly double
|
|
|
|
|
brackets. For aesthetic purposes we allow these to be omitted.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
class Z(Generic[P]):
|
2020-07-13 16:11:38 -04:00
|
|
|
|
f: Callable[P, int]
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def f(x: Z[[int, str, bool]]) -> str: ... # Accepted
|
|
|
|
|
def f(x: Z[int, str, bool]) -> str: ... # Equivalent
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-07-13 16:11:38 -04:00
|
|
|
|
# Both Z[[int, str, bool]] and Z[int, str, bool] express this:
|
|
|
|
|
class Z_instantiated:
|
|
|
|
|
f: Callable[[int, str, bool], int]
|
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
Semantics
|
2020-07-13 16:11:38 -04:00
|
|
|
|
`````````
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
The inference rules for the return type of a function invocation whose signature
|
2020-06-25 23:47:44 -04:00
|
|
|
|
contains a ``ParamSpec`` variable are analogous to those around
|
|
|
|
|
evaluating ones with ``TypeVar``\ s.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def changes_return_type_to_str(x: Callable[P, int]) -> Callable[P, str]: ...
|
|
|
|
|
|
|
|
|
|
def returns_int(a: str, b: bool) -> int: ...
|
|
|
|
|
|
|
|
|
|
f = changes_return_type_to_str(returns_int) # f should have the type:
|
|
|
|
|
# (a: str, b: bool) -> str
|
|
|
|
|
|
|
|
|
|
f("A", True) # Accepted
|
|
|
|
|
f(a="A", b=True) # Accepted
|
|
|
|
|
f("A", "A") # Rejected
|
|
|
|
|
|
|
|
|
|
expects_str(f("A", True)) # Accepted
|
|
|
|
|
expects_int(f("A", True)) # Rejected
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
Just as with traditional ``TypeVars``\ , a user may include the same
|
2020-06-25 23:47:44 -04:00
|
|
|
|
``ParamSpec`` multiple times in the arguments of the same function,
|
2019-12-20 16:12:00 -05:00
|
|
|
|
to indicate a dependency between multiple arguments. In these cases a type
|
|
|
|
|
checker may choose to solve to a common behavioral supertype (i.e. a set of
|
|
|
|
|
parameters for which all of the valid calls are valid in both of the subtypes),
|
|
|
|
|
but is not obligated to do so.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
P = ParamSpec("P")
|
|
|
|
|
|
|
|
|
|
def foo(x: Callable[P, int], y: Callable[P, int]) -> Callable[P, bool]: ...
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-07-31 16:23:39 -04:00
|
|
|
|
def x_y(x: int, y: str) -> int: ...
|
|
|
|
|
def y_x(y: int, x: str) -> int: ...
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2020-07-31 16:23:39 -04:00
|
|
|
|
foo(x_y, x_y) # Should return (x: int, y: str) -> bool
|
|
|
|
|
|
|
|
|
|
foo(x_y, y_x) # Could return (__a: int, __b: str) -> bool
|
|
|
|
|
# This works because both callables have types that are
|
|
|
|
|
# behavioral subtypes of Callable[[int, str], int]
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
def keyword_only_x(*, x: int) -> int: ...
|
|
|
|
|
def keyword_only_y(*, y: int) -> int: ...
|
2020-06-25 23:47:44 -04:00
|
|
|
|
foo(keyword_only_x, keyword_only_y) # Rejected
|
|
|
|
|
|
2020-07-31 16:23:39 -04:00
|
|
|
|
The constructors of user-defined classes generic on ``ParamSpec``\ s should be
|
|
|
|
|
evaluated in the same way.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-12-23 23:20:36 -05:00
|
|
|
|
U = TypeVar("U")
|
2020-07-31 16:23:39 -04:00
|
|
|
|
|
|
|
|
|
class Y(Generic[U, P]):
|
|
|
|
|
f: Callable[P, str]
|
|
|
|
|
prop: U
|
|
|
|
|
|
|
|
|
|
def __init__(self, f: Callable[P, str], prop: U) -> None:
|
|
|
|
|
self.f = f
|
|
|
|
|
self.prop = prop
|
|
|
|
|
|
|
|
|
|
def a(q: int) -> str: ...
|
|
|
|
|
|
|
|
|
|
Y(a, 1) # Should resolve to Y[(q: int), int]
|
|
|
|
|
Y(a, 1).f # Should resolve to (q: int) -> str
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
The semantics of ``Concatenate[X, Y, P]`` are that it represents the parameters
|
|
|
|
|
represented by ``P`` with two positional-only parameters prepended. This means
|
|
|
|
|
that we can use it to represent higher order functions that add, remove or
|
|
|
|
|
transform a finite number of parameters of a callable.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def bar(x: int, *args: bool) -> int: ...
|
|
|
|
|
|
|
|
|
|
def add(x: Callable[P, int]) -> Callable[Concatenate[str, P], bool]: ...
|
|
|
|
|
|
|
|
|
|
add(bar) # Should return (__a: str, x: int, *args: bool) -> bool
|
|
|
|
|
|
|
|
|
|
def remove(x: Callable[Concatenate[int, P], int]) -> Callable[P, bool]: ...
|
|
|
|
|
|
|
|
|
|
remove(bar) # Should return (*args: bool) -> bool
|
|
|
|
|
|
|
|
|
|
def transform(
|
|
|
|
|
x: Callable[Concatenate[int, P], int]
|
|
|
|
|
) -> Callable[Concatenate[str, P], bool]: ...
|
|
|
|
|
|
|
|
|
|
transform(bar) # Should return (__a: str, *args: bool) -> bool
|
|
|
|
|
|
|
|
|
|
This also means that while any function that returns an ``R`` can satisfy
|
|
|
|
|
``typing.Callable[P, R]``, only functions that can be called positionally in
|
|
|
|
|
their first position with a ``X`` can satisfy
|
|
|
|
|
``typing.Callable[Concatenate[X, P], R]``.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def expects_int_first(x: Callable[Concatenate[int, P], int]) -> None: ...
|
|
|
|
|
|
|
|
|
|
@expects_int_first # Rejected
|
|
|
|
|
def one(x: str) -> int: ...
|
|
|
|
|
|
|
|
|
|
@expects_int_first # Rejected
|
|
|
|
|
def two(*, x: int) -> int: ...
|
|
|
|
|
|
|
|
|
|
@expects_int_first # Rejected
|
|
|
|
|
def three(**kwargs: int) -> int: ...
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
@expects_int_first # Accepted
|
|
|
|
|
def four(*args: int) -> int: ...
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
There are still some classes of decorators still not supported with these
|
|
|
|
|
features:
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
* those that add/remove/change a **variable** number of parameters (for
|
|
|
|
|
example, ``functools.partial`` will remain untypable even after this PEP)
|
|
|
|
|
* those that add/remove/change keyword-only parameters (See
|
|
|
|
|
`Concatenating Keyword Parameters`_ for more details).
|
|
|
|
|
|
|
|
|
|
The components of a ``ParamSpec``
|
2019-12-20 10:12:44 -05:00
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
A ``ParamSpec`` captures both positional and keyword accessible
|
2019-12-20 16:12:00 -05:00
|
|
|
|
parameters, but there unfortunately is no object in the runtime that captures
|
|
|
|
|
both of these together. Instead, we are forced to separate them into ``*args``
|
|
|
|
|
and ``**kwargs``\ , respectively. This means we need to be able to split apart
|
2020-06-25 23:47:44 -04:00
|
|
|
|
a single ``ParamSpec`` into these two components, and then bring
|
|
|
|
|
them back together into a call. To do this, we introduce ``P.args`` to
|
2019-12-20 16:12:00 -05:00
|
|
|
|
represent the tuple of positional arguments in a given call and
|
2020-06-25 23:47:44 -04:00
|
|
|
|
``P.kwargs`` to represent the corresponding ``Mapping`` of keywords to
|
|
|
|
|
values.
|
|
|
|
|
|
|
|
|
|
Valid use locations
|
|
|
|
|
```````````````````
|
|
|
|
|
|
|
|
|
|
These "properties" can only be used as the annotated types for
|
|
|
|
|
``*args`` and ``**kwargs``\ , accessed from a ParamSpec already in scope.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def puts_p_into_scope(f: Callable[P, int]) -> None:
|
|
|
|
|
|
|
|
|
|
def inner(*args: P.args, **kwargs: P.kwargs) -> None: # Accepted
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
def mixed_up(*args: P.kwargs, **kwargs: P.args) -> None: # Rejected
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
def misplaced(x: P.args) -> None: # Rejected
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
def out_of_scope(*args: P.args, **kwargs: P.kwargs) -> None: # Rejected
|
2020-07-13 16:11:38 -04:00
|
|
|
|
pass
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Furthermore, because the default kind of parameter in Python (\ ``(x: int)``\ )
|
|
|
|
|
may be addressed both positionally and through its name, two valid invocations
|
|
|
|
|
of a ``(*args: P.args, **kwargs: P.kwargs)`` function may give different
|
2021-02-03 09:06:23 -05:00
|
|
|
|
partitions of the same set of parameters. Therefore, we need to make sure that
|
2020-06-25 23:47:44 -04:00
|
|
|
|
these special types are only brought into the world together, and are used
|
|
|
|
|
together, so that our usage is valid for all possible partitions.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def puts_p_into_scope(f: Callable[P, int]) -> None:
|
|
|
|
|
|
2021-01-02 23:39:50 -05:00
|
|
|
|
stored_args: P.args # Rejected
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2021-01-02 23:39:50 -05:00
|
|
|
|
stored_kwargs: P.kwargs # Rejected
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2021-01-02 23:39:50 -05:00
|
|
|
|
def just_args(*args: P.args) -> None: # Rejected
|
2020-06-25 23:47:44 -04:00
|
|
|
|
pass
|
|
|
|
|
|
2021-01-02 23:39:50 -05:00
|
|
|
|
def just_kwargs(**kwargs: P.kwargs) -> None: # Rejected
|
2020-06-25 23:47:44 -04:00
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Semantics
|
|
|
|
|
`````````
|
2019-12-20 16:12:00 -05:00
|
|
|
|
|
|
|
|
|
With those requirements met, we can now take advantage of the unique properties
|
2020-06-25 23:47:44 -04:00
|
|
|
|
afforded to us by this set up:
|
2019-12-20 16:12:00 -05:00
|
|
|
|
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
* Inside the function, ``args`` has the type ``P.args``\ , not
|
|
|
|
|
``Tuple[P.args, ...]`` as would be with a normal annotation
|
2019-12-20 16:12:00 -05:00
|
|
|
|
(and likewise with the ``**kwargs``\ )
|
2020-07-31 22:59:17 -04:00
|
|
|
|
|
2021-09-17 14:18:24 -04:00
|
|
|
|
* This special case is necessary to encapsulate the heterogeneous contents
|
2020-07-31 22:59:17 -04:00
|
|
|
|
of the ``args``/``kwargs`` of a given call, which cannot be expressed
|
|
|
|
|
by an indefinite tuple/dictionary type.
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
* A function of type ``Callable[P, R]`` can be called with ``(*args, **kwargs)``
|
|
|
|
|
if and only if ``args`` has the type ``P.args`` and ``kwargs`` has the type
|
|
|
|
|
``P.kwargs``\ , and that those types both originated from the same function
|
|
|
|
|
declaration.
|
|
|
|
|
* A function declared as ``def inner(*args: P.args, **kwargs: P.kwargs) -> X``
|
|
|
|
|
has type ``Callable[P, X]``.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
With these three properties, we now have the ability to fully type check
|
|
|
|
|
parameter preserving decorators.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def decorator(f: Callable[P, int]) -> Callable[P, None]:
|
|
|
|
|
|
|
|
|
|
def foo(*args: P.args, **kwargs: P.kwargs) -> None:
|
|
|
|
|
|
|
|
|
|
f(*args, **kwargs) # Accepted, should resolve to int
|
|
|
|
|
|
|
|
|
|
f(*kwargs, **args) # Rejected
|
|
|
|
|
|
|
|
|
|
f(1, *args, **kwargs) # Rejected
|
|
|
|
|
|
|
|
|
|
return foo # Accepted
|
|
|
|
|
|
|
|
|
|
To extend this to include ``Concatenate``, we declare the following properties:
|
|
|
|
|
|
|
|
|
|
* A function of type ``Callable[Concatenate[A, B, P], R]`` can only be
|
|
|
|
|
called with ``(a, b, *args, **kwargs)`` when ``args`` and ``kwargs`` are the
|
|
|
|
|
respective components of ``P``, ``a`` is of type ``A`` and ``b`` is of
|
|
|
|
|
type ``B``.
|
|
|
|
|
* A function declared as
|
|
|
|
|
``def inner(a: A, b: B, *args: P.args, **kwargs: P.kwargs) -> R``
|
|
|
|
|
has type ``Callable[Concatenate[A, B, P], R]``. Placing keyword-only
|
2020-07-29 19:08:00 -04:00
|
|
|
|
parameters between the ``*args`` and ``**kwargs`` is forbidden.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
def add(f: Callable[P, int]) -> Callable[Concatenate[str, P], None]:
|
|
|
|
|
|
|
|
|
|
def foo(s: str, *args: P.args, **kwargs: P.kwargs) -> None: # Accepted
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
def bar(*args: P.args, s: str, **kwargs: P.kwargs) -> None: # Rejected
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
return foo # Accepted
|
|
|
|
|
|
|
|
|
|
|
2020-07-29 19:08:00 -04:00
|
|
|
|
def remove(f: Callable[Concatenate[int, P], int]) -> Callable[P, None]:
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def foo(*args: P.args, **kwargs: P.kwargs) -> None:
|
|
|
|
|
f(1, *args, **kwargs) # Accepted
|
|
|
|
|
|
|
|
|
|
f(*args, 1, **kwargs) # Rejected
|
|
|
|
|
|
|
|
|
|
f(*args, **kwargs) # Rejected
|
|
|
|
|
|
|
|
|
|
return foo
|
|
|
|
|
|
|
|
|
|
Note that the names of the parameters preceding the ``ParamSpec``
|
|
|
|
|
components are not mentioned in the resulting ``Concatenate``. This means that
|
|
|
|
|
these parameters can not be addressed via a named argument:
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def outer(f: Callable[P, None]) -> Callable[P, None]:
|
|
|
|
|
def foo(x: int, *args: P.args, **kwargs: P.kwargs) -> None:
|
|
|
|
|
f(*args, **kwargs)
|
|
|
|
|
|
|
|
|
|
def bar(*args: P.args, **kwargs: P.kwargs) -> None:
|
|
|
|
|
foo(1, *args, **kwargs) # Accepted
|
|
|
|
|
foo(x=1, *args, **kwargs) # Rejected
|
|
|
|
|
|
|
|
|
|
return bar
|
|
|
|
|
|
|
|
|
|
.. _above:
|
|
|
|
|
|
|
|
|
|
This is not an implementation convenience, but a soundness requirement. If we
|
|
|
|
|
were to allow that second calling style, then the following snippet would be
|
|
|
|
|
problematic.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
@outer
|
|
|
|
|
def problem(*, x: object) -> None:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
problem(x="uh-oh")
|
|
|
|
|
|
|
|
|
|
Inside of ``bar``, we would get
|
|
|
|
|
``TypeError: foo() got multiple values for argument 'x'``. Requiring these
|
|
|
|
|
concatenated arguments to be addressed positionally avoids this kind of problem,
|
|
|
|
|
and simplifies the syntax for spelling these types. Note that this also why we
|
|
|
|
|
have to reject signatures of the form
|
|
|
|
|
``(*args: P.args, s: str, **kwargs: P.kwargs)`` (See
|
|
|
|
|
`Concatenating Keyword Parameters`_ for more details).
|
|
|
|
|
|
|
|
|
|
If one of these prepended positional parameters contains a free ``ParamSpec``\ ,
|
|
|
|
|
we consider that variable in scope for the purposes of extracting the components
|
|
|
|
|
of that ``ParamSpec``. That allows us to spell things like this:
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def twice(f: Callable[P, int], *args: P.args, **kwargs: P.kwargs) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
return f(*args, **kwargs) + f(*args, **kwargs)
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
The type of ``twice`` in the above example is
|
|
|
|
|
``Callable[Concatenate[Callable[P, int], P], int]``, where ``P`` is bound by the
|
|
|
|
|
outer ``Callable``. This has the following semantics:
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def a_int_b_str(a: int, b: str) -> int:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
twice(a_int_b_str, 1, "A") # Accepted
|
|
|
|
|
|
|
|
|
|
twice(a_int_b_str, b="A", a=1) # Accepted
|
|
|
|
|
|
|
|
|
|
twice(a_int_b_str, "A", 1) # Rejected
|
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Backwards Compatibility
|
|
|
|
|
-----------------------
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
The only changes necessary to existing features in ``typing`` is allowing these
|
2020-06-25 23:47:44 -04:00
|
|
|
|
``ParamSpec`` and ``Concatenate`` objects to be the first parameter to
|
|
|
|
|
``Callable`` and to be a parameter to ``Generic``. Currently ``Callable``
|
|
|
|
|
expects a list of types there and ``Generic`` expects single types, so they are
|
|
|
|
|
currently mutually exclusive. Otherwise, existing code that doesn't reference
|
|
|
|
|
the new interfaces will be unaffected.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Reference Implementation
|
|
|
|
|
------------------------
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
The `Pyre <https://pyre-check.org/>`_ type checker supports all of the behavior
|
|
|
|
|
described above. A reference implementation of the runtime components needed
|
2020-12-23 23:20:36 -05:00
|
|
|
|
for those uses is provided in the ``pyre_extensions`` module. A reference
|
|
|
|
|
implementation for CPython can be found
|
|
|
|
|
`here <https://github.com/python/cpython/pull/23702>`_.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Rejected Alternatives
|
|
|
|
|
---------------------
|
|
|
|
|
|
|
|
|
|
Using List Variadics and Map Variadics
|
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
We considered just trying to make something like this with a callback protocol
|
|
|
|
|
which was parameterized on a list-type variadic, and a map-type variadic like
|
|
|
|
|
so:
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
R = typing.TypeVar(“R”)
|
2020-07-29 19:08:00 -04:00
|
|
|
|
Tpositionals = ...
|
2019-12-20 10:12:44 -05:00
|
|
|
|
Tkeywords = ...
|
2020-06-25 23:47:44 -04:00
|
|
|
|
class BetterCallable(typing.Protocol[Tpositionals, Tkeywords, R]):
|
|
|
|
|
def __call__(*args: Tpositionals, **kwargs: Tkeywords) -> R: ...
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2021-02-03 09:06:23 -05:00
|
|
|
|
However, there are some problems with trying to come up with a consistent
|
2019-12-20 16:12:00 -05:00
|
|
|
|
solution for those type variables for a given callable. This problem comes up
|
|
|
|
|
with even the simplest of callables:
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def simple(x: int) -> None: ...
|
|
|
|
|
simple <: BetterCallable[[int], [], None]
|
|
|
|
|
simple <: BetterCallable[[], {“x”: int}, None]
|
|
|
|
|
BetterCallable[[int], [], None] </: BetterCallable[[], {“x”: int}, None]
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
Any time where a type can implement a protocol in more than one way that aren't
|
2019-12-20 16:12:00 -05:00
|
|
|
|
mutually compatible, we can run into situations where we lose information. If we
|
2020-06-25 23:47:44 -04:00
|
|
|
|
were to make a decorator using this protocol, we would have to pick one calling
|
2019-12-20 16:12:00 -05:00
|
|
|
|
convention to prefer.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def decorator(
|
|
|
|
|
f: BetterCallable[[Ts], [Tmap], int],
|
|
|
|
|
) -> BetterCallable[[Ts], [Tmap], str]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def decorated(*args: Ts, **kwargs: Tmap) -> str:
|
|
|
|
|
x = f(*args, **kwargs)
|
|
|
|
|
return int_to_str(x)
|
|
|
|
|
return decorated
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
@decorator
|
|
|
|
|
def foo(x: int) -> int:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
return x
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
reveal_type(foo) # Option A: BetterCallable[[int], {}, str]
|
|
|
|
|
# Option B: BetterCallable[[], {x: int}, str]
|
|
|
|
|
foo(7) # fails under option B
|
|
|
|
|
foo(x=7) # fails under option A
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
The core problem here is that, by default, parameters in Python can either be
|
2020-06-25 23:47:44 -04:00
|
|
|
|
called positionally or as a keyword argument. This means we really have
|
2019-12-20 16:12:00 -05:00
|
|
|
|
three categories (positional-only, positional-or-keyword, keyword-only) we’re
|
|
|
|
|
trying to jam into two categories. This is the same problem that we briefly
|
|
|
|
|
mentioned when discussing ``.args`` and ``.kwargs``. Fundamentally, in order to
|
|
|
|
|
capture two categories when there are some things that can be in either
|
2020-06-25 23:47:44 -04:00
|
|
|
|
category, we need a higher level primitive (\ ``ParamSpec``\ ) to
|
2019-12-20 16:12:00 -05:00
|
|
|
|
capture all three, and then split them out afterward.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
Defining ParametersOf
|
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
|
Another proposal we considered was defining ``ParametersOf`` and ``ReturnType``
|
|
|
|
|
operators which would operate on a domain of a newly defined ``Function`` type.
|
|
|
|
|
``Function`` would be callable with, and only with ``ParametersOf[F]``.
|
|
|
|
|
``ParametersOf`` and ``ReturnType`` would only operate on type variables with
|
|
|
|
|
precisely this bound. The combination of these three features could express
|
|
|
|
|
everything that we can express with ``ParamSpecs``.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
F = TypeVar("F", bound=Function)
|
|
|
|
|
|
|
|
|
|
def no_change(f: F) -> F:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(
|
|
|
|
|
*args: ParametersOf[F].args,
|
|
|
|
|
**kwargs: ParametersOf[F].kwargs
|
|
|
|
|
) -> ReturnType[F]:
|
|
|
|
|
return f(*args, **kwargs)
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def wrapping(f: F) -> Callable[ParametersOf[F], List[ReturnType[F]]]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(
|
|
|
|
|
*args: ParametersOf[F].args,
|
|
|
|
|
**kwargs: ParametersOf[F].kwargs
|
|
|
|
|
) -> List[ReturnType[F]]:
|
|
|
|
|
return [f(*args, **kwargs)]
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
def unwrapping(
|
2020-07-13 16:11:38 -04:00
|
|
|
|
f: Callable[ParametersOf[F], List[R]]
|
2020-06-25 23:47:44 -04:00
|
|
|
|
) -> Callable[ParametersOf[F], R]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(
|
|
|
|
|
*args: ParametersOf[F].args,
|
|
|
|
|
**kwargs: ParametersOf[F].kwargs
|
|
|
|
|
) -> R:
|
|
|
|
|
return f(*args, **kwargs)[0]
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
We decided to go with ``ParamSpec``\ s over this approach for several reasons:
|
|
|
|
|
|
|
|
|
|
* The footprint of this change would be larger, as we would need two new
|
|
|
|
|
operators, and a new type, while ``ParamSpec`` just introduces a new variable.
|
|
|
|
|
* Python typing has so far has avoided supporting operators, whether
|
|
|
|
|
user-defined or built-in, in favor of destructuring. Accordingly,
|
|
|
|
|
``ParamSpec`` based signatures look much more like existing Python.
|
|
|
|
|
* The lack of user-defined operators makes common patterns hard to spell.
|
|
|
|
|
``unwrapping`` is odd to read because ``F`` is not actually referring to any
|
|
|
|
|
callable. It’s just being used as a container for the parameters we wish to
|
|
|
|
|
propagate. It would read better if we could define an operator
|
|
|
|
|
``RemoveList[List[X]] = X`` and then ``unwrapping`` could take ``F`` and
|
|
|
|
|
return ``Callable[ParametersOf[F], RemoveList[ReturnType[F]]]``. Without
|
|
|
|
|
that, we unfortunately get into a situation where we have to use a
|
|
|
|
|
``Function``-variable as an improvised ``ParamSpec``, in that we never
|
|
|
|
|
actually bind the return type.
|
|
|
|
|
|
|
|
|
|
In summary, between these two equivalently powerful syntaxes, ``ParamSpec`` fits
|
|
|
|
|
much more naturally into the status quo.
|
|
|
|
|
|
|
|
|
|
.. _Concatenating Keyword Parameters:
|
|
|
|
|
|
|
|
|
|
Concatenating Keyword Parameters
|
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
|
In principle the idea of concatenation as a means to modify a finite number of
|
|
|
|
|
positional parameters could be expanded to include keyword parameters.
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def add_n(f: Callable[P, R]) -> Callable[Concatenate[("n", int), P], R]:
|
2020-07-13 16:11:38 -04:00
|
|
|
|
def inner(*args: P.args, n: int, **kwargs: P.kwargs) -> R:
|
|
|
|
|
# use n
|
|
|
|
|
return f(*args, **kwargs)
|
|
|
|
|
return inner
|
2020-06-25 23:47:44 -04:00
|
|
|
|
|
|
|
|
|
However, the key distinction is that while prepending positional-only parameters
|
|
|
|
|
to a valid callable type always yields another valid callable type, the same
|
|
|
|
|
cannot be said for adding keyword-only parameters. As alluded to above_ , the
|
|
|
|
|
issue is name collisions. The parameters ``Concatenate[("n", int), P]`` are
|
|
|
|
|
only valid when ``P`` itself does not already have a parameter named ``n``\ .
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
def innocent_wrapper(f: Callable[P, R]) -> Callable[P, R]:
|
|
|
|
|
def inner(*args: P.args, **kwargs: P.kwargs) -> R:
|
|
|
|
|
added = add_n(f)
|
|
|
|
|
return added(*args, n=1, **kwargs)
|
|
|
|
|
return inner
|
|
|
|
|
|
|
|
|
|
@innocent_wrapper
|
|
|
|
|
def problem(n: int) -> None:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
Calling ``problem(2)`` works fine, but calling ``problem(n=2)`` leads to a
|
|
|
|
|
``TypeError: problem() got multiple values for argument 'n'`` from the call to
|
|
|
|
|
``added`` inside of ``innocent_wrapper``\ .
|
|
|
|
|
|
|
|
|
|
This kind of situation could be avoided, and this kind of decorator could be
|
|
|
|
|
typed if we could reify the constraint that a set of parameters **not** contain
|
|
|
|
|
a certain name, with something like:
|
|
|
|
|
|
|
|
|
|
.. code-block::
|
|
|
|
|
|
|
|
|
|
P_without_n = ParamSpec("P_without_n", banned_names=["n"])
|
|
|
|
|
|
|
|
|
|
def add_n(
|
|
|
|
|
f: Callable[P_without_n, R]
|
|
|
|
|
) -> Callable[Concatenate[("n", int), P_without_n], R]: ...
|
|
|
|
|
|
|
|
|
|
The call to ``add_n`` inside of ``innocent_wrapper`` could then be rejected
|
|
|
|
|
since the callable was not guaranteed not to already have a parameter named
|
|
|
|
|
``n``\ .
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
However, enforcing these constraints would require enough additional
|
|
|
|
|
implementation work that we judged this extension to be out of scope of this
|
|
|
|
|
PEP. Fortunately the design of ``ParamSpec``\ s are such that we can return to
|
|
|
|
|
this idea later if there is sufficient demand.
|
|
|
|
|
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
Naming this a ``ParameterSpecification``
|
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
We decided that ParameterSpecification was a little too long-winded for use
|
|
|
|
|
here, and that this style of abbreviated name made it look more like TypeVar.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Naming this an ``ArgSpec``
|
2020-06-25 23:47:44 -04:00
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
We think that calling this a ParamSpec is more correct than
|
|
|
|
|
referring to it as an ArgSpec, since callables have parameters,
|
2019-12-20 16:12:00 -05:00
|
|
|
|
which are distinct from the arguments which are passed to them in a given call
|
2020-06-25 23:47:44 -04:00
|
|
|
|
site. A given binding for a ParamSpec is a set of function
|
2019-12-20 16:12:00 -05:00
|
|
|
|
parameters, not a call-site’s arguments.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Acknowledgements
|
|
|
|
|
----------------
|
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
Thanks to all of the members of the Pyre team for their comments on early drafts
|
|
|
|
|
of this PEP, and for their help with the reference implementation.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
2019-12-20 16:12:00 -05:00
|
|
|
|
Thanks are also due to the whole Python typing community for their early
|
|
|
|
|
feedback on this idea at a Python typing meetup, leading directly to the much
|
|
|
|
|
more compact ``.args``\ /\ ``.kwargs`` syntax.
|
2019-12-20 10:12:44 -05:00
|
|
|
|
|
|
|
|
|
Copyright
|
|
|
|
|
---------
|
|
|
|
|
|
2020-06-25 23:47:44 -04:00
|
|
|
|
This document is placed in the public domain or under the CC0-1.0-Universal
|
2019-12-20 16:12:00 -05:00
|
|
|
|
license, whichever is more permissive.
|