From 3e852705742a47bfd0f1e7536ab4bce8cc1ce0a3 Mon Sep 17 00:00:00 2001 From: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Date: Sun, 23 Jan 2022 22:23:13 +0000 Subject: [PATCH] PEP 676: Mention additional enhacements (#2260) Co-authored-by: Hugo van Kemenade --- .github/CODEOWNERS | 2 +- pep-0676.rst | 16 ++++++++++------ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0fe9b3915..869533100 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -550,7 +550,7 @@ pep-0672.rst @encukou pep-0673.rst @jellezijlstra pep-0674.rst @vstinner pep-0675.rst @jellezijlstra -pep-0676.rst @Mariatta +pep-0676.rst @AA-Turner @Mariatta pep-0677.rst @gvanrossum pep-0678.rst @iritkatriel pep-0679.rst @pablogsal diff --git a/pep-0676.rst b/pep-0676.rst index b955e1f92..957bd113d 100644 --- a/pep-0676.rst +++ b/pep-0676.rst @@ -79,6 +79,7 @@ There are several requests for additional features in reading PEPs, such as: * typographic quotation marks [4]_ * additional footer information [5]_ * intersphinx functionality [6]_ +* dark mode theme [7]_ These are "easy wins" from this proposal, and would serve to improve the quality-of-life for consumers of PEPs (including reviewers and writers). @@ -88,7 +89,7 @@ schedule. This means that updates to PEPs cannot be circulated immediately, reducing productivity. The reference implementation renders and publishes all PEPs on every commit to the repository, solving the issue by design. -The reference implementation fixes several issues [7]_. For example: +The reference implementation fixes several issues [8]_. For example: * list styles are currently not respected by `python.org`_'s stylesheets * support for updating images in PEPs is challenging in `python.org`_ @@ -168,11 +169,13 @@ Reference Implementation ======================== The proposed implementation has been merged into the `python/peps`_ repository -in a series of pull requests [8]_. It uses the `Sphinx`_ documentation system -with a custom theme and extensions. +in a series of pull requests [9]_. It uses the `Sphinx`_ documentation system +with a custom theme (supporting light and dark colour schemes) and extensions. This already automatically renders all PEPs on every commit, and publishes them -to `python.github.io/peps`_. +to `python.github.io/peps`_. The high level documentation for the system covers +`how to render PEPs locally `__ and +`the implementation of the system `__. Rejected Ideas @@ -233,11 +236,12 @@ Footnotes .. [4] Requested: `peps#165 `__ .. [5] Requested: `pythondotorg#1564 `__ .. [6] Requested: `comment in peps#2 `__ -.. [7] As of November 2021, see +.. [7] Requested: `in python-dev `__ +.. [8] As of November 2021, see `peps#1387 `__, `pythondotorg#824 `__, `pythondotorg#1556 `__, -.. [8] Implementation PRs: +.. [9] Implementation PRs: `peps#1930 `__, `peps#1931 `__, `peps#1932 `__,