Don't use 'strorunicodeobj' as the generic object name. Use just
'obj' -- after all, you don't know that it's a string or unicode object just yet, that's what the test in these examples is for!
This commit is contained in:
parent
22cf1a49f9
commit
6655f152be
|
@ -543,19 +543,19 @@ Programming Recommendations
|
|||
might be a unicode string too! In Python 2.3, str and unicode
|
||||
have a common base class, basestring, so you can do:
|
||||
|
||||
if isinstance(strorunicodeobj, basestring):
|
||||
if isinstance(obj, basestring):
|
||||
|
||||
In Python 2.2, the types module has the StringTypes type defined
|
||||
for that purpose, e.g.:
|
||||
|
||||
from string import StringTypes
|
||||
if isinstance(strorunicodeobj, StringTypes):
|
||||
if isinstance(obj, StringTypes):
|
||||
|
||||
In Python 2.0 and 2.1, you should do:
|
||||
|
||||
from string import StringType, UnicodeType
|
||||
if isinstance(strorunicodeobj, StringType) or \
|
||||
isinstance(strorunicodeobj, UnicodeType) :
|
||||
if isinstance(obj, StringType) or \
|
||||
isinstance(obj, UnicodeType) :
|
||||
|
||||
- For sequences, (strings, lists, tuples), use the fact that empty
|
||||
sequences are false, so "if not seq" or "if seq" is preferable
|
||||
|
|
Loading…
Reference in New Issue