From b16058c42715a66a59af831800b5517c7f3b01e0 Mon Sep 17 00:00:00 2001 From: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Date: Thu, 20 Jan 2022 16:03:35 +0000 Subject: [PATCH] PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs (#2252) Co-authored-by: Chris Angelico Co-authored-by: CAM Gerlach --- pep-0001.txt | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/pep-0001.txt b/pep-0001.txt index af34fdea5..d8ff86ca8 100644 --- a/pep-0001.txt +++ b/pep-0001.txt @@ -188,9 +188,10 @@ The standard PEP workflow is: "Informational", or "Process" as appropriate, and for the "Status:" field enter "Draft". For full details, see `PEP Header Preamble`_. -* Update `.github/CODEOWNERS` [7]_ such that any core developer co-author(s) or - sponsor are listed for your new file such that any future pull requests will - be assigned to them. +* Update `.github/CODEOWNERS` [7]_ such that any co-author(s) or sponsors + with write access to the `PEP repository`_ are listed for your new file. + This ensures any future pull requests changing the file will be assigned + to them. * Push this to your GitHub fork and submit a pull request. @@ -229,7 +230,7 @@ not providing proper motivation or addressing backwards compatibility, or not in keeping with the Python philosophy. The Steering Council can be consulted during the approval phase, and are the final arbiter of a draft's PEP-ability. -Developers with git push privileges for the `PEP repository`_ may claim PEP +Developers with write access to the `PEP repository`_ may claim PEP numbers directly by creating and committing a new PEP. When doing so, the developer must handle the tasks that would normally be taken care of by the PEP editors (see `PEP Editor Responsibilities & Workflow`_). This includes @@ -240,7 +241,7 @@ if you need assistance from PEP editors, mention ``@python/pep-editors`` on GitHub. As updates are necessary, the PEP author can check in new versions if they -(or a collaborating developer) have git push privileges. +(or a collaborating developer) have write access to the `PEP repository`_. After a PEP number has been assigned, a draft PEP may be discussed further on python-ideas (getting a PEP number assigned early can be useful for ease of @@ -642,7 +643,7 @@ your changes don't get lost. When in doubt about where to send your changes, please check first with the PEP author and/or a PEP editor. -PEP authors with git push privileges for the PEP repository can update the +PEP authors with write access to the PEP repository can update the PEPs themselves by using "git push" or the GitHub PR interface to submit their changes. @@ -677,7 +678,7 @@ PEP Editor Responsibilities & Workflow A PEP editor must be added to the ``@python/pep-editors`` group on GitHub and must watch the `PEP repository`_. -Note that developers with git push privileges for the `PEP repository`_ may +Note that developers with write access to the `PEP repository`_ may handle the tasks that would normally be taken care of by the PEP editors. Alternately, even developers may request assistance from PEP editors by mentioning ``@python/pep-editors`` on GitHub. @@ -696,8 +697,8 @@ For each new PEP that comes in an editor does the following: * The file name extension is correct (i.e. ``.rst``). -* Make sure the appropriate core developer(s) is added to - `.github/CODEOWNERS` [7]_. +* Ensure that everyone listed as a sponsor or co-author of the PEP who has write + access to the `PEP repository`_ is added to `.github/CODEOWNERS` [7]_. * Skim the PEP for obvious defects in language (spelling, grammar, sentence structure, etc.), and code style (examples should conform to