From cccaba9b8eb8eeb6577c742d74158814c7c5c38c Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Thu, 14 Feb 2019 11:29:06 -0500 Subject: [PATCH] PEP-551: change title of "Rejected Advice" section (#894) "Rejected Advice" sounds like the section will contain false statements that should not be followed, instead it contains true statements about things you should not do. Change the title to "Things not to do" to be clearer that these are correct advice but of a negative sense. --- pep-0551.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pep-0551.rst b/pep-0551.rst index a44e4aeeb..f56f4f2d2 100644 --- a/pep-0551.rst +++ b/pep-0551.rst @@ -292,7 +292,7 @@ the use of cached bytecode), and will raise a custom audit event ``spython.open_for_import`` containing ``(filename, True_if_allowed)``. After opening the file, the entire contents is read into memory in a -single buffer and the file is closed. +single buffer and the file is closed. Compilation will later trigger a ``compile`` event, so there is no need to validate the contents now using mechanisms that also apply to @@ -417,8 +417,8 @@ Since ``importlib``'s use of ``open_for_import`` may be easily bypassed with monkeypatching, an audit hook **should** be used to detect attribute changes on type objects. -Rejected Advice -=============== +Things not to do +================ This section discusses common or "obviously good" recommendations that we are specifically *not* making. These range from useless or incorrect