From d00648fc3deaa6ae9b0ad20a7034b77d619184e3 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Fri, 1 Sep 2000 07:04:59 +0000 Subject: [PATCH] Record that test_popen2 on Windows failed again, and why. Removed the line about "Windows threads problems" because I believe the test_popen2 failure is what that was talking about. --- pep-0200.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pep-0200.txt b/pep-0200.txt index 19a9e6702..b7fb11721 100644 --- a/pep-0200.txt +++ b/pep-0200.txt @@ -95,7 +95,6 @@ Failing test cases need to get fixed Open items -- Need to be resolved before 2.0b1 release Add popen2 support for Linux -- Fred Drake - There are some threads problems on windows... Deal with buffering problem with SocketServer -- GvR @@ -175,6 +174,15 @@ Previously failing test cases test_posixpath all 22-Aug-2000 test_popen2 Win32 26-Jul-2000 + [31-Aug-2000 tim + This died again, but for an entirely different reason: it uses a + dict to map file pointers to process handles, and calls a dict + access function during popen.close(). But .close releases threads, + which left the internal popen code accessing the dict without a + valid thread state. The dict implementation changed so that's no + longer accepted. Fixed by creating a temporary thread state in the + guts of popen's close routine, and grabbing the global lock with + it for the duration] [20-Aug-2000 tim changed the popen2.py _test function to use the "more" cmd when os.name == "nt". This makes test_popen2 pass under