Commit Graph

9 Commits

Author SHA1 Message Date
James Howe b085b2ddfa
PEP 615: consistent terminology (#1586)
* PEP-615 consistent terminology

It repeatedly refers to a ZoneInfo object as a "file", confusing it with either the file it was constructed from, or the IO object representing the file.

* Further clarification of caching implications
2020-09-08 18:44:27 -04:00
Marius Gedminas 116212bf6c
Add back missing example output (#1408) 2020-05-19 20:16:55 -04:00
Paul Ganssle d664bf5877
PEP 615: Mark as accepted (#1376) 2020-04-20 14:35:54 -07:00
Paul Ganssle 226d6efb95
PEP 615: Updates in response to Steering Council feedback (#1350)
* Rename nocache to no_cache

This is more consistent with the snake_case naming convention in
from_file and clear_cache.

* Add section on clear_cache

* Improve string representation section.

In response to suggestions by Barry Warsaw:

https://github.com/python/steering-council/issues/22#issuecomment-606169944

* Specify failure behavior for time zone data.

From discussion with Barry Warsaw:
https://github.com/python/steering-council/issues/22#issuecomment-606211514

* Add a footnote regarding the term "first-party"

Per comments from Barry Warsaw:
https://github.com/python/steering-council/issues/22#issuecomment-606211514
2020-04-04 11:35:27 -04:00
Paul Ganssle 58d2fdcb2c
PEP 615: Resolve "using datetime" and add rationale to updates section (#1347)
* Mark "use the datetime module" as rejected.

There did not seem to be any concerns about having `zoneinfo` live in
a separate module.

* Add additional rationale to updating behavior

* Update Post-History
2020-03-29 15:29:43 -04:00
Paul Ganssle cfe6639a6d
PEP 615: Move ICU support and alternate paths to rejected ideas (#1337)
* Move ICU support from "open" to "rejected".

* Move alternate environment variables to rejected
2020-03-29 12:25:55 -04:00
Paul Ganssle 37a7083660
PEP 615: Changes to TZPATH and str, plus minor tweaks (#1323)
* Change fallback behavior for __str__

Per Petr's suggestion in the discourse thread. Turns out this was
basically what the reference implementation does anyway.

* Rename `set_tzpath` to `reset_tzpath`

* Adjust TZPATH strategy

Partially in response to Petr's comment on the discourse thread, and
partially from further reflection.

* Fix typo in RFC 8536 reference

* Add path traversal to security implications.

Seems like a minor concern, but possibly worth noting.
2020-03-01 09:23:37 -05:00
Paul Ganssle 632742d2d7
PEP 615: Windows support, address first round of feedback (#1320)
* Address some of Petr's feedback

https://discuss.python.org/t/pep-615-support-for-the-iana-time-zone-database-in-the-standard-library/3468/3

* Update with description of update behavior

This is in response to Paul Eggert's insightful comments:

https://mm.icann.org/pipermail/tz/2020-February/028843.html

* Add note on leap seconds

Leap seconds are out of scope for the proposal, but several people have
asked about them, so it seems prudent to note this.

* Move Windows support to Open Issues

Based on comments sent privately by e-mail from Matt Johnson-Pint, who
suggested this approach.

* Make cache behavior explicit

Per Guido's comments, this was not previously explicit:

https://discuss.python.org/t/pep-615-support-for-the-iana-time-zone-database-in-the-standard-library/3468/10?u=pganssle

* Address Jelle's comment about type

* Update the pickle behavior to serialize by key

Per the discussion here (and the chain of posts that this replies to):
https://discuss.python.org/t/3468/17
2020-02-27 15:16:57 -05:00
Paul Ganssle b674d3ae26
PEP 615: Add PEP proposing zoneinfo module (#1316)
* Add IANA Time Zone Support PEP

* Add section rejecting Windows native time zones

* Normalize code-block and drop python3

Apparently this is rendered without pygments support, which is causing
the build to fail.

* Add justification for a separate module

* Clean up and reorganize footnotes and citations

This adds headlines / citations for each footnote, rather than bare
links, and tries to put them in a more logical grouping, and makes
them all render without issues.

* Add / adjust proposal targets

* Add justification for set_tzpath

Basically, "people are going to do this anyway, might as well have them
use a function that we can at least deprecate if it causes major
problems."

* Add citation for rearguard format

* Fix typos and formatting in abstract

Fixes a few typos and reformats the abstract using semantic newlines.

* Update location of reference implementation

* Tweaks to motivation section

* Clarify wording about PEP organization

* Tweaks to section on the ZoneInfo class

This adjusts the wording and fixes typos in the constructors and pickle
sections.

* Tweaks 'Sources for time zone data'

These are typos, clarifications and wording adjustments in the section
on time zone data sources.

* Use semantic newlines in 'Security implications'

* Clarify what 'no special verification' means

* Add clarification to custom compiler section

* Tweaks to wording on 'tzdata' in the standard library

* Tweaks to Windows section

* Adjust the justification for rejecting pytz

* Add quotation marks around blog titles

* Abandon semantic newlines

* Rename title

* Move module name into 'Open issues'

* Comment out temporarily unused headers

* Add open issue about TZPATH structure

* Remove erroneous blockquotes

* Add discourse link and Post-History
2020-02-25 10:56:05 -05:00