diff --git a/server/notification-providers/heii-oncall.js b/server/notification-providers/heii-oncall.js index 75ebf6140..585fa1381 100644 --- a/server/notification-providers/heii-oncall.js +++ b/server/notification-providers/heii-oncall.js @@ -17,19 +17,24 @@ class HeiiOnCall extends NotificationProvider { payload["url"] = baseURL + getMonitorRelativeURL(monitorJSON.id); } - if (!heartbeatJSON) { - // Testing or general notification like certificate expiry - payload["msg"] = msg; - return this.postNotification(notification, "alert", payload); + try { + if (!heartbeatJSON) { + // Testing or general notification like certificate expiry + payload["msg"] = msg; + return this.postNotification(notification, "alert", payload); + } + + if (heartbeatJSON.status === DOWN) { + return this.postNotification(notification, "alert", payload); + } + + if (heartbeatJSON.status === UP) { + return this.postNotification(notification, "resolve", payload); + } + } catch (error) { + this.throwGeneralAxiosError(error); } - if (heartbeatJSON.status === DOWN) { - return this.postNotification(notification, "alert", payload); - } - - if (heartbeatJSON.status === UP) { - return this.postNotification(notification, "resolve", payload); - } } /** @@ -49,15 +54,11 @@ class HeiiOnCall extends NotificationProvider { }; // Post to Heii On-Call Trigger https://heiioncall.com/docs#manual-triggers - try { - await axios.post( - `https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`, - payload, - config - ); - } catch (error) { - this.throwGeneralAxiosError(error); - } + await axios.post( + `https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`, + payload, + config + ); return "Sent Successfully"; } diff --git a/src/components/notifications/HeiiOnCall.vue b/src/components/notifications/HeiiOnCall.vue index 54c991344..7ae516c73 100644 --- a/src/components/notifications/HeiiOnCall.vue +++ b/src/components/notifications/HeiiOnCall.vue @@ -9,7 +9,7 @@ >