Commit Graph

9978 Commits

Author SHA1 Message Date
Justin Bertram 39b0f01ca9 ARTEMIS-4202 expand coverage of noCacheExceptions in LDAPLoginModule 2023-03-10 17:49:13 -06:00
Clebert Suconic 294daa0ff6 ARTEMIS-4162 Remove EMPTY_ROUTING_TYPES from AddressInfo
I have seen a werid intermittent failure in the testsuite
caused by some race where the EMPTY_SET ends up Not Empty! Causing weird failures that were really difficult to be investigated
2023-03-10 09:52:27 -08:00
Domenico Francesco Bruscino 648faf58cc ARTEMIS-4169 Auto detect dead-letter and expiry queues in the console 2023-03-10 10:33:04 -06:00
Domenico Francesco Bruscino 038d25064a ARTEMIS-4203 Replace aether-api with maven-resolver-api 2023-03-10 13:00:02 +00:00
Clebert Suconic 257dd86ae2 ARTEMIS-4193 Large Message Files orphaned after server killed
This fix is scanning journal and paging for existing large messages. We will remove any large messages that do not have a corresponding record in journals or paging.
2023-03-09 08:35:51 -08:00
Domenico Francesco Bruscino 7a0bf52ed8 ARTEMIS-4190 Fix config-delete-queues when address changes 2023-03-09 09:42:57 -06:00
Domenico Francesco Bruscino bb08a573eb ARTEMIS-3640 Use client connectors for HA 2023-03-09 11:20:51 +00:00
Gary Tully 00cae02ca4 ARTEMIS-4196 - set message routing type in mqtt publish 2023-03-08 14:30:30 -06:00
Clebert Suconic ed5322c54f NO-JIRA Fixing intermittent failure on ActiveMQServerControlUsingCoreTest
This failure was because of a noise from the test itself. as the test is creating a producer, and it's measuring for a producer from the test.
it makes no sense to fix it for OverCore.. we just ignore it on UsingCore
2023-03-08 12:13:17 -05:00
Clebert Suconic 3032bb9b0f NO-JIRA Adding more information on exception to track failing tests 2023-03-07 21:17:06 -05:00
Clebert Suconic dc93f01542 ARTEMIS-4199 PageCounter could leave a record pending in the journal
This is just an annoying thing. as the functionality would work properly if there was a previous value.
No other harm other than the cannot find TX record on startup for this, hence I'm fixing it.
2023-03-07 17:18:43 -05:00
Clebert Suconic 08a81a7402 I had a mistake reapplying the large message fix. I'm still reworking the commit.
I apologize for this spam

This reverts commit 14536bf311.
2023-03-06 20:05:18 -05:00
Clebert Suconic 6f974a359b ARTEMIS-4171 Test showing a Leak in Proton after deliveries sent to a consumer wihtout credits and would be closed 2023-03-06 17:04:18 -08:00
Clebert Suconic 216f5a3821 ARTEMIS-4171 Test showing a memory leak in the client with Proton-J and qpid-jms 2023-03-06 17:04:18 -08:00
Clebert Suconic ed620d09c8 ARTEMIS-4171 Skip Leaking Tests on FastTests 2023-03-06 17:04:18 -08:00
Clebert Suconic 0971886a36 ARTEMIS-4198 Upgrade qpid/proton-j at 0.34.1 2023-03-06 17:04:18 -08:00
Clebert Suconic 14536bf311 Revert "I'm temporarily reverting "ARTEMIS-4193 Large Message Files orphaned after server killed""
This reverts commit 7e6ce5a259.
2023-03-06 17:04:18 -08:00
Clebert Suconic 7e6ce5a259 I'm temporarily reverting "ARTEMIS-4193 Large Message Files orphaned after server killed"
while I figure out a better fix

This reverts commit 9f1927d3fa.
2023-03-06 12:31:54 -05:00
Justin Bertram c2a9ec73a3
NO-JIRA clarify MQTT sub queue clean-up doc 2023-03-03 14:26:22 -06:00
Robbie Gemmell 1f3745c87d ARTEMIS-4160: update the files used for the config upgrade testing to use the new comment.
Fixes the CompareUpgradeTest by removing this unimportant difference from a fresh broker instances jolokia-access.xml file, given that we dont actually update jolokia-access.xml currently during upgrade.

Tweaks or unwinds earlier changes in aae65fd527 and 3e7cb24381
2023-03-03 14:58:22 +00:00
Justin Bertram 97c78525da ARTEMIS-4181 make try-with-resources style consistent 2023-03-03 08:40:51 -06:00
Erwin Dondorp 5d024b7dd5 ARTEMIS-4183 fix relations on refresh icw added nodes 2023-03-03 08:40:20 -06:00
Clebert Suconic 812cdf3589 ARTEMIS-4194 Upgrade CheckLeak to 0.8 2023-03-02 21:15:17 -08:00
Clebert Suconic 9f1927d3fa ARTEMIS-4193 Large Message Files orphaned after server killed 2023-03-02 19:03:37 -08:00
Clebert Suconic aae65fd527 NO-JIRA Fixing CompareUpgradeTest 2023-03-02 18:12:51 -08:00
Clebert Suconic 3e7cb24381 NO-JIRA Adding CompareUpgradeTest to fast-tests 2023-03-02 18:12:51 -08:00
Justin Bertram 50e90cad5d ARTEMIS-4151 tighten default MBean access
This is a preventative measure to limit what users can do with any MBean
other than those in the hawtio or org.apache.activemq.artemis domains.
2023-03-02 19:17:14 -06:00
Justin Bertram b76c672305 ARTEMIS-4162 support deleting addresses & queues w/o usage check
There are certain use-cases where addresses will be auto-created and
never have a direct binding created on them. Because of this they will
never be auto-deleted. If a large number of these addresses build up
they will consume a problematic amount of heap space.

One specific example of this use-case is an MQTT subscriber with a
wild-card subscription and a large number of MQTT producers sending one
or two messages a large number of different MQTT topics covered by the
wild-card. Since no bindings are ever created on any of these individual
addresses (e.g. from a subscription queue) they will never be
auto-deleted, but they will eventually consume a large amount of heap.
The only way to deal with these addresses is to manually delete them.

There are also situations  where queues may be created and never have
any messages sent to them or never have a consumer connect. These
queues will never be auto-deleted so they must be deleted manually.

This commit adds the ability to configure the broker to skip the usage
check so that these kinds of addresses and queues can be deleted
automatically.
2023-03-02 19:17:03 -06:00
Justin Bertram 6874556f7c ARTEMIS-4188 auto-create + MDB using selector on queue 2023-03-02 16:26:12 -08:00
Clebert Suconic de7920d68a ARTEMIS-4191 Adding logger.debug on JournalImpl::needsCompact 2023-03-02 10:00:41 -05:00
Gary Tully dc7d1e25cc NO-JIRA - add test for ENC of tls params for broker amqp connection via props 2023-03-02 12:53:30 +00:00
Clebert Suconic 8078dd098c ARTEMIS-4171 Messages leaking thorugh AMQP Delivery
there are two leaks here:

* QueueImpl::delivery might create a new iterator if a delivery happens right after a consumer was removed, and that iterator might belog to a consumer that was already closed
             as a result of that, the iterator may leak messages and hold references until a reboot is done. I have seen scenarios where messages would not be dleivered because of this.

* ProtonTransaction holding references: the last transaction might hold messages in the memory longer than expected. In tests I have performed the messages were accumulating in memory. and I cleared it here.
2023-02-28 14:36:32 -05:00
Clebert Suconic 9e524d978d ARTEMIS-4175 JournalFileImpl Leaking
I am now removing the negatives once the file is removed or reused
2023-02-28 13:54:03 -05:00
Domenico Francesco Bruscino 7810a9d686 ARTEMIS-4179 Fix security-keycloak log errors 2023-02-27 11:46:55 +01:00
Justin Bertram 438dd47a78
ARTEMIS-4177 remove defunct logging doc 2023-02-24 12:15:11 -06:00
Domenico Francesco Bruscino aa8102d50f ARTEMIS-4179 Upgrade keycloak version to 21.0.0 2023-02-23 15:14:43 +00:00
Timothy Bish a7973c1dc3 ARTEMIS-4178 Fix some minor typos in broker connections docs
Fix a few small typos in the broker connections docs
2023-02-23 12:57:46 +00:00
Domenico Francesco Bruscino 8bdffe872c ARTEMIS-4176 Fix console custom root redirect 2023-02-23 12:56:06 +00:00
David Lanouette 7e1f6c1abe ARTEMIS-4160 Handle hostnames with double dashes
Previously, the code added a comment with the host name in it.
Sometimes hostnames don't follow the xml standards for comments.
Specifically, having a double dash ("--") in the host name would cause
an error when jolokia tried to load the config file - because it was
invalid xml.

The simple solution was to not put the host name into the comment.

A unit test has been included to ensure the same thing doesn't happen in the
future.

Signed-off-by: David Lanouette <David.Lanouette@RedHat.com>
2023-02-22 06:01:45 +01:00
Justin Bertram 7fe1a20909 ARTEMIS-4170 remove redundant queue creation for OpenWire
o.a.a.a.c.p.o.a.AMQConsumer#init will *always* try to create a core
queue when creating a consumer for a JMS queue. However, this is
already done in o.a.a.a.c.p.o.a.AMQSession#createConsumer.
2023-02-16 13:40:15 -08:00
Justin Bertram ef28cadfae ARTEMIS-4158 upgrade doc generation utils
Bump versions of NPM, Node, & HonKit. The changes to package-log.json
were automatically generated.
2023-02-16 13:38:44 -08:00
Justin Bertram fb169bc4af ARTEMIS-4172 sending large msg via core skips plugins & audit log 2023-02-16 13:34:29 -08:00
Justin Bertram 82fc42987a ARTEMIS-4171 potential large message file leak 2023-02-16 13:34:29 -08:00
Clebert Suconic c123a29f8e ARTEMIS-4161 Removing test.log left by accident 2023-02-16 16:10:28 -05:00
Clebert Suconic a2ba6ed298 ARTEMIS-4161 AMQP and OpenWire leaking leaking objects in certain conditions
The issue identified with AMQP was under Transaction usage, and while opening and closing sessions.
It seems the leak would be released once the connection is closed.

We added a new testsuite under ./tests/leak-tests To fix and validate these issues
2023-02-16 12:10:54 -08:00
Justin Bertram 49cc8ba1c8 ARTEMIS-4168 fix Keycloak example deps 2023-02-14 09:57:39 +00:00
Paul Wright d06d996950 NO-JIRA Add link to download page 2023-02-14 08:47:12 +01:00
Justin Bertram 9f04fea592
NO-JIRA add performance info to cluster doc 2023-02-13 14:07:51 -06:00
ALX 3db843a760 NO-JIRA Minor corrections to the HA documentation page 2023-02-13 11:53:58 +01:00
Justin Bertram d531a9378d
NO-JIRA update hacking guide 2023-02-10 12:24:20 -06:00