Commit Graph

2759 Commits

Author SHA1 Message Date
Clebert Suconic 15c2dbb1c3 ARTEMIS-3521 Option to disable duplicate detection on openwire failover clients 2021-10-06 16:26:01 -04:00
Clebert Suconic ef9011a83c ARTEMIS-3519 OperationContext not respecting store lineups and dones on store only 2021-10-06 14:56:19 -04:00
Clebert Suconic 481b73c8ca ARTEMIS-3502 Auto delete & auto create leading to inconsistencies 2021-10-05 17:53:30 -04:00
Clebert Suconic 20445bef7c ARTEMIS-3513 Fixing AIOJournalCompactTest 2021-10-05 15:06:51 -04:00
Clebert Suconic 557506140f ARTEMIS-3457 Dealing with String conversions
The test I wrote for ARTEMIS-3513 is throwing a few convert exceptions
because of SimpleString versus String conversion

This commit is addressing the issue,
The previous commit (the one addressing ARTEMIS-3513) should provide the test for this change.
2021-10-05 11:44:24 -04:00
Clebert Suconic ef63dc95bb ARTEMIS-3513 Compacting exception invalidates deletes and updates 2021-10-05 11:44:24 -04:00
Robbie Gemmell 20511375de NO-JIRA: update to errorprone 2.9.0, fix errors, enable it when running on Java 17+ 2021-09-29 11:55:40 +01:00
Andy Taylor e37175784c ARTEMIS-3493 - expose User ID (JMS Message ID) in send tab of console
https://issues.apache.org/jira/browse/ARTEMIS-3493
2021-09-28 08:11:26 +01:00
Clebert Suconic 116545c589 ARTEMIS-3498 Bridge reconnects will not clear delivering count statistics on internal queues 2021-09-24 16:40:59 -04:00
gtully 72cfda6b1a ARTEMIS-2007 - refactor to make use of existing refCountForConsumers for tracking consumer count and remove need for volatile redistributor 2021-09-24 15:07:01 +01:00
Justin Bertram e01d6c3846
ARTEMIS-2545 fix test 2021-09-20 12:54:14 -05:00
Domenico Francesco Bruscino 569c5994a5 ARTEMIS-3491 Fix cluster connection restart 2021-09-17 19:45:08 +02:00
Andy Taylor 0545664b3d ARTEMIS-3474 - replace whitelist with allowlist in management.xml
https://issues.apache.org/jira/browse/ARTEMIS-3474
2021-09-16 17:19:02 -05:00
Domenico Francesco Bruscino e8aeb99807 ARTEMIS-3477 Upgrade selenium-java to 3.141.59 2021-09-16 10:45:40 -04:00
Emmanuel Hugonnet f19337901a [ARTEMIS-2545]: Auto queue creation does not work with MDBs.
* Adding support for queue autocreation from the resource adapter.

Issue: https://issues.apache.org/jira/browse/ARTEMIS-2545
2021-09-16 10:44:54 -04:00
franz1981 cc527f6359 NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest 2021-09-16 14:16:39 +02:00
Justin Bertram 447422604c ARTEMIS-3484 flesh out Jakarta Messaging support
Back in version 2.17.0 we began to provide Maven artifacts for Jakarta
Messaging client resources. This commit expands that support in the
following ways:

 - Distribute a Jakarta Messaging 3.0 client with the broker (in the
   'lib/client' directory alongside the JMS client.
 - Update documentation.
 - Add example using the Jakarta Messaging client.
 - Update Artemis CLI to use core instead of JMS as it was causing
   conflicts with the new Jarkarta Messaging client.
 - Add example to build Jarkarta Messaging version of the JCA RA for
   deployment into Jakarta EE 9 application servers.
2021-09-15 15:20:54 -04:00
Clebert Suconic c3b403a980 ARTEMIS-3482 Removing non used methods and some reorg on message methods 2021-09-15 09:17:01 -04:00
Clebert Suconic b31737d2fc ARTEMIS-3464 Adding assertion to test 2021-09-13 15:07:53 -04:00
Clebert Suconic 14457c4308 ARTEMIS-3464 Protecting scheduled tasks counter with a synchronized 2021-09-13 14:35:45 -04:00
Clebert Suconic 6db6b8cf9e ARTEMIS-3442 Removing input for journal retention on cli create 2021-09-12 20:11:16 -04:00
Clebert Suconic 5dbbc98a62 ARTEMIS-3464 Fixing PageAckScanTest 2021-09-10 21:39:37 -04:00
Clebert Suconic 2fb23474ce ARTEMIS-3464 Improving ACK reliability on Paging and code improvements 2021-09-10 18:27:00 -04:00
Clebert Suconic 43ca9540be ARTEMIS-3472 Reconnect openwire could leave Openwire internal session null 2021-09-10 18:07:11 -04:00
Clebert Suconic 7792d8f7b3 ARTEMIS-3473 Some tests were leaving a directory named null for journal files under tests/integration-tests 2021-09-10 17:43:06 -04:00
Justin Bertram 8f6dd3ea37 ARTEMIS-3471 implement "session present" for MQTT CONNACK 2021-09-10 14:41:02 -05:00
gtully 6a346e71d4 ARTEMIS-3470 - exclude junit5 transitive deps - to allow junit introspection to work with our junit version 2021-09-10 15:21:10 +01:00
Domenico Francesco Bruscino 9ed12b53d6 ARTEMIS-3467 FD leak on receiving AMQP large messages 2021-09-09 16:56:52 -04:00
Clebert Suconic 7fb4f80649 ARTEMIS-3464 Missing ACKs on Page and Mirror 2021-09-08 15:30:39 -04:00
franz1981 1e5b361b6a ARTEMIS-3446 Pluggable quorum vote force live CLI command 2021-09-06 18:14:29 +02:00
franz1981 ce3b50c1a6 ARTEMIS-3430 Activation Sequence Auto-Repair 2021-09-06 18:14:29 +02:00
franz1981 c31db95f6b NO-JIRA Reduce amount of Apache Curator logs 2021-09-06 18:14:29 +02:00
franz1981 c629289e9b NO-JIRA speed-up replicated failback test 2021-09-06 18:14:29 +02:00
franz1981 44dd84d704 ARTEMIS-3429 Backup forget coordination-id after quorum loss 2021-09-06 18:14:29 +02:00
gtully 276f822a0e ARTEMIS-1925 - allow redistribution with new loadbalance type of OFF_WITH_REDISTRIBUTION to ensure local consumers get priority, we only optionally redistribute when messages are stuck 2021-09-06 11:18:11 +01:00
gtully b27aa03a37 ARTEMIS-1612 - strip any acceptor matching prefix from the message address such that further routing will match the lack of prefixes in broker routing, different fix for redistribution with prefixes 2021-09-06 11:08:36 +01:00
gtully e985df77fb ARTEMIS-3223 - ensure distribution uses the address from the message, rather than the address from the queue which may be a wildcard sub and not valid for publishng on, fix and test 2021-09-06 11:08:36 +01:00
gtully 224b89810d ARTEMIS-2007 - allow redistribution if there are unmatched messages pending on a queue and there is new remote demand 2021-09-06 10:40:39 +01:00
Justin Bertram 6ee7e72db1 ARTEMIS-3445 automatically clean-up abandoned MQTT subscriptions 2021-09-03 16:48:01 -04:00
Robbie Gemmell f82cd797cb NO-JIRA: undo addition of module-specific resources-plugin version from 97e84bb0d1
Also consolidates plugin configuration to fix warning from having plugin defined multiple times
2021-09-03 12:05:29 -04:00
Domenico Francesco Bruscino e984435b62 ARTEMIS-3455 Upgrade jasypt to 1.9.3 2021-09-02 16:13:28 +01:00
Domenico Francesco Bruscino 97e84bb0d1 NO-JIRA Fix test security resources copy 2021-09-01 15:10:29 -04:00
Robbie Gemmell 587e0f8252 ARTEMIS-3451: add dependencyManagement entry for qpid-jms-client, remove various redundant uses of property 2021-08-30 17:26:28 +01:00
Clebert Suconic b8ed0f21c8 NO-JIRA Fixing small typo on MessagesExpiredPagingTest 2021-08-27 13:20:42 -04:00
Robbie Gemmell 539749f0ba ARTEMIS-3447: update test use of bcprov-jdk15on to current 1.69 release
Also, remove stale exclusion that isnt doing anything
2021-08-26 17:13:37 +01:00
Clebert Suconic 9b8e82601b ARTEMIS-3442 Configure journal retention through cli create 2021-08-25 13:22:05 -04:00
Clebert Suconic 0266582a8f ARTEMIS-3441 Remove a few finalize methods 2021-08-24 19:08:00 -04:00
Clebert Suconic 4d2fd89882 ARTEMIS-3436 Journal Replay operation 2021-08-24 19:07:15 -04:00
Clebert Suconic edf688e706 NO-JIRA Adding Large Message into MessagesExpiredPagingTest 2021-08-24 18:52:45 -04:00
Clebert Suconic e05221eba4 ARTEMIS-3234 Adjusting sizes on MessagesExpiredPagingTest 2021-08-24 13:38:24 -04:00
Clebert Suconic ac46c56a2b ARTEMIS-3234 Adjusting sizes on MessagesExpiredPagingTest 2021-08-24 12:21:28 -04:00
Clebert Suconic d15680d8d9 ARTEMIS-3234 Additional test with expiry and paging
The issue found by this test has been previously fixed as part of ARTEMIS-3234

There's no additional fixing needed. This is just to commit the test to avoid future regressions.
2021-08-23 18:53:01 -04:00
Clebert Suconic 7e7150ffdc NO-JIRA Renaming TestTransfer as TransferTest to be compatible with the other tests names 2021-08-23 09:44:07 -04:00
Justin Bertram 3fd0eea667 ARTEMIS-3438 legacy updateQueue doesn't respect ringSize 2021-08-20 17:00:23 -04:00
Clebert Suconic ed4c915d50 ARTEMIS-3434 Fixing Journal Retention Wrong month 2021-08-20 11:22:33 -04:00
Andy Taylor 364d4cc324 ARTEMIS-3426 - fix copying of large retained message
https://issues.apache.org/jira/browse/ARTEMIS-3426
2021-08-19 09:58:28 -04:00
Clebert Suconic 52f429afa1 NO-JIRA Fixing ExpiryRunnerTest intermittent test failure 2021-08-19 09:00:09 -04:00
Robbie Gemmell fac1c4320d ARTEMIS-3423: remaining #3697 feedback, move the non-shared sub test out of the shared sub test class 2021-08-19 12:19:31 +01:00
Clebert Suconic 3edb96b09b ARTEMIS-3425 Possible NPE on Page reload 2021-08-18 17:49:35 -04:00
Clebert Suconic 656114045a ARTEMIS-3423 Addressing suggestiongs from Robbie Gemmel on PR #3697 2021-08-18 13:01:30 -04:00
Andy Taylor 191cb34c54 ARTEMIS-3423 - create correct queue when durable subs recreated via AMQP
https://issues.apache.org/jira/browse/ARTEMIS-3423
2021-08-18 12:41:19 -04:00
Justin Bertram 82f0ece67c ARTEMIS-3329 ability to purge all queues on address 2021-08-18 12:33:01 -04:00
Clebert Suconic 62cf93dd61 NO-JIRA Removing non used UnitTestLogger 2021-08-14 19:16:08 -04:00
Clebert Suconic b8c64590f9 [maven-release-plugin] prepare for next development iteration 2021-08-09 11:58:28 -04:00
Clebert Suconic 37cc298973 [maven-release-plugin] prepare release 2.18.0 2021-08-09 11:58:27 -04:00
Clebert Suconic cc4a51a3ea [maven-release-plugin] prepare for next development iteration 2021-08-06 17:04:18 -04:00
Clebert Suconic 0b30187091 [maven-release-plugin] prepare release 2.18.0 2021-08-06 17:04:16 -04:00
Clebert Suconic 2aebcb784b NO-JIRA Fixing Broker Balance Examples poms 2021-08-06 16:03:27 -04:00
Clebert Suconic ff27d10372 SNAPSHOT update on Extra Tests 2021-08-06 14:13:52 -04:00
Clebert Suconic 0e2ce484ba [maven-release-plugin] prepare for next development iteration 2021-08-06 13:46:56 -04:00
Clebert Suconic cb705b5c5c [maven-release-plugin] prepare release 2.18.0 2021-08-06 13:46:54 -04:00
Robbie Gemmell e72e7e74e9 ARTEMIS-3413: clean up tests to verify queue create behaviour, have names reflect what they check 2021-08-06 08:43:07 -04:00
Domenico Francesco Bruscino 3555dd7d25 ARTEMIS-3365 Add broker balancers 2021-08-06 08:33:21 -04:00
Domenico Francesco Bruscino 6d2b96c79e ARTEMIS-3275 Lock CORE client communication during failover retries 2021-08-06 08:32:59 -04:00
Clebert Suconic 2ee22912f0 ARTEMIS-3413 Testing with RemoveQueue=false on the replica 2021-08-05 18:30:01 -04:00
Clebert Suconic 56299433c3 ARTEMIS-3340 Removing not needed TemporaryFolder usages on tests 2021-08-05 14:18:21 -04:00
gtully ca7a100de0 ARTEMIS-3340 Sequential activation tracking for pluggable quorum replication policies + peer
Co-authored-by: franz1981 <nigro.fra@gmail.com>
2021-08-05 14:18:20 -04:00
Francesco Nigro 536271485f ARTEMIS-2716 Pluggable Quorum Vote 2021-08-05 14:18:20 -04:00
gtully c2da0fd663 ARTEMIS-3200 - remove braces from the belt and braces fix in ARTEMIS-2712, the braces are not necessary and leak, cleaning up in close negates the need to the session closeable 2021-08-05 09:27:12 -04:00
Robbie Gemmell 828d4940ec ARTEMIS-3302: enable some integration tests (primarily TLS+security) in the fast-tests profile
Help catch issues in these areas on PR runs rather than full builds.
2021-08-04 15:01:28 +01:00
Justin Bertram 9a2e2b3a34 ARTEMIS-3397 fix test failure 2021-08-04 09:20:12 -04:00
Robbie Gemmell 9726476c36 ARTEMIS-3410: disable karaf client integration tests on Java 16+ for now 2021-08-04 13:02:59 +01:00
Domenico Francesco Bruscino a741ae9994 ARTEMIS-3367 Set verifyHost true for connectors by default 2021-08-03 18:14:51 -04:00
Clebert Suconic 813ed88ecb ARTEMIS-3243 Implementing dual mirror with Broker Connections
There are some major tests added as part of this PR.

This PR has been done through an extensive collaboration with Robbie Gemmel on https://github.com/apache/activemq-artemis/pull/3633
2021-08-03 16:50:43 -04:00
Clebert Suconic b6d78076d4 NO-JIRA using latch::countdown on RedeployTest instead of new Runnable
I have done this just because I thought it was prettier
2021-08-03 12:34:21 -04:00
Justin Bertram 6bd30e8fe3 ARTEMIS-3385 management changes can be reverted by XML update
Durable changes made via the management API (e.g. adding
security-settings, adding address-settings, adding diverts) can be
reverted when reloading the XML at runtime.
2021-08-03 12:30:00 -04:00
Justin Bertram 516f3425e7 ARTEMIS-3393 support securityDomain on in-vm acceptor 2021-08-03 10:19:22 -04:00
Justin Bertram 8c3384a947 ARTEMIS-3397 remove queue rate metric from web console
This is a follow-up from ARTEMIS-2322.

The changes related to expired message are only there because
QueueFilterPredicate had a bug where the rate was correlated to expired
messages. When I fixed that I noticed that expired messages was actually
missing so I added it.
2021-08-03 10:15:57 -04:00
Justin Bertram 55533ae099 ARTEMIS-3394 ClassCastException when queue & divert have same name 2021-08-03 09:57:05 -04:00
Justin Bertram 7a9de8eea3 ARTEMIS-3302 swap deprecated X509Certificate
Casting the result of getPeerCertificates() to X509Certificate[] mirrors
what is done in the ActiveMQ "Classic" code-base.

A few tests which were imported from ActiveMQ "Classic" to verify our
OpenWire implementation were removed as they relied on a "stub"
implementation of javax.net.ssl.SSLSession that never would have worked
across multiple JDKs once javax.security.cert.X509Certificate[] was
removed. Furthermore, the tests appeared to be related to the OpenWire
*client* and not relevant to our broker-side implementation.
2021-08-03 09:55:36 -04:00
Andy Taylor c358688fd6 ARTEMIS-3404 - expose max retry interval on bridge mbean
https://issues.apache.org/jira/browse/ARTEMIS-3404
2021-08-03 09:07:39 -04:00
Robbie Gemmell 6b8fdcb079 ARTEMIS-3409: skip tests if preconditions cant be satisfied 2021-08-03 08:55:00 -04:00
franz1981 2694f8b52e ARTEMIS-3402 Split Brain detection should reject bad member updates 2021-08-03 14:43:20 +02:00
Robbie Gemmell ff9346d670 NO-JIRA: remove invalid tt tag usage to get javadoc building on Java 11 2021-07-30 15:39:20 +01:00
Robbie Gemmell 7ddc947413 ARTEMIS-3407: update pax-exam to 4.13.4 and karaf to 4.3.1, get tests working on Java 11
Also tweaks karaf test module name for clarity
2021-07-30 11:59:19 +01:00
Clebert Suconic eabfc0658f NO-JIRA Moving AssertionLoggerHandlerTest to Unit Tests
This would help capture issues with logging configuration on PR checks
2021-07-29 22:20:07 -04:00
Clebert Suconic 62c3d864a2 NO-JIRA Addressing Intermitent Failure on MessageExpirationTest 2021-07-29 17:50:26 -04:00
Clebert Suconic b8d0674ef9 NO-JIRA AssertionLoggerHandler improvements
I decided on NO-JIRA as this is only support tests themselves. No need for release notes on this commit:

I changed logging-CI.properties to be the same as logging.properties, with the only exception as file and console are limited by WARN.
while the AssertionLogger would still get INFO. as that's required for certain tests.
2021-07-29 11:38:26 -04:00
franz1981 4a677d01f0 NO-JIRA Speeding-up I/O paging for tests 2021-07-28 10:02:14 -04:00
franz1981 63577c7264 ARTEMIS-3405 Log the end of paging mode for a destination 2021-07-28 10:02:14 -04:00
Robbie Gemmell d9a44002c5 ARTEMIS-3304: replace use of deprecated constructors marked as for-removal since Java 16
updates all the uses in tests, missed in original commit
2021-07-27 14:55:40 +01:00
Justin Bertram f554806ec3 ARTEMIS-3400 add audit logging for message ack
Aside from adding audit logging for message acknowledgement this commit
also consolidates the two nearly identical acknowledge method
implementations in o.a.a.a.c.s.i.QueueImpl. This avoids duplicating
code for audit logging, plugin invocation, etc. There is no semantic
change.
2021-07-26 23:27:36 -04:00
Justin Bertram 2954829e3e ARTEMIS-3399 fix audit logging for AMQP
Due to the multi-threaded AMQP implementation the ThreadLocal variables
used by the AuditLogger to track the username and remote address don't
work properly. Changes include:

 - Passing the audit Subject (set during authentication) and the remote
   address explicitly for audit logging on the relevant ServerSession
   methods rather than relying on the AuditLogger's ThreadLocal
   variables
 - Audit logging core session creation *after* successful authentication
   so that we have the proper Subject; this is especially important for
   the SSL certificate authentication use-case
 - Renaming some methods and variables in AuditLogger to more accurately
   reflect their intended use
 - Adding JavaDoc and refactoring the getCaller methods on AuditLogger
 - Refactor audit log testing and add a new test
2021-07-26 23:27:35 -04:00
Justin Bertram bb9bbf062d ARTEMIS-3395 ensure sending audit log contains message ID 2021-07-23 14:28:53 -04:00
Domenico Francesco Bruscino 51801d978e ARTEMIS-3396 Convert bytes properties to String for OpenWire 2021-07-22 11:23:28 -04:00
Howard Gao 8a88c5f913 ARTEMIS-3392 Scale down would fail if target queue's id greater than max int 2021-07-21 15:12:43 -04:00
Clebert Suconic c479cb558a ARTEMIS-3384 Adding tests around duplicate detection 2021-07-16 09:10:14 -04:00
Clebert Suconic 277aa3706a NO-JIRA Adding Core Bridge Transfer Test 2021-07-16 09:09:48 -04:00
Domenico Francesco Bruscino 2d07d0d844 ARTEMIS-3384 Fix bridge duplicate messages after reconnection 2021-07-15 14:20:45 -04:00
Clebert Suconic b4aef3fca8 ARTEMIS-3386 Expiry messages using too many threads 2021-07-15 13:51:52 -04:00
Clebert Suconic ee3814dbfd ARTEMIS-3383 AMQPMessage.isDurable wrongly returns false during persistent lazy reload state 2021-07-12 23:00:16 -04:00
Justin Bertram ec508d8306 ARTEMIS-3381 AMQP bypasses session when deleting queues
The AMQP implementation bypasses the ServerSession when deleting queues
which also bypasses security authorization.
2021-07-12 11:25:11 -04:00
Justin Bertram bf875c3a37 ARTEMIS-3374 fix tests and shared subscriber case
A couple of tests were explicitly written to delete the
configuration-managed queue. Since this is no longer allowed these
tests had to change.
2021-07-12 11:25:11 -04:00
gtully 4c06d447fd ARTEMIS-2974 - fix up the regexp used in the test to match to the end 2021-07-09 14:56:29 +01:00
gtully 3961fd1cf2 ARTEMIS-3372 - ensure test verification happens after expected failover event such that expected message is not tracked as a duplicate 2021-07-09 12:41:17 +01:00
Clebert Suconic 000f83dbc2 ARTEMIS-3327 Reverting 5c051e9832 and adding test to validate
contract with sync.

This reverts commit 5c051e9832.

However this is adding two tests to make sure there won't be a regression on this.
2021-07-07 18:46:52 -04:00
franz1981 bb3f31340d ARTEMIS-3354 journal-max-io cannot be set to 1 with ASYNCIO journal 2021-07-07 12:17:36 -04:00
gtully 7fc312ab5d ARTEMIS-3372 - disconnect consumers on queue deletion event 2021-07-06 16:16:33 -04:00
Justin Bertram b7f9807cd9 ARTEMIS-2919 support timestamping incoming messages 2021-07-06 14:09:00 -05:00
Justin Bertram 1d02d06eab ARTEMIS-3374 config-managed queue can be deleted by durable subscriber 2021-07-06 14:06:39 -05:00
franz1981 bea0568a88 ARTEMIS-3360 Backup connector ignores TTL settings on the connection factories 2021-07-04 14:32:58 -05:00
Clebert Suconic 200e436931 ARTEMIS-3371 Adding TestContainers support and adding QpidDispatchPeerTest
This is testing peer integration with qpid-dispatch by using TestContainer and a docker image for Artemis
Also, as I added QpidDispatchTest, I reorganized the brokerConnect tests a bit into a brokerConnect folder.
2021-06-29 17:46:26 -04:00
Justin Bertram 45ae64a01c ARTEMIS-3366 deleteAddress can remove SnF queue 2021-06-24 13:27:35 -05:00
Clebert Suconic afa7209011 NO-JIRA Fixing Intermittent failure on AutoCreateExpiryResourcesTest with a Wait.assert change 2021-06-16 09:20:12 -04:00
Robbie Gemmell 98e5e19849 ARTEMIS-3347: update various commons-io usages, and bump all to latest
Consolidates and aligns versions missed in 73bcc78beb
2021-06-15 12:55:20 +01:00
Justin Bertram 867bf5e01e ARTEMIS-3155 support better backwards compatibility
Support better backwards compability for SSL keyStoreProvider and
trustStoreProvider.
2021-06-14 18:04:06 -04:00
Domenico Francesco Bruscino 65782cb457 ARTEMIS-3337 Add test on multiple connection failures 2021-06-14 16:37:02 -04:00
Justin Bertram a4c1155a01 ARTEMIS-3341 update checkstyle to latest + update code
As a follow-up to #3618/dc7de893747b90b627d729f9f18a758bb4dad9d5 update
checkstyle to the latest version, restoring the originally intended
"RightCurly" style, and updating all the code to properly adhere to the
style as enforced by the new checkstyle version.

The version of checkstyle we used before the aforementioned commit had
a bug which didn't properly enforced our intended "RightCurly" style
(see https://github.com/checkstyle/checkstyle/issues/6345). That commit
changed the style to accommodate the handful of unintended style
violations. This commit reverts that change for 2 main reasons:
 - The style was always intended to use `alone` for both `METHOD_DEF`
and `CTOR_DEF`.
 - There are over 1,000 existing uses of the intended style and around
30 violations of this style which were unintentionally allowed.

Reverting the style back to the original and cleaning up the unintented
violations makes the code more consistent and prevents further style
inconsistencies in the future.

There were a handful of other changes related to checkstyle bugs which
allowed unintended style violations. These were related to indentation
levels.

This closes #3619
(with some minor changes from Robbie to fix remaining violations)
2021-06-11 12:16:04 +01:00
Domenico Francesco Bruscino bafefdc8ec ARTEMIS-3338 Preserve prepared XA transactions on connection failure 2021-06-09 15:00:45 -04:00
Clebert Suconic 05498c350e ARTEMIS-3261 Remove need to lookup replaceableRecords on the hot path
We known it's a replaceable record as part of the logic, no need to lookup the record type unless it's a reload from the system.
2021-06-09 14:52:06 -04:00
gtully 085766033b no jira - remove unused log4j dependency 2021-06-08 10:19:12 +01:00
Justin Bertram 26b83985cf ARTEMIS-3330 JMS session stopped on failed rollback 2021-06-07 15:00:34 -04:00
Clebert Suconic 3913c17c8d NO-JIRA fixing intermittent failure on test 2021-06-07 13:05:34 -04:00
Clebert Suconic 0edf599adc ARTEMIS-3261 Updating logic to use only replaceable records on compacting verification 2021-06-07 13:05:02 -04:00
Clebert Suconic 7137252c5d NO-JIRA fixing spelling udpate as update 2021-06-03 10:43:11 -04:00
Clebert Suconic cfd032799c ARTEMIS-3327 removing unecessary blocking operations on update and delete records 2021-06-03 10:37:16 -04:00
gtully f4f31df97b no jira - only delay on expected messages and no wait on null. speed up test - thanks rgemmell 2021-06-03 15:17:48 +01:00
gtully 3f67d93592 no jira - intermittnet failure due to possibly slower hw, eliminate that 2021-06-03 12:22:52 +01:00
gtully 9484e49ab0 no jira - fix intermittent checkthreadrule failure in JDBCJournalTest 2021-06-03 11:28:39 +01:00
Clebert Suconic f380324ca3 NO-JIRA fixing intermittent failure with a Wait call 2021-06-02 19:53:26 -04:00
gtully 815f383f9c ARTEMIS-3234 - revisit fix to deal with credit on unmatched acks, thanks to brusdev for the interceptor feature and test from ARTEMIS-2650 2021-06-02 16:23:46 +01:00
Clebert Suconic ee92ddcb3b NO-JIRA Fixing test 2021-06-01 19:41:40 -04:00
Clebert Suconic 24c6d904b9 ARTEMIS-3324 JournalFilesRepository running out of open files while compacting 2021-06-01 16:36:51 -04:00
gtully 7ce9030e9f ARTEMIS-3323 - ensure openwire message id is unique and consistent for the life of a broker when converted from core 2021-06-01 19:43:25 +01:00
Domenico Francesco Bruscino ba6422d45f ARTEMIS-3315 Fix JSON serialization of AMQP messages
Replace the JSON serialization errors for unknown types with their respective string representation.
2021-05-27 11:31:25 -04:00
Justin Bertram cdaa00d470 ARTEMIS-3317 OpenWire property conversion can cause ClassCastException 2021-05-27 09:52:49 -04:00
Clebert Suconic cfee2035c8 ARTEMIS-3318 Invalid data on page should not hold page cleanup 2021-05-27 08:08:47 -04:00
Domenico Francesco Bruscino 6ec7a69d45 ARTEMIS-3236 Preserve managed queues on removing MQTT subscription 2021-05-25 11:24:53 -05:00
Justin Bertram e9c94e57d9 ARTEMIS-3288 support bulk user loading with basic security manager 2021-05-25 11:13:35 -05:00
Clebert Suconic 4de9e887f6 ARTEMIS-3309 Fixing QueueControlUsingCoreTest 2021-05-25 11:45:17 -04:00
Clebert Suconic f6df6083e3 ARTEMIS-3283 Fixing Slow Consuemr Test and speeding it up
I am removing some combinations that are not needed here,
and I'm adding another extra test to valiate the rate per minutes
2021-05-25 11:29:04 -04:00
Justin Bertram 3621258458 ARTEMIS-3285 potential duplicate messages with LVQ + non-destructive 2021-05-24 16:42:10 -04:00
Domenico Francesco Bruscino e03c4fe193 ARTEMIS-3309 Add a parameter to limit messages to move or transfer 2021-05-24 14:09:20 -04:00
Justin Bertram e543aa3bd5 ARTEMIS-3159 errors during concurrent expiration with auto-creation 2021-05-24 13:02:08 -05:00
Justin Bertram 81bbca15c1 ARTEMIS-3229 add details to AdressControl MBean 2021-05-24 11:51:14 -05:00
Martyn Taylor 3c0e14de58 ARTEMIS-3283 Added SlowConsumerThreshold unit configuration option 2021-05-24 11:49:38 -05:00
gtully 72c9cae8e1 ARTEMIS-3311 - ensure visibility of error state on operation context callback registration, fix and test 2021-05-24 16:07:36 +01:00
Clebert Suconic 847fe90411 ARTEMIS-3295 Removing Clutered OpenWire test since we are not clustering advisory any longer 2021-05-24 09:51:42 -04:00
Clebert Suconic c0128b29cb ARTEMIS-3297 Fixing BackupSyncLargeMessageTest 2021-05-24 09:05:58 -04:00
Clebert Suconic 3f38be8c08 ARTEMIS-3310 Paging could lose AMQPmessage if match didn't work for any reason 2021-05-20 13:19:57 -04:00
Domenico Francesco Bruscino 9e9e279d42 ARTEMIS-3294 Fix testTextMessageAttributeLimits 2021-05-20 13:19:39 -04:00
Clebert Suconic 5e622a642d ARTEMIS-3297 Fixing Tests that do not support retention on the file system 2021-05-18 22:27:39 -04:00
Clebert Suconic 27c343913f ARTEMIS-3297 Journal Retention Feature 2021-05-18 16:29:18 -04:00
Robbie Gemmell 2e2cd1f073 ARTEMIS-3296: get things building on Java 16 (and 17EA+21)
Updates parent pom, various plugins or deps, tidies up inconsistent versions
and consolidates to inherited version where possible, define properties for
some versions where not. Disables some problematic tests on JDK16+ for now.

Drops DS test dep back 1 version to remove a specific breakage affecting
multiple tests/modules, introduced after its upgrade in commit
9e70b26368.
2021-05-17 08:28:46 -04:00
Andy Taylor a34d9aad6b ARTEMIS-3295 - do not cluster advisories
https://issues.apache.org/jira/browse/ARTEMIS-3295
2021-05-14 10:08:21 -04:00
Robbie Gemmell a3de3d4c75 ARTEMIS-3038, ARTEMIS-2813: remove the CoreClientOverOneWaySSLKerb5Test test class
- It is already entirely disabled one or more ways depending on what JVM is in use.
- If enabled on any modern JVM it would either fail by default or can never work, as
  the related ciphers it requires have been disabled (8) or entirely removed (11+)
  due to being considered unsuitable for use.
2021-05-14 11:37:16 +01:00
Timothy Bish 9e70b26368 ARTEMIS-2813 Fix SaslKrb5LDAPSecurityTest failing on JDK 11
Fixes issues with SaslKrb5LDAPSecurityTest by updating to latest Apache Directory
release which required some updates to the test to fix deprecation warnings and an
updates to commons.lang to fix issues with new namespace for StringUtils that will
work on JDK 8+ only.
2021-05-14 10:07:38 +01:00
Timothy Bish 9513405020 ARTEMIS-2813 Update MiniKDC and fix Kerberos tests on JDK 11+
Updates the MiniKDC dependency and adds another now needed dep in order
to get the Kerberos tests working on JDK 11+ builds.
2021-05-14 10:07:38 +01:00
Clebert Suconic 67d47274a1 NO-JIRA removing runDirectJournalBlast 2021-05-12 09:51:56 -04:00
Clebert Suconic 4727be6a69 NO-JIRA fixing logging.properties 2021-05-12 09:51:56 -04:00
Clebert Suconic a30b3a81b9 ARTEMIS-3293 System test on Paging and DLQ processing 2021-05-11 16:30:23 -04:00
Clebert Suconic 5393470b84 NO-JIRA Reformating smoke-tests/pom.xml
no semantic changes on this commit.
just making it look prettier.
2021-05-05 16:27:53 -04:00
Clebert Suconic b0f8f515c5 ARTEMIS-3273 Recover tool and PrintData enhancements 2021-04-30 18:41:05 -04:00
Clebert Suconic d2676e77f8 ARTEMIS-3271 Improve Critical Analyzer to use AutoCloseable on the API 2021-04-30 12:46:15 -04:00
Clebert Suconic 42405fedcf ARTEMIS-3261 Expanding verification to journal compacting counters
After testing a production outage situation I still encountered issues on deciding the journal should be compacted.
This is addressing these issues.
2021-04-26 16:45:17 -04:00
Clebert Suconic 62395dcd44 ARTEMIS-3261 Fixing tests and allowing configuration to reload data files on start 2021-04-24 21:30:56 -04:00
Clebert Suconic 1392cb5f0b ARTEMIS-3261 Enhance compact to deal with Rollbacks and update records that can be replaced 2021-04-23 15:17:06 -04:00
Jacob Middag 6b86770079 NO-JIRA Fix description of DiskStoreUsage
In 73c4e399d9 a description is added to DiskStoreUsage. It incorrectly describes the diskStoreUsage as a percentage. This commit changes it to a fraction which it is (also before the description change). A percentage would be better, since MaxDiskUsage is also specified as percentage.
2021-04-19 12:47:29 -04:00
gtully 0f3d87799a ARTEMIS-3240 - ensure pending transactions are rolled back on connection failure. Fix and test 2021-04-16 10:22:06 -04:00
Clebert Suconic d408f284b1 ARTEMIS-3238 AMQP Mirror not routing correctly with SNF 2021-04-12 19:30:35 -04:00
gtully fa80c03049 ARTEMIS-3234 - fix and test, the existing tests suffered with suppressInternalManagementObjects defaulting to true. credit accounting is now independent of the ack list such that preack for advisories can work 2021-04-12 08:29:58 -04:00
Domenico Francesco Bruscino b4789a894f ARTEMIS-3221 Migrating to Jakarta EE 8 artifacts 2021-04-09 11:49:59 -04:00
gtully 9c9f89f1d5 ARTEMIS-3106 - remove sha-1 references from the test 2021-04-09 14:52:55 +01:00
Clebert Suconic 565d921a07 ARTEMIS-3106 Check style fix on SaslScramTest 2021-04-09 08:48:21 -04:00
Clebert Suconic 5642356c13 artemis-3106 Refactoring SaslScramTest to use ActiveMQTestBase
The main benefit on ActiveMQTestBase is to avoid thread leakaging between tests on this case
that is, one test affecting the next and being difficult to find the cause.
2021-04-09 08:43:21 -04:00
Clebert Suconic faf32fe550 ARTEMIS-3227 Web Console could be shutdown after certain failures 2021-04-08 19:59:00 -04:00
Christoph Läubrich 5313a800a3 ARTEMIS-3106 Support for SASL-SCRAM
adds the implementation necessary to perform SASL-SCRAM authentication with ActiveMQ Artemis
2021-04-08 19:58:09 -04:00
Domenico Francesco Bruscino a70b21cf89 NO-JIRA Fix SSLSupportTest for IBM JVM 2021-03-31 15:46:19 +02:00
Justin Bertram 0ca413004b ARTEMIS-3155 fix test 2021-03-29 11:38:42 -05:00
gtully 3b4872e1a2 ARTEMIS-3128 - add test of large message browse opentype support 2021-03-26 14:42:03 +00:00
Andy Taylor 658d45f543 ARTEMIS-3202 - add a flag to deleted diverts removed from config
https://issues.apache.org/jira/browse/ARTEMIS-3202
2021-03-24 19:24:16 -04:00
Andy Taylor 69bea6756c ARTEMIS-3201 - configured diverts arent persisted
https://issues.apache.org/jira/browse/ARTEMIS-3201
2021-03-24 19:24:16 -04:00
Domenico Francesco Bruscino e45c1d98d4 NO-JIRA Fix NettyConnectorWithHTTPUpgradeTest 2021-03-24 19:05:06 -04:00
Justin Bertram 186481bbe8 ARTEMIS-3155 differentiate SSL store type and provider
The provider of an SSL key/trust store is different from that store's
type. However, the broker currently doesn't differentiate these and uses
the provider for both. Changing this *may* potentially break existing
users who are setting the provider, but I don't see any way to avoid
that. This is a bug that needs to be fixed in order to support use-cases
like PKCS#11.

Change summary:
 - Added documentation.
 - Consolidated several 2-way SSL tests classes into a single
   parameterized test class. All these classes were essentially the same
   except for a few key test parameters. Consolidating them avoided
   having to update the same code in multiple places.
 - Expanded tests to include different providers & types.
 - Regenerated all SSL artifacts to allow tests to pass with new
   constraints.
 - Improved logging for when SSL handler initialization fails.
2021-03-24 09:08:33 -04:00
Clebert Suconic 8d24bfa646 ARTEMIS-3204 Fixing NPE on Counting Queue for Resource Limit 2021-03-24 08:12:40 -04:00
Clebert Suconic 7b8f34afe9 ARTEMIS-3196 Fixing ActiveMQServerControlUsingCoreTest 2021-03-23 18:49:47 -04:00
Clebert Suconic 89ea4ecda7 NO-JIRA Adding CoreMessage Test with Bytes access 2021-03-23 10:03:52 -04:00
Andy Taylor bb94d0a5b3 ARTEMIS-3196 - expose journal pool files in JMX
https://issues.apache.org/jira/browse/ARTEMIS-3196
2021-03-23 10:01:24 +00:00
gtully 02bb7031c2 ARTEMIS-3175 - implement address setting management-message-attribute-size-limit to sensibly limit data returned by list/browse/filter management ops 2021-03-23 09:48:45 +00:00
gtully 8fd1b33d16 ARTEMIS-3197 - add selectorAware option to virtualTopicConsumerWildcards for openwire acceptor 2021-03-22 19:15:02 -04:00
AntonRoskvist e9e1e476ee ARTEMIS-3198 Add concurrency option on core bridges 2021-03-22 19:13:06 -04:00
Clebert Suconic 41d9eef511 ARTEMIS-3191 Tests with Mirror and Credentials 2021-03-22 19:10:37 -04:00
Clebert Suconic b4beea1f2c ARTEMIS-3150 Broker Connections with restricted security
The local connections and sessions created internally were supposed to bypass security
just like bridges and other internal components
2021-03-22 17:32:43 -04:00
Markus Meierhofer 1d1a9433bc ARTEMIS-2870: Transfer connection close/failure listeners one by one on reattachment
Previously, when a session was reattached, all the close/failure listeners
were removed from the old connection and set onto the new connection.
This only worked when at most 1 session of the old connection was
transferred: When the second session was transferred, the old
connection already didn't contain any close/failure listeners anymore,
and therefore the list of close/failure listeners was overwritten by
an empty list for the new connection.

Now, when a session is being transferred, it only transfers the
close/failure listeners that belong to it, which are the session itself
+ the TempQueueCleanerUppers.

Modified a test to check whether the sessions are failure listeners of
the new connection after reattachment.
2021-03-18 18:26:07 -04:00
gtully 8d848f4615 ARTEMIS-3188 / ARTEMIS-2108 Fixing StackOverFlow over bindings
This fix was done in collaboration with Gary Tully
2021-03-18 18:08:42 -04:00
gtully 052bd60da4 ARTEMIS-3180 - fix multiple path match case in wildcard address map 2021-03-18 11:24:51 +00:00
Justin Bertram d36525348d ARTEMIS-3174 add test 2021-03-17 13:36:09 -05:00
Clebert Suconic 3c5b95c47c NO-JIRA Simple Logging Change on Test 2021-03-16 11:59:00 -04:00
Robbie Gemmell 96a09041ee ARTEMIS-3183: resolve various immediate warnings at build start
- Remove duplicates dependency definition following e7e3c71511.
- Removes deprecated RELEASE version use, consolidate modules on single paho client version.
- Remove prerequisites entry as per warning, suggested enforcer rule already in place.
2021-03-16 12:48:48 +00:00
Domenico Francesco Bruscino adf054f606 ARTEMIS-3144 Fix RestDeserializationTest 2021-03-11 13:09:15 +01:00
Clebert Suconic f49a163427 ARTEMIS-3137 Fixing Test with wrong message type on Xpath and Core 2021-03-10 21:44:07 -05:00
gtully 202601645b ARTEMIS-3141 - configure managementBrowsePageSize limit to 1k for test expectation 2021-03-10 16:15:20 +00:00
Justin Bertram eb26f67ab6 ARTEMIS-3137 support XPath filters
Change summary:
 - Remove the existing Xalan-based XPath evaluator since Xalan appears
   to be no longer maintained.
 - Implement a JAXP XPath evaluator (from the ActiveMQ 5.x code-base).
 - Pull in the changes from https://issues.apache.org/jira/browse/AMQ-5333
   to enable configurable XML parser features.
 - Add a method to the base Message interface to make it easier to get
   the message body as a string. This relieves the filter from having
   to deal with message implementation details.
 - Update the Qpid JMS client to get the jms.validateSelector parameter.
2021-03-10 09:32:23 -05:00
gtully 20007ad485 ARTEMIS-3141 - respect the browse page limit on all queue controll/jmx operations that use a queue browser 2021-03-10 08:51:06 -05:00
Domenico Francesco Bruscino 5a5794021c ARTEMIS-3044 Add Artemis web console tests 2021-03-10 08:23:13 -05:00
Domenico Francesco Bruscino d4f1552019 ARTEMIS-3123 Update netty version to 4.1.59.Final 2021-03-09 12:55:53 -06:00
franz1981 57e85bbc10 NO-JIRA fix flaky ReplicatedMultipleFailbackTest NPE 2021-03-05 10:18:48 -05:00
Domenico Francesco Bruscino 5aa3a4b6aa ARTEMIS-3147 Fix auto created addresses reload 2021-03-03 13:49:59 -05:00
gtully a0ce3812ba ARTEMIS-3067, ARTEMIS-3135 - rework accounting for lazy decoding by directly referencing the owning page store, owner now tracked on a message rather than the message reference. This avoids the error prone checks around potential decoding sites 2021-02-24 15:50:13 +00:00
Clebert Suconic 66040b009c ARTEMIS-3135 Fixing intermittent test failure 2021-02-23 13:59:26 -05:00
gtully a56ade38b4 ARTEMIS-3135 - track possible change in memory estimate when messages are converted to maps for JMX or UI display, follows up from ARTEMIS-3067 2021-02-23 15:30:40 +00:00
Clebert Suconic 12c8096a23 ARTEMIS-3093 Ordering on multiple consumers and core with rollback 2021-02-22 15:10:04 -05:00
franz1981 6126d926dd ARTEMIS-3045 ReplicationManager can batch sent replicated packets 2021-02-19 15:18:20 -05:00
Clebert Suconic 7d10e915b6 ARTEMIS-3116 Fixing Core->AMQP Conversion of Scheduled Delivery Time 2021-02-12 13:00:06 -05:00
Clebert Suconic 21ee5985ea [maven-release-plugin] prepare for next development iteration 2021-02-11 12:00:04 -05:00
Clebert Suconic 36a771150b [maven-release-plugin] prepare release 2.17.0 2021-02-11 11:59:51 -05:00
Clebert Suconic e7e3c71511 ARTEMIS-3113 - Artemis AMQP shouldn't depend on JMS.
* removing the  JMS dependency on AMQP module
* fixing destinations usage.
* refactoring to remove some JMS usage and make exceptions a bit better

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3113
2021-02-11 10:45:01 -05:00
Clebert Suconic c0867f0361 [maven-release-plugin] prepare for next development iteration 2021-02-09 12:12:48 -05:00
Clebert Suconic 9b473698e0 [maven-release-plugin] prepare release 2.17.0 2021-02-09 12:12:35 -05:00
Clebert Suconic 1647f5e1f1 NO-JIRA updating pom on jmh perf 2021-02-09 09:46:25 -05:00
Clebert Suconic 108334b333 NO-JIRA Fix Extra Tests pom 2021-02-08 16:09:13 -05:00
Clebert Suconic 6ed1e4c87d [maven-release-plugin] prepare for next development iteration 2021-02-08 15:56:31 -05:00
Clebert Suconic 06b29806ca [maven-release-plugin] prepare release 2.17.0 2021-02-08 15:56:18 -05:00
岳豹 9c5ec1b07c ARTEMIS-3105 large message file not closed on backup side 2021-02-07 10:41:41 +08:00
Clebert Suconic e65eff0f24 ARTEMIS-3096 Fixing compilation on JDK 1.8 2021-02-04 17:35:36 -05:00
Justin Bertram 15e3cdf409 ARTEMIS-3096 bridge config using wrong default conf-window-size 2021-02-04 13:48:37 -06:00
Emmanuel Hugonnet 40f4c0218e
[ARTEMIS-3080]: Provide JakartaEE 9 artefacts.
* using batavia and eclipse transformer to transform JMS code to JakartaEE.
* adding a test with JakartaEE
* upgrading owasp plugin to 6.1.0

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3080
2021-02-03 18:35:01 +01:00
Ingo Karkat 044d6101e9 ARTEMIS-3081 Swap precedence of key/tr.store props
If an application wants to use a special key/truststore for Artemis but
have the remainder of the application use the default Java store, the
org.apache.activemq.ssl.keyStore needs to take precedence over Java's
javax.net.ssl.keyStore. However, the current implementation takes the
first non-null value from
  System.getProperty(JAVAX_KEYSTORE_PATH_PROP_NAME),
  System.getProperty(ACTIVEMQ_KEYSTORE_PATH_PROP_NAME),
  keyStorePath

So if the default Java property is set, no override is possible. Swap
the order of the JAVAX_... and ACTIVEMQ_... property names so that the
ActiveMQ ones come first (as a component-specific overrides), the
standard Java ones comes second, and finally a local attribute value
(through Stream.of(...).firstFirst()).

(In our case the application uses the default Java truststore location
at $JAVA_HOME/lib/security/jssecacerts, and only supplies its password
in javax.net.ssl.trustStorePassword, and then uses a dedicated
truststore for Artemis. Defining both org.apache.activemq.ssl.trustStore
and org.apache.activemq.ssl.trustStorePassword now makes Artemis use the
dedicated truststore (javax.net.ssl.trustStore is not set as we use the
default location, so the second choice
org.apache.activemq.ssl.trustStore applies), but with the Java default
truststore password (first choice javax.net.ssl.trustStorePassword
applies instead of the second choice because it is set for the default
truststore). Obviously, this does not work unless both passwords are
identical!)
2021-02-03 12:02:19 -05:00
Domenico Francesco Bruscino bcdb13365e ARTEMIS-3075 Skip temporary queues scale down 2021-02-03 10:20:42 -05:00
Tomas Hofman ebeea15c2a ARTEMIS-3074 Add ActiveMQServerControl#createBridge() method variant accepting a JSON string 2021-02-01 19:21:40 -05:00
Justin Bertram d9e114da55 ARTEMIS-3089 direct delivery can break LVQ+non-destructive 2021-02-01 19:19:20 -05:00
Domenico Francesco Bruscino 267c6e5b56 ARTEMIS-3091 Fix AMQP message headers export from the journal 2021-02-01 11:54:37 -05:00
Clebert Suconic 1ed52cc5b0 NO-JIRA Speeding up AddressqueueDeleteDelayTest 2021-02-01 11:32:19 -05:00
gtully d186d20406 ARTEMIS-3067 - track application properties in memory estimate and check for modification after potential filter execution 2021-02-01 09:21:17 -05:00
gtully 05e9cfed4c ARTEMIS-3064 - ensure useTopologyForLoadBalancing is disabled when ha=false 2021-01-28 15:26:15 -05:00
Clebert Suconic f122b5059f NO-JIRA Improvements on StompStests
Replace some Wait clauses
Use lower timeout when results are expected to be null
2021-01-28 14:10:24 -05:00
Clebert Suconic c019218c4e ARTEMIS-3084 Eliminate Block on moving to next file on libaio 2021-01-28 11:10:40 -05:00
Justin Bertram 88b21f9039 ARTEMIS-3082 fix non-destructive + rollback 2021-01-27 20:41:33 -05:00
Ryan Yeats 86a2cad12a ARTEMIS-1884 add plugin API for message level authorization policies 2021-01-25 13:44:36 -06:00
Justin Bertram 4fbc8bf67d ARTEMIS-3008 mngmnt op to reload config file 2021-01-25 13:35:19 -06:00