Avoid local consumer starvation. We were not properly keeping the list sorted.

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@639422 13f79535-47bb-0310-9956-ffa450edef68

activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java

@@ -1145,14 +1145,8 @@ public class Queue extends BaseDestination implements Task {
     
     private void addToConsumerList(Subscription sub) {
         if (useConsumerPriority) {
-            int index = Collections
-                    .binarySearch(consumers, sub, orderedCompare);
-            // insert into the ordered list
-            if (index < 0) {
-                consumers.add(-index - 1, sub);
-            } else {
             consumers.add(sub);
-            }
+            Collections.sort(consumers, orderedCompare);
         } else {
             consumers.add(sub);
         }