Commit Graph

2742 Commits

Author SHA1 Message Date
Robert Davies 34378e8ec1 Only wait 1 second for connections to stop. When killing a stale
connection - if stop doesn't complete - it hangs the broker.

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@606241 13f79535-47bb-0310-9956-ffa450edef68
2007-12-21 16:45:21 +00:00
Robert Davies 9f94b6c509 Fix for https://issues.apache.org/activemq/browse/AMQ-1528
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@606022 13f79535-47bb-0310-9956-ffa450edef68
2007-12-20 20:42:43 +00:00
Hiram R. Chirino 01215e240d Updated version number now that 5.0.0 is out the door
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605972 13f79535-47bb-0310-9956-ffa450edef68
2007-12-20 16:23:16 +00:00
Hiram R. Chirino 471ea33051 Applied Dejan's patch on AMQ-1272 with some small tweaks.
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605944 13f79535-47bb-0310-9956-ffa450edef68
2007-12-20 14:37:41 +00:00
Robert Davies 462921addf Fix for https://issues.apache.org/activemq/browse/AMQ-1524
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605943 13f79535-47bb-0310-9956-ffa450edef68
2007-12-20 14:35:20 +00:00
Robert Davies 1d7b88431a Fix for https://issues.apache.org/activemq/browse/AMQ-1528
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605940 13f79535-47bb-0310-9956-ffa450edef68
2007-12-20 14:29:30 +00:00
Robert Davies de14440109 Fix for https://issues.apache.org/activemq/browse/AMQ-1525
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605698 13f79535-47bb-0310-9956-ffa450edef68
2007-12-19 21:09:40 +00:00
Robert Davies 8228663f6d close socket in a separate thread and only await stopLatch
for 2 seconds - as it close could be called by InactivityMonitor

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605671 13f79535-47bb-0310-9956-ffa450edef68
2007-12-19 19:50:11 +00:00
Robert Davies 3318a9f0e3 ConnectionClosed exceptions being thrown in a regular connection close
removed the isClosing() check before sending async

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@605518 13f79535-47bb-0310-9956-ffa450edef68
2007-12-19 11:49:15 +00:00
Robert Davies a32832f4cb Fix for https://issues.apache.org/activemq/browse/AMQ-1521
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@604700 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:40:50 +00:00
Robert Davies 5582cc1751 update performance tests
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@604691 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:16:59 +00:00
Robert Davies 628842f69a Fix for https://issues.apache.org/activemq/browse/AMQ-1518
take minimum threads to task factory to 0

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@604689 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:14:22 +00:00
Robert Davies 225d2bf055 try and ensure that the brokers shutdown cleanly for the
ReliableReconnectTest - as it can hang

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603952 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 16:52:27 +00:00
Robert Davies 0ac3f165dc changed unlock() method to use remove() instead of clearProperty
as this doesn't work on some platforms

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603927 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 14:45:01 +00:00
Robert Davies d4d9ba88b9 Add warning message if not enough space to complete a transaction
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603884 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 11:02:18 +00:00
Robert Davies 3099953b72 If can't recover message id from the store - change error message
to debug. The problem occurs because the message has already been
dispatched

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603881 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 10:56:07 +00:00
Robert Davies 388a5c4356 crap - left a Thread.dumpStack() method in the class - removing
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603873 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 10:41:16 +00:00
Robert Davies cea2f930c3 crap - left a Thread.dumpStack() method in the class - removing
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603869 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 09:57:27 +00:00
Robert Davies a3b4c5a358 Fix for https://issues.apache.org/activemq/browse/AMQ-1507
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603863 13f79535-47bb-0310-9956-ffa450edef68
2007-12-13 09:19:36 +00:00
Robert Davies 92bbce1d6f Fix for https://issues.apache.org/activemq/browse/AMQ-1507
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603772 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 23:10:25 +00:00
Robert Davies 1c4ef90ff3 Fix for https://issues.apache.org/activemq/browse/AMQ-1507
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603762 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 22:53:59 +00:00
Robert Davies a5a6a2a5d1 Added more synchronization
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@603348 13f79535-47bb-0310-9956-ffa450edef68
2007-12-11 20:19:46 +00:00
Hiram R. Chirino 27c87d20f3 Applied patch in AMQ-1515 Thx David.
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@602565 13f79535-47bb-0310-9956-ffa450edef68
2007-12-08 21:45:55 +00:00
Hiram R. Chirino 6f0dcac677 Added a little more debug logging to the InactivityMonitor because I suspect that
the schedular might not be triggering the read and write checks at the right time. 


git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@602553 13f79535-47bb-0310-9956-ffa450edef68
2007-12-08 21:31:14 +00:00
Hiram R. Chirino 2984963912 If you have a multi-threaded client which share 1 connection to the broker it is possible you may have seen errors like:
2007-12-05 14:14:52,606 [VMTransport] ERROR - org.apache.activemq.broker.TransportConnection.Service - Async error occurred: java.lang.IllegalStateException: Cannot lookup a connection that had not been registered: ID:bubba-38184-1196882086290-2:1
java.lang.IllegalStateException: Cannot lookup a connection that had not been registered: ID:bubba-38184-1196882086290-2:1
at org.apache.activemq.broker.SingleTransportConnectionStateRegister.lookupConnectionState(SingleTransportConnectionStateRegister.java:113)
at org.apache.activemq.broker.TransportConnection.lookupConnectionState(TransportConnection.java:1313)
at org.apache.activemq.broker.TransportConnection.processRemoveConsumer(TransportConnection.java:538)
at org.apache.activemq.command.RemoveInfo.visit(RemoveInfo.java:64)
at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:281)
at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:178)
at org.apache.activemq.transport.ResponseCorrelator.onCommand(ResponseCorrelator.java:100)
at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:67)
at org.apache.activemq.transport.vm.VMTransport.iterate(VMTransport.java:202)
at org.apache.activemq.thread.PooledTaskRunner.runTask(PooledTaskRunner.java:118)
at org.apache.activemq.thread.PooledTaskRunner$1.run(PooledTaskRunner.java:42)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
at java.lang.Thread.run(Thread.java:619)


root cause is that the client side has multiple threads calling close() on consumer/session and the connection objects. If the timing of those concurrent calls was just right, it is possible for the client to send the connection close message followed by a session or consumer close message which is invalid and would result in IllegalStateException reported by the broker.

- Simplified the ActiveMQConnection and TransportConnection shutdown so that this does does not happen.


git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@602529 13f79535-47bb-0310-9956-ffa450edef68
2007-12-08 18:56:11 +00:00
Robert Davies 8c541377bd Fix for excessive memory usage for durable consumers -
see https://issues.apache.org/activemq/browse/AMQ-1490

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@602440 13f79535-47bb-0310-9956-ffa450edef68
2007-12-08 10:03:26 +00:00
Robert Davies 5628b3e4ba Added synchronization to prevent concurrent modification
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@602260 13f79535-47bb-0310-9956-ffa450edef68
2007-12-07 22:47:10 +00:00
Robert Davies ddff5e5c16 Fix for https://issues.apache.org/activemq/browse/AMQ-1512
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@601011 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 17:21:54 +00:00
Robert Davies f472000467 Changes to address memory usage for large transactions for:
https://issues.apache.org/activemq/browse/AMQ-1490

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@600891 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 11:27:58 +00:00
Robert Davies 2913fb8ada Using wrong class to initialize the log
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@600671 13f79535-47bb-0310-9956-ffa450edef68
2007-12-03 20:33:34 +00:00
Hiram R. Chirino 1ba3532365 handle the inactivity actions in an async thread so that the schedular thread does not get blocked.
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599993 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 22:39:26 +00:00
Hiram R. Chirino d83969f6a8 Allow a blocked thread to unwind if it's connection is getting terminated.
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599835 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 14:42:53 +00:00
Hiram R. Chirino 27dff3538c Glen Mazza pointed out a little typo
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599493 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 15:51:48 +00:00
Robert Davies d59fd98daa updated so that we can use delete the db on start-up
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599470 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 15:03:29 +00:00
Robert Davies 9dd11cb71f Fix for https://issues.apache.org/activemq/browse/AMQ-1490
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599129 13f79535-47bb-0310-9956-ffa450edef68
2007-11-28 20:19:27 +00:00
Robert Davies 987ad27449 removed System.out logging
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@599122 13f79535-47bb-0310-9956-ffa450edef68
2007-11-28 20:02:16 +00:00
Guillaume Nodet ca4c58b564 Camel should be optional
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@598942 13f79535-47bb-0310-9956-ffa450edef68
2007-11-28 10:26:00 +00:00
Robert Davies bbe26eddc2 Fix for https://issues.apache.org/activemq/browse/AMQ-1502
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@598330 13f79535-47bb-0310-9956-ffa450edef68
2007-11-26 16:15:12 +00:00
Robert Davies fd2c95e9bc Fix for https://issues.apache.org/activemq/browse/AMQ-1491
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@597582 13f79535-47bb-0310-9956-ffa450edef68
2007-11-23 07:51:02 +00:00
Robert Davies ba8b248788 Fix for https://issues.apache.org/activemq/browse/AMQ-1500
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@597581 13f79535-47bb-0310-9956-ffa450edef68
2007-11-23 07:40:51 +00:00
Hiram R. Chirino 1aab7d3597 Adding missing headers
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@594172 13f79535-47bb-0310-9956-ffa450edef68
2007-11-12 15:11:44 +00:00
Hiram R. Chirino 88bdc562f1 Adding missing headers
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@594170 13f79535-47bb-0310-9956-ffa450edef68
2007-11-12 15:09:51 +00:00
Hiram R. Chirino 5e3aa21375 Scale back this test a little bit. It was storing 1.6 GIG is message contents. Which took a long time to store and also
will fail on machines that don't have the much free space.  If we want to run BIG tests like that they should go into a
system testing module.  Scaled it back so that only 160 Megs of data are generated by the test


git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@593585 13f79535-47bb-0310-9956-ffa450edef68
2007-11-09 16:30:07 +00:00
Hiram R. Chirino 2edad74ca9 The VMTransport now let's it's peer know when it's being stopped so that the Peer can give its' transport listener a peer disconnected exception. Otherwise a VM transport client could disconnect without the server side knowing it disconnected and the server side would not terminate it's side of the connection. This could be seen as a memory leak on when the static network config is setup and one of the static brokers is not up.
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@593204 13f79535-47bb-0310-9956-ffa450edef68
2007-11-08 15:39:51 +00:00
Hiram R. Chirino 5c45b00b1c Update YourKit profiling options since we now require java 1.5
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592818 13f79535-47bb-0310-9956-ffa450edef68
2007-11-07 17:06:21 +00:00
Hiram R. Chirino 04a637916e Added better temp destination support. We now properly create temp destinations that the client can subscribe to
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592531 13f79535-47bb-0310-9956-ffa450edef68
2007-11-06 19:44:58 +00:00
Hiram R. Chirino ada47fbc50 - memory leak fix: TransportConnection would leak memory if an error occured while start()ing the connection. Most visible when you create a network connector pointing at a remote broker that was down since this loops through creating TransportConnectors every few seconds.
- Deadlock fix VMTransport could dead lock if during start() an error occured and stop was recusively called.



git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592114 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 18:47:16 +00:00
Hiram R. Chirino 62890b3fbb - Reduced verbosity of logging in TransportConnector so that exceptions should only be in DEBUG messages.
- Added more logging to SimpleDiscoveryAgent so that we can see what it's doing in regards to reconnect handling and
  enabled exponential backoff by default.



git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592090 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 17:07:38 +00:00
Hiram R. Chirino 9ecfbf98f5 failover is no longer a vaild option on networkConnector
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592061 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 16:13:24 +00:00
Hiram R. Chirino 3c46ae9e71 The conf directory should be relative to the ACTIVEMQ_BASE
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@592057 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 16:06:06 +00:00