Commit Graph

502 Commits

Author SHA1 Message Date
gtully aa03f295f5 AMQ-7464 - ensure message.copy before server session run dispatch 2020-04-08 14:57:49 +01:00
jbonofre 6355f507c3 Revert "AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420"
This reverts commit 503416a001.
2020-03-10 16:16:01 +01:00
Colm O hEigeartaigh 67fb6f8871 AMQ-7423 - Remove synchronization from JAAS PropertiesLoader 2020-02-27 15:29:26 +00:00
Jean-Baptiste Onofré bfb810c507
Merge pull request #466 from coheigea/misc_fixes
AMQ-7413 - Misc logging fixes
2020-02-22 07:49:55 +01:00
gtully 503416a001 AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420 2020-02-19 13:01:25 +00:00
Daniel Trebbien b020cba744 Fix some incorrect SLF4J logger calls
In some cases, there were an inconsistent number of formatting anchors.

In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien 7b528ecee7 Fix some typos 2020-02-19 08:01:41 +00:00
Daniel Trebbien 252dda94a3 Reformat some code 2020-02-19 07:50:20 +00:00
Jean-Baptiste Onofré a9d89572ef
Merge pull request #449 from PascalSchumacher/setter_getter_synchronization
AMQ-7402: Inconsistent synchronization of getters/setters of some cla…
2020-02-13 08:15:57 +01:00
Jean-Baptiste Onofré 4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
Pascal Schumacher 6764511fa1 Fix unused format arguments in log messages. 2020-02-12 17:52:28 +01:00
Pascal Schumacher 5356893fac AMQ-7402: Inconsistent synchronization of getters/setters of some classes
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
jbonofre 097506a458 [AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default 2020-02-12 13:43:03 +01:00
Pascal Schumacher dac97e6294 [AMQ-7401] Make double-checked locking thread-safe by declaring the field volatile. 2020-02-10 19:06:17 +01:00
gtully 5a0c853ba0 AMQ-7353 - fix visibility of marshalledProperties to ensure competing threads don't see partial objects in error. Little test case that demonstrates the problem in isolation 2019-11-26 16:58:30 +00:00
Christopher L. Shannon (cshannon) 0c6f9a9a1e AMQ-7352 - Add support for anonymous producer advisories
By default this behavior is turned off but can be enabled by setting
anonymousProducerAdvisorySupport on the BrokerService to true
2019-11-22 13:35:32 -05:00
Jean-Baptiste Onofré a59ebe7d09
Merge pull request #283 from SaivR1t/master
AMQ-6963 Fix calling the toString() method in case of different log level.
2019-11-18 05:50:37 +01:00
Jean-Baptiste Onofré 057b950485
Merge pull request #322 from deeyes24/failing_cronparsertest_inIndia
NO-JIRA: CronParserTest is failing in Indian StandardTime
2019-11-17 06:56:20 +01:00
Christopher L. Shannon (cshannon) 65de327369 AMQ-7300 - Remove unnecessary call to sequence updater as read is already volatile 2019-09-06 12:19:23 -04:00
Christopher L. Shannon (cshannon) 4db2656066 AMQ-7300 - Improve performance of LongSequenceGenerator
LongSequenceGenerator now uses an AtomicLongFieldUpdater instead of
synchronized
2019-09-06 11:55:54 -04:00
gtully 02548777c2 AMQ-7298 - rework redelivery message tracking to ensure no duplicate suppression (and dlq) in error for local transaction batches that failover 2019-09-04 12:24:42 +01:00
Jean-Baptiste Onofré 7e72fbc98b [AMQ-7254] Fix OSGi headers 2019-08-05 08:38:47 +02:00
gtully de3f77063f AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test 2019-06-21 16:55:13 +01:00
gtully 30abc45f62 no jira - remove extraneous printStackTrace, ex is propagated up 2019-04-18 14:38:30 +01:00
gtully 487d4a112e AMQ-7185 - track durable sub prepared acks in preCommit callback and release/remove on xa outcome, avoid duplicate delivery; fix and test 2019-04-17 14:31:11 +01:00
gtully b9bcd2fcc3 AMQ-7165 - ensure failover updated uris are additive such that statically configured uris are respected 2019-03-12 12:24:20 +00:00
Alan Protasio 4b51f8b66c AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown) 2019-01-14 10:54:26 -05:00
212726340 b65fedf4dd NO-JIRA: CronParserTest is failing in Indian StandardTime 2018-11-23 15:49:04 +05:30
Colm O hEigeartaigh a87b61e8be Enable secure processing on all DocumentBuilderFactory.newInstance() 2018-11-22 10:24:43 +00:00
Christopher L. Shannon (cshannon) 02c1e6d8f2 AMQ-7047 - clarify documentation 2018-09-24 07:35:00 -04:00
Christopher L. Shannon (cshannon) 0b71b06ac8 Revert "AMQ-7004 - Improved logging in Failover Transport"
This reverts commit 7974e8c099.

This caused problems with too much logging so reverting
2018-09-04 06:53:00 -04:00
Christopher L. Shannon (cshannon) 1e31df9800 AMQ-7047 - Switch default for hostname verification to be false for
server

For the client it makes sense to have it true by default but for the
server it makes sense to have it false by default
2018-08-31 13:04:14 -04:00
Christopher L. Shannon (cshannon) 69fad2a135 Add support for hostname verification 2018-08-31 06:39:49 -04:00
gtully 8bb3a77270 AMQ-5917 - fix sync on SslContext lazy initialisation 2018-08-20 12:23:53 +01:00
Christopher L. Shannon (cshannon) 7974e8c099 AMQ-7004 - Improved logging in Failover Transport 2018-07-30 07:56:33 -04:00
giliva 5b1412ddfd Avoid overflow errors - see KAFKA-4290
Add test for overflow values

Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
gtully 0b76d3a0ea AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map 2018-07-26 10:42:10 +01:00
Jeff Genender 7f4851f31c [AMQ-7013] Added final for thread safety 2018-07-18 15:13:31 -06:00
jgoodyear e9a64b1c72 [AMQ-7013] Introduce JenkinsHash to XATransactionID 2018-07-18 10:39:29 -06:00
gtully 2b64b7b04f AMQ-4706 - ensure we log the first warn and include the failure reason 2018-07-05 17:34:30 +01:00
gtully 5ebee0ace7 AMQ-7000 - ensure server sessions with closed active sessions get removed from the pool on stop, fix and test 2018-06-26 11:07:04 +01:00
gtully 004be56127 AMQ-2659 - make configurable based on xaAckMode, otherwise pure xa case can default to autoack in error. Additional tests 2018-06-13 11:48:43 +01:00
Timothy Bish db8c771b2a AMQ-6968 Ensure that the correct exception is thrown
Allow the original exception that triggered the failure to be thrown
from the packet send methods
2018-05-21 16:39:58 -04:00
saivr1t 191e4ffbe6 AMQ-6963
Fix calling the toString() method in case of different log level.
2018-05-15 18:46:36 +03:00
saivr1t 2a95348182 AMQ-6959
Avoid creating a Throwable in case of non-trace logging
2018-05-14 15:11:10 +03:00
Christopher L. Shannon (cshannon) 703b7b1510 AMQ-6901 - Add NPE check inside DestinationMap filter 2018-02-16 14:32:24 -05:00
Christopher L. Shannon (cshannon) 2ce1c1352f AMQ-6901 - Make sure proper policy is used to configure a destination
When multiple wildcard policies exist in a hierarchy it was possible for
the wrong policy to be selected when configuring a destination
2018-02-16 10:41:33 -05:00
Christopher L. Shannon (cshannon) 4535e8f097 AMQ-6884 - Replacing printStackTrace() with logging statement 2018-01-11 07:27:03 -05:00
Sami Nurminen 39caca7cf6 AMQ-6327 - Remove System.out.println 2017-12-22 18:16:14 -05:00
Sami Nurminen 051e2b791c AMQ-6327 - getNextScheduledTime() returns incorrect time when working with day of month 2017-12-20 21:47:47 +02:00