Christopher L. Shannon (cshannon)
2fcf2fd75f
AMQ-8287 - fix NIOSSLTransport deadlock with serviceRead lock
...
This narrows the lock that was added to serviceRead() to secureRead()
which prevents processing commands while locked which should solve the
deadlock issues
2021-06-02 09:47:24 -04:00
Matt Pavlovich
950a140455
[AMQ-8282] Migrate from deprecated .newInstance() calls to .getConstructors().newInstance
2021-06-02 08:30:36 -05:00
Matt Pavlovich
2cc17a2fa0
[AMQ-8279] Compiler warning cleanups
...
- Remove unsused imports (exept for generated classes)
- Convert to T.valueOf on boxed primitives from new T()
2021-05-25 09:34:35 -05:00
Jean-Baptiste Onofré
fc80b86ac6
[AMQ-7442] Support JDK11 full build and code style ( #647 )
2021-05-25 06:55:39 +02:00
gtully
c4d2ddfce9
AMQ-7298 - fix regression with broker redelivery plugin, fix and test relates to AMQ-8168
2021-04-16 13:12:13 +01:00
Jean-Baptiste Onofré
db6098c53a
Merge pull request #365 from jgallimore/master-AMQ-7149
...
AMQ-7149 Remove dependency activemq-http and activemq-stomp
2021-03-24 11:36:04 +01:00
Jean-Baptiste Onofré
4c7bb06503
Merge pull request #423 from mdaley/master
...
Stop failed timer task from breaking timers.
2021-03-23 14:43:43 +01:00
Jean-Baptiste Onofré
ea5b2d8813
Merge pull request #274 from ashakirin/master
...
AMQ-6894: limit poison exception message to 1024
2021-03-22 06:02:38 +01:00
Christopher L. Shannon (cshannon)
944ca6c7e1
AMQ-8183 - prevent infinite loop when maxFrameSize is exceeded
...
This makes sure the nio transport thread properly terminates if
maxFrameSize is exceeded with OpenWire to prevent an infinite loop that
uses up all the cpu
2021-03-11 09:59:36 -05:00
Christopher L. Shannon (cshannon)
1654e6c79c
AMQ-8169: Synchronize on serviceRead inside NIOSSLTransport
...
This is needed to prevent concurrent access to the SSLEngine during
initialization. This is a regression from when auto+nio+ssl was added.
2021-03-08 11:28:33 -05:00
jbonofre
cbc1baa07a
[AMQ-8097] Deal with deserialization with xstream unmarshal poison ack
2021-01-13 16:13:25 +01:00
Jean-Baptiste Onofré
02d4f8efec
Merge pull request #565 from alevandoski/master
...
AMQ-8011 - Performance Related issue in ClassLoadingAwareObjectInputS…
2020-11-21 19:05:54 +01:00
Jean-Baptiste Onofré
5bc7532d42
Merge pull request #569 from garydgregory/NPE_NetworkInterface_getNetworkInterfaces
...
Guard against null NetworkInterface.getNetworkInterfaces()
2020-11-20 18:13:19 +01:00
Gary Gregory
d292372902
Guard against null return value from
...
java.net.NetworkInterface.getNetworkInterfaces().
2020-11-05 10:13:50 -05:00
Benjamin Graf
a2e718f259
AMQ-8055 - rename posion to correct poison
2020-10-23 09:50:18 +02:00
Andrew Levandoski
f3e0ab4c5a
AMQ-8011 - Performance Related issue in ClassLoadingAwareObjectInputStream.checkSecurity()
2020-10-20 17:21:31 -04:00
gtully
0c986c33f6
AMQ-8039 - support system property configuration of the inactivity monitor thread pool, follow example of nio. new test to verify
2020-09-11 10:39:15 +01:00
Christopher L. Shannon (cshannon)
17defa79d4
NO-JIRA: Update branch to 5.17.0-SNAPSHOT after release
2020-07-14 07:27:43 -04:00
Jean-Baptiste Onofré
334476ac63
[maven-release-plugin] prepare for next development iteration
2020-06-25 07:26:41 +02:00
Jean-Baptiste Onofré
86dd78b1aa
[maven-release-plugin] prepare release activemq-5.16.0
2020-06-25 07:26:13 +02:00
Jean-Baptiste Onofré
6908749c2f
Fix version
2020-06-25 07:13:04 +02:00
Jean-Baptiste Onofré
ff2dae82f3
[maven-release-plugin] prepare release activemq-5.16.0
2020-06-24 21:56:52 +02:00
jbonofre
4ed2ba22a9
Cancel 5.16.0 release
2020-06-24 15:19:34 +02:00
Jean-Baptiste Onofré
cd1e9f8697
[maven-release-plugin] prepare for next development iteration
2020-06-23 17:40:26 +02:00
Jean-Baptiste Onofré
2e890c6224
[maven-release-plugin] prepare release activemq-5.16.0
2020-06-23 17:39:53 +02:00
Jean-Baptiste Onofré
4991668549
Merge pull request #517 from coheigea/AMQ-7450
...
AMQ-7450 - Put some restrictions on the URLs that are allowed in Blob…
2020-06-23 07:01:38 +02:00
jbonofre
88525ce650
[AMQ-7121] Set setter accessible (for JDK 11)
2020-06-22 17:35:49 +02:00
gtully
ed41101755
AMQ-7497 - support reconnect of the single RA xaResource connection
2020-06-11 19:39:18 +01:00
Colm O hEigeartaigh
45108a2328
AMQ-7450 - Put some restrictions on the URLs that are allowed in BlobMessages
2020-05-25 14:24:10 +01:00
Pascal Schumacher
efcca7d062
Fix javadoc warnings related to non-existing parameter names.
2020-05-22 10:49:39 +02:00
gtully
62cfe83e9d
[AMQ-7291] rework fix to initializeWriting but just with the read only properties check
2020-05-21 10:41:58 +01:00
Jean-Baptiste Onofré
173426c55c
Merge pull request #535 from jbonofre/AMQ-7480
...
[AMQ-7480] Avoid NPE if original exception is null
2020-05-21 09:52:33 +02:00
jbonofre
ecbeb6d2eb
[AMQ-7480] Avoid NPE if original exception is null
2020-05-19 16:51:23 +02:00
Pascal Schumacher
67e06c82f7
Fix some javadoc warnings releated to non-existing parameter names.
2020-05-17 11:38:05 +02:00
Jean-Baptiste Onofré
079d9d7fe4
Merge pull request #504 from PascalSchumacher/ServiceStopper#throwFirstException_remove_unreachable_code
...
Remove unreachable code in ServiceStopper#throwFirstException.
2020-05-16 07:20:39 +02:00
Jean-Baptiste Onofré
0444dd96b2
Merge pull request #505 from PascalSchumacher/potential_overflow_in_int_multiplication
...
Avoid potential overflow in int multiplication before it is converted…
2020-05-16 07:17:13 +02:00
gtully
0ebb0f88ef
[AMQ-7485] add check for rollbackonly flag in session send such that failed ended transactions prevent further work till next transaction boundary
2020-05-15 15:39:56 +01:00
Jean-Baptiste Onofré
41bef94293
Merge pull request #521 from coheigea/AMQ-7458
...
AMQ-7458 - Implement bounds checking on the message scheduling proper…
2020-05-15 15:52:23 +02:00
anushaCoder
a5e70fa2d7
[AMQ-7463] Use ConcurrentHashMap in client connection state to avoid ConcurrentModificationException
2020-05-15 06:40:36 +02:00
gtully
aa03f295f5
AMQ-7464 - ensure message.copy before server session run dispatch
2020-04-08 14:57:49 +01:00
Colm O hEigeartaigh
24aaa4698c
AMQ-7458 - Implement bounds checking on the message scheduling properties
2020-03-27 12:14:03 +00:00
jbonofre
6355f507c3
Revert "AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420"
...
This reverts commit 503416a001
.
2020-03-10 16:16:01 +01:00
Pascal Schumacher
b43f5b8cf2
Avoid potential overflow in int multiplication before it is converted to long.
2020-03-08 11:50:21 +01:00
Pascal Schumacher
68355136d2
Remove unreachable code in ServiceStopper#throwFirstException.
2020-03-08 11:27:24 +01:00
Colm O hEigeartaigh
67fb6f8871
AMQ-7423 - Remove synchronization from JAAS PropertiesLoader
2020-02-27 15:29:26 +00:00
Jean-Baptiste Onofré
bfb810c507
Merge pull request #466 from coheigea/misc_fixes
...
AMQ-7413 - Misc logging fixes
2020-02-22 07:49:55 +01:00
gtully
503416a001
AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420
2020-02-19 13:01:25 +00:00
Daniel Trebbien
b020cba744
Fix some incorrect SLF4J logger calls
...
In some cases, there were an inconsistent number of formatting anchors.
In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien
7b528ecee7
Fix some typos
2020-02-19 08:01:41 +00:00
Daniel Trebbien
252dda94a3
Reformat some code
2020-02-19 07:50:20 +00:00
Jean-Baptiste Onofré
a9d89572ef
Merge pull request #449 from PascalSchumacher/setter_getter_synchronization
...
AMQ-7402: Inconsistent synchronization of getters/setters of some cla…
2020-02-13 08:15:57 +01:00
Jean-Baptiste Onofré
4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
...
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
Pascal Schumacher
6764511fa1
Fix unused format arguments in log messages.
2020-02-12 17:52:28 +01:00
Pascal Schumacher
5356893fac
AMQ-7402: Inconsistent synchronization of getters/setters of some classes
...
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
jbonofre
097506a458
[AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default
2020-02-12 13:43:03 +01:00
Pascal Schumacher
dac97e6294
[AMQ-7401] Make double-checked locking thread-safe by declaring the field volatile.
2020-02-10 19:06:17 +01:00
gtully
5a0c853ba0
AMQ-7353 - fix visibility of marshalledProperties to ensure competing threads don't see partial objects in error. Little test case that demonstrates the problem in isolation
2019-11-26 16:58:30 +00:00
Matt Daley
b379879dbf
Stop failed timer task from breaking timers.
2019-11-23 15:00:23 +00:00
Christopher L. Shannon (cshannon)
0c6f9a9a1e
AMQ-7352 - Add support for anonymous producer advisories
...
By default this behavior is turned off but can be enabled by setting
anonymousProducerAdvisorySupport on the BrokerService to true
2019-11-22 13:35:32 -05:00
Jean-Baptiste Onofré
a59ebe7d09
Merge pull request #283 from SaivR1t/master
...
AMQ-6963 Fix calling the toString() method in case of different log level.
2019-11-18 05:50:37 +01:00
Jean-Baptiste Onofré
057b950485
Merge pull request #322 from deeyes24/failing_cronparsertest_inIndia
...
NO-JIRA: CronParserTest is failing in Indian StandardTime
2019-11-17 06:56:20 +01:00
Christopher L. Shannon (cshannon)
65de327369
AMQ-7300 - Remove unnecessary call to sequence updater as read is already volatile
2019-09-06 12:19:23 -04:00
Christopher L. Shannon (cshannon)
4db2656066
AMQ-7300 - Improve performance of LongSequenceGenerator
...
LongSequenceGenerator now uses an AtomicLongFieldUpdater instead of
synchronized
2019-09-06 11:55:54 -04:00
gtully
02548777c2
AMQ-7298 - rework redelivery message tracking to ensure no duplicate suppression (and dlq) in error for local transaction batches that failover
2019-09-04 12:24:42 +01:00
Jean-Baptiste Onofré
7e72fbc98b
[AMQ-7254] Fix OSGi headers
2019-08-05 08:38:47 +02:00
gtully
de3f77063f
AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test
2019-06-21 16:55:13 +01:00
Jonathan Gallimore
82b3d02fc2
Remove dependency activemq-http and activemq-stomp
2019-06-06 14:42:49 +01:00
gtully
30abc45f62
no jira - remove extraneous printStackTrace, ex is propagated up
2019-04-18 14:38:30 +01:00
gtully
487d4a112e
AMQ-7185 - track durable sub prepared acks in preCommit callback and release/remove on xa outcome, avoid duplicate delivery; fix and test
2019-04-17 14:31:11 +01:00
gtully
b9bcd2fcc3
AMQ-7165 - ensure failover updated uris are additive such that statically configured uris are respected
2019-03-12 12:24:20 +00:00
Alan Protasio
4b51f8b66c
AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown)
2019-01-14 10:54:26 -05:00
212726340
b65fedf4dd
NO-JIRA: CronParserTest is failing in Indian StandardTime
2018-11-23 15:49:04 +05:30
Colm O hEigeartaigh
a87b61e8be
Enable secure processing on all DocumentBuilderFactory.newInstance()
2018-11-22 10:24:43 +00:00
Christopher L. Shannon (cshannon)
02c1e6d8f2
AMQ-7047 - clarify documentation
2018-09-24 07:35:00 -04:00
Christopher L. Shannon (cshannon)
0b71b06ac8
Revert "AMQ-7004 - Improved logging in Failover Transport"
...
This reverts commit 7974e8c099
.
This caused problems with too much logging so reverting
2018-09-04 06:53:00 -04:00
Christopher L. Shannon (cshannon)
1e31df9800
AMQ-7047 - Switch default for hostname verification to be false for
...
server
For the client it makes sense to have it true by default but for the
server it makes sense to have it false by default
2018-08-31 13:04:14 -04:00
Christopher L. Shannon (cshannon)
69fad2a135
Add support for hostname verification
2018-08-31 06:39:49 -04:00
gtully
8bb3a77270
AMQ-5917 - fix sync on SslContext lazy initialisation
2018-08-20 12:23:53 +01:00
Christopher L. Shannon (cshannon)
7974e8c099
AMQ-7004 - Improved logging in Failover Transport
2018-07-30 07:56:33 -04:00
giliva
5b1412ddfd
Avoid overflow errors - see KAFKA-4290
...
Add test for overflow values
Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
gtully
0b76d3a0ea
AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map
2018-07-26 10:42:10 +01:00
Jeff Genender
7f4851f31c
[AMQ-7013] Added final for thread safety
2018-07-18 15:13:31 -06:00
jgoodyear
e9a64b1c72
[AMQ-7013] Introduce JenkinsHash to XATransactionID
2018-07-18 10:39:29 -06:00
gtully
2b64b7b04f
AMQ-4706 - ensure we log the first warn and include the failure reason
2018-07-05 17:34:30 +01:00
gtully
5ebee0ace7
AMQ-7000 - ensure server sessions with closed active sessions get removed from the pool on stop, fix and test
2018-06-26 11:07:04 +01:00
gtully
004be56127
AMQ-2659 - make configurable based on xaAckMode, otherwise pure xa case can default to autoack in error. Additional tests
2018-06-13 11:48:43 +01:00
Timothy Bish
db8c771b2a
AMQ-6968 Ensure that the correct exception is thrown
...
Allow the original exception that triggered the failure to be thrown
from the packet send methods
2018-05-21 16:39:58 -04:00
saivr1t
191e4ffbe6
AMQ-6963
...
Fix calling the toString() method in case of different log level.
2018-05-15 18:46:36 +03:00
saivr1t
2a95348182
AMQ-6959
...
Avoid creating a Throwable in case of non-trace logging
2018-05-14 15:11:10 +03:00
Christopher L. Shannon (cshannon)
703b7b1510
AMQ-6901 - Add NPE check inside DestinationMap filter
2018-02-16 14:32:24 -05:00
Christopher L. Shannon (cshannon)
2ce1c1352f
AMQ-6901 - Make sure proper policy is used to configure a destination
...
When multiple wildcard policies exist in a hierarchy it was possible for
the wrong policy to be selected when configuring a destination
2018-02-16 10:41:33 -05:00
Andrei Shakirin
d0dab2e88b
AMQ-6894: limit poison exception message to 1024
2018-02-07 19:28:55 +01:00
Christopher L. Shannon (cshannon)
4535e8f097
AMQ-6884 - Replacing printStackTrace() with logging statement
2018-01-11 07:27:03 -05:00
Sami Nurminen
39caca7cf6
AMQ-6327 - Remove System.out.println
2017-12-22 18:16:14 -05:00
Sami Nurminen
051e2b791c
AMQ-6327 - getNextScheduledTime() returns incorrect time when working with day of month
2017-12-20 21:47:47 +02:00
Bernd
26eab53723
Javadoc typo fix and cleanup
...
This mostly fixes the url1/url2 copy and paste problem. It uses a bit more readable property syntax and introduces a single sentence (plain text) summary for class Javadoc and adds some links.
2017-12-18 21:28:28 -05:00
Christopher L. Shannon (cshannon)
5fa0bbd515
AMQ-6871 - By default only send generic platform details
...
The default behavior by the OpenWire client will be to send generic
platform details to the server with a new flag to send more specific
information.
2017-12-06 08:41:51 -05:00
gtully
e793260573
[AMQ-6831, AMQ-6771] trigger eofexception on read -1 - AMQ6522Test
2017-10-11 00:20:44 +01:00
Timothy Bish
a21dd40527
AMQ-6823 Ensure that MessagePull is works across HTTP transport
...
The MessagePull command needs to have the transients initialized such
that the pull operation works across transports that use XStream or
other marshaling that doesn't performs custom serialization.
2017-09-25 13:26:18 -04:00
Christopher L. Shannon (cshannon)
6e33507bf2
AMQ-6820 - Properly handle ClosedChannelException
...
When a ClosedChannelException occurs inside SelectorSelection properly
call the transport listener onError() method to handle cleanup and
logging.
2017-09-21 08:14:19 -04:00