gtully
62cfe83e9d
[AMQ-7291] rework fix to initializeWriting but just with the read only properties check
2020-05-21 10:41:58 +01:00
Jean-Baptiste Onofré
173426c55c
Merge pull request #535 from jbonofre/AMQ-7480
...
[AMQ-7480] Avoid NPE if original exception is null
2020-05-21 09:52:33 +02:00
jbonofre
ecbeb6d2eb
[AMQ-7480] Avoid NPE if original exception is null
2020-05-19 16:51:23 +02:00
Pascal Schumacher
67e06c82f7
Fix some javadoc warnings releated to non-existing parameter names.
2020-05-17 11:38:05 +02:00
Jean-Baptiste Onofré
079d9d7fe4
Merge pull request #504 from PascalSchumacher/ServiceStopper#throwFirstException_remove_unreachable_code
...
Remove unreachable code in ServiceStopper#throwFirstException.
2020-05-16 07:20:39 +02:00
Jean-Baptiste Onofré
0444dd96b2
Merge pull request #505 from PascalSchumacher/potential_overflow_in_int_multiplication
...
Avoid potential overflow in int multiplication before it is converted…
2020-05-16 07:17:13 +02:00
gtully
0ebb0f88ef
[AMQ-7485] add check for rollbackonly flag in session send such that failed ended transactions prevent further work till next transaction boundary
2020-05-15 15:39:56 +01:00
Jean-Baptiste Onofré
41bef94293
Merge pull request #521 from coheigea/AMQ-7458
...
AMQ-7458 - Implement bounds checking on the message scheduling proper…
2020-05-15 15:52:23 +02:00
anushaCoder
a5e70fa2d7
[AMQ-7463] Use ConcurrentHashMap in client connection state to avoid ConcurrentModificationException
2020-05-15 06:40:36 +02:00
gtully
aa03f295f5
AMQ-7464 - ensure message.copy before server session run dispatch
2020-04-08 14:57:49 +01:00
Colm O hEigeartaigh
24aaa4698c
AMQ-7458 - Implement bounds checking on the message scheduling properties
2020-03-27 12:14:03 +00:00
jbonofre
6355f507c3
Revert "AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420"
...
This reverts commit 503416a001
.
2020-03-10 16:16:01 +01:00
Pascal Schumacher
b43f5b8cf2
Avoid potential overflow in int multiplication before it is converted to long.
2020-03-08 11:50:21 +01:00
Pascal Schumacher
68355136d2
Remove unreachable code in ServiceStopper#throwFirstException.
2020-03-08 11:27:24 +01:00
Colm O hEigeartaigh
67fb6f8871
AMQ-7423 - Remove synchronization from JAAS PropertiesLoader
2020-02-27 15:29:26 +00:00
Jean-Baptiste Onofré
bfb810c507
Merge pull request #466 from coheigea/misc_fixes
...
AMQ-7413 - Misc logging fixes
2020-02-22 07:49:55 +01:00
gtully
503416a001
AMQ-7291 - allow setting properties after clearProperties for BytesMessage, closes #420
2020-02-19 13:01:25 +00:00
Daniel Trebbien
b020cba744
Fix some incorrect SLF4J logger calls
...
In some cases, there were an inconsistent number of formatting anchors.
In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien
7b528ecee7
Fix some typos
2020-02-19 08:01:41 +00:00
Daniel Trebbien
252dda94a3
Reformat some code
2020-02-19 07:50:20 +00:00
Jean-Baptiste Onofré
a9d89572ef
Merge pull request #449 from PascalSchumacher/setter_getter_synchronization
...
AMQ-7402: Inconsistent synchronization of getters/setters of some cla…
2020-02-13 08:15:57 +01:00
Jean-Baptiste Onofré
4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
...
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
Pascal Schumacher
6764511fa1
Fix unused format arguments in log messages.
2020-02-12 17:52:28 +01:00
Pascal Schumacher
5356893fac
AMQ-7402: Inconsistent synchronization of getters/setters of some classes
...
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
jbonofre
097506a458
[AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default
2020-02-12 13:43:03 +01:00
Pascal Schumacher
dac97e6294
[AMQ-7401] Make double-checked locking thread-safe by declaring the field volatile.
2020-02-10 19:06:17 +01:00
gtully
5a0c853ba0
AMQ-7353 - fix visibility of marshalledProperties to ensure competing threads don't see partial objects in error. Little test case that demonstrates the problem in isolation
2019-11-26 16:58:30 +00:00
Matt Daley
b379879dbf
Stop failed timer task from breaking timers.
2019-11-23 15:00:23 +00:00
Christopher L. Shannon (cshannon)
0c6f9a9a1e
AMQ-7352 - Add support for anonymous producer advisories
...
By default this behavior is turned off but can be enabled by setting
anonymousProducerAdvisorySupport on the BrokerService to true
2019-11-22 13:35:32 -05:00
Jean-Baptiste Onofré
a59ebe7d09
Merge pull request #283 from SaivR1t/master
...
AMQ-6963 Fix calling the toString() method in case of different log level.
2019-11-18 05:50:37 +01:00
Jean-Baptiste Onofré
057b950485
Merge pull request #322 from deeyes24/failing_cronparsertest_inIndia
...
NO-JIRA: CronParserTest is failing in Indian StandardTime
2019-11-17 06:56:20 +01:00
Christopher L. Shannon (cshannon)
65de327369
AMQ-7300 - Remove unnecessary call to sequence updater as read is already volatile
2019-09-06 12:19:23 -04:00
Christopher L. Shannon (cshannon)
4db2656066
AMQ-7300 - Improve performance of LongSequenceGenerator
...
LongSequenceGenerator now uses an AtomicLongFieldUpdater instead of
synchronized
2019-09-06 11:55:54 -04:00
gtully
02548777c2
AMQ-7298 - rework redelivery message tracking to ensure no duplicate suppression (and dlq) in error for local transaction batches that failover
2019-09-04 12:24:42 +01:00
Jean-Baptiste Onofré
7e72fbc98b
[AMQ-7254] Fix OSGi headers
2019-08-05 08:38:47 +02:00
gtully
de3f77063f
AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test
2019-06-21 16:55:13 +01:00
Jonathan Gallimore
82b3d02fc2
Remove dependency activemq-http and activemq-stomp
2019-06-06 14:42:49 +01:00
gtully
30abc45f62
no jira - remove extraneous printStackTrace, ex is propagated up
2019-04-18 14:38:30 +01:00
gtully
487d4a112e
AMQ-7185 - track durable sub prepared acks in preCommit callback and release/remove on xa outcome, avoid duplicate delivery; fix and test
2019-04-17 14:31:11 +01:00
gtully
b9bcd2fcc3
AMQ-7165 - ensure failover updated uris are additive such that statically configured uris are respected
2019-03-12 12:24:20 +00:00
Alan Protasio
4b51f8b66c
AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown)
2019-01-14 10:54:26 -05:00
212726340
b65fedf4dd
NO-JIRA: CronParserTest is failing in Indian StandardTime
2018-11-23 15:49:04 +05:30
Colm O hEigeartaigh
a87b61e8be
Enable secure processing on all DocumentBuilderFactory.newInstance()
2018-11-22 10:24:43 +00:00
Christopher L. Shannon (cshannon)
02c1e6d8f2
AMQ-7047 - clarify documentation
2018-09-24 07:35:00 -04:00
Christopher L. Shannon (cshannon)
0b71b06ac8
Revert "AMQ-7004 - Improved logging in Failover Transport"
...
This reverts commit 7974e8c099
.
This caused problems with too much logging so reverting
2018-09-04 06:53:00 -04:00
Christopher L. Shannon (cshannon)
1e31df9800
AMQ-7047 - Switch default for hostname verification to be false for
...
server
For the client it makes sense to have it true by default but for the
server it makes sense to have it false by default
2018-08-31 13:04:14 -04:00
Christopher L. Shannon (cshannon)
69fad2a135
Add support for hostname verification
2018-08-31 06:39:49 -04:00
gtully
8bb3a77270
AMQ-5917 - fix sync on SslContext lazy initialisation
2018-08-20 12:23:53 +01:00
Christopher L. Shannon (cshannon)
7974e8c099
AMQ-7004 - Improved logging in Failover Transport
2018-07-30 07:56:33 -04:00
giliva
5b1412ddfd
Avoid overflow errors - see KAFKA-4290
...
Add test for overflow values
Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
gtully
0b76d3a0ea
AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map
2018-07-26 10:42:10 +01:00
Jeff Genender
7f4851f31c
[AMQ-7013] Added final for thread safety
2018-07-18 15:13:31 -06:00
jgoodyear
e9a64b1c72
[AMQ-7013] Introduce JenkinsHash to XATransactionID
2018-07-18 10:39:29 -06:00
gtully
2b64b7b04f
AMQ-4706 - ensure we log the first warn and include the failure reason
2018-07-05 17:34:30 +01:00
gtully
5ebee0ace7
AMQ-7000 - ensure server sessions with closed active sessions get removed from the pool on stop, fix and test
2018-06-26 11:07:04 +01:00
gtully
004be56127
AMQ-2659 - make configurable based on xaAckMode, otherwise pure xa case can default to autoack in error. Additional tests
2018-06-13 11:48:43 +01:00
Timothy Bish
db8c771b2a
AMQ-6968 Ensure that the correct exception is thrown
...
Allow the original exception that triggered the failure to be thrown
from the packet send methods
2018-05-21 16:39:58 -04:00
saivr1t
191e4ffbe6
AMQ-6963
...
Fix calling the toString() method in case of different log level.
2018-05-15 18:46:36 +03:00
saivr1t
2a95348182
AMQ-6959
...
Avoid creating a Throwable in case of non-trace logging
2018-05-14 15:11:10 +03:00
Christopher L. Shannon (cshannon)
703b7b1510
AMQ-6901 - Add NPE check inside DestinationMap filter
2018-02-16 14:32:24 -05:00
Christopher L. Shannon (cshannon)
2ce1c1352f
AMQ-6901 - Make sure proper policy is used to configure a destination
...
When multiple wildcard policies exist in a hierarchy it was possible for
the wrong policy to be selected when configuring a destination
2018-02-16 10:41:33 -05:00
Andrei Shakirin
d0dab2e88b
AMQ-6894: limit poison exception message to 1024
2018-02-07 19:28:55 +01:00
Christopher L. Shannon (cshannon)
4535e8f097
AMQ-6884 - Replacing printStackTrace() with logging statement
2018-01-11 07:27:03 -05:00
Sami Nurminen
39caca7cf6
AMQ-6327 - Remove System.out.println
2017-12-22 18:16:14 -05:00
Sami Nurminen
051e2b791c
AMQ-6327 - getNextScheduledTime() returns incorrect time when working with day of month
2017-12-20 21:47:47 +02:00
Bernd
26eab53723
Javadoc typo fix and cleanup
...
This mostly fixes the url1/url2 copy and paste problem. It uses a bit more readable property syntax and introduces a single sentence (plain text) summary for class Javadoc and adds some links.
2017-12-18 21:28:28 -05:00
Christopher L. Shannon (cshannon)
5fa0bbd515
AMQ-6871 - By default only send generic platform details
...
The default behavior by the OpenWire client will be to send generic
platform details to the server with a new flag to send more specific
information.
2017-12-06 08:41:51 -05:00
gtully
e793260573
[AMQ-6831, AMQ-6771] trigger eofexception on read -1 - AMQ6522Test
2017-10-11 00:20:44 +01:00
Timothy Bish
a21dd40527
AMQ-6823 Ensure that MessagePull is works across HTTP transport
...
The MessagePull command needs to have the transients initialized such
that the pull operation works across transports that use XStream or
other marshaling that doesn't performs custom serialization.
2017-09-25 13:26:18 -04:00
Christopher L. Shannon (cshannon)
6e33507bf2
AMQ-6820 - Properly handle ClosedChannelException
...
When a ClosedChannelException occurs inside SelectorSelection properly
call the transport listener onError() method to handle cleanup and
logging.
2017-09-21 08:14:19 -04:00
Timothy Bish
61d3231d36
AMQ-6809 Fix issue where stream message getBytes returned wrong value
...
StreamMessage implementation should return zero when the full value of a
written byte array has been consumed before then returning -1 on the
next read. Ands fix and additional testing of ActiveMQStreamMessage
2017-09-20 15:50:09 -04:00
Christopher L. Shannon (cshannon)
6b27708ae1
AMQ-6811 - moving ActiveMQMessageIsMarshalled test to src/test/java
2017-09-15 12:20:44 -04:00
Christopher L. Shannon (cshannon)
f82993d9c2
AMQ-6811 - fix reduceMemoryFootprint when no message body
...
ReduceMemoryFootprint will now properly detect that a message is
marshalled even if there is no message body so the headers can be
cleared out after message send
2017-09-15 10:11:46 -04:00
gtully
3cd5529f50
[AMQ-6771] fix off by one on input stream read long check, with test
2017-07-18 12:28:12 +01:00
gtully
8c218ee05d
[AMQ-6771] do linear sequential scan of journal when validating checksums - remove batch reads via seek/read which depend on write batch size
2017-07-17 12:18:25 +01:00
gtully
499347542c
[no jira] make networkConsumerIds visible in toString of consumerinfo to aid tracing consumers in a network via transport trace logging
2017-07-07 16:01:49 +01:00
Christopher L. Shannon (cshannon)
a9fe4e33c3
[maven-release-plugin] prepare for next development iteration
2017-06-27 13:41:28 -04:00
Christopher L. Shannon (cshannon)
5f0d6943cb
[maven-release-plugin] prepare release activemq-5.15.0
2017-06-27 13:41:01 -04:00
gtully
d2c0eddaad
[AMQ-6691] allow dlq flag to be set via jmx to allow retry op after a restart - use destinations element for long term persistence
2017-05-31 12:39:48 +01:00
Timothy Bish
2e2d5ddd3d
https://issues.apache.org/jira/browse/AMQ-6669
...
Respect the wireFormat.maxFrameSize option on WS and WSS transports
allowing binary content larger than 65535
2017-05-04 16:37:53 -04:00
gtully
2bd3379932
[AMQ-6068] make full cleanup of the rar managed connection conditional on a user specified client id being present
2017-05-04 11:08:32 +01:00
Hiram Chirino
172c29091e
AMQ-6651: Add new implementations of the writeUTF8 and readUTF8 methods that are based on Apache Harmony code. This also avoid some code duplication that was occurring.
2017-04-10 10:49:17 -04:00
gtully
63b2e5c4ea
[AMQ-6494] fix check order of close state for onException handler
2017-04-06 10:23:16 +01:00
gtully
b64ac1dd77
[AMQ-6646] improve error reporting to include url
2017-04-04 17:30:29 +01:00
gtully
679db08db3
[AMQ-6643] ensure a wildcard virtual topic subscriber is restricted to the wildcard destination - avoid duplicate and spurious dispatch. fix and test
2017-04-04 10:16:48 +01:00
Timothy Bish
90b808ab98
AMQ-6603 Stop tracking producer if creation failed
...
Track the message producer create and ensure it is not recreated on
failover if the creation resulted in an error response. Add failover
level tests to cover consumer and producer failed create tracking.
2017-02-28 16:17:32 -05:00
gtully
8641928553
[AMQ-6603] ensure failover does not track consumer creation that fails with an exception, fix and test. Thanks for the test Tadayoshi Sato
2017-02-28 17:17:18 +00:00
Christopher L. Shannon (cshannon)
0cf64783d2
AMQ-6602 - fix java 7 incompatibility
2017-02-24 06:36:57 -05:00
Christopher L. Shannon (cshannon)
1f53b124bc
AMQ-6602 - Removing lambdas for java 7 compatibility
2017-02-23 10:56:57 -05:00
Christopher L. Shannon (cshannon)
79069598b1
AMQ-6606 - fix typo
2017-02-23 10:21:54 -05:00
Christopher L. Shannon (cshannon)
fe5164a404
AMQ-6602: Fix race condition in TaskRunnerFactory
...
Fixing a race condition in TaskRunnerFactory where if multiple threads
call createTaskRunner() at the same time some threads might see the
executor as null (if it hasn't finished initializing) leading to the
creation of extra DedicatedTaskRunner objects instead of sharing a
PooledTaskRunner.
2017-02-23 10:20:13 -05:00
Christopher L. Shannon (cshannon)
f6bf823ded
AMQ-6599 - Properly apply soTimeout value to TcpTransport
...
https://issues.apache.org/jira/browse/AMQ-6599
The soTimeout value needs to be applied to the TcpTransport as well as
the socket because the NIO transports use the value later on when
establishing a connection
2017-02-17 08:03:50 -05:00
gtully
85181d630c
[AMQ-6548] ensure any pending xa transaction is marked rollback only on delivery failure exception from on message, before delegating to potential clientInternalExceptionListener. Variant of patch applied with additional test - thanks to Andrey Dyachikhin for the patch inspiration
2017-01-17 16:51:27 +00:00
Christopher L. Shannon (cshannon)
2769298cf6
https://issues.apache.org/jira/browse/AMQ-6555
...
Fixing Scheduler so that a rescheduled task will first cancel the
existing task so it does not get orphaned from the task map. Also
fixing Topic start so that it will only start once and not twice.
2017-01-10 10:25:15 -05:00
Christopher L. Shannon (cshannon)
27238b2dd7
https://issues.apache.org/jira/browse/AMQ-6535
...
Fixing the auto+nio+ssl transport so that the protocol detection task
will properly terminate on timeout and not continue to run. Also
lowered the default detection timeout to 15 seconds instead of 30
seconds to match the InactivityMonitor default.
2016-12-12 11:17:19 -05:00
gtully
6a0c65828a
Revert "fix up createPublisher contract to throw on null topic param, match the java doc"
...
the java doc allows null for an anonymous publish - the check needs to go in TopicRequestor part of the jdk
This reverts commit 29ecfd6cdb
.
2016-12-02 13:57:44 +00:00
gtully
29ecfd6cdb
fix up createPublisher contract to throw on null topic param, match the java doc
2016-12-02 12:46:32 +00:00
gtully
b6bca3976c
[AMQ-6517] make pre dispatch redelivery policy check optional jms.redeliveryPolicy.preDispatchCheck=false
2016-11-24 17:02:37 +00:00
Christopher L. Shannon (cshannon)
016ae05d0e
https://issues.apache.org/jira/browse/AMQ-6489
...
Adding a new ActiveMQXASslContextFactory and jndi support for it
in ActiveMQSslInitialContextFactory
2016-11-04 08:31:19 -04:00
Hadrian Zbarcea
be24a133ef
This closes #88 (merged as a65ac586
). More file permissions fixes.
2016-11-03 14:26:34 -04:00