Apache
/
archiva
mirror of https://github.com/apache/archiva.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

revise tasklist 

git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@412316 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Porter 2006-06-07 07:44:47 +00:00
parent 3e2aef6652
commit cc5b69ec9f
12 changed files with 20 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
View File

@ -29,7 +29,7 @@ import java.security.NoSuchAlgorithmException;
import java.security.PrivilegedAction; import java.security.PrivilegedAction;
/** /**
* TODO: Description. * Applet that takes a file on the local filesystem and checksums it for sending to the server.
* *
* @author <a href="mailto:brett@apache.org">Brett Porter</a> * @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/ */

2
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
View File

@ -28,7 +28,7 @@ import java.util.Iterator;
import java.util.List; import java.util.List;
/** /**
* TODO [!]: Description. * Base class for the artifact and metadata discoverers.
* *
* @author <a href="mailto:brett@apache.org">Brett Porter</a> * @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/ */

2
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
View File

@ -39,7 +39,6 @@ public interface ArtifactDiscoverer
* @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning
* @param includeSnapshots whether to discover snapshots * @param includeSnapshots whether to discover snapshots
* @return the list of artifacts discovered * @return the list of artifacts discovered
* @todo replace repositoryBase with wagon repository
* @todo do we want blacklisted patterns in another form? Part of the object construction? * @todo do we want blacklisted patterns in another form? Part of the object construction?
* @todo should includeSnapshots be configuration on the component? * @todo should includeSnapshots be configuration on the component?
* @todo instead of a returned list, should a listener be passed in? * @todo instead of a returned list, should a listener be passed in?
@ -53,7 +52,6 @@ public interface ArtifactDiscoverer
* @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning
* @param includeSnapshots whether to discover snapshots * @param includeSnapshots whether to discover snapshots
* @return the list of artifacts discovered * @return the list of artifacts discovered
* @todo replace repositoryBase with wagon repository
* @todo do we want blacklisted patterns in another form? Part of the object construction? * @todo do we want blacklisted patterns in another form? Part of the object construction?
* @todo should includeSnapshots be configuration on the component? * @todo should includeSnapshots be configuration on the component?
* @todo instead of a returned list, should a listener be passed in? * @todo instead of a returned list, should a listener be passed in?

8
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
View File

@ -179,19 +179,19 @@ public class DefaultMetadataDiscoverer
} }
catch ( FileNotFoundException fe ) catch ( FileNotFoundException fe )
{ {
// TODO: log ignored metadata // TODO: log ignored metadata!
} }
catch ( XmlPullParserException xe ) catch ( XmlPullParserException xe )
{ {
// TODO: log ignored metadata // TODO: log ignored metadata!
} }
catch ( MalformedURLException e ) catch ( MalformedURLException e )
{ {
// TODO: log ignored metadata // TODO: log ignored metadata!
} }
catch ( IOException ie ) catch ( IOException ie )
{ {
// TODO: log ignored metadata // TODO: log ignored metadata!
} }
return metadata; return metadata;

8
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
View File

@ -52,7 +52,7 @@ import java.util.Map;
* @author Edwin Punzalan * @author Edwin Punzalan
* @plexus.component role="org.apache.maven.repository.proxy.ProxyManager" * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
* @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary? * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary?
* @todo this isn't reusing the parts of wagon manager than handle snapshots * @todo this isn't reusing the parts of wagon manager than handle snapshots [!]
*/ */
public class DefaultProxyManager public class DefaultProxyManager
extends AbstractLogEnabled extends AbstractLogEnabled
@ -297,13 +297,13 @@ public class DefaultProxyManager
private ArtifactRepositoryPolicy getReleasesPolicy() private ArtifactRepositoryPolicy getReleasesPolicy()
{ {
//todo get policy configuration from ProxyConfiguration //todo get policy configuration from ProxyConfiguration [!]
return new ArtifactRepositoryPolicy(); return new ArtifactRepositoryPolicy();
} }
private ArtifactRepositoryPolicy getSnapshotsPolicy() private ArtifactRepositoryPolicy getSnapshotsPolicy()
{ {
//todo get policy configuration from ProxyConfiguration //todo get policy configuration from ProxyConfiguration [!]
return new ArtifactRepositoryPolicy(); return new ArtifactRepositoryPolicy();
} }
@ -392,7 +392,7 @@ public class DefaultProxyManager
{ {
wagon = wagonManager.getWagon( repository.getProtocol() ); wagon = wagonManager.getWagon( repository.getProtocol() );
//@todo configure wagonManager //@todo configure wagonManager [!]
if ( useChecksum ) if ( useChecksum )
{ {

2
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
View File

@ -25,7 +25,7 @@ import java.io.File;
* Class used to bridge the servlet to the repository proxy implementation. * Class used to bridge the servlet to the repository proxy implementation.
* *
* @author Edwin Punzalan * @author Edwin Punzalan
* @todo the names get() and getRemoteFile() are confusing * @todo the names get() and getRemoteFile() are confusing [!]
*/ */
public interface ProxyManager public interface ProxyManager
{ {

2
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
View File

@ -29,7 +29,7 @@ import java.util.List;
* *
* @author Edwin Punzalan * @author Edwin Punzalan
* @plexus.component role="org.apache.maven.repository.proxy.configuration.ProxyConfiguration" * @plexus.component role="org.apache.maven.repository.proxy.configuration.ProxyConfiguration"
* @todo investigate how these should be set - probably plexus configuration * @todo investigate how these should be set - probably plexus configuration [!]
*/ */
public class ProxyConfiguration public class ProxyConfiguration
{ {

3
maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
View File

@ -30,8 +30,7 @@ public class CachedRepositoryQueryLayer
{ {
private Cache cache; private Cache cache;
private static final double CACHE_HIT_RATIO = 0.5; public static final double CACHE_HIT_RATIO = 0.5;
public CachedRepositoryQueryLayer( ArtifactRepository repository ) public CachedRepositoryQueryLayer( ArtifactRepository repository )
{ {

8
maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
View File

@ -22,8 +22,6 @@ package org.apache.maven.repository.reporting;
public class CachedRepositoryQueryLayerTest public class CachedRepositoryQueryLayerTest
extends AbstractRepositoryQueryLayerTestCase extends AbstractRepositoryQueryLayerTestCase
{ {
// TODO: share
private static final double CACHE_HIT_RATIO = 0.5;
protected void setUp() protected void setUp()
throws Exception throws Exception
@ -38,7 +36,7 @@ public class CachedRepositoryQueryLayerTest
testContainsArtifactTrue(); testContainsArtifactTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testContainsArtifactTrue(); testContainsArtifactTrue();
assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
} }
public void testUseMetadataCache() public void testUseMetadataCache()
@ -47,7 +45,7 @@ public class CachedRepositoryQueryLayerTest
testArtifactVersionsTrue(); testArtifactVersionsTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testArtifactVersionsTrue(); testArtifactVersionsTrue();
assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
} }
public void testUseFileCacheOnSnapshot() public void testUseFileCacheOnSnapshot()
@ -55,6 +53,6 @@ public class CachedRepositoryQueryLayerTest
testContainsSnapshotArtifactTrue(); testContainsSnapshotArtifactTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testContainsSnapshotArtifactTrue(); testContainsSnapshotArtifactTrue();
assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
} }
} }

4
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
View File

@ -33,7 +33,7 @@ import java.net.MalformedURLException;
import java.util.List; import java.util.List;
/** /**
* TODO: Description. * Search by package name.
* *
* @author <a href="mailto:brett@apache.org">Brett Porter</a> * @author <a href="mailto:brett@apache.org">Brett Porter</a>
* @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.PackageSearchAction" * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.PackageSearchAction"
@ -82,7 +82,7 @@ public class PackageSearchAction
return ERROR; return ERROR;
} }
// TODO: better config // TODO: better config [!]
String indexPath = configuration.getIndexDirectory(); String indexPath = configuration.getIndexDirectory();
// TODO: reduce the amount of lookup? // TODO: reduce the amount of lookup?

2
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
View File

@ -31,7 +31,7 @@ import java.util.Map;
import java.util.TreeMap; import java.util.TreeMap;
/** /**
* TODO: Description. * Browse the repository.
* *
* @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.RepositoryBrowseAction" * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.RepositoryBrowseAction"
*/ */

2
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java
View File

@ -156,7 +156,7 @@ public class DiscovererExecution
* *
* @throws MalformedURLException * @throws MalformedURLException
* @throws RepositoryIndexException * @throws RepositoryIndexException
* @todo why is this any different from legacy? * @todo why is this any different from legacy? [!]
*/ */
protected void executeDiscovererInDefaultRepo() protected void executeDiscovererInDefaultRepo()
throws MalformedURLException, RepositoryIndexException throws MalformedURLException, RepositoryIndexException