Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rework test fixtures 

Next, grow the amount of data tested to find bugs in the tests with
non-repeatable map ordering
This commit is contained in:
Gary Gregory 2024-03-31 10:54:20 -04:00
parent e5c95c28d2
commit eab18e9851
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/test/java/org/apache/commons/collections4/multimap/UnmodifiableMultiValuedMapTest.java
View File

@ -21,10 +21,13 @@ import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Iterator; import java.util.Iterator;
import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Map.Entry; import java.util.Map.Entry;
import java.util.Set; import java.util.Set;
@ -52,9 +55,21 @@ public class UnmodifiableMultiValuedMapTest<K, V> extends AbstractMultiValuedMap
* @param map the MultiValuedMap<K, V> to check * @param map the MultiValuedMap<K, V> to check
*/ */
private void assertMapContainsAllValues(final MultiValuedMap<K, V> map) { private void assertMapContainsAllValues(final MultiValuedMap<K, V> map) {
assertEquals("[v0_0, v0_1]", map.get((K) "k0").toString()); final int maxK = getSampleKeySize();
assertEquals("[v1_0, v1_1]", map.get((K) "k1").toString()); final int cpk = getSampleCountPerKey();
assertEquals("[v2_0, v2_1]", map.get((K) "k2").toString()); for (int k = 0; k < maxK; k++) {
final K key = makeKey(k);
final Collection<V> collection = map.get((K) key);
assertEquals(cpk, collection.size());
final String toString = collection.toString();
final List<V> expected = new ArrayList<>(cpk);
for (int j = 0; j < cpk; j++) {
expected.add(makeValue(k, j));
}
assertEquals(expected.size(), collection.size());
assertEquals(expected, new ArrayList<>(collection));
assertEquals(expected.toString(), toString);
}
} }
@Override @Override