Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,296 Commits 10 Branches 53 Tags 39 MiB
Commit Graph

3296 Commits

Author SHA1 Message Date
Alex Herbert 8b4ecbc084 Compute the bit index into a Bloom filter using bit shifts. 
Removes the use of Math.floorMod and integer division.

Operations have been put into a class for reuse among filters.
 2020-02-25 00:30:43 +00:00
Alex Herbert 24ad759b31 Document the HashFunctionIdentity Signedness 2020-02-24 23:27:55 +00:00
Alex Herbert 9a496dc61c Update the AbstractBloomFilter to not use BitSet for cardinality. 
The cardinality can be performed without memory allocation using
Long.bitCount.
 2020-02-24 23:01:39 +00:00
Alex Herbert e08f0be55b Revert CountingBloomFilter to ignore counts from another filter. 
Partially removes changes made in commit:
6ad69bedd3

The class requires a revision to handle add/subtract of another
CountingBloomFilter. Restore the tests to check that Counting filters
are merged as if another non-counting filter type.

Remove the javadoc from the CountingBloomFilter methods that state it
uses the counts when merge/remove are called with a CountingBloomFilter
as this is not what the functionality currently performs.

Fix the merge with a hasher to only increment the count by 1 even if the
hasher contains duplicates. Add test to verify this works as documented.
This matches the remove functionality which removes duplicates before
subtraction.
 2020-02-24 22:42:20 +00:00
Alex Herbert ad04fff90d Set scope of method comments to protected. 
This was the original level before update of checkstyle config.
 2020-02-24 21:22:06 +00:00
aherbert 3aa817726b Add indentation check to checkstyle. 
Fixed all code. Case statements have an indent of zero as recommended by
Oracle. Previously the code was using either 0 or 4 as the indent. Using
zero for the check has fewer violations that require fixing.
 2020-02-24 21:22:06 +00:00
Alex Herbert 9bc4d0bc61 Fixed checkstyle in tests. 
Changed rules to be more lenient on tests.
 2020-02-18 23:25:52 +00:00
Alex Herbert de46979712 Add checkstyle:check to defaultGoal 2020-02-18 23:07:37 +00:00
Alex Herbert 4797acefba Fixed checkstyle. 
Add missing newlines at end of files.

Remove redundant modifiers.

Fix incorrect Apache license header.

Fix whitespace around elements.

Remove tab characters.

Fix right-curly location.

Correct modifier order.
 2020-02-18 23:07:19 +00:00
Alex Herbert 72f45156d3 Update checkstyle configuration. 
Configuration has been added based on commons-lang.

The Apache licence header has been added to the checkstyle config.
 2020-02-18 21:38:53 +00:00
aherbert 6ad69bedd3 Increase coverage in CountingBloomFilter test. 
The counting functionality appears to be broken. Annotations have been
added to the code at locations that are incorrect.

Tests have been updated that currently fail and disabled to allow the
build to pass.
 2020-02-18 16:34:57 +00:00
aherbert 0f78a9c9e8 Test edge case in SetOperations when shapes are different. 2020-02-18 13:57:15 +00:00
aherbert 4ecffb5fee Test getProvider() is Apache Commons Collections. 2020-02-18 13:57:15 +00:00
aherbert 6215948227 Hit all edge cases in the Shape.equals method. 2020-02-18 13:57:15 +00:00
aherbert 55cb720ccf Remove HashFunctionIdentity comparators. 
The comparators are never used to perform ordering of functions. The
only current use is to determine that two hash functions are
functionally equivalent. A replacement utility class has been added to
test for equality.
 2020-02-18 13:35:58 +00:00
aherbert 66b418f3e9 Update DynamicHasher to have a specialised iterator when empty. 
Add tests to exercise the empty and non-empty iterators and their
expected exceptions when no more elements.
 2020-02-18 12:39:11 +00:00
aherbert 39f0955920 Removed spurious javadoc tag. 2020-02-17 15:22:13 +00:00
aherbert d31ebdd0e4 Javadoc clean-up. 2020-02-17 14:10:10 +00:00
aherbert 7aaf396c83 Correct test javadoc headers. 2020-02-17 13:44:14 +00:00
aherbert 1f17189d53 Remove unthrown exception. 2020-02-17 13:34:56 +00:00
aherbert 4033ff63c5 Test code clean-up. 
Make methods static if possible.

Correct formatting of braces.
 2020-02-17 13:34:14 +00:00
aherbert 373a241752 Removed invalid javadoc. 2020-02-17 13:30:40 +00:00
aherbert fa028268a8 Remove unthrown exception from test setup(). 2020-02-17 13:26:16 +00:00
aherbert b377f59613 Remove extra lines. 2020-02-17 13:24:03 +00:00
aherbert 5f70948570 Remove whitespace around parentheses. 2020-02-17 13:17:11 +00:00
aherbert 82273e966e Added orCardinality to BitSetBloomFilter. 2020-02-17 13:06:52 +00:00
aherbert 2a0e867744 Remove javadoc from override method. 
The javadoc incorrectly refers to BitSetBloomFilter as the argument.
 2020-02-17 13:00:22 +00:00
aherbert 28b381008e Eliminate extra lines. 2020-02-17 12:56:53 +00:00
aherbert a3e2ea2443 Remove methods from the javadoc that are not implemented. 
These methods have been moved from AbstractBloomFilter to SetOperations.
 2020-02-17 11:44:28 +00:00
Gary Gregory d5bf76870f [COLLECTIONS-748] Let 
org.apache.commons.collections4.properties.[Sorted]PropertiesFactory
accept XML input.
 2020-02-16 20:42:27 -05:00
Gary Gregory 87497d0fa1 Use the stock JRE Objects.requireNonNull() for parameter validation. 
Formatting. Javadoc.
 2020-02-16 15:39:57 -05:00
Gary Gregory a1ce1c2121 Formatting. 2020-02-16 15:22:43 -05:00
Gary Gregory 7d06bd77e9 [COLLECTIONS-747] MultiKey.getKeys class cast exception. 2020-02-16 15:18:27 -05:00
Gary Gregory 9fd080442c Javadoc. 2020-02-16 15:16:01 -05:00
Gary Gregory c665cdb28a Fix formatting. 2020-02-16 15:15:45 -05:00
Gary Gregory 4d6946c43a Cast to long to workaround a bug in animal-sniffer. 2020-02-16 15:15:35 -05:00
Gary Gregory 38c36b5685 Sort methods in AB order. 2020-02-16 15:15:26 -05:00
Gary Gregory f95c8526ad Use final. 2020-02-16 15:08:34 -05:00
Gary Gregory c5348397a9 Format tweaks. Consistently use 'this.' in ctors. 2020-02-16 15:08:00 -05:00
Gary Gregory 433229fd22 Sort members. 2020-02-13 10:34:04 -05:00
Gary Gregory f416d453af Update org.easymock:easymock 4.1 -> 4.2. 2020-02-13 10:29:54 -05:00
Gary Gregory 7b1a908a8c [COLLECTIONS-746] Add 
org.apache.commons.collections4.properties.PropertiesFactory.EMPTY_PROPERTIES.

Suppress deprecation warning since we are delegating.
 2020-02-11 08:50:37 -05:00
Gary Gregory acff58db5a [COLLECTIONS-746] Add 
org.apache.commons.collections4.properties.PropertiesFactory.EMPTY_PROPERTIES.

Fix imports.
 2020-02-09 11:42:05 -05:00
Gary Gregory 181fe9c708 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2020-02-09 11:40:54 -05:00
Gary Gregory 8f906c08fa [COLLECTIONS-746] Add 
org.apache.commons.collections4.properties.PropertiesFactory.EMPTY_PROPERTIES.

[build] Update Jacoco from 0.8.4 to 0.8.5.
 2020-02-09 11:40:43 -05:00
Eitan Adler 0bf44ae040 COLLECTIONS-697: correct changelog entry (ref #55) 
use the apache committer name instead of the github username

ref: 64420e34cc
 2020-02-01 14:36:23 -08:00
Gary Gregory ee282c7c6b Update JUnit from 4.12 to 4.13. 2020-01-26 18:01:22 -05:00
Gary Gregory 13b132450c Update Apache commons-parent from 48 to 50. 2020-01-26 17:53:38 -05:00
Gary Gregory b0fa61893a Javadoc and comment. 2020-01-26 17:42:27 -05:00
Gary Gregory 15bd5806d5 Remove unused imports. 2020-01-26 17:37:01 -05:00