Commit Graph

926 Commits

Author SHA1 Message Date
Sebastian Bazley 512e446d28 Add code and test for Quote.NONE
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1480499 13f79535-47bb-0310-9956-ffa450edef68
2013-05-08 23:54:22 +00:00
Sebastian Bazley bb3bb0d65b Test default Quote policy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1480498 13f79535-47bb-0310-9956-ffa450edef68
2013-05-08 23:43:14 +00:00
Sebastian Bazley 71c69df6dd CSV-98 Line number counting is confusing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479936 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 15:12:48 +00:00
Sebastian Bazley 5b2e5f809b Simplify code so delimiter only printed in one place
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479823 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 09:09:11 +00:00
Sebastian Bazley 978e5796e2 MOre tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479753 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 02:21:38 +00:00
Sebastian Bazley 0fabee5f24 Add some more tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479730 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:54:45 +00:00
Sebastian Bazley 02c1b35939 Document why original object is needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479721 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:29:45 +00:00
Sebastian Bazley c616a17650 Typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479719 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:24:07 +00:00
Sebastian Bazley e697318e68 Fix Javadoc to current behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479712 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:02:34 +00:00
Sebastian Bazley 4f61bd1aee Extract check for metaChar
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479706 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 22:38:23 +00:00
Sebastian Bazley 883511fa42 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479701 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 22:18:21 +00:00
Benedikt Ritter e6ba150743 Use isDelimiter method instead of != check.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478655 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 06:37:58 +00:00
Sebastian Bazley 2c61208262 CSV-58 Unescape handling needs rethinking
Fixed up most issues.
TODO should TAB, FF and BACKSPACE be un/escaped?

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478621 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 01:10:34 +00:00
Sebastian Bazley e31980892c Bug in test case result
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478619 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 01:01:20 +00:00
Gary D. Gregory 697a612a89 Remove unused import.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1469437 13f79535-47bb-0310-9956-ffa450edef68
2013-04-18 16:59:44 +00:00
Sebastian Bazley 6640e8597c Standardise on record rather than line; fix incorrect Javadoc comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1468827 13f79535-47bb-0310-9956-ffa450edef68
2013-04-17 10:31:57 +00:00
Sebastian Bazley 939a8a04eb Standardise on recordSeparator; fix incorrect Javadoc comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1468825 13f79535-47bb-0310-9956-ffa450edef68
2013-04-17 10:28:33 +00:00
Benedikt Ritter f16818b3ba Give tests a better name that expresses, what actually happens
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467766 13f79535-47bb-0310-9956-ffa450edef68
2013-04-14 11:35:47 +00:00
Benedikt Ritter 04522fbf90 Change JavaDoc to match actual parameter name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467666 13f79535-47bb-0310-9956-ffa450edef68
2013-04-13 17:55:16 +00:00
Benedikt Ritter 03fefe8c30 Add missing JavaDoc for parameter
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467665 13f79535-47bb-0310-9956-ffa450edef68
2013-04-13 17:49:37 +00:00
Benedikt Ritter 7e9b381a6f Document expected result for ignored test
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466605 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:16:23 +00:00
Benedikt Ritter 16e12d2130 Change wrong input data of test. Test now fails because of CSV-58 and is therefore changed to be @Ignore.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466604 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:15:36 +00:00
Benedikt Ritter fd8433b711 Give test a better name and remove comment that is now no longer needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466601 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:05:31 +00:00
Benedikt Ritter 6c346b143a Give test a better name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466591 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 17:48:28 +00:00
Benedikt Ritter b05af3c049 Add a test that makes sure ignoreSurroundingWhitespaces works for the tab character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466590 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 17:47:42 +00:00
Gary D. Gregory a7e4484db9 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466223 13f79535-47bb-0310-9956-ffa450edef68
2013-04-09 20:43:29 +00:00
Gary D. Gregory f57afe607e Fix checksyle trailing space.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465774 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:41:29 +00:00
Gary D. Gregory 75b9a4ba4e [CSV-97] Allow the String value for null to be customized for the CSV printer.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465768 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:34:49 +00:00
Gary D. Gregory 60cc83af7f Sort members, classes and methods (but not fields).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465763 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:23:57 +00:00
Gary D. Gregory afc9de71bd Better parameter name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465753 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:57:32 +00:00
Benedikt Ritter a0d975933d [CSV-96] CSVRecord does not verify that the length of the header mapping matches the number of values - convert ArrayIndexOutOfBoundsException to IllegalArgumentException to give users a better feedback about what went wrong
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465738 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:34:38 +00:00
Benedikt Ritter 5744ee8a16 Separate testing empty line handling from comment recognition
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465722 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:55:58 +00:00
Benedikt Ritter 449e9a8cf6 Make sure empty lines are ignored by constructing CSVFormat this way. Remove corresponding assert that would have failed if CSVFormat.newBuilder() was changed to withIgnoreEmptyLines(false)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465718 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:37:22 +00:00
Benedikt Ritter 19cb2ca2eb Give test a name that's a bit more expressive and remove comment that is no longer needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465715 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:33:36 +00:00
Benedikt Ritter 7c4121b5e0 Remove comment, intention of test is now expressed in its name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465709 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:27:34 +00:00
Benedikt Ritter 4c8024fb76 Express intention of tokens in token content and give test more structure
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465705 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:23:32 +00:00
Benedikt Ritter 1c728b40e5 Give test a name that's a bit more expressive
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465693 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 17:59:02 +00:00
Benedikt Ritter 61a879bf68 Replace assertTokenEquals with Token matcher
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465692 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 17:49:51 +00:00
Benedikt Ritter 4b5e8d70f1 Remove unneeded empty line
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465441 13f79535-47bb-0310-9956-ffa450edef68
2013-04-07 18:38:56 +00:00
Benedikt Ritter 759596a54a Correct JavaDoc indentation, remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465439 13f79535-47bb-0310-9956-ffa450edef68
2013-04-07 18:13:36 +00:00
Benedikt Ritter c694d060bd Add missing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463212 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:24:43 +00:00
Benedikt Ritter 09a6e887b8 Use hasContent matcher token type is not relevant (correct token type recognition is tested by other tests methods)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463210 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:15:31 +00:00
Benedikt Ritter aef71309b6 Add some matcher implementations as discussed on the ML http://markmail.org/message/k7gzqhbgfyiszyph
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463207 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:09:24 +00:00
Gary D. Gregory 8f436552ae [CSV-96] CSVRecord does not verify that the length of the header mapping matches the number of values.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1462110 13f79535-47bb-0310-9956-ffa450edef68
2013-03-28 14:23:56 +00:00
Gary D. Gregory 08f02a086c Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1462086 13f79535-47bb-0310-9956-ffa450edef68
2013-03-28 13:29:36 +00:00
Gary D. Gregory 83ad716bc2 Add a 'using' section to the main page with a short code example and pointers to the Javadoc. Move the "About" section to the end and remove broken package reference.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461338 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 22:12:57 +00:00
Gary D. Gregory 4c530ac40d Better lvar name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461307 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 20:52:28 +00:00
Gary D. Gregory 78d7055f71 Minor clean ups.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461302 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 20:46:11 +00:00
Gary D. Gregory 6f1db38058 Better param name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461241 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:49:05 +00:00
Gary D. Gregory d10442b68a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461240 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:48:22 +00:00
Gary D. Gregory 9107316c0b Javadoc: use the active voice.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461239 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:45:01 +00:00
Gary D. Gregory 05ecd91994 Make internal API package private.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461237 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:42:55 +00:00
Gary D. Gregory 193dfd79af Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461225 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:47:20 +00:00
Gary D. Gregory ad9e4f3b60 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461222 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:46:29 +00:00
Gary D. Gregory 0e2ec48f8e Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461219 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:45:01 +00:00
Gary D. Gregory ce1c01c403 Javdoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461217 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:43:54 +00:00
Gary D. Gregory ba016bd759 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461213 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:36:58 +00:00
Gary D. Gregory df08acad74 Add org.apache.commons.csv.CSVFormat.CSVFormatBuilder.parse(Reader).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461202 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:19:48 +00:00
Gary D. Gregory e33bedefce Change back to DEFAULT format name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461192 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 15:50:18 +00:00
Gary D. Gregory 1e83d1fb59 Better Javadoc hopefully.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461150 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 14:19:00 +00:00
Gary D. Gregory 40948cdcec After discussion on ML (http://apache-commons.680414.n4.nabble.com/CSV-org-apache-commons-csv-CSVFormat-DEFAULT-td4647843.html) from 6 days ago, handle this TODO, and renamed DEFAULT to RFC4180_EMPTY_LINES.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461134 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 13:58:30 +00:00
Benedikt Ritter eb13cb152a Fix typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460907 13f79535-47bb-0310-9956-ffa450edef68
2013-03-25 21:37:47 +00:00
Sebastian Bazley 6dc69934d2 Close printer (at least for non-Exception cases - these are unit tests)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460400 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:28:11 +00:00
Sebastian Bazley 1b78bc1502 Avoid Eclipse warning
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460396 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:14:53 +00:00
Sebastian Bazley 7825b260f3 Avoid double boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460392 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:10:50 +00:00
Benedikt Ritter dd1ebc9c9a Remove unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460388 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 14:51:25 +00:00
Gary D. Gregory 530d8d1248 Javadoc toBuilder().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460381 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 14:13:48 +00:00
Benedikt Ritter 3358e83a0d Add comment why test uses a different CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460369 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:38:32 +00:00
Benedikt Ritter dbbae1eccd Initialize format used by several test methods in setUp
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460367 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:36:16 +00:00
Benedikt Ritter 9e3f3cccb2 Remove test method, escaping at EOF is already tested through testEscapingAtEOF()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460365 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:30:32 +00:00
Benedikt Ritter 3a1806ba26 Split up escape testing into separate methods, add escaping tests that should work after CSV-58 is resolved (currently ignored)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460364 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:29:22 +00:00
Benedikt Ritter 6b67a34b87 Sort methods
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460348 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:14:21 +00:00
Gary D. Gregory b01898391d Add a toBuilder method to do:
CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", "Col3").build();
Instead of:
CSVFormat format = CSVFormat.newBuilder(CSVFormat.EXCEL).withHeader("Col1", "Col2", "Col3").build();


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460255 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 02:03:16 +00:00
Gary D. Gregory 6b2a504564 Add a toBuilder method to do:
CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", "Col3").build();
Instead of:
CSVFormat format = CSVFormat.newBuilder(CSVFormat.EXCEL).withHeader("Col1", "Col2", "Col3").build();


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460254 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 02:02:11 +00:00
Gary D. Gregory 68f4892138 Fix { } formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460251 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 01:56:44 +00:00
Benedikt Ritter 3567ad0acc Use Utils class for comparing list of CSVRecords against expectation array
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460194 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 16:57:13 +00:00
Benedikt Ritter 2e543f41f3 Add some unit tests for escape handling in preparation for CSV-58
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460138 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 13:07:04 +00:00
Benedikt Ritter c4014b6b38 Method names should start with a verb
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460136 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 12:48:24 +00:00
Benedikt Ritter 9bafed6b23 Clarify JavaDoc for builder factory method, also remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460134 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 12:01:25 +00:00
Benedikt Ritter 77c6382ee5 Remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460132 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 11:49:00 +00:00
Benedikt Ritter 8989b6fc56 Add missing @Test annotation to testGetHeaderMap()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460126 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 11:16:54 +00:00
Benedikt Ritter 4a70de4b44 Remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460125 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 11:14:57 +00:00
Gary D. Gregory e28d4e9c2e Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459447 13f79535-47bb-0310-9956-ffa450edef68
2013-03-21 18:47:40 +00:00
Gary D. Gregory 6e2c992072 content ivar can be final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459444 13f79535-47bb-0310-9956-ffa450edef68
2013-03-21 18:42:03 +00:00
Gary D. Gregory cdfa53530d Update site with better build info.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459403 13f79535-47bb-0310-9956-ffa450edef68
2013-03-21 17:07:23 +00:00
Benedikt Ritter 3f0faa00ed Add missing JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459020 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 19:52:27 +00:00
Benedikt Ritter b53a171ab3 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458805 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:43:43 +00:00
Benedikt Ritter 20fe471d40 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458803 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:42:37 +00:00
Benedikt Ritter c99e6d9ef6 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458797 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:40:33 +00:00
Benedikt Ritter 961cce294c Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458794 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:39:18 +00:00
Benedikt Ritter 62a527636d Remove trailing white space
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458791 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:38:45 +00:00
Benedikt Ritter 2018c0c41f Replace accidentally checked in tab characters with spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458721 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 10:23:30 +00:00
Benedikt Ritter 5e0e7703a1 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458713 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 10:08:17 +00:00
Benedikt Ritter 374cd7b16d Remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458683 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 08:31:14 +00:00
Gary D. Gregory dca481f79c Sort members in AB order.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458639 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:24:27 +00:00
Gary D. Gregory 8f0d0e03d6 Add testRFC4180().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458637 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:23:46 +00:00
Gary D. Gregory 6b1eaad5a6 Javadoc fixes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458636 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:16:26 +00:00
Gary D. Gregory 0956f6e85d Use the same wording in Javadoc as in the API name: "empty".
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458635 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:09:48 +00:00
Gary D. Gregory e2e8c2523c Fix spelling in Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458634 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:08:36 +00:00
Gary D. Gregory f656bb7cb6 Fix spelling in Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458633 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:07:05 +00:00
Gary D. Gregory 46b6a2de4c Fix Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458632 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:03:17 +00:00
Gary D. Gregory f6f02e5265 Fix formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458139 13f79535-47bb-0310-9956-ffa450edef68
2013-03-19 04:54:38 +00:00
Olivier Lamy bc1e1da91f restore download cgi
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1450540 13f79535-47bb-0310-9956-ffa450edef68
2013-02-26 23:54:04 +00:00
Gary D. Gregory 6447a82f35 JUnit 3 -> 4: replace import of junit.framework.Assert with org.junit.Assert.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1437517 13f79535-47bb-0310-9956-ffa450edef68
2013-01-23 16:00:03 +00:00
Gary D. Gregory 71a657004e Where possible:
- Add final modifier to private fields
- Add final modifier to method parameters
- Add final modifier to local variables

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1429926 13f79535-47bb-0310-9956-ffa450edef68
2013-01-07 18:00:46 +00:00
Sebastian Bazley 5d15c38eed Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411923 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:27:49 +00:00
Sebastian Bazley e5a7b27224 More useful to have double-quote as a Character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411920 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:24:58 +00:00
Sebastian Bazley 713e9c5382 Make some methods package-protected to avoid the need for synthetic accessors.
TODO consider whether to do so for the fields as well

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411919 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:22:21 +00:00
Sebastian Bazley 0e35052508 Correct name of character: it's not an escape, it's a backslash
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411918 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:11:09 +00:00
Gary D. Gregory db11c04d29 [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410759 13f79535-47bb-0310-9956-ffa450edef68
2012-11-17 18:00:38 +00:00
Gary D. Gregory e4889167d2 Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410084 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:46:56 +00:00
Gary D. Gregory 8b622677c6 Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410082 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:45:24 +00:00
Gary D. Gregory 8886fac6d7 Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410081 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:44:44 +00:00
Gary D. Gregory 7fa5b4e68f Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410080 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:44:23 +00:00
Gary D. Gregory eeeafa5faa Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410079 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:43:52 +00:00
Gary D. Gregory 0383fd51df [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410045 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 21:56:36 +00:00
Gary D. Gregory 68352ee98f Use the final keyword where possible.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409464 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:58:09 +00:00
Gary D. Gregory cdc8b8f2b1 Organize imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409461 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:56:46 +00:00
Gary D. Gregory 7ac5dd3ec6 Rename methods that create a builder newBuilder().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409455 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:54:16 +00:00
Gary D. Gregory 6a34b823c8 [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409449 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:50:36 +00:00
Sebastian Bazley d266471b4c Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399051 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:09:05 +00:00
Gary D. Gregory 7e67e14bb3 A field was left public.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399049 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:06:14 +00:00
Sebastian Bazley 3daeb02c08 Since DEFAULT is supposed to be RFC4180 + ignore blank lines: make it so
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399048 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:06:10 +00:00
Gary D. Gregory e04a86ae11 Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399047 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:05:42 +00:00
Gary D. Gregory 5a7138a1da Javadoc fix.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399045 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 23:44:35 +00:00
Gary D. Gregory 73ec29f75f Rename "line separator" to "record separator".
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398911 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 18:20:52 +00:00
Sebastian Bazley d8eaf1cd61 Alignment
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398847 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 15:25:51 +00:00
Gary D. Gregory 933cf2d038 Add // TODO comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398749 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 11:51:22 +00:00
Gary D. Gregory ef8a489172 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398748 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 11:50:29 +00:00
Sebastian Bazley 42757c2376 Multi-parameter ctor is confusing and unnecessary
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398563 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 23:02:59 +00:00
Sebastian Bazley 060fd48fe4 Oops, forgot to use DISABLED char
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398561 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 23:00:43 +00:00
Sebastian Bazley 5c9b878dfd PRISTINE can now be private as we have ctor which allows delimiter to be specified
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398560 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:57:51 +00:00
Sebastian Bazley 6f500d6067 Re-introduce DISABLED but as a private constant; only needed for PRISTINE definition
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398559 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:56:54 +00:00
Sebastian Bazley cbce4da24b Add ctor to create simplest possible CSV parser
Does not make sense to allow delim = EOL in ctor but disable it in withDelimiter()

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398556 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:50:00 +00:00
Sebastian Bazley 91058bb95f Typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398370 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:29:37 +00:00
Sebastian Bazley 7d8c7f17ff Remove redundant code
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398367 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:27:57 +00:00
Sebastian Bazley 3a90cfe249 Explicit unboxing; associated Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398365 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:27:25 +00:00
Sebastian Bazley 33c004f525 Invalid use of == to compare Character equality; add tests to detect this
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398357 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:04:29 +00:00
Sebastian Bazley 6f94c8a3da Explicit unboxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398354 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:02:32 +00:00
Sebastian Bazley 7c770e0b53 Now that delimiter is a char, simplify API by removing withDelimiter(Character)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398349 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 15:53:09 +00:00
Sebastian Bazley ae5e7898f5 Unused
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398343 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 15:39:30 +00:00
Gary D. Gregory 6870022916 The class implements Closeable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398278 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 13:15:09 +00:00
Gary D. Gregory 4aee321abb The class implements Flushable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398277 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 13:13:05 +00:00
Gary D. Gregory e1dc4f870e Remove method org.apache.commons.csv.CSVPrinter.print(Object, boolean), it should not have been public in the first place, the format is the API to specify this kind of option.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398276 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 13:12:21 +00:00
Gary D. Gregory 350d34d5cf Rename encapsulator to quote char.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398187 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:37:34 +00:00
Gary D. Gregory ddfe9df74f Rename encapsulator to quote char.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398186 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:30:45 +00:00
Gary D. Gregory 26188064b0 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398185 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:29:23 +00:00
Gary D. Gregory e6f2de0fa8 Organize imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398184 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:26:27 +00:00
Gary D. Gregory 6eddd544e5 Javadoc: @version.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398183 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:25:52 +00:00
Gary D. Gregory fc11e68728 Javadoc: @version.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398182 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:22:30 +00:00
Gary D. Gregory e4a6faf8ab Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398181 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:21:54 +00:00
Gary D. Gregory 8aa02596af Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398180 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 03:20:43 +00:00
Gary D. Gregory 70584f87f5 Fix Javadoc and better lvar name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398149 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 23:23:14 +00:00
Gary D. Gregory bdb5842eef Validation fails if no quotes mode set but no escape character is set.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398148 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 23:22:17 +00:00
Gary D. Gregory f51f43d184 Implement Quote.NON_NUMERIC and Quote.MINIMAL. NONE throws a 'not implemented yet' exception.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398137 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 21:23:33 +00:00
Gary D. Gregory b9b3b58cbd Sort members.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398135 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 21:02:55 +00:00
Gary D. Gregory 9c43ad3afb Rename test method.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398134 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 21:02:36 +00:00
Gary D. Gregory 2f2d9aa780 Implement Quote.ALL. Bullet-proof a unit test.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398133 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 21:01:21 +00:00
Gary D. Gregory cdef24d918 Printer can now use a JDBC result set as input. Use H2 as lightweight in-memory JDBC database for easy test set up.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398108 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 18:08:58 +00:00
Gary D. Gregory 1046db8f90 Remove unused imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398021 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 06:01:21 +00:00
Gary D. Gregory 010c81e8b4 Add roundtrip test.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398020 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 06:00:40 +00:00
Gary D. Gregory 79eb6e0392 Add APIs to print arrays of records and iterables of records.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398019 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:54:06 +00:00
Gary D. Gregory 7fd16f353a Rename "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me and provides symmetry with quotePolicy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398017 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:10:57 +00:00
Gary D. Gregory 0dbb499888 Rename "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me and provides symmetry with quotePolicy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398016 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:08:47 +00:00
Gary D. Gregory 17139b840f Better lvar names.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398015 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:06:35 +00:00
Gary D. Gregory 53f15f420b Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398014 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:04:21 +00:00
Gary D. Gregory 2ff847ea91 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398013 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:03:35 +00:00
Gary D. Gregory f80c5bd0ad Rename "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me and provides symmetry with quotePolicy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398012 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:01:56 +00:00
Gary D. Gregory f6c9a36ad6 Group quote test fragments together.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398011 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:01:26 +00:00
Gary D. Gregory ecea0c3599 Rename "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me and provides symmetry with quotePolicy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398010 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 05:00:19 +00:00
Gary D. Gregory 6e57364216 Rename "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me and provides symmetry with quotePolicy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398009 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:56:50 +00:00
Gary D. Gregory 0030e1a9a2 Add quote policy to format. (Considering renaming "encapsulator" to "quoteChar" so we have quoteChar and quotePolicy. Encapsulator makes me want to ask "encapsulate what"? fieldEncapsulator would be better but so verbose, quoteChar feels more to the point to me. )
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398008 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:53:51 +00:00
Gary D. Gregory 33eb71e9a1 In-line comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398007 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:37:10 +00:00
Gary D. Gregory 7aeddef435 Change the type of printer API to accept Object instead of String.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398006 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:36:51 +00:00
Gary D. Gregory 3be1057064 Change the type of printer API to accept Object instead of String.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398005 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:31:39 +00:00
Gary D. Gregory 68322e0336 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398003 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:07:43 +00:00
Gary D. Gregory 639e68e253 Rename printSep() to printDelimiter().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398002 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:06:39 +00:00
Gary D. Gregory 75a835a837 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398001 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:02:53 +00:00
Gary D. Gregory e693d87f71 Start of [CSV-53] Allow to always enclose printed values into quotes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398000 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 04:01:47 +00:00
Gary D. Gregory 1b4474c0a0 Javadoc: Use the active voice and change one verb.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397999 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 03:43:47 +00:00
Gary D. Gregory eb472cb82a Better lvar name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397998 13f79535-47bb-0310-9956-ffa450edef68
2012-10-14 03:33:20 +00:00
Gary D. Gregory a50d473a3b Delimiter is not optional so change back type from Character to char. The side effect is that the "pristine" format must be built with somekind of default (',') seems reasonable. The comment used to say "no settings defined" but that was not true, since false was passed in for two values instead of null. IMO, this is all due to the fluent API making this part of the code a little more tricky.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397930 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 19:15:59 +00:00
Gary D. Gregory f074aeedfe Delimiter is not optional so change back type from Character to char. The side effect is that the "pristine" format must be built with somekind of default (',') seems reasonable. The comment used to say "no settings defined" but that was not true, since false was passed in for two values instead of null. IMO, this is all due to the fluent API making this part of the code a little more tricky.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397927 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 19:05:08 +00:00
Gary D. Gregory df592767fc Fix param name and Javadoc to match ivar names.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397925 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:58:56 +00:00
Gary D. Gregory c7576ccded Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397924 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:57:09 +00:00
Gary D. Gregory 2a8ce4a11c Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397923 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:56:57 +00:00
Gary D. Gregory 0f8cc2228c In-line comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397915 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:45:31 +00:00
Gary D. Gregory 8c3aaee61a Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397914 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:45:05 +00:00
Gary D. Gregory d37f1a6ed7 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397913 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:42:06 +00:00
Gary D. Gregory 9f6d3f5413 Rename readAgain() to getLastChar()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397911 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:40:05 +00:00
Gary D. Gregory f342cb2caf Validation checks the delimiter character cannot be null.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397909 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:38:39 +00:00
Gary D. Gregory 0e7e9deabb Make package private classes final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397907 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:28:56 +00:00
Gary D. Gregory 17c26354df org.apache.commons.csv.Token.reset() does not need to return itself. Save a return.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397906 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:24:27 +00:00
Gary D. Gregory aa4d069a7f Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397904 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:20:04 +00:00
Gary D. Gregory 6306dd7181 In-line comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397903 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:18:56 +00:00
Gary D. Gregory 9542a399b8 It looks like TWO record objects were created for each record read!
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397902 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:16:41 +00:00
Gary D. Gregory 0e8084ab27 Rename getRecord() to nextRecord()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397900 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:13:18 +00:00
Gary D. Gregory 3b938ba40d Let the line number count be a long.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397898 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:11:42 +00:00
Gary D. Gregory daf984983b [CSV-52] Keep track of record numbers.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397895 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:09:48 +00:00
Gary D. Gregory 3d72cb087a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397889 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:23:02 +00:00
Sebastian Bazley 03a6b50319 Add missing single-quote
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397878 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:11:54 +00:00
Gary D. Gregory 933a950c88 [CSV-88] Not possible to create a CSVFormat from scratch. Should the validate method be public?
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397877 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:10:33 +00:00
Gary D. Gregory ae47fb8432 CSVFormat.validate() throws IllegalStateException instead of IllegalArgumentException because the method validates the state of the object.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397876 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:08:44 +00:00
Gary D. Gregory e331df694c Use the single quote char to delineate a char in error messages. Remove a trailing space.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397872 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:03:03 +00:00
Gary D. Gregory 8f068b60ed Rename method nullMeansDisabled() to mapNullToDisabled()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397864 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:43:40 +00:00
Gary D. Gregory ef9018bb1e [CSV-94] Lexer should only use char fields.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397863 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:41:56 +00:00
Sebastian Bazley 96a55f1d2b Drop @Ignore from perf/PerformanceTest; instead add to pom surefire excludes
This makes it possible to run the test without needing to edit the source file.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397859 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:30:07 +00:00
Sebastian Bazley d99244287c Use locally stored big file as per perf/PerformanceTest
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397851 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:15:36 +00:00
Gary D. Gregory 992c0645e0 Rename ivar to ignoreEmptyLines to match CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397785 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:29:09 +00:00
Gary D. Gregory 3655efcedb Rename ivar to ignoreSurroundingSpaces to match CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397784 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:28:47 +00:00
Gary D. Gregory 50e2719bb6 Remove DISABLED character hack.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397783 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:27:52 +00:00
Gary D. Gregory dc7a71979d Rename constant.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397772 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:41:12 +00:00
Gary D. Gregory bb7d696218 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397771 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:39:15 +00:00
Gary D. Gregory ba609af7e3 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397770 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:30:00 +00:00
Gary D. Gregory 48b26f82f7 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397579 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 14:26:35 +00:00
Gary D. Gregory 9428b9cc1a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397574 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 14:15:25 +00:00
Gary D. Gregory 8159aea6d1 Update CRLF to be easier to read.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397562 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:48:26 +00:00
Gary D. Gregory 883a0e91cf Allow performance test to traverse column values (optional).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397559 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:31:06 +00:00
Gary D. Gregory 53fd86dfbc More constants clean ups.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397556 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:15:30 +00:00
Gary D. Gregory b5c334222c Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397549 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:58:29 +00:00
Gary D. Gregory 56ca5858db Refactor constants from various classes into a package private Constants class and use static imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397541 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:35:46 +00:00
Gary D. Gregory 9a27bb570d Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397536 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:16:38 +00:00
Gary D. Gregory 66a56ee1a4 Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397534 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:12:44 +00:00
Gary D. Gregory a5cd9dc1c5 Fix constant name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397530 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:00:35 +00:00
Gary D. Gregory 5b6b1fa33c Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397527 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 11:58:50 +00:00
Gary D. Gregory 625bafab76 Add CVSRecord.isSet(String) API.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397136 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 16:07:51 +00:00
Gary D. Gregory 6ab9b46e5a Use final keyword where possible.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397122 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 15:47:44 +00:00
Gary D. Gregory db374369ae Better performance tests. Provide a test CSV file to work with. Tests depends on Commons IO to help decompress the large-ish CSV test file.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397119 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 15:45:13 +00:00
Gary D. Gregory 3eededce88 Add CVSRecord.isMapped(String) API.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397094 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:56:16 +00:00
Gary D. Gregory 67bbc35289 Rename ivars that were in the past tense to use the imperative style.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397087 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:39:23 +00:00
Gary D. Gregory b5589d0fcb Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397080 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:31:43 +00:00
Gary D. Gregory 3ea85d4c8b Replace magic char with constant TAB.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397078 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:30:04 +00:00
Gary D. Gregory 13092bad7d Replace magic char with constant DOUBLE_QUOTE.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397077 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:29:12 +00:00
Gary D. Gregory 4efb5ae19a Replace magic char with constant COMMA.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397074 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:27:56 +00:00
Gary D. Gregory 2ea171f2ed Remove extra parens.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397071 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:24:23 +00:00
Gary D. Gregory 4bc562f47b Organize imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397059 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:02:33 +00:00
Gary D. Gregory 6359d220bd Fix typo.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383942 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 13:49:05 +00:00
Gary D. Gregory 3cd5c85e8a [CVS-92] Need a way to extract parsed headers, e.g. for use in formatting output.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383934 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 13:41:06 +00:00
Gary D. Gregory 25f4b3e998 Sort methods in AB order.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383924 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 13:14:48 +00:00
Gary D. Gregory 473727be26 Rename ivar headerMapping -> headerMap.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383920 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 12:59:30 +00:00
Gary D. Gregory 7c86611ee4 Fix web site image reference.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383916 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 12:33:50 +00:00
Gary D. Gregory 5e7945e1ce Last of the Checkstyle fixes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383758 13f79535-47bb-0310-9956-ffa450edef68
2012-09-12 04:14:01 +00:00
Gary D. Gregory 57a1aef278 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383611 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 21:09:12 +00:00
Gary D. Gregory 6c1b0fa1c4 Fix Checkstyle: Format for 120 line length.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383598 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 20:12:27 +00:00
Gary D. Gregory 8608520aa1 Rename pname from 'tkn' to 'token'.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383583 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:47:51 +00:00
Gary D. Gregory 93fc1f9363 Fix Checkstyle: Format for 120 line length.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383582 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:47:15 +00:00
Sebastian Bazley a5d3d4ed7c Add assembly descriptors and plugin build reference
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383580 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:45:32 +00:00
Gary D. Gregory 42a4812bce Fix Checkstyle: File does not end with a newline.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383578 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:41:25 +00:00
Gary D. Gregory bf06bed9b8 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383577 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:40:37 +00:00
Gary D. Gregory 0638a37368 Match ASF headers to checkstyle.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383573 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:36:54 +00:00
Gary D. Gregory 6a132b40ab Match ASF headers to checkstyle.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383572 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:35:45 +00:00
Gary D. Gregory 97d59f8704 Replace empty throws that "should not happen" with an IllegalStateException.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383569 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:30:21 +00:00
Gary D. Gregory cc4cc4747e Remove extra blank line.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383567 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:25:12 +00:00
Gary D. Gregory e235b2a63c Refactor '\r' and '\n' into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383564 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:17:25 +00:00
Gary D. Gregory 29944bcec1 Fix incorrect Javadoc method reference.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383558 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:08:56 +00:00
Gary D. Gregory 3eff704245 Remove unneeded @SuppressWarnings("unused")
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383557 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:03:45 +00:00
Gary D. Gregory 87466459c0 Add default serialVersionUID to two classes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383556 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:03:03 +00:00
Gary D. Gregory 71ded2eff0 Better version and date.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383555 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 18:58:30 +00:00
Gary D. Gregory 4cec1b66f2 Add missing ASF header.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383554 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 18:55:58 +00:00
Gary D. Gregory 1018dafd5d Add missing ASF header.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383545 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 18:54:17 +00:00
Gary D. Gregory b372050f7f Fix compilation issue.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1383504 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 18:18:14 +00:00
Sebastian Bazley 720b341bf0 CSV-90 CSVFormat isEscaping/isEncapsulating are not public
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1327754 13f79535-47bb-0310-9956-ffa450edef68
2012-04-19 00:23:51 +00:00
Sebastian Bazley adf5f834db Covert to new style package Javadoc; tidy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307210 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 01:51:28 +00:00
Sebastian Bazley 795fe61858 Use public CRLF constant
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307205 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 01:33:02 +00:00
Sebastian Bazley d89a0f482f Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307201 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 01:16:45 +00:00
Sebastian Bazley 5c3e51363f Use public CRLF constant
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307188 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 01:00:32 +00:00
Sebastian Bazley 0186a3d335 CRLF might as well be public to make it easier to use to build formats.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307187 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 00:58:36 +00:00
Sebastian Bazley d994897420 Reduce dependency on DISABLED package constant
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307186 13f79535-47bb-0310-9956-ffa450edef68
2012-03-30 00:57:29 +00:00
Sebastian Bazley 7d2ec7a053 CSV-85 Allow comments to be returned in CSVRecord
Added test for comment before header

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307078 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 19:50:26 +00:00
Sebastian Bazley 29c80daa3c Add test for CSV-57
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307068 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 19:26:28 +00:00
Sebastian Bazley 5a925ff1ff Another baseline
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307043 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 18:49:20 +00:00
Sebastian Bazley 3296f59696 Javadoc tweak
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1307042 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 18:48:47 +00:00
Sebastian Bazley aae00f39ad CSV-85 Allow comments to be returned in CSVRecord
More test cases

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306948 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 16:03:32 +00:00
Sebastian Bazley 787ab08db9 CSV-85 Allow comments to be returned in CSVRecord
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306947 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 16:03:03 +00:00
Sebastian Bazley e94085595f CSV-35 add test
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306896 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 15:10:56 +00:00
Sebastian Bazley a07c9f72fc Improve escape tests
Fix bug in readEscape() - was not handling EOF

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306890 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 15:01:04 +00:00
Sebastian Bazley 5c9697c158 More debug
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306889 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 14:57:55 +00:00
Sebastian Bazley cee5cc3d74 CSV-69 Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306833 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 13:09:43 +00:00
Sebastian Bazley 9d00beb352 CSV-69 Utility methods for comparing results
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306828 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 13:02:27 +00:00
Sebastian Bazley 8462234502 We don't care if trailing LF has been consumed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306797 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 12:03:53 +00:00
Sebastian Bazley a5b76b6c20 Fix revision
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306789 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 11:35:20 +00:00
Sebastian Bazley 517bf0d583 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306784 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 10:57:55 +00:00
Sebastian Bazley fe10274918 Test comments and blank lines
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306668 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 01:25:47 +00:00
Sebastian Bazley 3fd45b5441 Have to check for comment after dealing with empty lines.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306667 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 01:24:24 +00:00
Sebastian Bazley 9ce0716a43 Save current lexer for comparisons
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306664 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 01:10:25 +00:00
Sebastian Bazley 19ba389fe8 Checking the token type seems to be quite slow
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306663 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:58:36 +00:00
Sebastian Bazley 810c8d0ae5 Initial tests for CSV-85 - to be updated when issue is implemented
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306662 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:46:54 +00:00
Sebastian Bazley 9dd5ace960 More blank line tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306661 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:45:39 +00:00
Sebastian Bazley 49c9a67b26 Add back trailing comment test (this time with correct expected results)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306660 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:43:34 +00:00
Sebastian Bazley a4dd5eb503 Add a few more blank lines to the test
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306659 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:31:16 +00:00
Sebastian Bazley 03dbcf48c0 Test with empty lines
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306651 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:05:45 +00:00
Sebastian Bazley 02a36dd41d Test multiple adjacent comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306650 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:03:19 +00:00
Sebastian Bazley 70f00f973a Fix readLine() so can still detect start of line next time round
Also fix broken test: format was set to ignore empty lines, yet it checked for one

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306649 13f79535-47bb-0310-9956-ffa450edef68
2012-03-29 00:02:35 +00:00
Sebastian Bazley 7addc8f688 Misplaced comment
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306643 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 23:35:09 +00:00
Sebastian Bazley 8cd4024e6d Add experimental state-driven lexer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306519 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 18:12:08 +00:00
Sebastian Bazley 6ca0f78156 Allow for new COMMENT token type
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306516 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 17:56:53 +00:00
Sebastian Bazley 61b66220b5 Add a trailing comment
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306432 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 15:35:10 +00:00
Sebastian Bazley 22af43218a Don't detect comments except at start of a line
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306422 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 15:31:20 +00:00
Sebastian Bazley a708256b65 Make lines clearer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306414 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 15:27:53 +00:00
Sebastian Bazley 67390ea304 Handle CommentStart option
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306345 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 14:06:01 +00:00
Sebastian Bazley fcfb6dc7c5 CSV-84 Clarify comment handling
Test was wrong; line comment should have been dropped entirely.
Fix record handling accordingly

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306342 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 14:05:25 +00:00
Sebastian Bazley e922bf949a CSV-84 Clarify comment handling
Fix code so comment only detected at start of a line

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306325 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:46:27 +00:00
Sebastian Bazley 05b5c8ef48 Revert r1306321 - committed wrong file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306324 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:44:38 +00:00
Sebastian Bazley 0fee01aa2d Add method for detecting start of line
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306322 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:41:42 +00:00
Sebastian Bazley 93089b260c Add method for detecting start of line
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306321 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:40:46 +00:00
Sebastian Bazley 6a91c05061 CSV-84 Clarify comment handling
Document how comment behaves

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306316 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:35:38 +00:00
Sebastian Bazley f299569070 CSV-84 Clarify comment handling
Fix test case which expected to handle a trailing comment

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306315 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:34:21 +00:00
Sebastian Bazley 0fb414b6f2 Give a bit more detail when reporting an error
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306313 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:32:14 +00:00
Sebastian Bazley c510c7222f Tidy up; rename shared fields to be clearer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306307 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 13:18:11 +00:00
Sebastian Bazley ba26844c7b CSV-70 Improve readability of CSVLexer
Simplify; remove while(true) loop

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306079 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 00:34:27 +00:00
Sebastian Bazley 7c2cfeaf58 lastChar cannot possibly be EOF if it is CR, LF or UNDEFINED
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306073 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 00:22:25 +00:00
Sebastian Bazley 0a0f3bbd36 CSV-70 Improve readability of CSVLexer
Introduce COMMENT type

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306064 13f79535-47bb-0310-9956-ffa450edef68
2012-03-28 00:01:43 +00:00
Sebastian Bazley 9114337075 CSV-70 Improve readability of CSVLexer
Remove unnecessary parameters

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306062 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 23:50:04 +00:00
Sebastian Bazley fba580930f Provide toString method for IDE debugging
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306047 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 23:11:32 +00:00
Sebastian Bazley bf1d01d79d More info
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306046 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 23:10:32 +00:00
Sebastian Bazley 1337758f9f Use super-class rather than specific implementation
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1306045 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 23:10:08 +00:00
Sebastian Bazley bfc40dede6 Add CSV file parser test case runner
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305919 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 17:32:15 +00:00
Sebastian Bazley f921e77605 Provide test access to PRISTINE
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305705 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 01:31:33 +00:00
Sebastian Bazley aeef773ed6 Calculate the booleans once; prepares for CSV-78
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305700 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 01:07:30 +00:00
Sebastian Bazley 8a683f009d CSV-75 ExtendedBufferReader does not handle EOL consistently
Fix tests

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305695 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:54:36 +00:00
Sebastian Bazley de1838ea06 CSV-75 ExtendedBufferReader does not handle EOL consistently
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305694 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:49:17 +00:00
Sebastian Bazley 0833f45bff CSV-87 CSVParser.getRecords() returns null rather than empty List at EOF
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305692 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:42:22 +00:00
Emmanuel Bourg c4e120bbf4 Added tests for line counting by the parser (CSV-75)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305689 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:20:21 +00:00
Emmanuel Bourg c6212540df Use JUnit 4 assertions for arrays
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305674 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:37:47 +00:00
Sebastian Bazley 8e9fb0e989 Add more info to toString() method; use space separator for clarity
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305669 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:32:18 +00:00
Emmanuel Bourg 50a89da39f Test empty files
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305668 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:25:48 +00:00
Emmanuel Bourg c53d3f3025 Resistance is futile
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305629 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 22:09:53 +00:00
Emmanuel Bourg e857ebfca1 Fixed floating semi columns
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305548 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 20:39:13 +00:00
Sebastian Bazley 38741a48c6 CSV-54 Confusing semantic of the ignore leading/trailing spaces parameters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305494 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 19:02:30 +00:00
Sebastian Bazley 5063b16c7a CSV-77 RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305482 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 18:31:53 +00:00
Sebastian Bazley 4406fba31c Document existing behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304503 13f79535-47bb-0310-9956-ffa450edef68
2012-03-23 17:22:22 +00:00
Sebastian Bazley 37a261b385 Add basic toString method
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304462 13f79535-47bb-0310-9956-ffa450edef68
2012-03-23 16:19:23 +00:00
Sebastian Bazley 43987a7d78 Rename to avoid hiding class field
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304097 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 22:16:01 +00:00
Sebastian Bazley dd26201ac4 CSV-81 Token.Type.isReady could perhaps be removed
Not removed, but only set on EOF if there is data to return

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303988 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 19:04:41 +00:00
Sebastian Bazley 8bba58d1ed Don't use == null; use assertNull
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303983 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 19:00:27 +00:00
Sebastian Bazley a1f7d8b166 Unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303982 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:59:52 +00:00
Sebastian Bazley 9ebd0d9425 CSV-80 - CSVLexer.nextToken does not need wsBuf
remove useless wsBuf

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303955 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:23:22 +00:00
Sebastian Bazley 1299ddfe3f Oops - fix bug introduced in r1303933
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303948 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:15:20 +00:00
Sebastian Bazley fa07dea585 CSV-71 - Add convenience Methods to CSVLexer
Use convenience fields from Lexer parent class; missed one method replacement earlier

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303933 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:00:43 +00:00
Sebastian Bazley 523171ed41 Additional convenience fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303929 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:56:03 +00:00
Sebastian Bazley 83e4a903b1 CSV-71 - Add convenience Methods to CSVLexer
Use convenience methods from Lexer parent class

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303904 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:27:51 +00:00
Sebastian Bazley ff41f78ef5 Temporary copy of original CSVLexer for performance comparison.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303901 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:25:48 +00:00
Sebastian Bazley 1ae3639d2c CSV-71 - Add convenience Methods to CSVLexer
Added methods to Lexer parent class (updated CSVLexer to follow)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303882 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:37:01 +00:00
Sebastian Bazley fdfe50842f Allow class to be instantiated dynamically
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303879 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:32:44 +00:00
Sebastian Bazley 72e830c08c Allow testing of dynamically loaded CSVLexers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303878 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:28:47 +00:00
Sebastian Bazley 5111efd46d Add direct lexer tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303719 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 10:29:11 +00:00
Sebastian Bazley 1e0dd7b4b3 Reduce Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303699 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 09:25:44 +00:00
Sebastian Bazley 65ab9db952 Make it easy to provide an alternative lexer if required
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303620 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 23:46:44 +00:00
Sebastian Bazley 7592782eee Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303506 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:50 +00:00
Sebastian Bazley 3ea8118ff3 Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303505 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:32 +00:00
Sebastian Bazley 0519364a83 Excel works as well for the input file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303504 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:03:30 +00:00
Sebastian Bazley 75bd702468 CSV-74 - CSVFormat definitions are difficult to read and maintain
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303488 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:20:05 +00:00
Sebastian Bazley 9fb2b4f2b1 CSV-79 - CSVFormat.isCommentingDisabled() is confusing/confused
renamed method to isCommentingEnabled and fixed code

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303483 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:13:54 +00:00
Sebastian Bazley d0035e6c7a headerMapping is only created once, so make it final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303455 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 16:01:31 +00:00
Sebastian Bazley 10bf28ee2e eol native
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302383 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 11:52:10 +00:00
Sebastian Bazley 4c5dbfefa5 We need a description
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302262 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 03:03:42 +00:00
Sebastian Bazley 564e8244b6 create strings for each field
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302039 13f79535-47bb-0310-9956-ffa450edef68
2012-03-18 00:00:36 +00:00
Sebastian Bazley b227c29978 Add tests of ExtendedBufferedReader for comparison
Allow tests to be configured dynamically


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302037 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 23:34:42 +00:00
Sebastian Bazley 462af64456 Simplify
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301973 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:19:22 +00:00
Sebastian Bazley 83b1072703 Add test for CSV-75
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301971 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:17:15 +00:00
Sebastian Bazley a019caec3f Simplify assertions, and provide details if the strings are not equal
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301967 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 17:36:38 +00:00
Sebastian Bazley 16278171d2 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301938 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 13:37:54 +00:00
Sebastian Bazley c9dedff12e CSV-67 UnicodeUnescapeReader should not be applied before parsing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301928 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 12:29:15 +00:00
Sebastian Bazley 9a705d8605 Initial checkin of test harness
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301864 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:57:49 +00:00
Sebastian Bazley d422c1a8b5 Simplify and avoid boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301862 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:17:44 +00:00
Sebastian Bazley 530c93392c @Override; explicit unboxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301861 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:12:16 +00:00
Sebastian Bazley 7d07c1915c Explict boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301860 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:11:03 +00:00
Emmanuel Bourg aee6c50e28 Header support (CSV-65)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301852 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 01:39:04 +00:00
Sebastian Bazley d45289f384 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301298 13f79535-47bb-0310-9956-ffa450edef68
2012-03-16 00:49:03 +00:00
Emmanuel Bourg 3362f9c9d8 Static imports in the unit tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301084 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 16:54:30 +00:00
Gary D. Gregory 186e9f9804 Update to JUnit 4.10 from 3.8.1.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300977 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 13:44:44 +00:00
Emmanuel Bourg 38670dbe92 Moved the lexer in a separate file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300850 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 08:52:05 +00:00
Emmanuel Bourg 35b954ed36 Optimized trimTrailingSpaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300780 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 23:12:57 +00:00
Sebastian Bazley 861da51f24 @literal clearer than <span>
Props Benedikt Ritter

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300707 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 20:18:56 +00:00
Sebastian Bazley 1746b7475d Document why we use CRLF rather than local line separator
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300706 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 20:12:32 +00:00
Sebastian Bazley 0ea3603628 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300699 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 19:48:12 +00:00
Sebastian Bazley bbb2da1b69 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300678 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 18:34:23 +00:00
Sebastian Bazley 31896b6d43 FIx test due to change in remove() behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300675 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 18:24:52 +00:00
Sebastian Bazley b30da4450f It's not a line, it's a record
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300665 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:59:09 +00:00
Sebastian Bazley eb6ffbb7f3 Not needed outside the iterator
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300664 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:57:24 +00:00
Sebastian Bazley f7220c40b1 CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300661 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:43:35 +00:00
Emmanuel Bourg 3cb5801a98 Replaced CharBuffer with StringBuilder (CSV-59)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300659 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:42:28 +00:00
Sebastian Bazley f8294d2d22 Check that Unicode works with the MYSQL format which uses backslash as its escape character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300591 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 15:26:14 +00:00
Sebastian Bazley ecf59bef6e Check iterator is done
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300585 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 15:15:18 +00:00
Sebastian Bazley 8033a710b0 Rename local variables to make them easier to read
l (ell) looks rather like 1 (one)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300540 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 13:38:43 +00:00
Sebastian Bazley 18d706032a Perform the cheaper test first
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300531 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 13:03:11 +00:00
Emmanuel Bourg d2c8f90800 Improved test coverage
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300516 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 12:01:47 +00:00
Emmanuel Bourg 637426c50d Removed unused methods from CharBuffer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300491 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 10:01:55 +00:00
Emmanuel Bourg 9141cb39e6 Changed while loops (CSV-55)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299706 13f79535-47bb-0310-9956-ffa450edef68
2012-03-12 15:12:55 +00:00
Emmanuel Bourg afc831bcb8 Optimized ExtendedBufferedReader as suggested by Bob Smith in CSV-42 (improves the performance by 30%)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299618 13f79535-47bb-0310-9956-ffa450edef68
2012-03-12 10:47:15 +00:00
Emmanuel Bourg 12b600c252 Serialization test for CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299580 13f79535-47bb-0310-9956-ffa450edef68
2012-03-12 08:45:34 +00:00
Emmanuel Bourg 94b9f8dc95 Minor performance improvement (~2%)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299486 13f79535-47bb-0310-9956-ffa450edef68
2012-03-11 23:23:37 +00:00
Emmanuel Bourg 740a1b6993 Removed the volatile modifier on the fields in CSVFormat to improve the performances
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299479 13f79535-47bb-0310-9956-ffa450edef68
2012-03-11 23:01:23 +00:00
Niall Pemberton 107c90daae Fix issue-tracking page config & re-generate
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299315 13f79535-47bb-0310-9956-ffa450edef68
2012-03-11 00:13:46 +00:00
Gary D. Gregory dcd7a8e061 A logo with TM mark.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299135 13f79535-47bb-0310-9956-ffa450edef68
2012-03-10 01:44:42 +00:00
Sebastian Bazley a73628d09f CSV moved to proper
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1299115 13f79535-47bb-0310-9956-ffa450edef68
2012-03-10 00:26:29 +00:00
Sebastian Bazley 883780bcf6 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298953 13f79535-47bb-0310-9956-ffa450edef68
2012-03-09 18:15:02 +00:00
Emmanuel Bourg 7ccc4c7c01 Made the fields of CSVFormat volatile to ensure its thread safety (SANDBOX-408)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298910 13f79535-47bb-0310-9956-ffa450edef68
2012-03-09 16:42:06 +00:00
Sebastian Bazley 84e46bd585 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298517 13f79535-47bb-0310-9956-ffa450edef68
2012-03-08 19:12:23 +00:00
Emmanuel Bourg 2ec4c994c0 Renamed CSVParser.getLine() into getRecord() to avoid confusions since a record can span several lines
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298333 13f79535-47bb-0310-9956-ffa450edef68
2012-03-08 09:59:51 +00:00
Emmanuel Bourg a65806a126 Validation of the format parameters (suggested by Bob Smith in SANDBOX-291)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298234 13f79535-47bb-0310-9956-ffa450edef68
2012-03-08 00:00:42 +00:00
Sebastian Bazley 72d6e797ca private field unchanged after construction, so might as well be final
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298225 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 23:42:23 +00:00
Sebastian Bazley ac6e85792f Stop Eclipse complaining about fall-through
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298223 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 23:41:14 +00:00
Sebastian Bazley 5e12903325 private fields are unchanged after construction, so might as well be final
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298221 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 23:38:46 +00:00
Sebastian Bazley 78d3d98406 Silence Eclipse warning about unthrown Exception
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298217 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 23:35:46 +00:00
Sebastian Bazley 660f37a20a @Override + Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298215 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 23:34:39 +00:00
Emmanuel Bourg 194e21c283 More Javadoc for CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298176 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 22:34:51 +00:00
Emmanuel Bourg ca7bbae40e Extracted the lexer from CSVParser in a distinct class (suggested by Bob Smith)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298033 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 18:21:52 +00:00
Emmanuel Bourg 898b7f9629 Added a mutator to CSVFormat to change the trimming behavior at both ends
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298013 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 16:32:36 +00:00
Emmanuel Bourg 00d0def695 Replaced the unicode escaping code from the parser with a class implementing java.io.Reader
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1298001 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 15:58:12 +00:00
Emmanuel Bourg 60709c2040 Added a predefined format for MySQL (SANDBOX-410)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297944 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 11:29:32 +00:00
Emmanuel Bourg 4f3ef66ce3 Removed the constructors of CSVFormat from the public API, as well as the DISABLED constant which becomes useless because the special characters are disabled by default in the predefined formats
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297930 13f79535-47bb-0310-9956-ffa450edef68
2012-03-07 11:02:52 +00:00
Emmanuel Bourg 516b82b471 Made all public methods in CharBuffer and ExtendedBufferedReader package private
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297719 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 21:00:44 +00:00
Emmanuel Bourg 9dd3dda09f Removed the package private method CSVParser.nextToken()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297431 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 11:23:04 +00:00
Emmanuel Bourg 6cf4a36a4e Added a note in the Javadoc explaining the issue with the value separator for the Excel format (SANDBOX-263)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297429 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 11:20:36 +00:00
Emmanuel Bourg 4ea25c050e Removed the writer package (SANDBOX-269), fixed width fields are out of the scope of [csv]
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297383 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 08:46:26 +00:00
Emmanuel Bourg e7434e5cb5 Changed CSVPrinter to print to any Appendable and optimized the internals to avoid string copies
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297309 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 00:48:34 +00:00
Emmanuel Bourg e80b8112a7 Fixed the NullPointerException on null values in CSVPrinter and print an empty value instead (SANDBOX-209)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297306 13f79535-47bb-0310-9956-ffa450edef68
2012-03-06 00:09:51 +00:00
Emmanuel Bourg fafacd179d Made CSVPrinter.print(char[], int, int, boolean) private
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297138 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 17:30:44 +00:00
Emmanuel Bourg 323b7aedae Varargs for CSVPrinter.println()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297136 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 17:28:56 +00:00
Emmanuel Bourg f6c0433b65 Added a constructor with a String to CSVParser and removed CSVUtils
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297135 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 17:27:28 +00:00
Emmanuel Bourg 1a35541867 Added a convenient format() method in CSVFormat replacing CSVUtils.printLine()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297091 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 15:42:03 +00:00
Emmanuel Bourg a53c76b43a Removed unused methods from CharBuffer
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297078 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 15:01:41 +00:00
Emmanuel Bourg fa5dca3be1 Test cases for CSVPrinter.printComment()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297075 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 14:42:14 +00:00
Emmanuel Bourg 7bd9d1d970 Updated the Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297043 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 13:08:19 +00:00
Emmanuel Bourg 312f5b033e Added a convenient parse() method to CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1297022 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 12:12:04 +00:00
Emmanuel Bourg c7f90f93c6 Changed the default line separator to \r\n to comply with RFC 4180 (SANDBOX-163)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1201115 13f79535-47bb-0310-9956-ffa450edef68
2011-11-12 00:16:56 +00:00
Emmanuel Bourg 70337bef8f Changed the return type of CSVFormat.clone()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1201060 13f79535-47bb-0310-9956-ffa450edef68
2011-11-11 21:34:36 +00:00
Emmanuel Bourg 2598862d94 Fixed the immutability of the delimiter in CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200283 13f79535-47bb-0310-9956-ffa450edef68
2011-11-10 11:58:02 +00:00
David Brosius 9acd5cd4d3 bad logic, should use || rather than &&, but instanceof covers the null case anyway
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200112 13f79535-47bb-0310-9956-ffa450edef68
2011-11-10 03:37:47 +00:00
Emmanuel Bourg 2417ea6c4e Changed the signature of CSVUtils.printLine() to use varargs
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200065 13f79535-47bb-0310-9956-ffa450edef68
2011-11-10 00:41:43 +00:00
Emmanuel Bourg 9cb66ca7fb Reduced the constants in CSVFormat for disabling the features to only one
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200061 13f79535-47bb-0310-9956-ffa450edef68
2011-11-10 00:26:09 +00:00
Emmanuel Bourg 4a48180eb6 Removed the references to Jakarta and fixed some links
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200041 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 23:39:17 +00:00
Emmanuel Bourg 045dbbbe4a Made CSVParser iterable to simplify the iteration over the records
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200024 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 23:04:13 +00:00
Emmanuel Bourg a7bd28c496 Renamed CSVParser.getAllValues() to getRecords()
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199997 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 22:04:01 +00:00
Emmanuel Bourg 16bfec07ff Turned the token types into an Enum
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199872 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 17:11:22 +00:00
Emmanuel Bourg cbcfb72912 Upgrading to Java 5
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199845 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 16:58:32 +00:00
Emmanuel Bourg cb99634ab3 Renamed CSVStrategy to CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199842 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 16:54:09 +00:00
Emmanuel Bourg 42476f4b08 CSVStrategy is now immutable (SANDBOX-279)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199827 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 16:21:23 +00:00
Emmanuel Bourg fc4ccb426e Removed CSVParser.nextValue() (SANDBOX-220)
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199780 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 14:54:05 +00:00
Emmanuel Bourg d90fa381c4 Made the protected fields in CSVPrinter private
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199775 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 14:42:58 +00:00
Emmanuel Bourg be3cb017eb Removed the deprecated constructors
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199772 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 14:31:40 +00:00
Emmanuel Bourg cacb79dab9 Changed the visibility of the Token types and the protected methods to package private
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199769 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 14:26:09 +00:00
Emmanuel Bourg 43b777b982 Made the static fields final in CSVStrategy
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199768 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 14:16:22 +00:00
Emmanuel Bourg e6e80741d8 Removed an unused constructor in ExtendedBufferedReader
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199761 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 13:56:16 +00:00
Emmanuel Bourg 5f1aa66714 CharBuffer is now package private
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199749 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 13:40:16 +00:00
Emmanuel Bourg 165a5dcaf4 Optimized imports
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199697 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 11:17:33 +00:00
Emmanuel Bourg c9aeca5c39 Moved the directories to match the Maven layout
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1199691 13f79535-47bb-0310-9956-ffa450edef68
2011-11-09 10:38:54 +00:00
Jacopo Cappellato 1166ca605b No functional changes are contained in this commit: reformatted Java code to fix several formatting inconsistencies (between classes and within the same class); sorry for the big commit, but I have preferred to isolate into one commit all the formatting changes.
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1065950 13f79535-47bb-0310-9956-ffa450edef68
2011-02-01 08:46:00 +00:00
Jacopo Cappellato fe5bd51f8a Applied patch contributed by Henri Yandell in SANDBOX-219: "ExtendedBufferedReader does too much"
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1065948 13f79535-47bb-0310-9956-ffa450edef68
2011-02-01 08:18:59 +00:00