Commit Graph

620 Commits

Author SHA1 Message Date
Gary D. Gregory 60cc83af7f Sort members, classes and methods (but not fields).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465763 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:23:57 +00:00
Gary D. Gregory afc9de71bd Better parameter name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465753 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:57:32 +00:00
Benedikt Ritter a0d975933d [CSV-96] CSVRecord does not verify that the length of the header mapping matches the number of values - convert ArrayIndexOutOfBoundsException to IllegalArgumentException to give users a better feedback about what went wrong
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465738 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:34:38 +00:00
Benedikt Ritter 5744ee8a16 Separate testing empty line handling from comment recognition
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465722 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:55:58 +00:00
Benedikt Ritter 449e9a8cf6 Make sure empty lines are ignored by constructing CSVFormat this way. Remove corresponding assert that would have failed if CSVFormat.newBuilder() was changed to withIgnoreEmptyLines(false)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465718 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:37:22 +00:00
Benedikt Ritter 19cb2ca2eb Give test a name that's a bit more expressive and remove comment that is no longer needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465715 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:33:36 +00:00
Benedikt Ritter 7c4121b5e0 Remove comment, intention of test is now expressed in its name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465709 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:27:34 +00:00
Benedikt Ritter 4c8024fb76 Express intention of tokens in token content and give test more structure
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465705 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:23:32 +00:00
Benedikt Ritter 1c728b40e5 Give test a name that's a bit more expressive
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465693 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 17:59:02 +00:00
Benedikt Ritter 61a879bf68 Replace assertTokenEquals with Token matcher
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465692 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 17:49:51 +00:00
Benedikt Ritter 4b5e8d70f1 Remove unneeded empty line
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465441 13f79535-47bb-0310-9956-ffa450edef68
2013-04-07 18:38:56 +00:00
Benedikt Ritter 759596a54a Correct JavaDoc indentation, remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465439 13f79535-47bb-0310-9956-ffa450edef68
2013-04-07 18:13:36 +00:00
Benedikt Ritter c694d060bd Add missing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463212 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:24:43 +00:00
Benedikt Ritter 09a6e887b8 Use hasContent matcher token type is not relevant (correct token type recognition is tested by other tests methods)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463210 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:15:31 +00:00
Benedikt Ritter aef71309b6 Add some matcher implementations as discussed on the ML http://markmail.org/message/k7gzqhbgfyiszyph
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1463207 13f79535-47bb-0310-9956-ffa450edef68
2013-04-01 17:09:24 +00:00
Gary D. Gregory 8f436552ae [CSV-96] CSVRecord does not verify that the length of the header mapping matches the number of values.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1462110 13f79535-47bb-0310-9956-ffa450edef68
2013-03-28 14:23:56 +00:00
Gary D. Gregory 08f02a086c Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1462086 13f79535-47bb-0310-9956-ffa450edef68
2013-03-28 13:29:36 +00:00
Gary D. Gregory 83ad716bc2 Add a 'using' section to the main page with a short code example and pointers to the Javadoc. Move the "About" section to the end and remove broken package reference.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461338 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 22:12:57 +00:00
Gary D. Gregory 4c530ac40d Better lvar name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461307 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 20:52:28 +00:00
Gary D. Gregory 78d7055f71 Minor clean ups.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461302 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 20:46:11 +00:00
Gary D. Gregory 6f1db38058 Better param name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461241 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:49:05 +00:00
Gary D. Gregory d10442b68a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461240 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:48:22 +00:00
Gary D. Gregory 9107316c0b Javadoc: use the active voice.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461239 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:45:01 +00:00
Gary D. Gregory 05ecd91994 Make internal API package private.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461237 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 17:42:55 +00:00
Gary D. Gregory 193dfd79af Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461225 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:47:20 +00:00
Gary D. Gregory ad9e4f3b60 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461222 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:46:29 +00:00
Gary D. Gregory 0e2ec48f8e Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461219 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:45:01 +00:00
Gary D. Gregory ce1c01c403 Javdoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461217 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:43:54 +00:00
Gary D. Gregory ba016bd759 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461213 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:36:58 +00:00
Gary D. Gregory df08acad74 Add org.apache.commons.csv.CSVFormat.CSVFormatBuilder.parse(Reader).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461202 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 16:19:48 +00:00
Gary D. Gregory e33bedefce Change back to DEFAULT format name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461192 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 15:50:18 +00:00
Gary D. Gregory 1e83d1fb59 Better Javadoc hopefully.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461150 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 14:19:00 +00:00
Gary D. Gregory 40948cdcec After discussion on ML (http://apache-commons.680414.n4.nabble.com/CSV-org-apache-commons-csv-CSVFormat-DEFAULT-td4647843.html) from 6 days ago, handle this TODO, and renamed DEFAULT to RFC4180_EMPTY_LINES.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1461134 13f79535-47bb-0310-9956-ffa450edef68
2013-03-26 13:58:30 +00:00
Benedikt Ritter eb13cb152a Fix typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460907 13f79535-47bb-0310-9956-ffa450edef68
2013-03-25 21:37:47 +00:00
Sebastian Bazley 6dc69934d2 Close printer (at least for non-Exception cases - these are unit tests)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460400 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:28:11 +00:00
Sebastian Bazley 1b78bc1502 Avoid Eclipse warning
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460396 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:14:53 +00:00
Sebastian Bazley 7825b260f3 Avoid double boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460392 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 15:10:50 +00:00
Benedikt Ritter dd1ebc9c9a Remove unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460388 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 14:51:25 +00:00
Gary D. Gregory 530d8d1248 Javadoc toBuilder().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460381 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 14:13:48 +00:00
Sebastian Bazley f4b9d6dcd1 ASF => The ASF
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460379 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 14:07:51 +00:00
Benedikt Ritter 6bc7500edb Add myself to the group of developers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460374 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:43:07 +00:00
Benedikt Ritter 8307f4af40 Change organization from 'Apache' to 'Apache Software Foundation'
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460373 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:42:04 +00:00
Benedikt Ritter 3358e83a0d Add comment why test uses a different CSVFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460369 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:38:32 +00:00
Benedikt Ritter dbbae1eccd Initialize format used by several test methods in setUp
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460367 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:36:16 +00:00
Benedikt Ritter 9e3f3cccb2 Remove test method, escaping at EOF is already tested through testEscapingAtEOF()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460365 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:30:32 +00:00
Benedikt Ritter 3a1806ba26 Split up escape testing into separate methods, add escaping tests that should work after CSV-58 is resolved (currently ignored)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460364 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:29:22 +00:00
Benedikt Ritter 6b67a34b87 Sort methods
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460348 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 13:14:21 +00:00
Gary D. Gregory b01898391d Add a toBuilder method to do:
CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", "Col3").build();
Instead of:
CSVFormat format = CSVFormat.newBuilder(CSVFormat.EXCEL).withHeader("Col1", "Col2", "Col3").build();


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460255 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 02:03:16 +00:00
Gary D. Gregory 6b2a504564 Add a toBuilder method to do:
CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", "Col3").build();
Instead of:
CSVFormat format = CSVFormat.newBuilder(CSVFormat.EXCEL).withHeader("Col1", "Col2", "Col3").build();


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460254 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 02:02:11 +00:00
Gary D. Gregory 68f4892138 Fix { } formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460251 13f79535-47bb-0310-9956-ffa450edef68
2013-03-24 01:56:44 +00:00