Commit Graph

1336 Commits

Author SHA1 Message Date
Sebb c025d73d31 CSV235 - WRONG Implementation for RFC4180
Show that implementation is actually correct
2019-06-16 13:44:04 +01:00
Sebb bc64fb569c CSV-243 CSVFormat withTrim() and withIgnoreSurroundingSpaces()
need better docs
2019-06-16 12:51:00 +01:00
Gary Gregory 8b6cfb21bb [CSV-245] Post 1.7 release fixes. 2019-06-15 13:55:50 -04:00
Alex Herbert 03550ab565 Post release fixes (#44)
* Fix checkstyle: remove tabs
* Fix checkstyle: Split long line
* Fix checkstyle: exclude pom.properties
* Update findbugs to allow deliberate fall-through
* Fix pmd: Remove ternary operator returning false
* Fix pmd: Remove implicit final
* Fix pmd: Ignore TooManyStaticImports.

This requires adding the default ruleset and then modifying with
suppressions.

* Add tests to cover use of the IOUtils class.

Requires the CSVFormat to have no quote or escape character, and the
formatted value to be a java.io.Reader.

* Clean-up findbugs exclude filter.
* Removed unused import
* Updated test comments for print tests targeting IOUtils.
* Fix checkstyle: Suppress line length warning in CSVParser.
2019-06-15 13:52:44 -04:00
Sebb 42b9fdb099 CSV-244 Test case failures following CSVFormat#equals() update 2019-06-15 14:29:30 +01:00
Gary Gregory 0279beaba0 Javadoc. 2019-06-14 20:24:59 -04:00
Gary Gregory 2a6bcc1f73 Fix odd local variable names. 2019-06-14 20:24:15 -04:00
Gary Gregory 50d727fc64 End descriptions with a period. 2019-06-14 20:19:22 -04:00
Sebb dd5de38072 CSV-243 CSVFormat withTrim() and withIgnoreSurroundingSpaces()
need better docs
2019-06-14 22:56:30 +01:00
Sebb ed8602db29 Typo 2019-06-14 22:52:41 +01:00
Sebb 7ddc71c20a Wrong method name 2019-06-14 17:22:32 +01:00
Sebb c683594f59 CSV-242 CSVFormat equals() and hashCode() don't use all fields
Fix hashCode()
2019-06-14 17:21:33 +01:00
Sebb 46c84341e6 Document change to test behaviour 2019-06-14 17:14:54 +01:00
Sebb 605bc0154f CSV-242 CSVFormat equals() and hash() don't use all fields
Fix equals()
TODO fix hash()
2019-06-14 16:32:45 +01:00
Gary Gregory 3718ec3a8e Name "Apache Commons" in page title. 2019-06-06 10:02:39 -04:00
Gary Gregory d6e494b44d [CSV-241] CSVFormat#valiadte() does not account for
llowDuplicateHeaderNames.

Applying a different version of the GitHub patch with adjustments to the
tests. Also remove trailing whitespace from CSVRecord.

Closes #43.
2019-06-05 18:03:25 -04:00
Gary Gregory 7d100bf05b Bump to next development version 2019-06-05 08:29:56 -04:00
Gary Gregory a227a1e2fb Update POM version numbers for Apache Commons CSV release 1.7 2019-06-01 20:09:24 -04:00
Gary Gregory 33bfaeef8a Prepare for release 1.7.
- There is no longer site archives. We forgot to do it for 1.6 but the
sites are still in svn.
- The Javadoc archives now point to the same place GitHub uses:
javadoc.io
- Checkstyle fixes.
2019-06-01 17:20:20 -04:00
Gary Gregory b94e5ac025 Add @since 1.7. 2019-06-01 15:16:59 -04:00
Gary Gregory e2b55d0a7b Fix typo. 2019-06-01 08:37:52 -04:00
Gary Gregory 6532c22438 Camel-case name. 2019-05-30 16:44:42 -04:00
Gary Gregory 89f8171215 Javadoc: Add missing @since 1.7. 2019-05-28 23:47:29 -04:00
Gary Gregory 0ff2f24499 Add missing Javadoc tag. 2019-05-28 23:46:36 -04:00
Gary Gregory 6ffce5335b Standardize on US spelling of "behavior". 2019-05-28 23:45:25 -04:00
Dave Moten 474b7f4d00 [CSV-239] Add javadoc to CSVFormat (#42) 2019-05-27 18:17:26 -04:00
Gary Gregory dca99998f1 Sort methods. 2019-05-27 08:10:35 -04:00
Gary Gregory 3241e0c7b2 Be quiet on the console. 2019-05-27 08:04:32 -04:00
Gary Gregory 8eb36bd8a7 - Remove unused import.
- Remove trailing white spaces on all lines.
- Use final.
- Use for-each (in test).
- Use try-with-resources (in test).
- Document empty blocks.
2019-05-24 08:21:21 -04:00
Dave Moten 030fb8e37c [CSV-239] Add CSVRecord.getHeaderNames and allow duplicate headers (#41)
* [CSV-239] Cannot get headers in column order from CSVRecord.
* getHeaderNames returns all headers in column order including repeats which are allowed as per RFC 4180
* add CSVFormat.withAllowDuplicateHeaderNames()

* [CSV-239] Cannot get headers in column order from CSVRecord.
* only wrap headerNames with unmodifiableList if non-empty
* fix and enhance CSVRecord.toMap javadoc

* [CSV-239] Cannot get headers in column order from CSVRecord.
* fix exception messages

* [CSV-239] Cannot get headers in column order from CSVRecord.
* fix whitespace

* [CSV-239] Cannot get headers in column order from CSVRecord.
* simplify if statement

* [CSV-239] Cannot get headers in column order from CSVRecord.
* fix indentation
* add javadoc to Headers class
* rename method to createHeaders
* use String.format to build error message
* initialize header names List with appropriate size
2019-05-24 08:11:17 -04:00
Gary Gregory 4d2616b7a5 [CSV-239] Cannot get headers in column order from CSVRecord.
Undo previous change.
2019-05-20 20:08:08 -04:00
Gary Gregory da55604794 [CSV-239] Cannot get headers in column order from CSVRecord.
CSVParser.createHeaderNames(Map<String, Integer>) -> private and
instance side.
2019-05-20 19:53:15 -04:00
Gary Gregory 6fd5179244 [CSV-239] Cannot get headers in column order from CSVRecord.
Rename CSVRecord.getCSVParser() -> getParser().
2019-05-20 19:51:21 -04:00
Gary Gregory d346048552 Fix warning reported by 'mvn versions:display-plugin-updates' 2019-05-20 08:27:36 -04:00
Gary Gregory 5722332c9a Fix warning reported by 'mvn versions:display-plugin-updates' 2019-05-20 08:25:08 -04:00
Gary Gregory 3fa020303b javancss-maven-plugin blows up, drop it. 2019-05-20 08:21:43 -04:00
Gary Gregory 024f98e039 [CSV-239] Cannot get headers in column order from CSVRecord.
Add test.
2019-05-20 08:14:35 -04:00
Gary Gregory 282f211394 [CSV-239] Cannot get headers in column order from CSVRecord.
- Redo header names as an read-only list.
2019-05-20 08:10:49 -04:00
Gary Gregory 476e883081 Remove unused import. 2019-05-19 19:50:41 -04:00
Gary Gregory ef51c1ecad [CSV-239] Cannot get headers in column order from CSVRecord.
- Redo so that the record tracks its source parser where call sites can
find metadata. This avoids adding slots to the record class itself.
2019-05-19 19:49:23 -04:00
Gary Gregory 9dcad06c00 Sort methods. 2019-05-19 18:55:22 -04:00
Gary Gregory 788f2aaa7a [CSV-239] Cannot get headers in column order from CSVRecord. 2019-05-19 10:26:27 -04:00
Gary Gregory d8d5de6476 [CSV-239] Cannot get headers in column order from CSVRecord.
Some NPE-proofing.
2019-05-19 09:32:46 -04:00
Gary Gregory 8a5efdeb7e Better method name. 2019-05-19 09:25:02 -04:00
Gary Gregory 734e7a910f Update maven-pmd-plugin from 3.11.0 to 3.12.0. 2019-04-23 16:02:26 -04:00
Gary Gregory a6ecad93bd Add OpenJDK 12 to Travis builds. 2019-04-16 09:14:09 -04:00
Gary Gregory 01e7e384ac Update tests from Apache Commmons Lang 3.8.1 to 3.9. 2019-04-14 20:26:30 -04:00
Gary Gregory 7c1a3fab64 Update Apache Commons Parent from 47 to 48. 2019-03-25 12:00:31 -04:00
Gary Gregory 766562306c Update Travis build with current JDKs. 2019-03-22 15:20:01 -04:00
Gary Gregory b281a0a986 Update tests from H2 1.4.198 to 1.4.199. 2019-03-13 12:16:13 -04:00