Commit Graph

244 Commits

Author SHA1 Message Date
Sebastian Bazley fa07dea585 CSV-71 - Add convenience Methods to CSVLexer
Use convenience fields from Lexer parent class; missed one method replacement earlier

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303933 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:00:43 +00:00
Sebastian Bazley 523171ed41 Additional convenience fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303929 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:56:03 +00:00
Sebastian Bazley 83e4a903b1 CSV-71 - Add convenience Methods to CSVLexer
Use convenience methods from Lexer parent class

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303904 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:27:51 +00:00
Sebastian Bazley ff41f78ef5 Temporary copy of original CSVLexer for performance comparison.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303901 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:25:48 +00:00
Sebastian Bazley 1ae3639d2c CSV-71 - Add convenience Methods to CSVLexer
Added methods to Lexer parent class (updated CSVLexer to follow)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303882 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:37:01 +00:00
Sebastian Bazley fdfe50842f Allow class to be instantiated dynamically
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303879 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:32:44 +00:00
Sebastian Bazley 72e830c08c Allow testing of dynamically loaded CSVLexers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303878 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:28:47 +00:00
Sebastian Bazley 5111efd46d Add direct lexer tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303719 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 10:29:11 +00:00
Sebastian Bazley 1e0dd7b4b3 Reduce Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303699 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 09:25:44 +00:00
Sebastian Bazley 65ab9db952 Make it easy to provide an alternative lexer if required
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303620 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 23:46:44 +00:00
Sebastian Bazley 7592782eee Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303506 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:50 +00:00
Sebastian Bazley 3ea8118ff3 Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303505 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:32 +00:00
Sebastian Bazley 0519364a83 Excel works as well for the input file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303504 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:03:30 +00:00
Sebastian Bazley 75bd702468 CSV-74 - CSVFormat definitions are difficult to read and maintain
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303488 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:20:05 +00:00
Sebastian Bazley 9fb2b4f2b1 CSV-79 - CSVFormat.isCommentingDisabled() is confusing/confused
renamed method to isCommentingEnabled and fixed code

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303483 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:13:54 +00:00
Sebastian Bazley d0035e6c7a headerMapping is only created once, so make it final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303455 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 16:01:31 +00:00
Sebastian Bazley 10bf28ee2e eol native
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302383 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 11:52:10 +00:00
Sebastian Bazley 101a040805 Provide initial description
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302263 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 03:08:09 +00:00
Sebastian Bazley 4c5dbfefa5 We need a description
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302262 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 03:03:42 +00:00
Sebastian Bazley 564e8244b6 create strings for each field
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302039 13f79535-47bb-0310-9956-ffa450edef68
2012-03-18 00:00:36 +00:00
Sebastian Bazley b227c29978 Add tests of ExtendedBufferedReader for comparison
Allow tests to be configured dynamically


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302037 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 23:34:42 +00:00
Sebastian Bazley 462af64456 Simplify
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301973 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:19:22 +00:00
Sebastian Bazley 83b1072703 Add test for CSV-75
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301971 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:17:15 +00:00
Sebastian Bazley a019caec3f Simplify assertions, and provide details if the strings are not equal
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301967 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 17:36:38 +00:00
Sebastian Bazley 16278171d2 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301938 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 13:37:54 +00:00
Sebastian Bazley c9dedff12e CSV-67 UnicodeUnescapeReader should not be applied before parsing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301928 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 12:29:15 +00:00
Henri Yandell 29efef70f1 Updating copyright dates in notice per expressive last entries in each components svn log
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301865 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 05:09:23 +00:00
Sebastian Bazley 9a705d8605 Initial checkin of test harness
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301864 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:57:49 +00:00
Sebastian Bazley d422c1a8b5 Simplify and avoid boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301862 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:17:44 +00:00
Sebastian Bazley 530c93392c @Override; explicit unboxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301861 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:12:16 +00:00
Sebastian Bazley 7d07c1915c Explict boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301860 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:11:03 +00:00
Emmanuel Bourg aee6c50e28 Header support (CSV-65)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301852 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 01:39:04 +00:00
Sebastian Bazley d45289f384 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301298 13f79535-47bb-0310-9956-ffa450edef68
2012-03-16 00:49:03 +00:00
Emmanuel Bourg 3362f9c9d8 Static imports in the unit tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301084 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 16:54:30 +00:00
Gary D. Gregory 186e9f9804 Update to JUnit 4.10 from 3.8.1.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300977 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 13:44:44 +00:00
Emmanuel Bourg 38670dbe92 Moved the lexer in a separate file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300850 13f79535-47bb-0310-9956-ffa450edef68
2012-03-15 08:52:05 +00:00
Emmanuel Bourg 35b954ed36 Optimized trimTrailingSpaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300780 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 23:12:57 +00:00
Sebastian Bazley 861da51f24 @literal clearer than <span>
Props Benedikt Ritter

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300707 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 20:18:56 +00:00
Sebastian Bazley 1746b7475d Document why we use CRLF rather than local line separator
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300706 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 20:12:32 +00:00
Sebastian Bazley 0ea3603628 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300699 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 19:48:12 +00:00
Sebastian Bazley bbb2da1b69 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300678 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 18:34:23 +00:00
Sebastian Bazley 31896b6d43 FIx test due to change in remove() behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300675 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 18:24:52 +00:00
Sebastian Bazley b30da4450f It's not a line, it's a record
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300665 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:59:09 +00:00
Sebastian Bazley eb6ffbb7f3 Not needed outside the iterator
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300664 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:57:24 +00:00
Sebastian Bazley f7220c40b1 CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300661 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:43:35 +00:00
Emmanuel Bourg 3cb5801a98 Replaced CharBuffer with StringBuilder (CSV-59)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300659 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 17:42:28 +00:00
Sebastian Bazley f8294d2d22 Check that Unicode works with the MYSQL format which uses backslash as its escape character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300591 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 15:26:14 +00:00
Sebastian Bazley ecf59bef6e Check iterator is done
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300585 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 15:15:18 +00:00
Sebastian Bazley 8033a710b0 Rename local variables to make them easier to read
l (ell) looks rather like 1 (one)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300540 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 13:38:43 +00:00
Sebastian Bazley 18d706032a Perform the cheaper test first
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1300531 13f79535-47bb-0310-9956-ffa450edef68
2012-03-14 13:03:11 +00:00