Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LANG-571 ArrayUtils.add(T[] array[, offset], T element) can create unexpected ClassCastException 

Remove tests for generation of Object arrays when both objects are null

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@899940 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2010-01-16 13:05:07 +00:00
parent 13bdd203ce
commit 01067903aa
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java
View File

@ -178,15 +178,8 @@ public void testAddObjectArrayShort() {
public void testAddObjectArrayObject() { public void testAddObjectArrayObject() {
Object[] newArray; Object[] newArray;
newArray = ArrayUtils.add((Object[])null, null);
assertTrue(Arrays.equals((new Object[]{null}), newArray));
assertEquals(Object.class, newArray.getClass().getComponentType());
//show that not casting is okay //show that not casting is okay
newArray = ArrayUtils.add(null, null);
assertTrue(Arrays.equals((new Object[]{null}), newArray));
assertEquals(Object.class, newArray.getClass().getComponentType());
newArray = ArrayUtils.add((Object[])null, "a"); newArray = ArrayUtils.add((Object[])null, "a");
assertTrue(Arrays.equals((new String[]{"a"}), newArray)); assertTrue(Arrays.equals((new String[]{"a"}), newArray));
assertTrue(Arrays.equals((new Object[]{"a"}), newArray)); assertTrue(Arrays.equals((new Object[]{"a"}), newArray));
@ -216,10 +209,6 @@ public void testAddObjectArrayObject() {
newArray = ArrayUtils.add(numberArray1, new Float(3)); newArray = ArrayUtils.add(numberArray1, new Float(3));
assertTrue(Arrays.equals((new Float[]{new Float(3)}), newArray)); assertTrue(Arrays.equals((new Float[]{new Float(3)}), newArray));
assertEquals(Float.class, newArray.getClass().getComponentType()); assertEquals(Float.class, newArray.getClass().getComponentType());
newArray = ArrayUtils.add(numberArray1, null);
assertTrue(Arrays.equals((new Object[]{null}), newArray));
assertEquals(Object.class, newArray.getClass().getComponentType());
} }
public void testLANG571(){ public void testLANG571(){
@ -360,9 +349,6 @@ public void testAddObjectArrayToObjectArray() {
public void testAddObjectAtIndex() { public void testAddObjectAtIndex() {
Object[] newArray; Object[] newArray;
newArray = ArrayUtils.add((Object[])null, 0, null);
assertTrue(Arrays.equals((new Object[]{null}), newArray));
assertEquals(Object.class, newArray.getClass().getComponentType());
newArray = ArrayUtils.add((Object[])null, 0, "a"); newArray = ArrayUtils.add((Object[])null, 0, "a");
assertTrue(Arrays.equals((new String[]{"a"}), newArray)); assertTrue(Arrays.equals((new String[]{"a"}), newArray));
assertTrue(Arrays.equals((new Object[]{"a"}), newArray)); assertTrue(Arrays.equals((new Object[]{"a"}), newArray));