Commit Graph

5412 Commits

Author SHA1 Message Date
pascalschumacher 274dbfe81f pom.xml: remove jacoco configuration from reporting section, so that c56b87d6ef is completely reverted 2017-10-11 18:54:14 +02:00
Chas Honton 862a0d1ff5 revert change.xml note 2017-10-11 08:54:23 -07:00
Chas Honton 07f3694a5c revert LANG-1354; java7 has synthetic fields on Integer, jacoco does not yet work with java9 2017-10-11 08:50:01 -07:00
Chas Honton 0f32b292c2 remove checkstyle error 2017-10-11 08:15:21 -07:00
Chas Honton e7b3e1d20f update travis to use jacoco coverage report 2017-10-11 08:03:59 -07:00
Chas Honton c56b87d6ef LANG-1354: FieldUtils should ignore any synthetic fields 2017-10-10 20:52:50 -07:00
Gary Gregory 1e9e36640f Make private fields final. 2017-10-10 16:28:59 -06:00
Gary Gregory 9a7de3974d Sort members. 2017-10-10 12:03:07 -06:00
Gary Gregory 060e66bf99 No need to nest. 2017-10-10 12:02:06 -06:00
Gary Gregory 33a1f82a13 [LANG-1355] TimeZone.getTimeZone() in FastDateParser causes resource
contention</action>. Javadoc: Use the active voice.
2017-10-10 12:01:31 -06:00
Chas Honton 1dbfaeecbd [LANG-1355] TimeZone.getTimeZone() in FastDateParser causes resource
contention</action>. This closes #296.
2017-10-10 11:58:29 -06:00
Gary Gregory 15d5503215 Checkstyle: Remove trailing white spaces on all lines. 2017-10-09 15:44:17 -06:00
Gary Gregory d848328a7a Set date template and description. 2017-10-09 14:58:35 -06:00
Gary Gregory 09d70ce73d Make tests a little more bullet-proof. 2017-10-09 14:54:31 -06:00
Gary Gregory 732ea5e94f Make tests a little more bullet-proof. 2017-10-09 14:53:32 -06:00
Gary Gregory 87eff4c78f Make tests a little more bullet-proof. 2017-10-09 14:52:43 -06:00
Gary Gregory 0726ffe1e9 Minor formatting. 2017-10-09 14:48:10 -06:00
Gary Gregory ed94e5a5cc UTC and GMT are the same, so simplify. 2017-10-09 14:47:33 -06:00
Gary Gregory 3b6867fc25 Refactor "GMT" magic string. 2017-10-09 14:44:35 -06:00
Gary Gregory f4bfd9c71f Refactor "GMT" magic string. 2017-10-09 14:41:46 -06:00
Gary Gregory fd60085a2a Refactor "GMT" magic string. 2017-10-09 14:40:43 -06:00
Gary Gregory 4485491219 [LANG-1357] org.apache.commons.lang3.time.FastDateParser should use
toUpperCase(Locale)
2017-10-09 14:30:07 -06:00
pascalschumacher 00feb98f80 LANG-1348: StackOverflowError on TypeUtils.toString(...) for a generic return type of Enum.valueOf
add changes.xml entry
2017-10-07 11:54:38 +02:00
mbusso cc6beb2d05 LANG-1348 - StackOverflowError on TypeUtils.toString(...) for a generic return type of Enum.valueOf (closes #292) 2017-10-07 11:50:15 +02:00
Allon Mureinik 36217ee164 ExtendedMessageFormatTest integers (#295)
Use the decimal "5" instead of the octal notation "05" to make the
code more straight forward and easier to read.
2017-10-07 11:47:30 +02:00
pascalschumacher cc748d35e5 travis: remove travis profile from pom and use travis-cobertura profile commons-parent 2017-10-01 16:19:50 +02:00
pascalschumacher f3df2590df .travis.yml: trusty is now the default distribution, so remove it from explicit configuration 2017-10-01 15:47:59 +02:00
Allon Mureinik d65b9d2bed Improve tests for CharUtils illegal usages (closes #293)
CharUtilsTest has several instances of the following pattern:

    try {
        CharUtils.someMethod("illegal input");
    } catch (final IllegalArgumentException ex) {}

This pattern is not very useful for testing, as the test would pass
whether an IllegalArgumentException is thrown or not. This patch
enhances the test by explicitly failing it if the exception is not
thrown:

    try {
        CharUtils.someMethod("illegal input");
        fail("An IllegalArgumentException should have been thrown");
    } catch (final IllegalArgumentException ex) {}
2017-10-01 14:33:21 +02:00
Allon Mureinik ae862ae116 CharUtilsTest#testIsAscii_char loop
The loop currently loops only up to 128, thus testing just positive
return values of CharUtils#isAscii(char). This patch increase the loop
to go over all the possible values of an unsigned byte, thus testing
also negative return values.
2017-10-01 14:33:16 +02:00
Allon Mureinik c7554151d3 Clean up if in CharUtilsTest#testIsAscii_char
The if statement calls assertTrue on the if branch and assertFalse on
the else branch on the same expression. This can easily be simplified
to assertEquals with a boolean expression to make the code clean and
easier to read.
2017-10-01 14:33:16 +02:00
Allon Mureinik 7076b7408f Boolean comparisons in CharRange (closes #289)
Cleaned up comparisons to false to just use the boolean negation
operator (!).
2017-09-29 17:05:31 +02:00
Benedikt Ritter 1406f2a4f2
Correct link to JavaDoc badge image 2017-09-25 20:30:04 +02:00
Benedikt Ritter e1a6e08417
Add JavaDoc badge 2017-09-25 20:27:59 +02:00
Allon Mureinik be31b6eb24 Fix typo stateme->statement
This closes #288
2017-09-21 22:48:03 +12:00
Allon Mureinik 466244ce3d Clean up findbugs exclusions for old XYZRange classes (closes #287)
Commit 56e830a removed all the old XYZRange classes from
org.apache.lang3.math, and left only the generic Range<T> class.

This patch removes the left-over findbugs exclusions for those
classes.
2017-09-20 22:10:16 +02:00
Bruno P. Kinoshita ff4967536b Merge branch 'pr/285'
This closes #285
2017-09-09 19:10:57 +12:00
Oliver Siegmar 67830fe249 make checkstyle config more portable (no maven coupling) 2017-09-09 08:51:49 +02:00
pascalschumacher fdf05fa29b LANG-1349: EqualsBuilder#isRegistered: swappedPair construction bug
Modify test to clean-up registry at the end.
2017-09-08 18:43:16 +02:00
pascalschumacher a2dce32cda LANG-1349: EqualsBuilder#isRegistered: swappedPair construction bug
Add a test and a changes.xml entry.
2017-09-08 18:23:03 +02:00
namannigam 3e08af573f LANG-1349: EqualsBuilder#isRegistered: swappedPair construction bug (closes #282)
SwappedPair constructed as Pair.of(rhs,lhs)
2017-09-08 18:19:04 +02:00
Oliver Siegmar d6ad3f0157 remove redundant modifiers (support recent checkstyle versions) (closes #284) 2017-09-08 17:12:51 +02:00
Gary Gregory cc94767e7e [LANG-1350] ConstructorUtils.invokeConstructor(Class, Object...)
regression
2017-08-21 09:28:01 -06:00
pascalschumacher 05d9518038 add oraclejdk9 to travis configuration (closes #280)
maven java9 profile:
- use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0 do not work on java 9
- skip maven-coveralls-plugin, because version 4.3.0 does not work on java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112
2017-07-28 19:31:18 +02:00
pascalschumacher daeed97201 LANG-1346: Remove deprecation from RandomStringUtils
fix checkstyle violation
2017-07-28 18:26:35 +02:00
pascalschumacher f2d8493ac4 LANG-1346: Remove deprecation from RandomStringUtils 2017-07-28 17:06:36 +02:00
pascalschumacher fdccdeaec5 Remove oraclejdk7 from travis configuration, because it is no longer available.
see: https://github.com/travis-ci/travis-ci/issues/7964#issuecomment-316769421 for details
2017-07-24 23:42:38 +02:00
Amey Jadiye 187a05b8a4 Apply patch for Travis-CI build:
https://github.com/apache/commons-lang/pull/277
2017-07-14 11:50:43 -07:00
Jonathan Bluett-Duncan 1571050a19 [GitHub] commons-lang pull request #276: IntelliJ IDEA refactorings.
Closes #276.
2017-07-12 00:09:41 -07:00
Allon Mureinik a37d19eb45 Fix ExceptionUtils#getStackFrame(String) javadoc (closes #274)
ExceptionUtils#getStackFrame(String)'s javadoc contains a broken
reference to SystemUtils#LINE_SEPARATOR (as the class name is not
fully qualified, and there's no import of
org.apache.commons.lang3.SystemUtils).

This patch fixes the broken reference by replacing it it with a
reference to System#lineSeparator(), which the method actually uses.
2017-07-02 16:58:02 +02:00
Amey Jadiye 5f0d812757 Replaced test with verify. Closes #72. 2017-06-23 15:11:01 -07:00