Commit Graph

564 Commits

Author SHA1 Message Date
Stephen Colebourne bdbdb49ace Declare variable final
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137515 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 15:33:34 +00:00
Stephen Colebourne 3f532cf5c3 Add test for indexOf edge case
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137514 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 14:36:30 +00:00
Stephen Colebourne 3d97997494 Comment out unreliable test based on stack trace
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137513 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 14:36:00 +00:00
Stephen Colebourne 89e735ed4e Handle JDK1.2/JDK1.3 bug in String.indexOf
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137512 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 14:34:49 +00:00
Stephen Colebourne 9345b31d15 Fix bug in isNestedThrowable, shown on JDK<1.4
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137511 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 14:22:21 +00:00
Stephen Colebourne 858d38ddcf Comment out checkstyle to allow for maven-beta10
bug 21809


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137510 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 13:21:44 +00:00
Stephen Colebourne ccb2c966f9 Update null handling in ExceptionUtils
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137509 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 13:11:21 +00:00
Stephen Colebourne 96de08907e Update null handling in ExceptionUtils
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137508 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 13:05:21 +00:00
Stephen Colebourne 5943137656 Javadoc improvements
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137507 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 13:00:36 +00:00
Stephen Colebourne 7edd55554a Fix Javadoc troubles
from Phil Steitz


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137506 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 10:32:17 +00:00
Gary D. Gregory b612cd4156 In 2 places, removed local var def before return of var, replaced with actual expression.
This follows the other methods' code pattern.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137505 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 02:57:37 +00:00
Gary D. Gregory f133c130bc Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type int for expression of type int	Fraction.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/math	line 391	July 25, 2003 5:56:34 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137504 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 00:57:02 +00:00
Gary D. Gregory da00e1d426 Avoid Javadoc warning with Standard Doclet version 1.4.2.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137503 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 00:45:27 +00:00
Gary D. Gregory 77f8c186f2 Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type int for expression of type char	Entities.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang	line 643	July 23, 2003 11:22:37 AM
	Unnecessary cast to type int for expression of type char. It is already compatible with the argument type int	Entities.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang	line 642	July 23, 2003 11:22:37 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137502 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 00:32:19 +00:00
Gary D. Gregory 9e100212ce Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type int for expression of type char. It is already compatible with the argument type int	EntitiesTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang	line 130	July 23, 2003 11:22:39 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137501 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 00:31:29 +00:00
Gary D. Gregory e81e45f27f Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type int for expression of type char	RandomStringUtils.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang	line 259	July 23, 2003 11:22:36 AM
	Unnecessary cast to type int for expression of type char. It is already compatible with the argument type int	RandomStringUtils.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang	line 258	July 23, 2003 11:22:36 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137500 13f79535-47bb-0310-9956-ffa450edef68
2003-07-26 00:26:32 +00:00
Stephen Colebourne 98732b58ca Change as recommended by findBugs
(static variables private or final, and Boolean constructor optimisation)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137499 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 23:06:58 +00:00
Gary D. Gregory d9816dab73 Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type String[] for expression of type Object[]. It is already compatible with the argument type Object	NestableDelegate.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/exception	line 378	July 23, 2003 11:22:36 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137498 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 23:05:22 +00:00
Gary D. Gregory 85d33454a1 Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type Object for expression of type Object	ToStringStyle.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 420	July 23, 2003 11:22:36 AM
	Unnecessary cast to type Object for expression of type Object	ToStringStyle.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 422	July 23, 2003 11:22:36 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137497 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 23:04:24 +00:00
Gary D. Gregory 43dd7284cf Severity Description Resource In Folder Location Creation Time
Unnecessary cast to type int for expression of type byte. It is already compatible with the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 471	July 23, 2003 11:22:36 AM
	Unnecessary cast to type int for expression of type char. It is already compatible with the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 460	July 23, 2003 11:22:36 AM
	Unnecessary cast to type int for expression of type short. It is already compatible with the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 449	July 23, 2003 11:22:36 AM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137496 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 23:03:30 +00:00
Stephen Colebourne 247c97f507 Remove unneeded String constructor as found by findBugs
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137495 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 22:53:49 +00:00
Stephen Colebourne a303646251 Javadoc and tests for ObjectUtils
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137494 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 22:37:59 +00:00
Stephen Colebourne 7ff6e3a30f Rename slice functions to substringAfter/substringBefore
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137493 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 22:22:30 +00:00
Stephen Colebourne d33605dfc9 Update slice methods to be more consistent
from Phil Steitz


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137492 13f79535-47bb-0310-9956-ffa450edef68
2003-07-25 00:50:00 +00:00
Stephen Colebourne e758deb5e8 Add extra example code javadoc and related tests
bug 21797, from Phil Steitz


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137491 13f79535-47bb-0310-9956-ffa450edef68
2003-07-22 23:36:40 +00:00
Stephen Colebourne e00c4a2546 Increase explanation comment, requested by Gary Gregory
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137490 13f79535-47bb-0310-9956-ffa450edef68
2003-07-22 00:09:14 +00:00
Stephen Colebourne 2d17989e28 Fix stupid compile error....
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137489 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 23:32:41 +00:00
Stephen Colebourne 1f0aeca4d5 Javadoc fixes
bug 21758, from Pete Gieser


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137488 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 23:30:42 +00:00
Stephen Colebourne dbe97c09ca Javadoc fixes
bug 21758, from Pete Gieser


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137487 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 23:14:37 +00:00
Stephen Colebourne a1e6b5d617 Reverse recent addition of date formatting. Better solution required.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137486 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 23:03:53 +00:00
Stephen Colebourne 6a0ce20988 Fix class so IS_JAVA_* and IS_OS_* constants work correctly.
bug 21767, from Tetsuya Kaneuchi


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137485 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 22:57:51 +00:00
Stephen Colebourne 6a5bdacba3 Change ant script to improve readability
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137484 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 22:54:37 +00:00
Gary D. Gregory 0e08941e69 Severity Description Resource In Folder Location Creation Time
Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 157	July 20, 2003 12:01:26 PM
	Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 168	July 20, 2003 12:01:26 PM
	Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 179	July 20, 2003 12:01:26 PM
	Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 190	July 20, 2003 12:01:26 PM
	Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 201	July 20, 2003 12:01:26 PM
	Superfluous semicolon	NumberUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 212	July 20, 2003 12:01:26 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137483 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 19:42:12 +00:00
Gary D. Gregory 3d3276ba5a Missing '.' caused the Javadoc warning:
[javadoc] Generating C:\cvs-store\apache.org\jakarta\commons\lang\dist\docs\api\index-all.html...
  [javadoc] "<p>Append to the <code>toString</code> a <code>Date</code>
  [javadoc]  value, using the optional <code>DateFormat</code>"
  [javadoc] C:\cvs-store\apache.org\jakarta\commons\lang\src\java\org\apache\commons\lang\builder\ToStringStyle.java:476: warning - The first sentence is interp
reted to be:
  [javadoc] This sentence is different from what will be interpreted as the first sentence in the
  [javadoc] next major release (when that interpretation will be internationalized), which is:
  [javadoc] "<p>Append to the <code>toString</code> a <code>Date</code>
  [javadoc]  value, using the optional <code>DateFormat</code></p>"
  [javadoc] To avoid this note, change the doc comment to make this a proper first sentence, then
  [javadoc] use -breakiterator from that point forward, which will output this new sentence.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137482 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 19:34:10 +00:00
Gary D. Gregory 2445ba85ff Javadocs now links to the JRE 1.2 Sun Javadoc (1.2 is the [lang] base requirement).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137481 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 19:30:46 +00:00
Stephen Colebourne f434e7ba71 Update Javadoc examples
Change mid() to accept invalid startPos


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137480 13f79535-47bb-0310-9956-ffa450edef68
2003-07-21 00:41:13 +00:00
Stephen Colebourne d381baaf33 Update Javadoc and tests
bug 21750, from Phil Steitz


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137479 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 23:57:26 +00:00
Gary D. Gregory 82c4c69189 Severity Description Resource In Folder Location Creation Time
Superfluous semicolon	RandomUtilsTest.java	Apache Jakarta Commons/lang/src/test/org/apache/commons/lang/math	line 315	July 18, 2003 8:21:31 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137478 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 18:58:46 +00:00
Stephen Colebourne f5d4e8456e Updates pre 2.0
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137477 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 16:14:51 +00:00
Stephen Colebourne af6aba957f Update null handling behaviour and documentation
bug 21734, from Phil Steiz


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137476 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 16:03:21 +00:00
Stephen Colebourne 69756032f5 Organize imports
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137475 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 15:49:58 +00:00
Stephen Colebourne 9af8bc1c40 Remove defaultString(Object) from StringUtils
Add  toString(Object)  to ObjectUtils


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137474 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 15:41:52 +00:00
Stephen Colebourne 1ea34cbbba Add more javadoc example code
Ensure empty string behaviour documented in example code


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137473 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 15:29:44 +00:00
Stephen Colebourne 91a22bc494 Add summary javadoc section to StringUtils class
Rename reverseDelimitedString to reverseDelimited


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137472 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 14:47:29 +00:00
Stephen Colebourne 4c1e760dd8 Add new method center(String, int, char) to complete API
Rework padding internals
Example javadoc difference()/differenceAt()
Remove dependency on NumberUtils


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137471 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 10:29:22 +00:00
Stephen Colebourne 5d5af47995 Fix wrong javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137470 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 10:24:49 +00:00
Gary D. Gregory 2cf366c11a Severity Description Resource In Folder Location Creation Time
The static field DateFormat.FULL should be accessed directly	FastDateFormat.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/time	line 112	July 19, 2003 5:17:12 PM
	The static field DateFormat.LONG should be accessed directly	FastDateFormat.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/time	line 116	July 19, 2003 5:17:12 PM
	The static field DateFormat.MEDIUM should be accessed directly	FastDateFormat.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/time	line 120	July 19, 2003 5:17:12 PM
	The static field DateFormat.SHORT should be accessed directly	FastDateFormat.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/time	line 124	July 19, 2003 5:17:12 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137469 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 01:21:29 +00:00
Gary D. Gregory 155533d20d Severity Description Resource In Folder Location Creation Time
Superfluous semicolon	MethodUtils.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/reflect	line 491	July 18, 2003 8:21:29 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137468 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 01:13:54 +00:00
Gary D. Gregory cd63d78c4a Severity Description Resource In Folder Location Creation Time
The static method setAccessible(AccessibleObject[], boolean) from the type AccessibleObject should be accessed directly 	ReflectionToStringBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 346	July 18, 2003 8:21:31 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137467 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 01:13:14 +00:00
Gary D. Gregory 42a2549dc0 Severity Description Resource In Folder Location Creation Time
The static method setAccessible(AccessibleObject[], boolean) from the type AccessibleObject should be accessed directly 	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 341	July 18, 2003 8:21:31 PM


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137466 13f79535-47bb-0310-9956-ffa450edef68
2003-07-20 01:12:32 +00:00