Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add an item to concurrency checklist about assertions in parall… (#8701) 

Add an item to concurrency checklist about assertions in parallel threads and async code in tests
This commit is contained in:
Roman Leventov 2019-10-29 11:38:04 +03:00 committed by GitHub
parent b8ceee4eee
commit 3e9723e3ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/code-review/concurrency.md
View File

@ -108,6 +108,8 @@ Testing
https://github.com/code-review-checklists/java-concurrency#coordinate-test-workers)
- [There are more test threads than CPUs (if possible for the test)?](
https://github.com/code-review-checklists/java-concurrency#test-workers-interleavings)
- [Assertions in parallel threads and asynchronous code are handled properly?](
https://github.com/code-review-checklists/java-concurrency#concurrent-assert)
Locks
- [Can use `LifecycleLock` instead of a standard lock in a lifecycled object?](#use-lifecycle-lock)
@ -245,4 +247,4 @@ daemon threads already.
<a name="use-execs"></a>
[#](#use-execs) TE.D2. Is it possible to use one of the static factory methods in Druid's `Execs` utility class to
create an `ExecutorService` instead of Java's standard `ExecutorServices`? This is recommended because `Execs` configure
ThreadFactories to create daemon threads by default, as required by the previous item.
ThreadFactories to create daemon threads by default, as required by the previous item.