Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add checkbox for licenses.yaml in PR template, mention it in CONTRIBUTING.md (#8367)

This commit is contained in:
Clint Wylie 2019-08-22 14:14:24 -07:00 committed by Gian Merlino
parent e3e85e8f1a
commit 71676cd16d
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/pull_request_template.md vendored
View File

@ -42,6 +42,7 @@ This PR has:
- [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors. - [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests. - [ ] added integration tests.

3
CONTRIBUTING.md
View File

@ -36,6 +36,9 @@ When submitting a pull request (PR), please use the following guidelines:
- Do not use author tags/information in the code. - Do not use author tags/information in the code.
- Try to keep pull requests short and submit separate ones for unrelated - Try to keep pull requests short and submit separate ones for unrelated
features, but feel free to combine simple bugfixes/tests into one pull request. features, but feel free to combine simple bugfixes/tests into one pull request.
- If you are adding or updating a dependency, be sure to update the version, license, or notice information in
[licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml) as appropriate to help ease
LICENSE and NOTICE management for ASF releases.
You can find more developers' resources in [`dev/`](dev) directory. You can find more developers' resources in [`dev/`](dev) directory.