Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable CacheDistributionTest by default (#4527)

This commit is contained in:
Jihoon Son 2017-07-12 01:16:12 +09:00 committed by Gian Merlino
parent 298310ad78
commit c5d5263c10
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/main/java/io/druid/client/cache/MemcachedCache.java vendored
View File

@ -74,6 +74,12 @@ public class MemcachedCache implements Cache
{ {
private static final Logger log = new Logger(MemcachedCache.class); private static final Logger log = new Logger(MemcachedCache.class);
/**
* Default hash algorithm for cache distribution.
*
* If some other algorithms are considered as the default algorithm instead of this one, the cache distribution for
* those hash algorithms should be checked and compared using {@code CacheDistributionTest}.
*/
final static HashAlgorithm MURMUR3_128 = new HashAlgorithm() final static HashAlgorithm MURMUR3_128 = new HashAlgorithm()
{ {
final HashFunction fn = Hashing.murmur3_128(); final HashFunction fn = Hashing.murmur3_128();

6
server/src/test/java/io/druid/client/cache/CacheDistributionTest.java vendored
View File

@ -32,6 +32,7 @@ import net.spy.memcached.util.DefaultKetamaNodeLocatorConfiguration;
import org.apache.commons.codec.digest.DigestUtils; import org.apache.commons.codec.digest.DigestUtils;
import org.easymock.EasyMock; import org.easymock.EasyMock;
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.Parameterized; import org.junit.runners.Parameterized;
@ -93,7 +94,10 @@ public class CacheDistributionTest
this.reps = reps; this.reps = reps;
} }
// run to get a sense of cache key distribution for different ketama reps / hash functions // Run to get a sense of cache key distribution for different ketama reps / hash functions
// This test is disabled by default because it's a qualitative test not an unit test and thus it have a meaning only
// when being run and checked by humans.
@Ignore
@Test @Test
public void testDistribution() throws Exception public void testDistribution() throws Exception
{ {