HDFS-2526. (Client)NamenodeProtocolTranslatorR23 do not need to keep a reference to rpcProxyWithoutRetry (atm)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1196171 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Aaron Myers 2011-11-01 17:59:53 +00:00
parent 1852c2c1da
commit abe45f59ac
3 changed files with 7 additions and 16 deletions

View File

@ -85,6 +85,9 @@ Trunk (unreleased changes)
HDFS-2497 Fix TestBackupNode failure. (suresh) HDFS-2497 Fix TestBackupNode failure. (suresh)
HDFS-2526. (Client)NamenodeProtocolTranslatorR23 do not need to keep a
reference to rpcProxyWithoutRetry (atm)
Release 0.23.0 - 2011-11-01 Release 0.23.0 - 2011-11-01
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

View File

@ -79,7 +79,6 @@ import org.apache.hadoop.hdfs.protocol.HdfsConstants;
@InterfaceStability.Stable @InterfaceStability.Stable
public class ClientNamenodeProtocolTranslatorR23 implements public class ClientNamenodeProtocolTranslatorR23 implements
ClientProtocol, Closeable { ClientProtocol, Closeable {
final private ClientNamenodeWireProtocol rpcProxyWithoutRetry;
final private ClientNamenodeWireProtocol rpcProxy; final private ClientNamenodeWireProtocol rpcProxy;
private static ClientNamenodeWireProtocol createNamenode( private static ClientNamenodeWireProtocol createNamenode(
@ -118,16 +117,11 @@ public class ClientNamenodeProtocolTranslatorR23 implements
public ClientNamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr, public ClientNamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr,
Configuration conf, UserGroupInformation ugi) throws IOException { Configuration conf, UserGroupInformation ugi) throws IOException {
rpcProxyWithoutRetry = createNamenode(nameNodeAddr, conf, ugi); rpcProxy = createNamenodeWithRetry(createNamenode(nameNodeAddr, conf, ugi));
rpcProxy = createNamenodeWithRetry(rpcProxyWithoutRetry);
}
public Object getProxyWithoutRetry() {
return rpcProxyWithoutRetry;
} }
public void close() { public void close() {
RPC.stopProxy(rpcProxyWithoutRetry); RPC.stopProxy(rpcProxy);
} }
@Override @Override

View File

@ -57,7 +57,6 @@ import org.apache.hadoop.security.UserGroupInformation;
@InterfaceStability.Stable @InterfaceStability.Stable
public class NamenodeProtocolTranslatorR23 implements public class NamenodeProtocolTranslatorR23 implements
NamenodeProtocol, Closeable { NamenodeProtocol, Closeable {
final private NamenodeWireProtocol rpcProxyWithoutRetry;
final private NamenodeWireProtocol rpcProxy; final private NamenodeWireProtocol rpcProxy;
private static NamenodeWireProtocol createNamenode( private static NamenodeWireProtocol createNamenode(
@ -97,16 +96,11 @@ public class NamenodeProtocolTranslatorR23 implements
public NamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr, public NamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr,
Configuration conf, UserGroupInformation ugi) throws IOException { Configuration conf, UserGroupInformation ugi) throws IOException {
rpcProxyWithoutRetry = createNamenode(nameNodeAddr, conf, ugi); rpcProxy = createNamenodeWithRetry(createNamenode(nameNodeAddr, conf, ugi));
rpcProxy = createNamenodeWithRetry(rpcProxyWithoutRetry);
}
public Object getProxyWithoutRetry() {
return rpcProxyWithoutRetry;
} }
public void close() { public void close() {
RPC.stopProxy(rpcProxyWithoutRetry); RPC.stopProxy(rpcProxy);
} }
@Override @Override