Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-14421 TestFastFail* are flakey; ADDENDUM

This commit is contained in:
stack 2015-09-13 10:12:30 -07:00
parent 439ca071ec
commit e4e906f436
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
View File

@ -268,18 +268,20 @@ public class TestFastFail {
assertEquals("The regionservers that returned true should equal to the" assertEquals("The regionservers that returned true should equal to the"
+ " number of successful threads", numThreadsReturnedTrue, + " number of successful threads", numThreadsReturnedTrue,
numSuccessfullThreads.get()); numSuccessfullThreads.get());
assertTrue(
"There should be atleast one thread that retried instead of failing",
MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);
/* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly /* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly
* not but true. St.Ack 20151012 * not but true. St.Ack 20151012
* *
* assertTrue(
"There should be atleast one thread that retried instead of failing",
MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);*/
assertTrue( assertTrue(
"There should be atleast one PreemptiveFastFail exception," "There should be atleast one PreemptiveFastFail exception,"
+ " otherwise, the test makes little sense." + " otherwise, the test makes little sense."
+ "numPreemptiveFastFailExceptions: " + "numPreemptiveFastFailExceptions: "
+ numPreemptiveFastFailExceptions.get(), + numPreemptiveFastFailExceptions.get(),
numPreemptiveFastFailExceptions.get() > 0); numPreemptiveFastFailExceptions.get() > 0);
*/
assertTrue( assertTrue(
"Only few thread should ideally be waiting for the dead " "Only few thread should ideally be waiting for the dead "
+ "regionserver to be coming back. numBlockedWorkers:" + "regionserver to be coming back. numBlockedWorkers:"