18102 Commits

Author SHA1 Message Date
Andrew Purtell
057bc95268 HBASE-26761 TestMobStoreScanner (testGetMassive) can OOME (#4204)
Change the timing of the test but not the objective by storing three large
MOB values into the row with three separate puts, each randomizing the
data. Increases running time of the testGetMassive case 2x but avoids OOME
in the test environment where the OOME was consistently reproductable.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
2022-03-11 15:13:06 +08:00
Andrew Purtell
cc256bd78f HBASE-26824 TestHBaseTestingUtil.testResolvePortConflict failing after HBASE-26582 (#4203)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-11 15:07:01 +08:00
Andrew Purtell
5386325acd HBASE-26582 Prune use of Random and SecureRandom objects (#4118)
Avoid the pattern where a Random object is allocated, used once or twice, and
then left for GC. This pattern triggers warnings from some static analysis tools
because this pattern leads to poor effective randomness. In a few cases we were
legitimately suffering from this issue; in others a change is still good to
reduce noise in analysis results.

Use ThreadLocalRandom where there is no requirement to set the seed to gain
good reuse.

Where useful relax use of SecureRandom to simply Random or ThreadLocalRandom,
which are unlikely to block if the system entropy pool is low, if we don't need
crypographically strong randomness for the use case. The exception to this is
normalization of use of Bytes#random to fill byte arrays with randomness.
Because Bytes#random may be used to generate key material it must be backed by
SecureRandom.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-11 15:06:48 +08:00
Andrew Purtell
e8cca6d111 HBASE-26715 Blocked on SyncFuture in AsyncProtobufLogWriter#write (#4184)
Co-authored-by: Bryan Beaudreault <bbeaudreault@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-10 12:16:03 -08:00
Xiaolin Ha
99912c9783 HBASE-26552 Introduce retry to logroller to avoid abort (#4170)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-10 12:16:03 -08:00
Tak Lon (Stephen) Wu
f39a1057a7 HBASE-26804 Missing opentelemetry agent in hadoop-two-compat.xml (#4185)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-10 11:40:39 -08:00
Bryan Beaudreault
1f9e5a1f7c HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-10 10:10:16 -08:00
Nick Dimiduk
9359449a3a HBASE-26782 Minor code cleanup in and around RpcExecutor
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-10 14:32:47 +01:00
xicm
46ca0dbba6 HBASE-26815 TestFanOutOneBlockAsyncDFSOutput is flakey (#4186)
Trigger BlockReports in MiniDFSCluster after restarting datanode

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-10 16:10:13 +08:00
Bryan Beaudreault
206100f515 HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on (#4194)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 14:44:29 -08:00
Bryan Beaudreault
8251e8d2c9 HBASE-26783 ScannerCallable doubly clears meta cache on retries (#4147)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 12:03:12 -08:00
Bryan Beaudreault
b1a7c6210f HBASE-26784 Addendum: Close scanner request should properly inherit original timeout and priority (#4183)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-08 11:42:14 -08:00
Bryan Beaudreault
6facc82585 HBASE-26784 Use HIGH_QOS for ResultScanner.close requests (#4163)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-08 11:42:12 -08:00
Sean Busbey
5a8df45cd7 HBASE-26760 LICENSE handling should not allow non-aggregated apache-2.0 (#4172)
branch-2* already has correct names for Xerial Snappy wrapper and GSON.

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit bcd9a9acefe0f5ceb3ccf6cc11e6ba9464526426)
2022-03-07 10:55:56 -06:00
Nick Dimiduk
84eb868f98 HBASE-26764 Implement generic exception support for TraceUtil methods over Callables and Runnables
For the `TraceUtil` methods that accept `Callable` and `Runnable` types, make them generic over a
child of `Throwable`. This allows us to consolidate the two method signatures into a single more
flexible definition.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-07 13:57:22 +01:00
Rushabh Shah
9ddc90e258 HBASE-26792 Implement ScanInfo#toString (#4154)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-05 17:49:26 +08:00
Nick Dimiduk
09bd726d46 HBASE-26759 Fix trace continuity through CallRunner (#4126)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-04 16:03:02 -08:00
Andrew Purtell
6c70e4b4c5 [branch-2.5] Amend HBASE-26731 Add metrics for active and expired scanners
Compliation fixes

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 14:11:33 -08:00
Bryan Beaudreault
0f28fa8433 HBASE-26731 Add metrics for active and expired scanners (#4145)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java
2022-03-04 14:07:16 -08:00
Istvan Toth
d4060aeda7 HBASE-26777 BufferedDataBlockEncoder$OffheapDecodedExtendedCell.deepC… (#4139)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 13:53:29 -08:00
Andrew Purtell
492f8f23fd Amend HBASE-26691 Replacing log4j with reload4j for branch-2.x
- Update reload4j version to 1.2.19
- Update shading and assembly configurations

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:25:41 -08:00
Duo Zhang
71ddf74dda HBASE-26691 Replacing log4j with reload4j for branch-2.x (#4050)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:08:36 -08:00
Nick Dimiduk
79a8d7a80b HBASE-26788 Disable Checks API callback from test results in PRs
Signed-off-by: Sean Busbey <busbey@apache.org>
2022-03-03 12:02:45 +01:00
Mike Drob
d971a9d298 HBASE-26622 Update error-prone to 2.10
Author:    Mike Drob <mdrob@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-03 11:52:00 +01:00
Bri Augenreich
b381cb4bcb HBASE-26745: Include balancer cost metrics in jmx endpoint (#4140)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-02 17:39:54 -08:00
Niels Basjes
4858b2543c HBASE-26762 Un-Deprecate and improve documentation for Scan#setRowPrefixFilter (#4119)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-02 23:34:02 +08:00
Nick Dimiduk
ff7f18923a HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2022-03-02 15:52:22 +01:00
Andor Molnár
6aa32f03a8 HBASE-23303 Add default security headers if SSL is enabled (#4128)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2022-03-02 15:43:51 +01:00
Peter Somogyi
cd5b3393b9 HBASE-26772 Shell suspended in background (#4137)
Signed-off-by: Sean Busbey <busbey@apache.org>
2022-03-01 12:01:51 +01:00
Nick Dimiduk
57d547dca0 HBASE-26663 Upgrade Maven Enforcer Plugin
The upgrade is to get the fix in MENFORCER-336, making beanshell evaluation safe for use with `mvn
-T`. Also upgrade extra-enforcer-rules to 1.5.1, as per experience with HBASE-26664.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
2022-02-28 10:24:37 +01:00
Nick Dimiduk
a4036a666f HBASE-26765 Minor refactor of async scanning code (#4121)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-24 19:09:04 +01:00
Bryan Beaudreault
d13cc385bf HBASE-26546 hbase-shaded-client missing required thirdparty classes under hadoop 3.3.1 (#3926)
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit cd45cadbc1a42db359ff4e775cbd4b55cfe28140)
2022-02-22 00:47:15 -06:00
Bryan Beaudreault
5f11bc4e50 HBASE-26703 Allow configuration of IPC queue balancer (#4063)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
2022-02-18 17:55:06 -08:00
Bryan Beaudreault
1fb4ee37be HBASE-26727 Fix CallDroppedException reporting (#4088)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 17:27:59 -08:00
Richard Marscher
2be2072704 HBASE-26576 Allow pluggable queue to be used with the fast path executor or normal balanced executor (#3944)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 10:26:35 -08:00
Yutong Xiao
932bf591b3 HBASE-26659 The ByteBuffer of metadata in RAMQueueEntry in BucketCache could be reused. (#4026)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-19 00:42:04 +08:00
chenglei
af338d2c99
HBASE-26712 Balancer encounters NPE in rare case (#4112) (#4092)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-16 12:15:12 +05:30
Xiaolin Ha
42bb0afaf8 HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate (#4105)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-16 11:23:48 +08:00
Andrew Purtell
a19dcc3be0 HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' (#4094)
Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-15 18:39:03 -08:00
Xiaolin Ha
40882b5681 HBASE-26434 Do compact when all L0 files are expired (#3830)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 22:39:14 +08:00
Yutong Xiao
3803b8be2c HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down (#4073)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 20:31:19 +08:00
Duo Zhang
9282c8e796 HBASE-26749 Migrate HBase main pre commit job to ci-hbase (#4107)
Signed-off-by: Sean Busbey <busbey@apache.org>
2022-02-11 11:44:28 +08:00
Duo Zhang
e77799b2be HBASE-26747 Addendum use python2 directly in Jenkinsfile and Jenkinsfile_Github 2022-02-11 00:21:40 +08:00
Nick Dimiduk
600a6a8faf HBASE-26521 Name RPC spans as $package.$service/$method (#4024)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-10 12:58:01 +01:00
Peter Somogyi
2d25613e34 HBASE-26741 Incorrect exception handling in shell (#4101)
Override eval_input in HIRB to modify exception handling logic.

Signed-off-by: Josh Elser <elserj@apache.org>
2022-02-10 12:24:06 +01:00
Duo Zhang
b64a507340 HBASE-26709 Ban the usage of junit 3 TestCase (#4065)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-02-10 01:06:21 +08:00
Duo Zhang
12002e6a79 HBASE-26724 Backport the UT changes in HBASE-24510 to branch-2.x (#4081)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-02-10 00:53:14 +08:00
Duo Zhang
4e15101fa1 HBASE-26747 Addendum remove python from Jenkinsfile and Jenkinsfile_Github 2022-02-09 21:42:56 +08:00
Duo Zhang
64a7c7b9a0 HBASE-26747 Use python2 instead of python in our python scripts (#4102)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-02-09 16:31:31 +08:00
Duo Zhang
b7b704abc4 HBASE-26697 Migrate HBase Nightly HBase-Flaky-Tests and HBase-Find-Flaky-Tests to ci-hbase (#4053)
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2022-02-09 16:31:23 +08:00