Ashish Singhi
34e9a6ff30
HBASE-15669 HFile size is not considered correctly in a replication request
2016-05-06 17:26:17 +05:30
Ramkrishna
bec81b1977
HBASE-15608 Remove PB references from SnapShot related Exceptions (ram)
2016-05-06 17:06:25 +05:30
Alex Moundalexis
0bf065a5d5
HBASE-15768 fix capitalization of ZooKeeper usage
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-05 15:35:44 -05:00
tedyu
8b0ce77942
HBASE-15292 Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction (Hiroshi Ikeda)
2016-05-05 11:14:32 -07:00
Gary Helmling
d23d600d76
HBASE-15741 Provide backward compatibility for HBase coprocessor service names
2016-05-04 12:09:57 -07:00
Ramkrishna
c06a976a98
HBASE-15607 Remove PB references from Admin for 2.0 (Ram)
2016-05-03 10:51:46 +05:30
Mikhail Antonov
58c4c3d174
HBASE-15703 Deadline scheduler needs to return to the client info about skipped calls, not just drop them
2016-05-02 15:23:07 -07:00
Jurriaan Mous
15631a76f5
HBASE-15744 Port over small format/text improvements from HBASE-13784
...
(Jurriaan Mous)
Signed-off-by: stack <stack@apache.org>
2016-05-01 19:48:43 -07:00
chenheng
ccd8888b4b
Revert "HBASE-15278 AsyncRPCClient hangs if Connection closes before RPC call response"
...
This reverts commit 01c0448ccd
.
2016-04-30 11:37:05 +08:00
chenheng
01c0448ccd
HBASE-15278 AsyncRPCClient hangs if Connection closes before RPC call response
2016-04-30 09:27:32 +08:00
Yu Li
d8e032279f
HBASE-15711 Add client side property to allow logging details for batch errors
2016-04-29 10:14:27 +08:00
tedyu
9343ef438f
HBASE-15676 FuzzyRowFilter fails and matches all the rows in the table if the mask consists of all 0s (Matt Warhaftig)
2016-04-27 21:00:11 -07:00
Gary Helmling
ce318a2906
HBASE-15658 Avoid excess meta cache clearing for RegionServerCallable
2016-04-26 22:54:13 -07:00
Phil Yang
53d7316075
HBASE-15645 hbase.rpc.timeout is not used in operations of HTable
...
Signed-off-by: stack <stack@apache.org>
2016-04-26 10:51:29 -07:00
stack
4bdd47c52c
HBASE-15710 Include issue servers information in RetriesExhaustedWithDetailsException message (Yu Li)
2016-04-26 09:15:02 -07:00
chenheng
03f3c392a3
HBASE-15674 HRegionLocator#getAllRegionLocations should put the results in cache
2016-04-21 14:19:39 +08:00
chenheng
a9f1c4a871
HBASE-15406 Split / merge switch left disabled after early termination of hbck
2016-04-15 14:09:52 +08:00
Vasudevan
a395922ad5
HBASE-15605 Remove PB references from HCD and HTD for 2.0 (Ram)
2016-04-11 14:12:07 +05:30
tedyu
e0f31ba6e6
HBASE-15507 Online modification of enabled ReplicationPeerConfig (Geoffrey Jacoby)
2016-04-08 21:26:31 -07:00
Samir Ahmic
d393603dea
HBASE-15606 Limit creating zk connection in HBaseAdmin#getCompactionState() only to case when 'hbase:meta' is checked.
...
Signed-off-by: stack <stack@apache.org>
2016-04-07 14:25:49 -07:00
Enis Soztutar
7e399883f6
HBASE-15505 ReplicationPeerConfig should be builder-style (Gabor Liptak)
2016-04-05 11:44:05 -07:00
Stephen Yuan Jiang
e1d5c3d269
HBASE-15521 Procedure V2 - RestoreSnapshot and CloneSnapshot (Stephen Yuan Jiang)
2016-03-31 21:49:13 -07:00
chenheng
7f39baf0f4
HBASE-11393 Replication TableCfs should be a PB object rather than a string
2016-03-29 10:25:29 +08:00
Enis Soztutar
0520097611
HBASE-15295 MutateTableAccess.multiMutate() does not get high priority causing a deadlock
2016-03-28 17:56:32 -07:00
Mikhail Antonov
db3ba652f8
HBASE-15524 Fix NPE in client-side metrics
2016-03-23 21:23:54 -07:00
zhangduo
fd5c0934b6
HBASE-15520 Fix broken TestAsyncIPC
2016-03-24 10:46:44 +08:00
Elliott Clark
925c185969
HBASE-15475 Allow TimestampsFilter to provide a seek hint
...
Summary:
Allow TestTimestampFilterSeekHint to provide a seek next hint.
This can be incorrect as it might skip deletes. However it can
make things much much faster.
Test Plan: Added a unit test.
Differential Revision: https://reviews.facebook.net/D55617
2016-03-23 18:56:52 -07:00
Misty Stanley-Jones
b6e1f63074
HBASE-15447 Improve javadocs description for Delete methods <Wellington Chevreuil>
2016-03-22 12:56:30 -07:00
tedyu
dc6cd0bb74
HBASE-15479 No more garbage or beware of autoboxing (Vladimir Rodionov)
2016-03-19 17:22:53 -07:00
tedyu
fbf58f330b
HBASE-15325 ResultScanner allowing partial result will miss the rest of the row if the region is moved between two rpc requests (Phil Yang)
2016-03-17 11:03:29 -07:00
Mikhail Antonov
a2c99b133f
HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta (ADDENDUM)
2016-03-17 01:08:36 -07:00
Elliott Clark
ecec35ae4e
HBASE-15441 Fix WAL splitting when region has moved multiple times
...
Summary:
Currently WAL splitting is broken when a region has been opened multiple times in recent minutes.
Region open and region close write event markers to the wal. These markers should have the sequence id in them. However it is currently getting 1. That means that if a region has moved multiple times in the last few mins then multiple split log workers will try and create the recovered edits file for sequence id 1. One of the workers will fail and on failing they will delete the recovered edits. Causing all split wal attempts to fail.
We need to:
It appears that the close event with a sequence id of one is coming from region warm up.
This patch fixes that by making sure the close on warm up doesn't happen. Also splitting will ignore any of the events that are already in the logs.
Test Plan: Unit tests pass
Differential Revision: https://reviews.facebook.net/D55557
2016-03-16 16:26:09 -07:00
Mikhail Antonov
3adcc750e3
HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta
2016-03-16 16:22:36 -07:00
Enis Soztutar
ca816f0780
HBASE-6721 RegionServer Group based Assignment (Francis Liu)
2016-03-14 18:28:50 -07:00
anoopsjohn
eea8b38dfa
HBASE-15180 Reduce garbage created while reading Cells from Codec Decoder.
2016-03-11 13:58:41 +05:30
anoopsjohn
6628d2df11
HBASE-15322 Operations using Unsafe path broken for platforms not having sun.misc.Unsafe.
2016-03-11 09:37:00 +05:30
tedyu
ad9b91a904
HBASE-15378 Scanner cannot handle heartbeat message with no results (Phil Yang)
2016-03-09 09:28:54 -08:00
Mikhail Antonov
46cc3d4972
HBASE-15137 CallTimeoutException and CallQueueTooBigException should trigger PFFE
2016-03-07 20:54:54 -08:00
tedyu
ed977fd125
HBASE-15243 Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
2016-03-07 16:15:59 -08:00
tedyu
dfc650a953
HBASE-15243 Revert due to compilation error - master branch change makes the patch stale
2016-03-07 15:59:29 -08:00
tedyu
05c1309b3c
HBASE-15243 Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
2016-03-07 15:41:06 -08:00
Jesse Yates
ef712df944
HBASE-14703 HTable.mutateRow does not collect stats (Heng Chen)
2016-03-05 11:01:45 -08:00
tedyu
d083e4f29f
HBASE-15393 Enable table replication command will fail when parent znode is not default in peer cluster (Ashish Singhi)
2016-03-05 06:28:09 -08:00
Ashu Pachauri
27cf0c8c36
HBASE-15354 Same criteria to clear metacache across operations (Ashu Pachauri)
...
Signed-off-by: Mikhail Antonov <antonov@apache.org>
2016-03-04 17:55:35 -08:00
tedyu
664575598e
HBASE-15397 Create bulk load replication znode(hfile-refs) in ZK replication queue by default (Ashish Singhi)
2016-03-04 13:43:25 -08:00
Jonathan M Hsieh
f658f3ef83
HBASE-15356 Remove unused imports (Youngjoon Kim)
2016-03-03 11:42:38 -08:00
chenheng
99955a3240
HBASE-15128 Disable region splits and merges switch in master
2016-02-27 08:36:59 +08:00
chenheng
bf4fcc30c6
Revert "HBASE-15128 Disable region splits and merges switch in master"
...
This reverts commit 24d481c580
.
2016-02-26 08:52:12 +08:00
chenheng
24d481c580
HBASE-15128 Disable region splits and merges switch in master
2016-02-26 08:11:16 +08:00
Josh Elser
a8073c4a98
HBASE-15232 Handle region location cache mgmt in AsyncProcess for multi()'s
...
Further investigation after HBASE-15221 lead to some findings that
AsyncProcess should have been managing the contents of the region
location cache, appropriately clearing it when necessary (e.g. an
RPC to a server fails because the server doesn't host that region)
For multi() RPCs, the tableName argument is null since there is no
single table that the updates are destined to. This inadvertently
caused the existing region location cache updates to fail on 1.x
branches. AsyncProcess needs to handle when tableName is null
and perform the necessary cache evictions.
As such, much of the new retry logic in HTableMultiplexer is
unnecessary and is removed with this commit. Getters which were
added as a part of testing were left since that are mostly
harmless and should contain no negative impact.
Signed-off-by: stack <stack@apache.org>
2016-02-22 22:03:14 -08:00
anoopsjohn
2d66cd86d0
HBASE-15247 InclusiveStopFilter does not respect reverse Filter property. (Amal Joshy)
2016-02-23 09:21:37 +05:30
stack
4b1acead42
HBASE-15285 Forward-port respect for isReturnResult from HBASE-15095
2016-02-17 19:26:17 -08:00
anoopsjohn
12982d1957
HBASE-15198 RPC client not using Codec and CellBlock for puts by default-addendum.
2016-02-12 07:37:45 +05:30
anoopsjohn
29a192ef3c
HBASE-15198 RPC client not using Codec and CellBlock for puts by default.
2016-02-11 09:51:11 +05:30
tedyu
7bb68b9031
HBASE-15231 Make TableState.State private (Misty Stanley-Jones)
2016-02-08 15:21:18 -08:00
Josh Elser
dfd8a31a13
HBASE-15221 Reload the cache on re-tried puts in HTableMultiplexer and adds a close() method to HTableMultiplexer
...
When a Put fails due to a NotServingRegionException, the cached location
of that Region is never cleared. Thus, subsequent calls to resubmit
the Put will fail in the same way as the original, never determining
the new location of the Region.
If the Connection is not closed by the user before the Multiplexer
is discarded, it will leak resources and could cause resource
issues.
Signed-off-by: Sean Busbey <busbey@cloudera.com>
2016-02-08 00:04:28 -06:00
anoopsjohn
7239056c78
HBASE-15214 Valid mutate Ops fail with RPC Codec in use and region moves across.
2016-02-06 02:40:49 +05:30
chenheng
8f20bc748d
HBASE-15197 Expose filtered read requests metric to metrics framework and Web UI (Eungsop Yoo)
2016-02-05 10:57:14 +08:00
Andrew Purtell
b80325fb1b
Amend HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname
...
Fixes for newly introduced FindBugs warnings
2016-02-04 17:33:32 -08:00
Enis Soztutar
a69272efe1
HBASE-15177 Reduce garbage created under high load
2016-02-04 13:27:00 -08:00
stack
d5d26f0804
Fixup on the hbasecon banner image.. add date and location
2016-02-04 11:44:16 -08:00
Andrew Purtell
6256ce4e63
HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname
2016-02-03 10:43:20 -08:00
Enis Soztutar
2f5767376f
HBASE-15129 Set default value for hbase.fs.tmp.dir rather than fully depend on hbase-default.xml (Yu Li)
2016-02-02 17:10:19 -08:00
stack
ed46591f30
HBASE-15196 HBASE-15158 Preamble 2 of 2:Add Increment tests
2016-02-02 11:27:03 -08:00
stack
2cc48e039d
HBASE-15158 HBASE-15158 Preamble 1 of 2: fix findbugs, add javadoc, change Region#getReadpoint to #getReadPoint, and some util
2016-01-31 20:21:48 -08:00
tedyu
1ee07688c8
HBASE-15173 Execute mergeRegions RPC call as the request user
2016-01-28 09:53:24 -08:00
Elliott Clark
138b754671
HBASE-15146 Don't block on Reader threads queueing to a scheduler queue
2016-01-28 07:58:43 -05:00
Devaraj Das
4681827d63
HBASE-14963. Remove Guava dependency from HBase client code
2016-01-22 13:26:54 -08:00
Mikhail Antonov
4bf6f8379d
HBASE-15139 Connection manager doesn't pass client metrics to RpcClient
2016-01-20 14:17:01 -08:00
tedyu
eb17f74b9e
HBASE-15073 Revert due to different opinion on usefulness
2016-01-18 17:51:21 -08:00
stack
76bce77326
HBASE-15115 Fix findbugs complaints in hbase-client
2016-01-15 10:25:49 -08:00
stack
300fe5e6bf
Revert "v1"
...
Bad commit message; revert
This reverts commit c516968b8c
.
2016-01-15 10:24:58 -08:00
stack
c516968b8c
v1
2016-01-15 10:15:05 -08:00
tedyu
4ac8d4ce61
HBASE-14865 Support passing multiple QOPs to SaslClient/Server via hbase.rpc.protection (Appy)
2016-01-14 16:39:52 -08:00
ramkrishna
28c2b18d30
HBASE-15027 Refactor the way the CompactedHFileDischarger threads are
...
created (Ram)
2016-01-08 11:18:39 +05:30
tedyu
d65978fceb
HBASE-15073 Finer grained control over normalization actions for RegionNormalizer
2016-01-06 17:25:41 -08:00
anoopsjohn
a9b671b31f
HBASE-12593 Tags to work with ByteBuffer.
2016-01-06 21:28:06 +05:30
stack
46303dfd75
HBASE-14888 ClusterSchema: Add Namespace Operations
2016-01-05 14:35:27 -08:00
tedyu
00656688f7
HBASE-14987 Compaction marker whose region name doesn't match current region's needs to be handled
2016-01-04 07:10:10 -08:00
stack
a82f7fc94a
Revert "HBASE-14888 ClusterSchema: Add Namespace Operations"
...
This reverts commit c5f3d17ae3
.
2016-01-03 07:15:18 -08:00
stack
c5f3d17ae3
HBASE-14888 ClusterSchema: Add Namespace Operations
2016-01-02 16:16:56 -08:00
Ashish Singhi
413d663f92
HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implementations
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-12-29 20:25:47 -06:00
tedyu
a1a19d9405
HBASE-14717 enable_table_replication command should only create specified table for a peer cluster (Ashish)
2015-12-24 11:07:49 -08:00
anoopsjohn
6fc2596ab3
HBASE-14940 Make our unsafe based ops more safe.
2015-12-24 07:54:13 +05:30
stack
04de427e57
Revert "HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implemenations (Ashish Singhi)"
...
This reverts commit e00a04df10
.
2015-12-23 15:31:10 -08:00
stack
e00a04df10
HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implemenations (Ashish Singhi)
2015-12-23 07:29:18 -08:00
chenheng
f018c371b5
HBASE-14654 Reenable TestMultiParallel#testActiveThreadsCount
2015-12-22 11:33:25 +08:00
Lars Hofhansl
86a417eead
HBASE-14822 Renewing leases of scanners doesn't work.
2015-12-19 09:55:03 -08:00
anoopsjohn
408666a06d
HBASE-13158 When client supports CellBlock, return the result Cells as controller payload for get(Get) API also.
2015-12-18 09:50:53 +05:30
anoopsjohn
cf458d3023
HBASE-14999 Remove ref to org.mortbay.log.Log.
2015-12-17 18:01:16 +05:30
Mikhail Antonov
abe30b52a8
HBASE-14534 Bump yammer/coda/dropwizard metrics dependency version
2015-12-15 12:11:27 -08:00
stack
22b95aebcd
HBASE-14946 Don't allow multi's to over run the max result size.
2015-12-10 21:25:21 -08:00
Enis Soztutar
cff664c5e2
HBASE-14960 Fallback to using default RPCControllerFactory if class cannot be loaded
2015-12-10 19:11:57 -08:00
Elliott Clark
48e217a7db
HBASE-14946 Don't allow multi's to over run the max result size.
...
Summary:
* Add VersionInfoUtil to determine if a client has a specified version or better
* Add an exception type to say that the response should be chunked
* Add on client knowledge of retry exceptions
* Add on metrics for how often this happens
Test Plan: Added a unit test
Differential Revision: https://reviews.facebook.net/D51771
2015-12-10 18:10:32 -08:00
stack
bebcc09fb3
HBASE-14769 Remove unused functions and duplicate javadocs from HBaseAdmin
2015-12-10 15:02:21 -08:00
Nate Edel
9511150bd6
HBASE-14901 Remove duplicate code to create/manage encryption keys
...
Signed-off-by: Gary Helmling <garyh@apache.org>
2015-12-10 14:38:43 -08:00
ramkrishna
26ac60b03f
HBASE-13153 Bulk Loaded HFile Replication (Ashish Singhi)
2015-12-10 13:07:46 +05:30
Gary Helmling
c1e0fcc26d
HBASE-14866 VerifyReplication and ReplicationAdmin should use full peer configuration for peer connection
2015-12-09 15:52:27 -08:00
stack
92e178df28
Revert "HBASE-14769 Removing unused functions from HBaseAdmin. Removing redundant javadocs from HBaseAdmin as they will be automatically inhertited from Admin.java. (Apekshit)"
...
Reverting. The conversation on issues to do with this patch was not done (Appy brought it to my attention).
This reverts commit 6adce67572
.
2015-12-01 11:30:39 -08:00
Apekshit(Appy) Sharma
6adce67572
HBASE-14769 Removing unused functions from HBaseAdmin. Removing redundant javadocs from HBaseAdmin as they will be automatically inhertited from Admin.java. (Apekshit)
...
Signed-off-by: stack <stack@apache.org>
2015-11-30 20:44:11 -08:00
Apekshit
3bac31b2a4
HBASE-14890 Fix broken checkstyle tool. Some javadocs had parsing errors because of wrongly formatted HTML tags. (Apekshit)
...
Signed-off-by: stack <stack@apache.org>
2015-11-28 21:57:52 -08:00
tedyu
2317ec583d
HBASE-14894 Fix misspellings of threshold in log4j.properties files for tests (Youngjoon Kim)
2015-11-28 10:08:38 -08:00
anoopsjohn
daba867734
HBASE-13347 Deprecate FirstKeyValueMatchingQualifiersFilter. (Abhishek)
2015-11-24 09:50:56 +05:30
tedyu
9a91f5ac81
HBASE-14737 Clear cachedMaxVersions when HColumnDescriptor#setValue(VERSIONS, value) is called (Pankaj Kumar)
2015-11-23 20:13:00 -08:00
chenheng
ebe5801e00
HBASE-14782 FuzzyRowFilter skips valid rows (Vladimir Rodionov)
2015-11-19 11:28:18 +08:00
tedyu
d738aade2e
HBASE-14824 HBaseAdmin.mergeRegions should recognize both full region names and encoded region names (Eungsop Yoo)
2015-11-18 14:24:47 -08:00
Elliott Clark
d6fdf92f9e
HBASE-14812 Fix ResultBoundedCompletionService deadlock
2015-11-17 14:41:35 -08:00
Elliott Clark
a591df1073
HBASE-14708 Use copy on write Map for region location cache
...
Summary:
Create and use a copy on write map for region location.
- Create a copy on write map backed by a sorted array.
- Create a test for both comparing each with a jdk provided map.
- Change MetaCache to use the new map.
Test Plan:
- org.apache.hadoop.hbase.client.TestFromClientSide
- TestHCM
Differential Revision: https://reviews.facebook.net/D49545
2015-11-17 10:52:43 -08:00
tedyu
789f8a5a70
HBASE-14498 Revert for on-going review
2015-11-12 12:57:23 -08:00
stack
290ecbe829
HBASE-14355 Scan different TimeRange for each column family (Churro Morales)
2015-11-12 10:54:16 -10:00
tedyu
b677f2e65d
HBASE-14498 Master stuck in infinite loop when all Zookeeper servers are unreachable (Pankaj Kumar)
2015-11-12 07:21:19 -08:00
stack
32de06f663
HBASE-14787 Remove obsolete ConnectionImplementation.refCount (Appy)
2015-11-09 17:08:17 -10:00
chenheng
086bacd12d
HBASE-14693 Add client-side metrics for received pushback signals
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-11-09 18:03:30 -08:00
Apekshit(Appy) Sharma
08963189a2
HBASE-14767 - Remove deprecated functions from HBaseAdmin Deprecated in HBASE-12083 (1.0.0, 2.0.0, 0.99.2) - HBaseAdmin(Configuration)
...
Deprecated in HBASE-10479 (0.99.0, hbase-10070)
- HBaseAdmin(Connection)
Deprecated in HBASE-11826 (0.99.0, 1.0.0, 2.0.0)
- flush()
- compact()
- majorCompact()
- split()
- getCompactionState()
- Changes many declarations from HBaseAdmin to Admin
(Apekshit)
Signed-off-by: stack <stack@apache.org>
2015-11-06 16:23:55 -10:00
tedyu
cfc5348b5e
HBASE-14758 Add UT case for unchecked error/exception thrown in AsyncProcess#sendMultiAction (Yu Li)
2015-11-04 07:20:59 -08:00
stack
ceddec9141
HBASE-14725 Vet categorization of tests so they for sure go into the right small/medium/large buckets
2015-11-03 20:47:20 -08:00
chenheng
6871724104
HBASE-12986 Compaction pressure based client pushback
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-11-03 18:32:08 -08:00
stack
e4bf77e2de
HBASE-14754 TestFastFailWithoutTestUtil failing on trunk now in #testPreemptiveFastFailException50Times
2015-11-03 16:20:55 -08:00
Jesse Yates
1b8b612b8b
HBASE-14715 Add javadocs to DelegatingRetryingCallable
2015-11-02 16:20:55 -08:00
stack
9630fec2d5
Revert "HBASE-14725 Vet categorization of tests so they for sure go into the right small/medium/large buckets"
...
Revert. Seems to have destabilized the build
This reverts commit 6dbb5a8052
.
2015-11-02 08:17:41 -08:00
stack
6dbb5a8052
HBASE-14725 Vet categorization of tests so they for sure go into the right small/medium/large buckets
2015-11-01 22:26:43 -08:00
Jonathan M Hsieh
4c25549e9f
HBASE-14711 Remove or annotate deprecated methods in HRegionInfo
2015-11-01 04:29:51 -08:00
Elliott Clark
ec651bfc7b
HBASE-14687 Un-synchronize BufferedMutator
...
Summary:
Use concurrent collections and atomic longs to keep track of edits in buffered mutator.
This keeps buffered mutator as thread safe but it means that shared buffered mutators are not contending on thread locking.
Test Plan: Unit Tests.
Differential Revision: https://reviews.facebook.net/D49467
2015-10-30 13:27:25 -07:00
Matteo Bertozzi
4b91a6425e
HBASE-14714 some cleanup to snapshot code
2015-10-29 13:48:59 -07:00
Jonathan M Hsieh
094d65e6f5
HBASE-14673 Exorcise deprecated Delete#delete* api
2015-10-29 11:15:34 -07:00
Jonathan M Hsieh
de9555cec4
HBASE-14675 Exorcise deprecated Put#add(...) and replace with Put#addColumn(...)
2015-10-29 11:15:31 -07:00
tedyu
210c3dd937
HBASE-12769 Replication fails to delete all corresponding zk nodes when peer is removed (Jianwei Cui)
2015-10-27 19:40:40 -07:00
Misty Stanley-Jones
e24d03b10c
HBASE-14695 Fix some easy HTML warnings and bad links
2015-10-28 12:12:40 +10:00
Enis Soztutar
0e6dd3257b
HBASE-14425 In Secure Zookeeper cluster superuser will not have sufficient permission if multiple values are configured in hbase.superuser (Pankaj Kumar)
2015-10-27 16:56:20 -07:00
tedyu
f91546f2e6
HBASE-14696 Support setting allowPartialResults in mapreduce Mappers
2015-10-27 07:57:32 -07:00
tedyu
a321da2039
HBASE-14694 Scan copy constructor doesn't handle allowPartialResults
2015-10-27 07:51:04 -07:00
Elliott Clark
caae3b2e5f
HBASE-14683 Fix Batching in buffered mutator is awful when adding lists of mutations.
...
Summary: Send the list of mutations to AsyncProcess only after done adding the list otherwise there's a lot of contention
Test Plan: UnitTests.
Differential Revision: https://reviews.facebook.net/D49251
2015-10-24 10:05:39 -07:00
Ashish Singhi
467bc098a9
HBASE-13538 Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
...
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2015-10-22 13:12:35 -07:00
Matteo Bertozzi
36a196722c
HBASE-14669 remove unused import and fix javadoc
2015-10-22 09:25:26 -07:00
Misty Stanley-Jones
2996355e94
HBASE-14603 Lots of work on the POM to enhance Javadocs, Xrefs
...
* We now have apidocs, devapidocs, testapidocs, and testdevapidocs
* When using reportSets, the Javadoc plugin ignores the plugin configuration,
so I propagated it to the individual reportSet configuration blocks.
* I was able to remove some of the logic that moved / copied things around
in post-site.
* We now have xref and xref-test (these are superfluous but something needs them
so I left them)
* Added source to Javadocs -- you can click a method or property to browse its source.
More user-friendly than xref maybe.
* You can now get the whole site to build by doing 'mvn clean site site:stage' and
it takes about 10 minutes.
2015-10-22 19:12:42 +10:00
Misty Stanley-Jones
74d5232065
Revert "Lots of work on the POM to enhance Javadocs, Xrefs"
...
This reverts commit aa78ebbd5a
.
2015-10-22 19:11:40 +10:00
Misty Stanley-Jones
aa78ebbd5a
Lots of work on the POM to enhance Javadocs, Xrefs
...
* We now have apidocs, devapidocs, testapidocs, and testdevapidocs
* When using reportSets, the Javadoc plugin ignores the plugin configuration,
so I propagated it to the individual reportSet configuration blocks.
* I was able to remove some of the logic that moved / copied things around
in post-site.
* We now have xref and xref-test (these are superfluous but something needs them
so I left them)
* Added source to Javadocs -- you can click a method or property to browse its source.
More user-friendly than xref maybe.
* You can now get the whole site to build by doing 'mvn clean site site:stage' and
it takes about 10 minutes.
2015-10-22 18:29:08 +10:00
tedyu
8e6316a80c
HBASE-14458 AsyncRpcClient#createRpcChannel() should check and remove dead channel before creating new one to same server (Samir Ahmic)
2015-10-18 20:49:31 -07:00
Enis Soztutar
6076ed2a12
HBASE-14474 Addendum closes connection in writeRequest() outside synchronized block
...
This reverts commit 414a7b18b1
.
2015-10-16 11:54:22 -07:00
Nicolas Liochon
e7defd7d9a
HBASE-14521 Unify the semantic of hbase.client.retries.number (Yu Li)
2015-10-15 10:42:40 +02:00
tedyu
8c69b0f751
HBASE-14594 Use new DNS API introduced in HADOOP-12437 (Josh Elser)
2015-10-14 14:17:36 -07:00
stack
940e5404df
HBASE-14598 ByteBufferOutputStream grows its HeapByteBuffer beyond JVM limitations (Ian Friedman)
2015-10-14 13:13:01 -07:00
stack
b9639d1e82
HBASE-14590 Shorten ByteBufferedCell#getXXXPositionInByteBuffer method name (Anoop Sam John)
2015-10-12 12:33:28 -07:00
stack
e37e72c160
Revert "HBASE-14583 Enabled client-side metrics by default"
...
Causes TestShell to hang. Reverting for now till we figure why.
This reverts commit c7efd14726
.
2015-10-10 13:18:48 -07:00
anoopsjohn
4969879df5
HBASE-14366 NPE in case visibility expression is not present in labels table during importtsv run. (Bhupendra)
2015-10-10 12:04:47 +05:30
stack
445dbd8a0e
HBASE-14517 Show regionserver's version in master status page (Liu Shaohui)
2015-10-09 15:06:39 -07:00
Nick Dimiduk
c7efd14726
HBASE-14583 Enabled client-side metrics by default
2015-10-09 10:17:56 -07:00
Nick Dimiduk
7e30436e3f
HBASE-12911 Client-side metrics
2015-10-07 17:01:56 -07:00
Elliott Clark
ceafa09d3c
HBASE-14544 Allow HConnectionImpl to not refresh the dns on errors
2015-10-05 09:35:40 -07:00
Mikhail Antonov
19045a5ea7
HBASE-14367 Add normalization support to shell
2015-10-04 00:29:39 -07:00
smaddineni
44b8809726
HBASE-13770 Programmatic JAAS configuration option for secure zookeeper may be broken
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-10-02 17:50:54 -07:00
Matteo Bertozzi
2e8575bb0f
HBASE-14485 ConnectionImplementation leaks on construction failure
2015-10-01 12:56:37 -07:00
stack
e0929bbc5a
HBASE-14510 Fix coprocessor handling of duplicate classes (Yerui Sun)
2015-09-29 15:01:10 -07:00
chenheng
02699fe967
HBASE-14227 Fold special cased MOB APIs into existing APIs
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-09-25 18:28:13 -07:00
tedyu
414a7b18b1
HBASE-14474 Revert addendum
2015-09-25 15:48:08 -07:00
tedyu
dc2aa7e513
HBASE-14474 Addendum closes connection in writeRequest() outside synchronized block
2015-09-25 15:18:21 -07:00
Enis Soztutar
32f49fa7fc
HBASE-14474 DeadLock in RpcClientImpl.Connection.close()
2015-09-25 11:04:53 -07:00
Andrew Purtell
2239d55871
HBASE-13324 o.a.h.h.Coprocessor should be LimitedPrivate("Coprocessor")
2015-09-24 10:57:32 -07:00
Stephen Yuan Jiang
5b7894f92b
HBASE-14107 Administrative Task: Provide an API to List all procedures (Stephen Yuan Jiang)
2015-09-23 21:48:32 -07:00
tedyu
b6bd811c76
HBASE-14397 Revert pending review comments
2015-09-22 10:00:50 -07:00
tedyu
86cf148894
HBASE-14431 Addendum checks for null connectionInPool (Yu Li)
2015-09-21 07:23:14 -07:00
tedyu
1545e1ed8d
HBASE-14431 AsyncRpcClient#removeConnection() never removes connection from connections pool if server fails (Samir Ahmic)
2015-09-19 07:32:04 -07:00
tedyu
b0f5233265
HBASE-14449 Rewrite deadlock prevention for concurrent connection close
2015-09-18 14:40:39 -07:00
stack
bd26386dc7
HBASE-14433 Set down the client executor core thread count from 256 in tests: REAPPLY AGAIN (WAS MISSING JIRA)
2015-09-16 10:13:55 -07:00
stack
b0aa86a694
Revert "Set down the client executor core thread count from 256 in tests: REAPPLY"
...
Missing JIRA number.
This reverts commit b00f3d3703
.
2015-09-16 10:12:39 -07:00
stack
b00f3d3703
Set down the client executor core thread count from 256 in tests: REAPPLY
2015-09-16 08:57:06 -07:00
stack
8633b26ee5
Revert "HBASE-14433 Set down the client executor core thread count from 256 to number of processors"
...
This reverts commit d2e3381818
.
2015-09-16 08:53:34 -07:00
stack
d2e3381818
HBASE-14433 Set down the client executor core thread count from 256 to number of processors
2015-09-15 22:36:05 -07:00
Apekshit(Appy) Sharma
fe2c4f630d
HBASE-14400 Fix HBase RPC protection documentation
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-09-15 17:43:48 -07:00
Samir Ahmic
f51c79076d
HBASE-13337 Table regions are not assigning back, after restarting all regionservers at once.
...
Signed-off-by: stack <stack@apache.org>
2015-09-15 06:36:57 -07:00
stack
ceff3e242b
HBASE-14421 TestFastFail* are flakey; ADDENDUM 2 DISABLE testInterceptorIntercept50Times
2015-09-13 10:33:44 -07:00
stack
a9157379a3
HBASE-14421 TestFastFail* are flakey
2015-09-12 22:34:04 -07:00
tedyu
36675c81fb
HBASE-14397 PrefixFilter doesn't filter all remaining rows if the prefix is longer than rowkey being compared (Jianwei Cui)
2015-09-11 16:04:31 -07:00
Srikanth Srungarapu
1a19b0ee17
HBASE-14385 Close the sockets that is missing in connection closure.
2015-09-09 23:31:37 -07:00
Nick Dimiduk
a11bb2a933
HBASE-14382 TestInterfaceAudienceAnnotations should hadoop-compt module resources
2015-09-09 11:08:28 -07:00
stack
a11f5c55b4
HBASE-14308 HTableDescriptor WARN is not actionable (Lars Francke)
2015-09-04 22:44:21 -07:00
Andrew Purtell
2481b7f76f
HBASE-14359 HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction (Victor Xu)
2015-09-03 17:48:45 -07:00
Stephen Yuan Jiang
3341f13e71
HBASE-14108 Procedure V2 Administrative Task: provide an API to abort a procedure (Stephen Yuan Jiang)
2015-09-02 19:18:46 -07:00
tedyu
df341c4299
HBASE-14309 Allow load balancer to operate when there is region in transition by adding force flag
2015-08-29 13:15:53 -07:00
Elliott Clark
cc1542828d
HBASE-14313 After a Connection sees ConnectionClosingException it never recovers -- ADDENDUM
2015-08-27 15:23:43 -07:00
Elliott Clark
56890d9fe1
HBASE-14313 After a Connection sees ConnectionClosingException on a connection it never recovers
2015-08-26 13:44:12 -07:00
tedyu
6661f2d025
HBASE-14269 FuzzyRowFilter omits certain rows when multiple fuzzy keys exist (hongbin ma)
2015-08-26 07:23:43 -07:00
stack
3dacee674c
HBASE-14290 Spin up less threads in tests
2015-08-25 16:16:03 -07:00
stack
d0873f5a8c
HBASE-14224 Fix coprocessor handling of duplicate classes
2015-08-24 13:47:19 -07:00
stack
b85857cf3c
HBASE-13480 ShortCircuitConnection doesn't short-circuit all calls as expected (Jingcheng Du and Josh Elser)
2015-08-24 12:29:46 -07:00
tedyu
16f8d27708
HBASE-14241 Fix deadlock during cluster shutdown due to concurrent connection close
2015-08-19 08:49:38 -07:00
Enis Soztutar
395ec5a9bb
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
2015-08-17 16:05:26 -07:00
Enis Soztutar
2ed7f9bb1d
HBASE-14122 Client API for determining if server side supports cell level security - ADDENDUM for javadoc fix
2015-08-17 14:04:28 -07:00
Andrew Purtell
5e5bcceb53
HBASE-14122 Client API for determining if server side supports cell level security
2015-08-12 13:26:55 -07:00
Elliott Clark
38b94709ee
HBASE-14208 Remove yarn dependencies on -common and -client
2015-08-11 13:00:13 -07:00
tedyu
a2dbe31b26
HBASE-14206 MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges (Anton Nazaruk)
2015-08-11 09:40:13 -07:00
Nick Dimiduk
e4106b4c4a
Revert "HBASE-12911 Client-side metrics"
...
This reverts commit 06989fd1f9
.
2015-08-10 17:13:09 -07:00
Nick Dimiduk
06989fd1f9
HBASE-12911 Client-side metrics
...
First pass. Plumbs up metrics for each connection instance. Exposes
static information about those connections (zk quorum and root node,
cluster id, user). Exposes basic thread pool utilization gauges for
"meta lookup" and "batch" pools.
2015-08-10 16:48:48 -07:00
Andrew Purtell
ea8833fd63
HBASE-12865 WALs may be deleted before they are replicated to peers (He Liangliang)
2015-08-07 15:08:30 -07:00
Andrew Purtell
f06daaf010
HBASE-13825 Use ProtobufUtil#mergeFrom and ProtobufUtil#mergeDelimitedFrom in place of builder methods of same name
2015-08-06 21:48:09 -07:00
Sean Busbey
1b0b67fb7c
HBASE-14085 Update LICENSE and NOTICE files.
...
* corrects license/notice for source distribution
* adds inception year to correct copyright in generated NOTICE files for jars
* updates project names in poms to use "Apache HBase" instead of "HBase" so jar NOTICE files will be correct
* uses append-resources to include supplemental info on jars with 3rd party works in source
* adds an hbase specific resource bundle for jars that include 3rd party works for binaries
** uses supplemental-model to fill in license gaps
** uses the above and a shade plugin transformation to build proper files for shaded jars.
** uses the above and the assembly plugin to build the proper files for bin assembly
* adds a NOTICE item for things copied out of Hadoop (TODO legal-discuss)
2015-08-04 17:16:56 -05:00
tedyu
598cfeb775
HBASE-13965 Stochastic Load Balancer JMX Metrics (Lei Chen)
2015-08-03 12:46:01 -07:00
tedyu
4b6598e394
HBASE-13864 HColumnDescriptor should parse the output from master and from describe for TTL (Ashu Pachauri)
2015-08-01 02:15:02 -07:00
Ashish Singhi
f504e4b4ed
HBASE-14154 DFS Replication should be configurable at column family level
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-07-31 19:15:48 -07:00
Sean Busbey
4ce6f486d0
HBASE-14087 Ensure correct ASF headers for docs/code
...
* adds missing headers
* corrects some old-form headers to current
* restores proper header for guava copied LimitInputStream
* adds proper header for protobuf copied read/writeRawVarint
2015-07-29 14:25:43 -05:00
Srikanth Srungarapu
05de2ec580
HBASE-14097 Log link to client scan troubleshooting section when scanner exceptions happen.
2015-07-28 15:14:27 -07:00
Srikanth Srungarapu
1d4c2452e7
HBASE-14057 HBase shell user_permission should list super users defined on hbase-site.xml
2015-07-28 11:33:52 -07:00
ramkrishna
6b9b7cb8c7
HBASE-14152 Fix the warnings in Checkstyle and FindBugs brought in by merging hbase-11339 (Jingcheng Du)
...
Signed-off-by: Sean Busbey <busbey@cloudera.com>
2015-07-28 10:14:29 -05:00
Sean Busbey
e36af70835
Revert "Fix the warnings in Checkstyle and FindBugs brought in by merging"
...
This reverts commit 89d0409462
.
2015-07-28 10:13:57 -05:00
ramkrishna
89d0409462
Fix the warnings in Checkstyle and FindBugs brought in by merging
...
hbase-11339 (Jingcheng Du)
2015-07-28 11:41:41 +05:30
anoopsjohn
4f60d9c28d
HBASE-14151 Remove the unnecessary file ProtobufUtil.java.rej which is brought in by merging hbase-11339. (Jingcheng)
2015-07-23 11:43:23 +05:30
Jonathan M Hsieh
493f36c899
HBASE-11339 Merge remote-tracking branch 'apache/hbase-11339' (Jingcheng Du)
2015-07-22 12:51:11 -07:00
anoopsjohn
3b6db26863
HBASE-13954 Remove HTableInterface#getRowOrBefore related server side code. (Ashish)
2015-07-21 09:08:26 +05:30
anoopsjohn
ebdac4b52e
HBASE-12296 Filters should work with ByteBufferedCell.
2015-07-16 09:36:05 +05:30
Andrew Purtell
6c6c7c51f6
HBASE-14089 Remove unnecessary draw of system entropy from RecoverableZooKeeper
2015-07-15 18:41:34 -07:00
Ashish Singhi
e6bd0c8c15
HBASE-8642 [Snapshot] List and delete snapshot by table
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-07-15 15:56:07 -07:00
terence.yoo
a63e3ac83f
HBASE-14041 Do not clear MetaCache if a ThrottlingException is thrown
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-07-15 02:53:21 -05:00
ramkrishna
a3d30892b4
HBASE-14047 - Cleanup deprecated APIs from Cell class (Ashish Singhi)
2015-07-13 22:06:16 +05:30
Matteo Bertozzi
951ec7a0b7
HBASE-13415 Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-07-13 11:02:30 -05:00
Sean Busbey
60d6435ad8
Revert "Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)"
...
This reverts commit 87ee37ceb8
.
2015-07-13 11:01:45 -05:00
Enis Soztutar
5e708746b8
HBASE-13997 ScannerCallableWithReplicas cause Infinitely blocking (Zephyr Guo and Enis)
2015-07-10 16:06:29 -07:00
stack
66082c7224
HBASE-14052 Mark a few methods in CellUtil audience private since only make sense internally to hbase
2015-07-10 10:44:38 -07:00
Matteo Bertozzi
87ee37ceb8
Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)
2015-07-09 07:44:36 -07:00
anoopsjohn
d07ff5ec5a
HBASE-13387 Add ByteBufferedCell an extension to Cell.
2015-07-09 15:35:24 +05:30
Ashish Singhi
5b75faefcc
HBASE-13925 Use zookeeper multi to clear znodes in ZKProcedureUtil
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-07-03 12:24:47 -07:00
anoopsjohn
62f5694491
HBASE-13998 Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength).
2015-07-02 11:58:25 +05:30
stack
20e855f282
HBASE-13895 DATALOSS: Region assigned before WAL replay when abort (Enis Soztutar) -- REAPPLY
2015-07-01 23:16:30 -07:00
stack
f0e29c49a1
Revert "HBASE-13895 DATALOSS: Region assigned before WAL replay when abort (Enis"
...
This reverts commit fca725a899
.
2015-07-01 20:20:08 -07:00
stack
fca725a899
HBASE-13895 DATALOSS: Region assigned before WAL replay when abort (Enis
...
Soztutar)
2015-07-01 20:07:26 -07:00
stack
460d76f623
HBASE-13983 Doc how the oddball HTable methods getStartKey, getEndKey, etc. will be removed in 2.0.0
2015-07-01 13:04:19 -07:00
anoopsjohn
7b92d8c06a
HBASE-13968 Remove deprecated methods from BufferedMutator class.(Ashish Singhi)
2015-06-29 11:00:54 +05:30
Ashish Singhi
3efde85614
HBASE-13214 Remove deprecated and unused methods from HTable class
2015-06-26 15:39:53 -07:00
Gábor Lipták
5826bf2a7c
HBASE-13963 Do not leak jdk.tools dependency from hbase-annotations
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-26 08:48:02 -05:00
stack
b5b5853043
HBASE-13893 Replace HTable with Table in client tests (Jurriaan Mous)
2015-06-25 14:42:33 -07:00
Nick Dimiduk
3e72dc9f08
HBASE-13938 Deletes done during the region merge transaction may get eclipsed (ddas, enis, ndimiduk)
2015-06-23 10:23:38 -07:00
Gábor Lipták
6a537eb854
HBASE-13900 Use ProtobufMagic methods in ProtobufUtil
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-23 00:32:23 -05:00
Sean Busbey
abc2e61eb1
Revert "Use ProtobufMagic methods in ProtobufUtil"
...
This reverts commit 6b37f26280
.
2015-06-23 00:30:25 -05:00
Sean Busbey
93640bb798
Revert "HBASE-13898 Move 'converter' functions from ProtobufUtil into a helper class"
...
This reverts commit 1d7c68c086
.
2015-06-23 00:04:27 -05:00
Mikhail Antonov
fd37ccb63c
HBASE-13103 [ergonomics] add region size balancing as a feature of master
2015-06-22 15:52:07 -07:00
Gábor Lipták
d51a184051
HBASE-13843 Correct typo in ReplicationAdmin
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-22 08:54:01 -05:00
Gábor Lipták
1d7c68c086
HBASE-13898 Move 'converter' functions from ProtobufUtil into a helper class
...
Signed-off-by: Misty Stanley-Jones <mstanleyjones@cloudera.com>
2015-06-22 12:11:51 +10:00
Misty Stanley-Jones
43c0647c62
Revert "Move 'converter' functions from ProtobufUtil into a helper class"
...
Bad commit message
This reverts commit 2b9afcad3eca725ff322cd9e70cde1d9522d8e21.
2015-06-22 12:10:12 +10:00
Gábor Lipták
80b2b85ab2
Move 'converter' functions from ProtobufUtil into a helper class
...
Signed-off-by: Misty Stanley-Jones <mstanleyjones@cloudera.com>
2015-06-22 12:05:11 +10:00
anoopsjohn
04c25e0f35
HBASE-13931 Move Unsafe based operations to UnsafeAccess.
2015-06-20 20:52:06 +05:30
Gábor Lipták
6b37f26280
Use ProtobufMagic methods in ProtobufUtil
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-19 13:50:09 -07:00
Misty Stanley-Jones
b16293b5e2
HBASE-13898 correct additional javadoc failures under java 8 <Gabor Liptak>
2015-06-16 14:18:09 +10:00
Misty Stanley-Jones
5e6373e8ec
Revert "Correct Javadoc generation errors"
...
This reverts commit 0a227b79d6
.
2015-06-16 14:18:09 +10:00
Gábor Lipták
0a227b79d6
Correct Javadoc generation errors
2015-06-16 13:27:45 +10:00
Ashish Singhi
d28f299807
HBASE-13901 Error while calling watcher on creating and deleting an HBase table
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-15 11:27:59 -07:00
Gábor Lipták
682b8ab8a5
HBASE-13569 Correct Javadoc (for Java8)
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-13 01:10:37 -05:00
Josh Elser
8cef99e506
HBASE-13892 NPE in ClientScanner on null results array
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
2015-06-11 19:03:59 -07:00
tedyu
4713fc6407
HBASE-13875 Clock skew between master and region server may render restored region without server address
2015-06-09 18:52:49 -07:00
tedyu
6cc42c8cd1
HBASE-13829 Add more ThrottleType (Guanghao Zhang)
2015-06-09 06:42:55 -07:00
Enis Soztutar
587b0b4f20
HBASE-13851 RpcClientImpl.close() can hang with cancelled replica RPCs
2015-06-06 14:01:33 -07:00
Changgeng Li
dcc711fff2
HBASE-13638 Put copy constructor is shallow
...
Deep copy the cell list
Signed-off-by: Elliott Clark <eclark@apache.org>
2015-06-01 13:55:29 -07:00