Commit Graph

8869 Commits

Author SHA1 Message Date
litao 31f4b422ab HBASE-27032 The draining region servers metric description is incorrect (#4428)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit ed1665355a)
2022-05-17 10:38:15 +05:30
Rushabh Shah 7bc7eb5f48 HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists (#4422)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-13 18:25:19 -07:00
Tak Lon (Stephen) Wu 43e8c11989 HBASE-27013 Introduce read all bytes when using pread for prefetch (#4414)
- introduce optional flag `hfile.pread.all.bytes.enabled` for pread that must read full bytes with the next block header

Signed-off-by: Josh Elser <elserj@apache.org>
2022-05-13 13:14:17 -07:00
Duo Zhang 62dbae2914 HBASE-26999 Addendum fix spotless errors 2022-05-13 09:57:26 +08:00
Wellington Chevreuil 930bc5368c HBASE-27021 StoreFileInfo should set its initialPath in a consistent way
(Amending spotless errors after revert by Duo)
2022-05-12 10:53:19 +01:00
Duo Zhang e3359efe7a Revert "HBASE-27021 StoreFileInfo should set its initialPath in a consistent way (#4419)"
Revert due to failure spotless:check

This reverts commit aa31b0f695.
2022-05-12 10:53:10 +01:00
Wellington Ramos Chevreuil b7647d8d5f HBASE-27021 StoreFileInfo should set its initialPath in a consistent way (#4419)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-12 10:52:47 +01:00
Wellington Ramos Chevreuil 7b7f57619b HBASE-26999 HStore should try write WAL compaction marker before repl… (#4407)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-09 11:00:26 +01:00
skysiders ad2180b75d
HBASE-26994 MasterFileSystem create directory without permission check (#4391)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-08 13:28:40 -07:00
Rushabh Shah f5a08063b6
HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. (#4413)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-07 10:38:17 -07:00
litao 91eab0b657
HBASE-27000 Block cache stats (Misses Caching) display error in RS web UI (#4406)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-05 23:35:09 -07:00
LiangJun He cb61d6a4bd HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false (#4397)
Signed-off-by: Yu Li <liyu@apache.org>
2022-05-05 21:55:50 +08:00
Nick Dimiduk 1b5c881ffb HBASE-26648 Improve fidelity of RegionLocator spans (addendum)
Addendum extends the test case to cover both `RpcConnectionRegistry` and `ZKConnectionRegistry`.
2022-05-03 13:40:42 +02:00
Nick Dimiduk a38716ca2a HBASE-26648 Improve fidelity of RegionLocator spans
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-03 13:40:42 +02:00
d-c-manning be8a9a5920 HBASE-26989 TestStochasticLoadBalancer fixes for performance and consistency (#4385)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Reviewed by: Rushabh Shah <shahrs87@gmail.com>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
2022-05-02 10:51:37 -07:00
Duo Zhang 1a5b1b266c HBASE-26899 Run spotless:apply 2022-05-01 22:41:49 +08:00
d-c-manning afb8afd26c HBASE-26988 dynamic configuration of loadbalance.bytable (#4384)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
2022-04-29 15:55:16 -07:00
LiangJun He e9c9418d1d HBASE-26943 HMaster page style display confusion (#4369)
Signed-off-by: Yu Li <liyu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-29 15:59:53 +08:00
d-c-manning fd2e7205ac HBASE-22349 slop in StochasticLoadBalancer (#4371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
2022-04-28 12:38:50 -07:00
liangxs 895e0f474a HBASE-26975 Add on heap and off heap memstore info in rs web UI (#4368)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit cdf81ea5cc)
2022-04-28 23:15:10 +08:00
liangxs ea5c5da1b3 HBASE-26980 Update javadoc of BucketCache.java (#4374)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c02e7553d4)
2022-04-28 23:11:51 +08:00
Andrew Purtell 6813a5c502 HBASE-26979 StoreFileListFile logs frequent stacktraces at INFO level (#4373)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-04-27 18:02:18 -07:00
Bri Augenreich c2baa1fb7b HBASE-26581 Add metrics for failed replication edits (#4347)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-26 17:44:01 -04:00
Wellington Ramos Chevreuil c9d833ed5e HBASE-26971 SnapshotInfo --snapshot param is marked as required even when trying to list all snapshots (#4366)
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit af13c6d4c6)
2022-04-25 14:18:57 +01:00
Ruanhui 8d17241ce0
HBASE-26942 cache region locations when getAllRegionLocations (#4364)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-22 15:30:26 -04:00
Bryan Beaudreault 2240025349
HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException (#4273)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-22 08:56:52 -04:00
Duo Zhang 085c65107e HBASE-26941 LocalHBaseCluster.waitOnRegionServer should not call join while interrupted (#4352)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 35aa57e445)
2022-04-17 23:26:56 +08:00
Duo Zhang ae8eccd5c0 HBASE-26938 Compaction failures after StoreFileTracker integration (#4350)
Introduce a StoreFileWriterCreationTracker to track the store files being written

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 48c4a4626e)
2022-04-17 22:44:44 +08:00
Duo Zhang bbe048c1e5 HBASE-26946 TestRetainAssignmentOnRestartSplitWithoutZk infinite loop (#4344)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 2622fa05a6)
2022-04-16 13:23:57 +08:00
Pankaj c76daa1cc8 HBASE-26944 Possible resource leak while creating new region scanner (#4339)
* HBASE-26944 Possible resource leak while creating new region scanner

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 62e3efccef)
2022-04-15 11:37:58 +05:30
Duo Zhang b405a6f119 Revert "HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while thread is interrupted (#4333)"
This reverts commit f8b2ac0518.
2022-04-13 11:53:19 +08:00
Duo Zhang f8b2ac0518 HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while thread is interrupted (#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c722)
2022-04-13 11:10:25 +08:00
eomiks 52ca440ad6 HBASE-26901 delete with null columnQualifier occurs NullPointerException when NewVersionBehavior is on (#4295)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7ac9e0be27)
2022-04-12 20:31:48 +08:00
huaxiangsun f9abe3d8f1
HBASE-26618 Involving primary meta region in meta scan with CatalogRe… (#4321) (#4326)
Signed-off-by: Michael Stack <stack@apache.org>
2022-04-11 10:27:15 -07:00
Duo Zhang e7eb628025 HBASE-26922 Fix LineLength warnings as much as possible if it can not be fixed by spotless (#4324)
Signed-off-by: Yulin Niu <niuyulin@apache.org
(cherry picked from commit 3ae0d9012c)
2022-04-09 23:13:49 +08:00
Duo Zhang 197b8d48ec HBASE-26928 Fix several indentation problems (#4323)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit e68c61dd54)
2022-04-06 15:14:03 +08:00
Tak Lon (Stephen) Wu 87555093cf
HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f… (#4278)
- Include HBASE-25288 that has the configuration manager registration in HMaster

Signed-off-by: Ankit Singhal <ankit@apache.org>
2022-04-05 10:06:13 -07:00
Wellington Ramos Chevreuil 1c14046ee0 HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… (#4322)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>

(cherry picked from commit ae3718be0f)
2022-04-05 17:52:30 +01:00
bsglz 8ef1ae32e6 HBASE-26885 Addendum throw exception instead of return in TRSP to let the procedure retry (#4299)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7f9d1f2259)
2022-04-04 20:26:48 +08:00
weimingdiit 3b383806be HBASE-26924 Fix log parameter error and spelling error (#4318)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
(cherry picked from commit 003c572246)
2022-04-04 20:26:41 +08:00
Duo Zhang ab9ccabe8f HBASE-26921 Rewrite the counting cells part in TestMultiVersions (#4316)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 3e09e87fad)
2022-04-03 23:04:51 +08:00
Duo Zhang 1560b4149c HBASE-26920 Fix missing braces warnings in TestProcedureMember (#4315)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 78676bb85e)
2022-04-03 23:04:43 +08:00
Duo Zhang 0b87621a38 HBASE-26919 Rewrite the counting rows part in TestFromClientSide4 (#4314)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 4e12eee531)
2022-04-03 23:04:36 +08:00
chenglei 4311974758
HBASE-26811 Secondary replica may be disabled for read incorrectly forever (#4308) 2022-04-01 11:20:48 +08:00
Nick Dimiduk 489af42792
HBASE-26545 Implement tracing of scan
* on `AsyncTable`, both `scan` and `scanAll` methods should result in `SCAN` table operations.
* the span of the `SCAN` table operation should have children representing all the RPC calls
  involved in servicing the scan.
* when a user provides custom implementation of `AdvancedScanResultConsumer`, any spans emitted
  from the callback methods should also be tied to the span that represents the `SCAN` table
  operation. This is easily done because these callbacks are executed on the RPC thread.
* when a user provides a custom implementation of `ScanResultConsumer`, any spans emitted from the
  callback methods should be also be tied to the span that represents the `SCAN` table
  operation. This accomplished by carefully passing the span instance around after it is created.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-31 17:29:51 +02:00
Duo Zhang 98db15acd2 HBASE-26245 Store region server list in master local region (#4136)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit bb1bbddf74)
(cherry picked from commit 27111421d9)
2022-03-31 22:26:40 +08:00
chenglei 1a85588265
HBASE-26812 ShortCircuitingClusterConnection fails to close RegionSca… (#4243) 2022-03-31 20:04:01 +08:00
bsglz af5624bb8e HBASE-26885 The TRSP should not go on when it get a bogus server name… (#4276)
* HBASE-26885 The TRSP should not go on when it get a bogus server name from AM

(cherry picked from commit 1efd8fe53c)
2022-03-29 10:18:15 +08:00
d-c-manning 0dbcf8f263 HBASE-26718 HFileArchiver can remove referenced StoreFiles from the archive (#4274)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-28 11:47:11 -07:00
Xiaolin Ha 170570b799 HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)
Signed-off-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-03-28 23:38:30 +08:00
haxiaolin 762390045b Revert "HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)"
This reverts commit 7ae6be7c25.
2022-03-28 18:16:38 +08:00
Duo Zhang fd621a7c1b HBASE-26832 Avoid repeated releasing of flushed wal entries in AsyncFSWAL#syncCompleted (#4281)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 4f491fd5e4)
2022-03-28 07:59:58 +08:00
Xiaolin Ha 7ae6be7c25 HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)
Signed-off-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-03-27 11:13:55 +08:00
huaxiangsun 9ecd4e7c56 HBASE-26864 SplitTableRegionProcedure calls openParentRegions() at a … (#4261)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-26 12:04:44 -07:00
Wellington Ramos Chevreuil 66508074cc
HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-25 10:04:13 +00:00
Xiaolin Ha b7cfc1d0bd HBASE-26175 MetricsHBaseServer should record all kinds of Exceptions (#4248)
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
2022-03-24 19:04:59 +08:00
Bryan Beaudreault 1caa28869b
HBASE-21065 Try ROW_INDEX_V1 encoding on meta table (#4268)
Set encoding and blooms on meta as default. Also shutdown access to the
initial meta schema creating method; get from TableDescriptors if you
need access to schema or edit it as you would any other table if you
want to edit it.

Co-authored-by: Michael Stack <stack@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-23 16:30:08 -07:00
chenglei 5affa20359
HBASE-26869 RSRpcServices.scan should deep clone cells when RpcCallContext is null (#4264) 2022-03-23 18:31:47 +08:00
chenglei c55c289e99
Revert "HBASE-26869 RSRpcServices.scan should deep clone cells when RpcCallContext is null (#4262)" (#4263)
This reverts commit d889746bc6.
2022-03-23 17:52:11 +08:00
chenglei d889746bc6
HBASE-26869 RSRpcServices.scan should deep clone cells when RpcCallContext is null (#4262) 2022-03-23 17:48:20 +08:00
Duo Zhang 68f3fbe035 HBASE-26791 Memstore flush fencing issue for SFT (#4202)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit e56ed404cb)
2022-03-22 12:35:09 +08:00
Nick Dimiduk 0d968af513 HBASE-26531 Trace coprocessor exec endpoints
Trace table ExecService invocations as table operations. Ensure span relationships for both table
and master invocations.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-21 19:29:37 +01:00
Nick Dimiduk 321c35a6ef
HBASE-26834 Adapt ConnectionRule for both sync and async connections
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-21 12:42:18 +01:00
Duo Zhang 7af08ce614 HBASE-26861 Fix flaky TestSnapshotFromMaster.testSnapshotHFileArchiving (#4242)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 520ad638d9)
2022-03-19 00:46:31 +08:00
Duo Zhang ac5651c1b2 HBASE-26858 Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop (#4238)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 31db8e3b3b)
2022-03-19 00:46:03 +08:00
huiruan 4a6ba116bf HBASE-26842 TestSnapshotProcedure fails in branch-2 (#4225)
Closes #4225

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-18 16:21:29 +08:00
Duo Zhang 81398f9064 HBASE-26833 Addendum fix NPE in TestReplicationSource.testTerminateClearsBuffer
(cherry picked from commit bd65ad42a2)
2022-03-17 23:23:10 +08:00
Xiaolin Ha db5e954068 HBASE-26680 Close and do not write trailer for the broken WAL writer (#4174)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-16 20:29:27 +08:00
Duo Zhang d3629bbf16 HBASE-26837 Set SFT config when creating TableDescriptor in TestCloneSnapshotProcedure (#4226)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 5b28d76652)
2022-03-16 20:16:26 +08:00
Nick Dimiduk 3c968a1bb8 HBASE-25896 Implement a Region Visualization on Master WebUI (#4228)
This is a demonstration of visualization of regions on the cluster. The visualization is a stacked
bar chart showing total storefile size per table per region server, with the x-axis being server
names, the y-axis being storfile size, and the bars stacked per table. The visualization is
generated entirely on the fly from within the browser, implemented using Vega Lite. So far, Vega
appears to handle rendering this visualization for a cluster of over 700 region servers with
approximately 300,000 regions.

Per [0], include an update to the top-level LICENSE.txt. Also update LICENSE files in all binary
distributions (i.e., jars), by way of LICENSE.vm. Vega uses a BSD 3-clause variant without
advertising clause, and as such is a "Category A" license, per [1].

No changes are made to the NOTICE files, as per the existing example of bundling the minified
JQuery, which is also a Category A license.

[0]: https://infra.apache.org/licensing-howto.html
[1]: https://www.apache.org/legal/resolved.html#category-a

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-15 21:10:23 +01:00
Xiaolin Ha c1bf2ffcd9 HBASE-26833 Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS (#4218)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-15 22:12:02 +08:00
Xiaolin Ha 46af73b5c0 HBASE-26840 Fix NPE in the retry of logroller (#4224)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-15 22:08:41 +08:00
Duo Zhang a4b192e33d HBASE-26611 Changing SFT implementation on disabled table is dangerous (#4082)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-15 20:26:24 +08:00
Duo Zhang 350db514c7 HBASE-26835 Rewrite TestLruAdaptiveBlockCache to make it more stable (#4219)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 5ad51e8b2b)
2022-03-15 20:19:32 +08:00
Nick Dimiduk e6879b8fd7 HBASE-25895 Implement a Cluster Metrics JSON endpoint (addendum) 2022-03-14 17:26:20 +01:00
Nick Dimiduk cdabd6a1ad HBASE-25895 Implement a Cluster Metrics JSON endpoint
Publishes a set of JSON endpoints following a RESTful structure, which expose a subset of the
`o.a.h.h.ClusterMetrics` object tree. The URI structure is as follows

    /api/v1/admin/cluster_metrics
    /api/v1/admin/cluster_metrics/live_servers
    /api/v1/admin/cluster_metrics/dead_servers

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-14 17:26:20 +01:00
meiyi 50e12309ea HBASE-26670 HFileLinkCleaner should be added even if snapshot is disabled (#4032)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-14 12:25:03 +08:00
Duo Zhang 05627b78ec HBASE-26830 Rewrite TestLruBlockCache to make it more stable (#4212)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit c3d0cc7040)
2022-03-14 11:24:31 +08:00
Ruanhui 0f93663db5 HBASE-26323 Introduce a Snapshot Procedure (#4115)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-12 23:58:56 +08:00
Duo Zhang 9e1de13d03 HBASE-25465 Use javac --release option for supporting cross version compilation (#4164)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-12 18:30:29 +08:00
Duo Zhang 340cc6c6f1
HBASE-26802 Backport the log4j2 changes to branch-2 (#4166)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-11 11:17:43 -08:00
Nick Dimiduk a227d76009 HBASE-26819 Minor code cleanup in and around RpcScheduler
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-11 11:15:59 +01:00
Nick Dimiduk 51fd863daa HBASE-26817 Mark RpcExecutor as IA.LimitedPrivate COPROC and PHOENIX
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-11 11:08:14 +01:00
Andrew Purtell e46fbedf56 HBASE-26761 TestMobStoreScanner (testGetMassive) can OOME (#4204)
Change the timing of the test but not the objective by storing three large
MOB values into the row with three separate puts, each randomizing the
data. Increases running time of the testGetMassive case 2x but avoids OOME
in the test environment where the OOME was consistently reproductable.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
2022-03-11 15:12:51 +08:00
Andrew Purtell 0b879f2054 HBASE-26824 TestHBaseTestingUtil.testResolvePortConflict failing after HBASE-26582 (#4203)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-11 14:54:49 +08:00
Xiaolin Ha 8c42bca86e HBASE-26816 Fix CME in ReplicationSourceManager (#4187)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-11 11:49:29 +08:00
Andrew Purtell 49d3a00652 HBASE-26715 Blocked on SyncFuture in AsyncProtobufLogWriter#write (#4184)
Co-authored-by: Bryan Beaudreault <bbeaudreault@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-10 11:57:01 -08:00
Bryan Beaudreault fac011ed87 HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-10 10:10:12 -08:00
Bryan Beaudreault 8a4317838b HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on (#4194)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 14:44:23 -08:00
Bryan Beaudreault 91cb3028c4
HBASE-26783 ScannerCallable doubly clears meta cache on retries (#4147)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 12:02:51 -08:00
Nick Dimiduk 7e267c6069 HBASE-26782 Minor code cleanup in and around RpcExecutor
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-09 12:44:54 +01:00
Andrew Purtell 300f9b9576 HBASE-26582 Prune use of Random and SecureRandom objects (#4118)
Avoid the pattern where a Random object is allocated, used once or twice, and
then left for GC. This pattern triggers warnings from some static analysis tools
because this pattern leads to poor effective randomness. In a few cases we were
legitimately suffering from this issue; in others a change is still good to
reduce noise in analysis results.

Use ThreadLocalRandom where there is no requirement to set the seed to gain
good reuse.

Where useful relax use of SecureRandom to simply Random or ThreadLocalRandom,
which are unlikely to block if the system entropy pool is low, if we don't need
crypographically strong randomness for the use case. The exception to this is
normalization of use of Bytes#random to fill byte arrays with randomness.
Because Bytes#random may be used to generate key material it must be backed by
SecureRandom.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-08 15:22:00 -08:00
Bryan Beaudreault 5bae04e20c
HBASE-26784 Use HIGH_QOS for ResultScanner.close requests (#4163)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-08 10:50:00 +08:00
Xiaolin Ha f4c91ee65b
HBASE-26552 Introduce retry to logroller to avoid abort (#4170)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-07 16:41:49 +08:00
Xiaolin Ha 1aff89e0e4 HBASE-25709 Close region may stuck when region is compacting and skipped most cells read (#3117)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-07 11:45:40 +08:00
Rushabh Shah 0a7e49ca3b
HBASE-26792 Implement ScanInfo#toString (#4154)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-05 17:45:45 +08:00
Nick Dimiduk 01acd870b7 HBASE-26759 Fix trace continuity through CallRunner (#4126)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-04 15:26:48 -08:00
Andrew Purtell 961796a59e [branch-2] Amend HBASE-26731 Add metrics for active and expired scanners
Compliation fixes

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 14:14:12 -08:00
Bryan Beaudreault fc92a00bd1 HBASE-26731 Add metrics for active and expired scanners (#4145)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java
2022-03-04 14:06:13 -08:00
Istvan Toth eb1c57d12e HBASE-26777 BufferedDataBlockEncoder$OffheapDecodedExtendedCell.deepC… (#4139)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 13:50:03 -08:00
Duo Zhang 4644efb9f3
HBASE-26691 Replacing log4j with reload4j for branch-2.x (#4050)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:06:34 -08:00
Xiaolin Ha df90a4ba6b HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 20:47:50 +08:00
haxiaolin b5ac6380c4 Revert "HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)"
This reverts commit 2fa4bb0313.
2022-03-04 20:38:32 +08:00
Xiaolin Ha 2fa4bb0313 HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 20:25:23 +08:00
Nick Dimiduk 87ce5755cd
HBASE-26764 Implement generic exception support for TraceUtil methods over Callables and Runnables
For the `TraceUtil` methods that accept `Callable` and `Runnable` types, make them generic over a
child of `Throwable`. This allows us to consolidate the two method signatures into a single more
flexible definition.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-04 09:19:03 +01:00
Mike Drob 8a9e083994 HBASE-26622 Update error-prone to 2.10
Author:    Mike Drob <mdrob@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-03 11:51:51 +01:00
Niels Basjes c5f63550b7 HBASE-26762 Un-Deprecate and improve documentation for Scan#setRowPrefixFilter (#4119)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-02 23:34:17 +08:00
Nick Dimiduk e93abe687b HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2022-03-02 15:51:27 +01:00
BukrosSzabolcs 77bb153a2e
HBASE-26707: Reduce number of renames during bulkload (#4066) (#4122)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-02-25 20:11:41 +00:00
Duo Zhang 4cdb380ccc HBASE-26640 Reimplement master local region initialization to better work with SFT (#4111)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-02-24 11:09:50 +08:00
Bryan Beaudreault 5118e7199c HBASE-26703 Allow configuration of IPC queue balancer (#4063)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
2022-02-18 17:49:41 -08:00
Bryan Beaudreault 2a7b413b71 HBASE-26727 Fix CallDroppedException reporting (#4088)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 17:27:52 -08:00
Richard Marscher 1145581489 HBASE-26576 Allow pluggable queue to be used with the fast path executor or normal balanced executor (#3944)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 10:19:12 -08:00
Yutong Xiao cb225f1d90 HBASE-26659 The ByteBuffer of metadata in RAMQueueEntry in BucketCache could be reused. (#4026)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-19 00:41:49 +08:00
chenglei 07d638161c
HBASE-26712 Balancer encounters NPE in rare case (#4112) (#4092)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-16 12:12:56 +05:30
Xiaolin Ha 69062916a3 HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate (#4105)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-16 11:22:37 +08:00
Andrew Purtell 3e84e50107
HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' (#4094)
Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-15 18:38:25 -08:00
Xiaolin Ha 55a83ac1af HBASE-26434 Do compact when all L0 files are expired (#3830)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 22:37:40 +08:00
Yutong Xiao 1bee6046f0 HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down (#4073)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 20:30:55 +08:00
Nick Dimiduk d242c8fafa HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-10 12:57:45 +01:00
Duo Zhang d747da6985 HBASE-26709 Ban the usage of junit 3 TestCase (#4065)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-02-10 01:06:06 +08:00
Duo Zhang cbbb1a0542
HBASE-26724 Backport the UT changes in HBASE-24510 to branch-2.x (#4081)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-02-09 21:45:52 +08:00
Tak Lon (Stephen) Wu f637a60bdd
HBASE-26729 Backport "HBASE-26714 Introduce path configuration for system coprocessors" to branch-2 (#4093)
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility

Signed-off-by: Ankit Singhal <ankit@apache.org>
2022-02-04 05:56:23 -08:00
Andrew Purtell 08c2c65957
HBASE-26726 Allow disable of region warmup before graceful move (#4086)
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-02-01 15:38:31 -08:00
Duo Zhang dffeb8e63e
HBASE-26587 Introduce a new Admin API to change SFT implementation (#4030) (#4080)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
2022-01-30 20:43:23 +08:00
Bryan Beaudreault 76eb1b091d
HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append (#4075)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-01-28 12:55:51 -08:00
Duo Zhang a8b68c9b88 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor (#4054)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-27 13:38:11 +08:00
Nick Dimiduk d8085b43fc HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)
The code starting at `ZKUtil.dump(ZKWatcher)` is a small mess – it has cyclic dependencies woven
through itself, `ZKWatcher` and `RecoverableZooKeeper`. It also initializes a static variable in
`ZKUtil` through the factory for `RecoverableZooKeeper` instances. Let's decouple and clean it
up.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-01-25 09:08:35 -08:00
Duo Zhang 3021c58513 HBASE-26700 The way we bypass broken track file is not enough in StoreFileListFile (#4055)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-25 15:12:38 +08:00
Duo Zhang 5aa0fd2651 HBASE-26675 Data race on Compactor.writer (#4035)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-01-24 19:52:31 +08:00
Peter Somogyi d9a20630b0
HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider (#4049)
Duo Zhang <zhangduo@apache.org>
2022-01-20 15:04:31 +01:00
Duo Zhang 8fbc9a2606 HBASE-26674 Should modify filesCompacting under storeWriteLock (#4040)
Signed-off-by: Josh Elser <elserj@apache.org>
2022-01-19 16:53:00 +08:00
Nick Dimiduk d4f2b66a43
HBASE-26474 Implement connection-level attributes (#4014)
Add support for `db.system`, `db.connection_string`, `db.user`.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Huaxiang Sun <huaxiangsun@apache.org>
Co-authored-by: Josh Elser <josh.elser@gmail.com>
2022-01-18 12:29:35 -08:00
Duo Zhang f1dd865c35 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor while executing (#4034)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
2022-01-16 16:44:08 +08:00
xianjingfeng cf4a8266eb HBASE-26671 Misspellings of hbck usage (#4033)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-16 16:34:24 +08:00
Yutong Xiao 933fcdbe7c
Backport HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor to branch-2 (#4027)
Signed-off-by: Reid Chan <reidchan@apache.org>
2022-01-15 17:12:07 +08:00
Nick Dimiduk 2a42e8ed7a HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is
moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class
`JaasConfiguration` is also moved along with them.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-10 10:11:10 -08:00
Xiaolin Ha d9fae5cb67 HBASE-26397 Display the excluded datanodes on regionserver UI (#3990)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-10 13:02:31 +08:00
Duo Zhang 2f0b5ae59b HBASE-26643 LoadBalancer should not return empty map (#4005)
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2022-01-08 00:39:45 +08:00
Duo Zhang 6e1f5b7fec HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading (#4006)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-07 23:47:38 +08:00
Duo Zhang 39c42c7dc2 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is problematic (#4010)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-07 23:14:57 +08:00
Xiaolin Ha 7db277737a
HBASE-26347 Support detect and exclude slow DNs in fan-out of WAL (#3800)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-06 11:45:38 +08:00
Wellington Ramos Chevreuil 755b3b4cb8 HBASE-26585 Add SFT configuration to META table descriptor when creating META (#3998)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>

(cherry picked from commit baeb51ff8a)
2022-01-05 13:08:31 +00:00
Xiaolin Ha b2e65b7ce3
HBASE-26578 CompactedHFilesDischarger should be shutdown when aborting regionserver (#4001)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-05 15:26:49 +08:00
chenglei fb1c88adac HBASE-26567 Remove IndexType from ChunkCreator (#3947)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-05 00:08:16 +08:00
BukrosSzabolcs 53285d8e2a HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
Closes #3851

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-01-04 22:58:03 +08:00
Wellington Ramos Chevreuil 48e28917e0 HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (#3845)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-04 22:58:03 +08:00
BukrosSzabolcs 68252e17cb HBASE-26271 Cleanup the broken store files under data directory (#3786)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-04 22:58:03 +08:00
GeorryHuang c4325ff088 HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables (#3700)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-04 22:58:03 +08:00
Wellington Ramos Chevreuil 80b04229a2 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl (#3749)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-04 22:58:03 +08:00