Commit Graph

8746 Commits

Author SHA1 Message Date
Nick Dimiduk 48b1587d34 HBASE-26648 Improve fidelity of RegionLocator spans (addendum)
Addendum extends the test case to cover both `RpcConnectionRegistry` and `ZKConnectionRegistry`.
2022-05-03 13:47:35 +02:00
Nick Dimiduk ede80fb108 HBASE-26648 Improve fidelity of RegionLocator spans
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-03 13:47:35 +02:00
d-c-manning 44884eaa81 HBASE-26989 TestStochasticLoadBalancer fixes for performance and consistency (#4385)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Reviewed by: Rushabh Shah <shahrs87@gmail.com>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
2022-05-02 11:05:40 -07:00
Duo Zhang 1aea663c6d HBASE-26899 Run spotless:apply 2022-05-01 22:52:40 +08:00
d-c-manning adc9d07385 HBASE-26988 dynamic configuration of loadbalance.bytable (#4384)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
2022-04-29 15:28:23 -07:00
d-c-manning 6556350d4f HBASE-22349 slop in StochasticLoadBalancer (#4371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
2022-04-28 14:35:01 -07:00
liangxs 27c3584f90 HBASE-26975 Add on heap and off heap memstore info in rs web UI (#4368)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit cdf81ea5cc)
2022-04-28 23:15:27 +08:00
liangxs abedac5a2d HBASE-26980 Update javadoc of BucketCache.java (#4374)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c02e7553d4)
2022-04-28 23:12:07 +08:00
Andrew Purtell 4b2ac4b38e HBASE-26979 StoreFileListFile logs frequent stacktraces at INFO level (#4373)
Signed-off-by: Duo Zhang <zhangduo@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFile.java
2022-04-27 18:03:50 -07:00
Bri Augenreich 3439c5bd90 HBASE-26581 Add metrics for failed replication edits (#4347)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-26 17:46:26 -04:00
Wellington Ramos Chevreuil 47c62a9165 HBASE-26971 SnapshotInfo --snapshot param is marked as required even when trying to list all snapshots (#4366)
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit af13c6d4c6)
2022-04-25 14:20:14 +01:00
Ruanhui e2ac5a9338 HBASE-26942 cache region locations when getAllRegionLocations (#4364)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-22 15:31:53 -04:00
Bryan Beaudreault dc86de467b HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException (#4273)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-22 08:58:35 -04:00
Duo Zhang cd51da1d5a HBASE-26941 LocalHBaseCluster.waitOnRegionServer should not call join while interrupted (#4352)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 35aa57e445)
2022-04-17 23:27:10 +08:00
Duo Zhang 450a54bed8 HBASE-26938 Compaction failures after StoreFileTracker integration (#4350)
Introduce a StoreFileWriterCreationTracker to track the store files being written

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 48c4a4626e)
2022-04-17 22:53:36 +08:00
Duo Zhang 07531728b1 HBASE-26946 TestRetainAssignmentOnRestartSplitWithoutZk infinite loop (#4344)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 2622fa05a6)
2022-04-16 13:24:07 +08:00
Pankaj 3510db4d2d HBASE-26944 Possible resource leak while creating new region scanner (#4339)
* HBASE-26944 Possible resource leak while creating new region scanner

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 62e3efccef)
2022-04-15 11:40:39 +05:30
Duo Zhang 785a54661f Revert "HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while thread is interrupted (#4333)"
This reverts commit 29ce27c5d5.
2022-04-13 11:53:00 +08:00
Duo Zhang 29ce27c5d5 HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while thread is interrupted (#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c722)
2022-04-13 11:10:39 +08:00
eomiks f4ec10b958 HBASE-26901 delete with null columnQualifier occurs NullPointerException when NewVersionBehavior is on (#4295)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7ac9e0be27)
2022-04-12 20:32:31 +08:00
huaxiangsun 43af814d1a
HBASE-26618 Involving primary meta region in meta scan with CatalogRe… (#4321) (#4327)
Signed-off-by: Michael Stack <stack@apache.org>
2022-04-11 10:28:55 -07:00
Duo Zhang 913dd9c305 HBASE-26922 Fix LineLength warnings as much as possible if it can not be fixed by spotless (#4324)
Signed-off-by: Yulin Niu <niuyulin@apache.org
(cherry picked from commit 3ae0d9012c)
2022-04-09 23:21:21 +08:00
Andrew Purtell abb1bf2617 Revert "HBASE-26306 Backport "HBASE-26220 Use P2P communicate between region servers to sync the list for bootstrap node" to branch-2 (#3727)"
This reverts commit 10584d70d2.

See HBASE-26937 for discussion.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
2022-04-08 09:14:01 -07:00
Duo Zhang 5288220f2c HBASE-26928 Fix several indentation problems (#4323)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit e68c61dd54)
2022-04-06 15:14:19 +08:00
Wellington Ramos Chevreuil beed73be39 HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… (#4322)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>

(cherry picked from commit ae3718be0f)
2022-04-05 17:53:53 +01:00
weimingdiit eaa1c7fed3 HBASE-26924 Fix log parameter error and spelling error (#4318)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
(cherry picked from commit 003c572246)
2022-04-04 20:27:21 +08:00
bsglz a8d637402c HBASE-26885 Addendum throw exception instead of return in TRSP to let the procedure retry (#4299)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7f9d1f2259)
2022-04-04 20:27:17 +08:00
Duo Zhang f74d41486f HBASE-26921 Rewrite the counting cells part in TestMultiVersions (#4316)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 3e09e87fad)
2022-04-03 23:09:33 +08:00
Duo Zhang 787cc87794 HBASE-26920 Fix missing braces warnings in TestProcedureMember (#4315)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 78676bb85e)
2022-04-03 23:09:32 +08:00
Duo Zhang 8650de2c3c HBASE-26919 Rewrite the counting rows part in TestFromClientSide4 (#4314)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 4e12eee531)
2022-04-03 23:09:32 +08:00
Nick Dimiduk 235308d8bf HBASE-26545 Implement tracing of scan
* on `AsyncTable`, both `scan` and `scanAll` methods should result in `SCAN` table operations.
* the span of the `SCAN` table operation should have children representing all the RPC calls
  involved in servicing the scan.
* when a user provides custom implementation of `AdvancedScanResultConsumer`, any spans emitted
  from the callback methods should also be tied to the span that represents the `SCAN` table
  operation. This is easily done because these callbacks are executed on the RPC thread.
* when a user provides a custom implementation of `ScanResultConsumer`, any spans emitted from the
  callback methods should be also be tied to the span that represents the `SCAN` table
  operation. This accomplished by carefully passing the span instance around after it is created.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-04-01 12:47:33 +02:00
chenglei 69ea6f579f
HBASE-26811 Secondary replica may be disabled for read incorrectly forever (#4309) 2022-04-01 11:28:29 +08:00
chenglei 2bf81c6647
HBASE-26812 ShortCircuitingClusterConnection fails to close RegionScanners when making short-circuited calls (#4307) 2022-04-01 10:42:40 +08:00
Duo Zhang 75c81c7338 HBASE-26245 Store region server list in master local region (#4136)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit bb1bbddf74)
(cherry picked from commit 27111421d9)
2022-03-31 22:27:07 +08:00
bsglz e56388a34c HBASE-26885 The TRSP should not go on when it get a bogus server name… (#4276)
* HBASE-26885 The TRSP should not go on when it get a bogus server name from AM
2022-03-29 10:09:25 +08:00
d-c-manning a28e7ac52d HBASE-26718 HFileArchiver can remove referenced StoreFiles from the archive (#4274)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-28 11:49:40 -07:00
Xiaolin Ha f0088df551 HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)
Signed-off-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-03-28 23:32:42 +08:00
haxiaolin 245229055e Revert "HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)"
This reverts commit 568b335b44.
2022-03-28 18:19:01 +08:00
Duo Zhang 464ddfae15 HBASE-26832 Avoid repeated releasing of flushed wal entries in AsyncFSWAL#syncCompleted (#4281)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 4f491fd5e4)
2022-03-28 08:00:10 +08:00
Xiaolin Ha 568b335b44 HBASE-26872 Load rate calculator for cost functions should be more precise (#4253)
Signed-off-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-03-27 11:29:25 +08:00
huaxiangsun 8482a285c6 HBASE-26864 SplitTableRegionProcedure calls openParentRegions() at a … (#4261)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-26 12:15:24 -07:00
Andrew Purtell 6902cb2568 HBASE-26826 Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5
Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file #3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-03-26 09:30:58 -07:00
Wellington Ramos Chevreuil 2bbddfee1e HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-26 09:30:58 -07:00
Duo Zhang 6a4b2428df HBASE-26837 Set SFT config when creating TableDescriptor in TestCloneSnapshotProcedure (#4226)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 5b28d76652)
2022-03-26 09:30:58 -07:00
Duo Zhang 9c8d1e4625 HBASE-26611 Changing SFT implementation on disabled table is dangerous (#4082)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-26 09:30:58 -07:00
BukrosSzabolcs 4f9fbd8d58 HBASE-26707: Reduce number of renames during bulkload (#4066) (#4122)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
2022-03-26 09:30:58 -07:00
Duo Zhang c76c08308c HBASE-26640 Reimplement master local region initialization to better work with SFT (#4111)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-03-26 09:30:58 -07:00
Duo Zhang 6c43e62163 HBASE-26587 Introduce a new Admin API to change SFT implementation (#4030) (#4080)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
2022-03-26 09:30:58 -07:00
Duo Zhang f0e1bc81f9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor (#4054)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-03-26 09:30:58 -07:00
Duo Zhang 46c10f78ff HBASE-26700 The way we bypass broken track file is not enough in StoreFileListFile (#4055)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-03-26 09:30:58 -07:00