Commit Graph

15964 Commits

Author SHA1 Message Date
stack 65a6b270dd HBASE-22723 Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
Refactor of CatalogJanitor so it generates a
Report on the state of hbase:meta when it runs. Also
refactor so CJ runs even if RIT (previous it would
punt on running if RIT) so it can generate a 'Report'
on the interval regardless. If RIT, it just doesn't
go on to do the merge/split GC as it used to.

If report finds an issue, dump as a WARN message
to the master log.

Follow-on is to make the Report actionable/available
for the Master to pull when it goes to draw the hbck
UI page (could also consider shipping the Report as
part of ClusterMetrics?)

Adds new, fatter Visitor to CJ, one that generates
Report on each run keeping around more findings as
it runs.

Moved some methods around so class reads better;
previous methods were randomly ordered in the class.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Make a few handy methods public.

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
 Add utility as defaults on the Inteface; i.e. is this the first region
 in table, is it last, does a passed region come next, or does passed
 region overlap this region (added tests for this new stuff).

M hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
 Bugfix... handle case where buffer passed is null.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Lots of change, reorg., but mostly adding consistency checking
 to the visitor used scanning hbase:meta on a period and the
 generation of a Report on what the scan has found traversing
 hbase:meta. Added a main so could try the CatalogJanitor against
 a running cluster.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java
 Fat ugly test for CatalogJanitor consistency checking.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
 Add tests for new functionality in RI.

M hbase-shell/src/main/ruby/hbase/table.rb
 Bug fix for case where meta has a null regioninfo; scan was aborting.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-29 16:21:05 -07:00
stack d45b2d4469 HBASE-22751 table.jsp fails if ugly regions in table 2019-07-29 15:15:32 -07:00
Viraj Jasani 31c99ff393 HBASE-22743 : ClientUtils for Demo Client classes (#413) 2019-07-28 10:22:06 +08:00
Guanghao Zhang e54c4018e7 HBASE-22709 Add a chore thread in master to do hbck checking (#404)
Signed-off-by: stack <stack@apache.org>
2019-07-27 18:55:22 +08:00
Guanghao Zhang f8b592e9f8 HBASE-22742 [HBCK2] Add more log for hbck operations at master side
Signed-off-by: stack <stack@apache.org>
2019-07-27 12:41:54 +08:00
Gabriel a1442a8295 HBASE-22750 Correct @throws in comment.(In class org.apache.hadoop.hbase.client.RetryingCallerInterceptor) (#418) 2019-07-26 21:34:40 -07:00
stack fd267168d8 HBASE-22382 Refactor tests in TestFromClientSide; ADDENDUM to fix tests 2019-07-26 13:42:45 -07:00
linkaline 100a625324 HBASE-22733 TestSplitTransactionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor is flakey (#408)
Signed-off-by: stack <stack@apache.org>
2019-07-25 11:16:16 -07:00
syedmurtazahassan 141ccc4fd2 HBASE-22702 [Log] 'Group not found for table' is chatty
Signed-off-by Reid Chan <reidchan@apache.org>
2019-07-25 23:18:25 +08:00
Andor Molnár 884843d085 HBASE-22382 Refactor tests in TestFromClientSide (#385)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-25 10:41:31 +08:00
Guanghao Zhang 56417284bf HBASE-22721 Refactor HBaseFsck: move the inner class out
Signed-off-by: stack <stack@apache.org>
2019-07-25 08:32:19 +08:00
Jeongdae Kim d88ee0447a
HBASE-22715 All scan requests should be handled by scan handler threads in RWQueueRpcExecutor (#393)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
2019-07-24 11:56:48 -07:00
Jan Hentschel f77baaba3b HBASE-22692 Rubocop definition is not used in the /bin directory
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-24 11:17:55 +02:00
Duo Zhang ac80f4e1dc HBASE-22722 Upgrade jackson databind dependencies to 2.9.9.1 (#402)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-07-24 10:03:47 +08:00
Balazs Meszaros 439da93231 HBASE-15666 shaded dependencies for hbase-testing-util
HBASE-15666 shaded dependencies for hbase-testing-util

Added new artifact hbase-shaded-testing-util. It wraps a whole hbase-server
with its testing dependencies. Users should use only the following dependency
in pom:

<dependency>
  <groupId>org.apache.hbase</groupId>
  <artifactId>hbase-shaded-testing-util</artifactId>
  <version>${hbase.version}</version>
  <scope>test</scope>
</dependency>

Added hbase-shaded-testing-util-tester maven module which ensures
that hbase-shaded-testing-util works with a shaded client.

Signed-off-by: Josh Elser <elserj@apache.org>
2019-07-23 15:35:17 +02:00
syedmurtazahassan 6a46e071c5
HBASE-22603 Javadoc Warnings related to @link tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-23 14:46:24 +02:00
Peter Somogyi 78edb1e17f
HBASE-22720 Incorrect link for hbase.unittests
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-23 13:58:46 +02:00
syedmurtazahassan 49fcd92bdf HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize
Co-authored-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-07-23 12:05:51 +08:00
Toshihiro Suzuki 03f9fc3aa8 HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+
Signed-off-by: stack <stack@apache.org>
2019-07-23 10:22:54 +09:00
Duo Zhang 60cfdd822b HBASE-22719 Add debug support for github PR pre commit job 2019-07-22 13:49:40 +08:00
Guanghao Zhang 8c94bd47b2 Revert "HBASE-22673 Avoid to expose protobuf stuff in Hbck interface"
This reverts commit 2449d9c05d.
2019-07-19 08:27:23 +08:00
Guanghao 2449d9c05d HBASE-22673 Avoid to expose protobuf stuff in Hbck interface
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-19 08:21:41 +08:00
Guanghao Zhang 727ebbddac HBASE-22527 [hbck2] Add a master web ui to show the problematic regions 2019-07-18 08:11:06 -07:00
sreenivasulureddy df2cdc8e5d HBASE-22537 Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-18 15:29:35 +01:00
Guanghao c5af92b644 HBASE-22704 Avoid NPE when access table.jsp and snapshot.jsp but master not finish initialization (#389) 2019-07-18 08:45:51 +08:00
stack fa35bbc0d2 HBASE-7191 HBCK - Add offline create/fix hbase.version and hbase.id
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-17 08:01:12 -07:00
毛蛤丝 c14ccc302d HBASE-22700:incorrect timeout in recommended ZooKeeper configuration
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-17 22:27:39 +08:00
Viraj Jasani 8b37958161
HBASE-22643 : Delete region without archiving only if regiondir is present
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
2019-07-16 17:52:56 -07:00
Duo Zhang f017e7b8aa HBASE-22661 list_regions command in hbase shell is broken
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-16 16:13:00 +08:00
Mate Szalay-Beko 4211266a81 HBASE-21606 document meta table load metrics
Closes #369

Signed-off-by: Xu Cang <xcang@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit e5f05bf119)
2019-07-15 11:12:59 -05:00
Duo Zhang 1092533308 HBASE-22684 The log rolling request maybe canceled immediately in LogRoller due to a race (#378)
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-15 22:14:08 +08:00
Jan Hentschel 88ab7acbca
HBASE-22689 Added line breaks for fix version in JIRA
Signed-off-by: stack <stack@apache.org>
2019-07-14 17:31:55 +02:00
Viraj Jasani 74ae25d843
HBASE-22638 ZooKeeper Utility enhancements
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 20:54:54 +02:00
syedmurtazahassan 84ee7244d7
HBASE-19230 Write up fixVersion policy from dev discussion in refguide
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 18:16:14 +02:00
syedmurtazahassan d26e9d04e1
HBASE-22586 Javadoc Warnings related to @param tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 17:24:57 +02:00
Duo Zhang 421ae2a688 HBASE-22681 The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL (#376)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-07-13 22:16:46 +08:00
syedmurtazahassan 30e874ae58
HBASE-22571 Javadoc Warnings related to @return tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 16:01:32 +02:00
Andrew Purtell 5fc84844b3
HBASE-22686 ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of the split work it is capable of (#377)
Signed-off-by: Xu Cang <xcang@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
2019-07-12 18:13:15 -07:00
Braavos 3c017c5b50 HBASE-22669 Add unit tests for org.apache.hadoop.hbase.util.Strings (#363)
These tests were written using Diffblue Cover.
2019-07-10 10:12:15 +02:00
Toshihiro Suzuki 8ec797d08e HBASE-19893 restore_snapshot is broken in master branch when region splits
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
Signed-off-by: stack <stack@apache.org>
2019-07-07 20:45:47 -07:00
Reid Chan 1fb3fa22fb HBASE-22656 [Metrics] Table metrics 'BatchPut' and 'BatchDelete' are never updated
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-07 23:33:03 +08:00
openinx 6d5e120596 HBASE-22582 The Compaction writer may access the lastCell whose memory has been released when appending fileInfo in the final (#341) 2019-07-04 14:50:26 +08:00
stack b316833161 HBASE-22652 Flakey TestLockManager; test timed out after 780 seconds
Signed-off-by: Duo Zhang <Apache9@apache.org>
2019-07-03 07:50:49 -07:00
Murtaza Hassan 8e833472fd HBASE-22604 fix the link in the docs to "Understanding HBase and BigTable" by Jim R. Wilson
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-07-03 08:54:58 -05:00
stack 352184f16b HBASE-22652 Flakey TestLockManager; test timed out after 780 seconds
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-07-02 22:13:27 -07:00
Andor Molnár 35521d4a2f HBASE-13798 TestFromClientSide* don't close the Table 2019-07-02 13:00:20 +02:00
Mate Szalay-Beko 6205a6c8b3 HBASE-22637 fix flaky test in TestMetaTableMetrics
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
2019-07-02 09:46:21 +02:00
Bing Xiao a2a929f488 HBASE-21751 WAL creation fails during region open may cause region assign forever fail
Signed-off-by: Allan Yang <allan163@apache.org>
    Signed-off-by: Michael Stack <stack@apache.org>
2019-07-01 21:54:00 -07:00
zhangduo 668f543cdc HBASE-22477 Throwing exception when meta region is not in OPEN state in client registry may crash a master 2019-07-02 10:36:59 +08:00
Bing Xiao 963cb45f1c HBASE-22169 Open region failed cause memory leak
Signed-off-by: stack <stack@apache.org>
2019-07-01 13:13:19 -07:00