Enis Soztutar
81a9c1ac31
HBASE-16053 Master code is not setting the table in ENABLING state in create table
2016-06-17 13:29:33 -07:00
Joseph Hwang
61ff6ced5b
HBASE-16018 Refactored the ReplicationPeers interface to clear up what some methods do and move away from a ZooKeeper-specific implementation.
...
Also added some documentation for undocumented methods.
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-17 13:04:21 -07:00
tedyu
5147fb12a5
HBASE-16048 Tag InternalScanner with LimitedPrivate(HBaseInterfaceAudience.COPROC)
2016-06-17 07:27:52 -07:00
Ashu Pachauri
3abd52bdc6
HBASE-15429 Add split policy for busy regions
...
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-16 17:36:54 -07:00
tedyu
6d0e0e3721
HBASE-5291 Addendum 2 passes correct path to deleteRecursively
2016-06-16 17:00:57 -07:00
tedyu
d8902ba0e6
HBASE-16045 endtime argument for VerifyReplication was incorrectly specified in usage
2016-06-16 15:50:29 -07:00
Mikhail Antonov
62a4a2c029
HBASE-16047 TestFastFail is broken again
2016-06-16 14:09:48 -07:00
Yu Li
6d02f36ac7
HBASE-16033 Add more details in logging of responseTooSlow/TooLarge
2016-06-16 16:42:10 +08:00
Ramkrishna
f19f1d9e99
HBASE-15999 NPE in MemstoreCompactor (Ram)
2016-06-16 10:06:40 +05:30
tedyu
1bad166f67
HBASE-5291 Addendum removes duplicate spnego (Josh Elser)
2016-06-15 14:59:17 -07:00
Enis Soztutar
bff35d6387
HBASE-15950 Fix memstore size estimates to be more tighter
2016-06-15 13:34:39 -07:00
Mikhail Antonov
5f9d1a71c8
HBASE-16026 Master UI should display status of additional ZK switches
2016-06-15 12:59:24 -07:00
Joseph Hwang
2093aadec1
HBASE-15974 Create a ReplicationQueuesClientHBaseImpl
...
Building on HBase-15958.
Provided a ReplicationQueuesClientHBaseImpl that relies on the HBase Replication Table to track WAL queues.
Refactored out a large section of ReplicationQueuesHBaseImpl into a ReplicationTableClient class that handles Replication Table operations.
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-15 10:43:14 -07:00
tedyu
ae5fe1e616
HBASE-5291 Add Kerberos HTTP SPNEGO authentication support to HBase web consoles (Josh Elser)
2016-06-15 09:26:44 -07:00
tedyu
6c60bc9f6c
HBASE-16017 HBase TableOutputFormat has connection leak in getRecordWriter (Zhan Zhang)
2016-06-15 06:32:23 -07:00
chenheng
db234bf15d
HBASE-16023 Fastpath for the FIFO rpcscheduler. addendum
2016-06-15 16:20:55 +08:00
stack
ee86e91e7e
HBASE-16023 Fastpath for the FIFO rpcscheduler Adds an executor that does balanced queue and fast path handing off requests directly to waiting handlers if any present. Idea taken from Apace Kudu (incubating). See https://gerrit.cloudera.org/#/c/2938/7/src/kudu/rpc/service_queue.h
...
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
Refactor which makes a Handler type. Put all 'handler' stuff inside this
new type. Also make it so subclass can provide its own Handler type.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
Name the handler threads for their type so can tell if configs are
having an effect.
Signed-off-by: stack <stack@apache.org>
2016-06-14 17:42:01 -07:00
stack
fa50d456a8
HBASE-15971 Regression: Random Read/WorkloadC slower in 1.x than 0.98 Restore FIFO as the default in place of 'deadline' that sorted on request priority. The sort costs us throughput. Enable it if you want it rather than have it as default.
...
Name threads to include the scheduler type.
2016-06-14 16:51:24 -07:00
Stephen Yuan Jiang
df24004353
HBASE-15746 Remove extra RegionCoprocessor preClose() in RSRpcServices#closeRegion (Stephen Yuan Jiang)
2016-06-14 13:30:41 -07:00
anoopsjohn
17bcf14fea
HBASE-15525 OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts.
2016-06-14 19:03:54 +05:30
Stephen Yuan Jiang
e486d274c5
HBASE-16016 Fix overflow deadline value in AssignmentManager#waitForAssignment (Stephen Yuan Jiang)
2016-06-13 18:21:41 -07:00
Ramkrishna
56c209c8aa
HBASE-15991 CompactingMemstore#InMemoryFlushRunnable should implement
...
Comparable/Comparator (Ram)
2016-06-13 17:42:35 +05:30
Ramkrishna
2d0448fa84
Revert HBASE-15991 commit
2016-06-13 15:05:50 +05:30
Ramkrishna
2738518d43
HBASE-15991 CompactingMemstore#InMemoryFlushRunnable should implement
...
Comparable/Comparator (Ram)
2016-06-13 12:43:52 +05:30
tedyu
6360cc0307
HBASE-16007 Job's Configuration should be passed to TableMapReduceUtil#addDependencyJars() in WALPlayer
2016-06-11 07:05:27 -07:00
Matteo Bertozzi
4c885f4fdb
HBASE-14644 Region in transition metric is broken (Huaxiang Sun)
2016-06-10 21:52:24 -07:00
Sean Mackrory
6da6babe4f
HBASE-15946. Eliminate possible security concerns in Store File metrics.
...
Invoking 'hbase hfile' inside a servlet raises several concerns. This
patch avoids invoking a separate process, and also adds validation that
the file being read is at least inside the HBase root directory.
Signed-off-by: Mikhail Antonov <antonov@apache.org>
2016-06-09 16:08:19 -07:00
Joseph Hwang
babdedc1b0
HBASE-15958 Implement ClaimQueues on top of HBase
...
Building on HBase-15883.
Now implementing the claim queues procedure within an HBase table.
Also added UnitTests to test claimQueue.
Peer tracking will still be performed by ZooKeeper though.
Also modified the queueId tracking procedure so we no longer have to perform scans over the Replication Table.
This does make our queue naming schema slightly different from ReplicationQueuesZKImpl though.
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-09 15:05:54 -07:00
tedyu
55a04b7810
HBASE-15990 The priority value of subsequent coprocessors in the Coprocessor.Priority.SYSTEM list are not incremented by one (ChiaPing Tsai)
2016-06-09 10:26:10 -07:00
Ashish Singhi
9012a0b123
HBASE-15952 Bulk load data replication is not working when RS user does not have permission on hfile-refs node
2016-06-09 18:44:29 +05:30
stack
031b745001
HBASE-15994 Allow selection of RpcSchedulers
...
Adds logging by the RpcExecutors of their run configs
Adds a FifoRpcSchedulerFactory so you can try Fifo scheduler.
2016-06-08 20:23:11 -07:00
stack
407aa4d496
Revert "HBASE-15994 Allow selection of RpcSchedulers Adds logging by the RpcExecutors of their run configs Changes the default RpcSchedulerFactory from SimpleRpcSchedulerFactory.class to RpcSchedulerFactoryImpl.class. RpcSchedulerFactoryImpl.class. defaults to using SimpleRpcSchedulerFactory.class and the SimpleRpcScheduler, as has been default up to this, unless you set "hbase.region.server.rpc.scheduler.class" to org.apache.hadoop.hbase.ipc.FifoRpcScheduler"
...
This reverts commit 3ac4a57fd2
.
2016-06-08 20:22:50 -07:00
stack
3ac4a57fd2
HBASE-15994 Allow selection of RpcSchedulers Adds logging by the RpcExecutors of their run configs Changes the default RpcSchedulerFactory from SimpleRpcSchedulerFactory.class to RpcSchedulerFactoryImpl.class. RpcSchedulerFactoryImpl.class. defaults to using SimpleRpcSchedulerFactory.class and the SimpleRpcScheduler, as has been default up to this, unless you set "hbase.region.server.rpc.scheduler.class" to org.apache.hadoop.hbase.ipc.FifoRpcScheduler
...
Signed-off-by: stack <stack@apache.org>
2016-06-08 20:20:50 -07:00
Jonathan M Hsieh
a7172d5611
HBASE-15959 Fix flaky test TestRegionServerMetrics.testMobMetrics (Huaxiang Sun and Jingcheng Du)
2016-06-08 19:07:13 -07:00
Matteo Bertozzi
d9463bcce0
HBASE-15989 Remove hbase.online.schema.update.enable
2016-06-08 13:09:31 -07:00
Matteo Bertozzi
d5d9b7d500
HBASE-15107 Procedure v2 - Procedure Queue with Region locks
2016-06-08 12:52:58 -07:00
Enis Soztutar
d05a3722c8
HBASE-15600 Add provision for adding mutations to memstore or able to write to same region in batchMutate coprocessor hooks (Rajeshbabu and Enis)
2016-06-07 20:12:51 -07:00
stack
3a95552cfe
HBASE-15948 Port "HADOOP-9956 RPC listener inefficiently assigns connections to readers" Adds HADOOP-9955 RPC idle connection closing is extremely inefficient
...
Changes how we do accounting of Connections to match how it is done in Hadoop.
Adds a ConnectionManager class. Adds new configurations for this new class.
"hbase.ipc.client.idlethreshold" 4000
"hbase.ipc.client.connection.idle-scan-interval.ms" 10000
"hbase.ipc.client.connection.maxidletime" 10000
"hbase.ipc.client.kill.max", 10
"hbase.ipc.server.handler.queue.size", 100
The new scheme does away with synchronization that purportedly would freeze out
reads while we were cleaning up stale connections (according to HADOOP-9955)
Also adds in new mechanism for accepting Connections by pulling in as many
as we can at a time adding them to a Queue instead of doing one at a time.
Can help when bursty traffic according to HADOOP-9956. Removes a blocking
while Reader is busy parsing a request. Adds configuration
"hbase.ipc.server.read.connection-queue.size" with default of 100 for
queue size.
Signed-off-by: stack <stack@apache.org>
2016-06-07 16:42:21 -07:00
stack
e66ecd7db6
Revert "HBASE-15948 Port "HADOOP-9956 RPC listener inefficiently assigns connections to readers""
...
Revert mistaken commit...
This reverts commit e0b70c00e7
.
2016-06-07 16:41:30 -07:00
stack
6d5a25935e
Revert "HBASE-15967 Metric for active ipc Readers and make default fraction of cpu count"
...
Revert mistaken commit
This reverts commit 1125215aad
.
2016-06-07 16:41:01 -07:00
stack
1125215aad
HBASE-15967 Metric for active ipc Readers and make default fraction of cpu count
...
Add new metric hbase.regionserver.ipc.runningReaders
Also make it so Reader count is a factor of processor count
2016-06-07 13:10:14 -07:00
stack
e0b70c00e7
HBASE-15948 Port "HADOOP-9956 RPC listener inefficiently assigns connections to readers"
...
Adds HADOOP-9955 RPC idle connection closing is extremely inefficient
Then removes queue added by HADOOP-9956 at Enis suggestion
Changes how we do accounting of Connections to match how it is done in Hadoop.
Adds a ConnectionManager class. Adds new configurations for this new class.
"hbase.ipc.client.idlethreshold" 4000
"hbase.ipc.client.connection.idle-scan-interval.ms" 10000
"hbase.ipc.client.connection.maxidletime" 10000
"hbase.ipc.client.kill.max", 10
"hbase.ipc.server.handler.queue.size", 100
The new scheme does away with synchronization that purportedly would freeze out
reads while we were cleaning up stale connections (according to HADOOP-9955)
Also adds in new mechanism for accepting Connections by pulling in as many
as we can at a time adding them to a Queue instead of doing one at a time.
Can help when bursty traffic according to HADOOP-9956. Removes a blocking
while Reader is busy parsing a request. Adds configuration
"hbase.ipc.server.read.connection-queue.size" with default of 100 for
queue size.
2016-06-07 13:10:14 -07:00
Andrew Purtell
376ad0d986
HBASE-15698 Increment TimeRange not serialized to server (Ted Yu)
2016-06-06 22:17:00 -07:00
Enis Soztutar
3d7840a173
HBASE-15954 REST server should log requests with TRACE instead of DEBUG
2016-06-06 10:58:37 -07:00
Stephen Yuan Jiang
de1b5ff776
HBASE-15955 Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish (Stephen Yuan Jiang)
2016-06-03 15:49:23 -07:00
Joseph Hwang
21e98271c3
HBASE-15883 Adding WAL files and tracking offsets in HBase.
...
Implemented ReplicationQueuesHBaseImpl that tracks WAL offsets and replication queues in an HBase table.
Only wrote the basic tracking methods, have not implemented claimQueue() or HFileRef methods yet.
Wrote a basic unit test for ReplicationQueueHBaseImpl that tests the implemented functions on a single Region Server
Signed-off-by: Elliott Clark <elliott@fb.com>
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-03 15:23:10 -07:00
Apekshit
9a53d8b385
HBASE-15929 There are two tests named TestRegionServerMetrics. This causes slight issues when parsing console output for hanging tests and flaky tests analysis. Moving .../hbase/TestRegionServerMetrics.java to .../hbase/regionserver/TestRegionServerReadRequestMetrics.java. (Apekshit)
...
Change-Id: I379c15fe2c2c01bed53bddf7619d5f2a07c5640e
2016-06-03 15:13:49 -07:00
Apekshit
b557f0bec6
HBASE-15949 Cleanup TestRegionServerMetrics.
...
@Before and @After to setup/teardown tables using @Rule to set table name based on testname.
Refactor out copy-pasted code fragments to single function.
(Apekshit)
Change-Id: Ic22e5027cc3952bab5ec30070ed20e98017db65a
2016-06-03 14:27:24 -07:00
Matteo Bertozzi
f0c159b5fe
HBASE-15927 Remove HMaster.assignRegion()
2016-06-03 12:36:25 -07:00
Ashish Singhi
0cbce07626
HBASE-15888 Extend HBASE-12769 for bulk load data replication
2016-06-03 18:42:00 +05:30
Lars Hofhansl
fc890a2ecb
HBASE-15881 Allow BZIP2 compression.
2016-06-02 12:19:02 -07:00
tedyu
7e5d530870
HBASE-15727 Canary Tool for Zookeeper (churro morales)
2016-06-02 10:15:08 -07:00
tedyu
cd2588001c
HBASE-15933 Addendum - make merge decision when sizes of both regions are known
2016-06-02 09:30:36 -07:00
tedyu
cfe868d56e
HBASE-15933 NullPointerException may be thrown from SimpleRegionNormalizer#getRegionSize()
2016-06-02 01:55:28 -07:00
Apekshit
1a27278624
HBASE-15915 Set timeouts on hanging tests. Tests run: 8, Time elapsed: 94.191 sec - in org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures Tests run: 103, Time elapsed: 69.057 sec - in org.apache.hadoop.hbase.regionserver.TestHRegion Tests run: 103, Time elapsed: 67.957 sec - in org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush Tests run: 5, Time elapsed: 34.629 sec - in org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster Tests run: 9, Time elapsed: 82.913 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Tests run: 9, Time elapsed: 80.458 sec - in org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient (Apekshit)
...
Change-Id: Ia7b986ca6276ff5498f588c0b1b9c570e2a9d798
Signed-off-by: stack <stack@apache.org>
2016-05-30 21:13:55 -07:00
Daniel Vimont
e6d613de70
HBASE-15835 - Prevent HBaseTestingUtility#startMiniCluster from throwing _HMasterAddress already in use_ RuntimeException when another HBase thread is running
...
Signed-off-by: stack <stack@apache.org>
2016-05-30 20:05:19 -07:00
Jurriaan Mous
a1f0c1cbb3
HBASE-15875 Remove HTable references and HTableInterface
...
Signed-off-by: stack <stack@apache.org>
2016-05-30 19:56:54 -07:00
Jurriaan Mous
cdd532da8a
HBASE-15610 Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
...
Signed-off-by: stack <stack@apache.org>
2016-05-29 07:50:55 -07:00
Sean Mackrory
f4470af95d
HBASE-15891. Closeable resources potentially not getting closed if exception is thrown.
...
Signed-off-by: stack <stack@apache.org>
2016-05-28 21:32:22 -07:00
Sean Mackrory
3b6e6e6c25
HBASE-15889. String case conversions are locale-sensitive, used without locale
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-28 10:41:31 -07:00
Mikhail Antonov
60c8f76a9d
HBASE-15908 Checksum verification is broken due to incorrect passing of ByteBuffers in DataChecksum (Mikhail Antonov and Appy)
2016-05-28 03:14:52 -07:00
Gary Helmling
da0d74cd27
HBASE-15830 SASL encryption doesn't work with AsyncRpcChannelImpl (Colin Ma)
2016-05-26 21:58:27 -07:00
Enis Soztutar
43d1a999fe
HBASE-15837 Memstore size accounting is wrong if postBatchMutate() throws exception
2016-05-26 11:12:17 -07:00
Apekshit
94696d4067
HBASE-14635 Fix flaky test TestSnapshotCloneIndependence
...
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-05-25 21:14:06 -07:00
Joseph Hwang
b3362ccb0c
HBASE-15471 Added in Priority, General, and Replication queue sizes for RegionServers to the Web UI
...
Changed UI labels so that queue "size" refers to size in bytes and queue "length" refers to number of items in queue.
Signed-off-by: Elliott Clark <elliott@fb.com>
2016-05-25 15:10:48 -07:00
tedyu
fa74baeb40
HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan (Sergey Soldatov)
2016-05-25 08:58:28 -07:00
tedyu
39dc19236e
HBASE-15806 revert due to discussion on security
2016-05-24 02:08:11 -07:00
tedyu
c03ea895c4
HBASE-15806 An endpoint-based export tool (ChiaPing Tsai)
2016-05-23 10:51:25 -07:00
Jurriaan Mous
7130a222ce
HBASE-15876 Remove doBulkLoad(Path hfofDir, final HTable table) though it has not been through a full deprecation cycle
...
Signed-off-by: stack <stack@apache.org>
2016-05-23 10:25:22 -07:00
tedyu
ae42c65cfd
HBASE-15802 ConnectionUtils should use ThreadLocalRandom instead of Random (Matt Warhaftig)
2016-05-21 21:15:10 -07:00
Jerry He
56e4b85d06
HBASE-14818 user_permission does not list namespace permissions (li xiang)
2016-05-21 20:06:05 -07:00
tedyu
0671cba65f
HBASE-15529 Override needBalance in StochasticLoadBalancer (Guanghao Zhang)
2016-05-21 04:03:00 -07:00
anoopsjohn
0e52ac2464
HBASE-15228 Add the methods to RegionObserver to trigger start/complete restoring WALs. (Toshihiro Suzuki)
2016-05-21 09:56:28 +05:30
tedyu
2bb07e209e
HBASE-15529 Revert due to TestRegionRebalancing failing
2016-05-20 12:56:17 -07:00
Gary Helmling
4793988aef
HBASE-15856 Don't cache unresolved addresses for connections
2016-05-20 09:36:11 -07:00
tedyu
58798fc091
HBASE-15529 Override needBalance in StochasticLoadBalancer (Guanghao Zhang)
2016-05-20 07:44:05 -07:00
Matteo Bertozzi
d34f5d4b96
HBASE-15865 Move TestTableDeleteFamilyHandler and TestTableDescriptorModification handler tests to procedure
2016-05-20 07:03:11 -07:00
Matteo Bertozzi
7a84ee262f
HBASE-15864 Reuse the testing helper to wait regions in transition
2016-05-20 06:48:38 -07:00
eshcar
a27504c701
HBASE-14920: Compacting memstore
...
Signed-off-by: stack <stack@apache.org>
2016-05-20 03:41:43 -07:00
Jerry He
af5146ee04
HBASE-15465 userPermission returned by getUserPermission() for the selected namespace does not have namespace set (li xiang)
2016-05-19 20:35:58 -07:00
tedyu
a050e1d9f8
HBASE-15847 VerifyReplication prefix filtering (Geoffrey Jacoby)
2016-05-19 06:38:27 -07:00
Vincent
460b41c800
HBASE-15617 Canary in regionserver mode might not enumerate all regionservers
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-05-18 16:25:29 -07:00
Stephen Yuan Jiang
8aa8abfcb6
HBASE-15850 Localize the configuration change in testCheckTableLocks to reduce flakiness of TestHBaseFsck test suite (Stephen Yuan Jiang)
2016-05-18 13:22:41 -07:00
Matteo Bertozzi
5ac54e6abb
HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set
2016-05-18 12:48:26 -07:00
Jerry He
393bcd69f9
HBASE-15841 Performance Evaluation tool total rows may not be set correctly
2016-05-18 12:09:13 -07:00
Enis Soztutar
c1ada0a373
HBASE-15824 LocalHBaseCluster gets bind exception in master info port - ADDENDUM
2016-05-18 11:36:10 -07:00
Phil Yang
3bd9220f0c
HBASE-15593 Time limit of scanning should be offered by client
...
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-05-18 19:13:15 +08:00
Ramkrishna
7b5d5394c0
HBASE-15784 Misuse core/maxPoolSize of LinkedBlockingQueue in
...
ThreadPoolExecutor (Jingcheng Du)
2016-05-18 12:40:43 +05:30
zhangduo
b2b3b1fa4d
Revert "HBASE-15593 Time limit of scanning should be offered by client (Phil Yang)"
...
This reverts commit e47bfb9078
.
2016-05-18 13:08:50 +08:00
stack
e47bfb9078
HBASE-15593 Time limit of scanning should be offered by client (Phil Yang)
2016-05-17 12:49:31 -07:00
Elliott Clark
9269b8199e
HBASE-15840 WAL.proto compilation broken for cpp
2016-05-17 12:04:14 -07:00
tedyu
838c306c0a
HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig)
2016-05-17 11:01:26 -07:00
tedyu
00e61d2cfd
HBASE-15842 SnapshotInfo should display ownership information
2016-05-16 20:34:04 -07:00
Enis Soztutar
c3223a59ff
HBASE-15824 LocalHBaseCluster gets bind exception in master info port
2016-05-16 10:32:43 -07:00
Sean Busbey
e0aff10901
HBASE-15780 Make AuthUtil public and rely on it for talking to secure HBase.
...
Signed-off-by: Gary Helmling <garyh@apache.org>
Signed-off-by: Mikhail Antonov <antonov@apache.org>
Signed-off-by: stack <stack@apache.org>
2016-05-16 00:50:14 -05:00
Mikhail Antonov
2482062d34
HBASE-15615 Wrong sleep time when RegionServerCallable need retry (Guanghao Zhang)
2016-05-15 20:37:26 -07:00
Apekshit
60e19f60a9
HBASE-13532 Make UnknownScannerException less scary by giving more information in the exception string. (Apekshit)
...
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-05-13 15:00:23 -07:00
Jerry He
acca95fb50
HBASE-15808 Reduce potential bulk load intermediate space usage and waste
2016-05-12 15:43:48 -07:00
zhangduo
1267f76e9a
HBASE-15813 Rename DefaultWALProvider to a more specific name and clean up unnecessary reference to it
2016-05-12 11:27:00 +08:00
tedyu
c867858c44
HBASE-15812 Revert pending investigation on whether metrics dump can be re-implemented
2016-05-11 09:39:20 -07:00