Commit Graph

8012 Commits

Author SHA1 Message Date
Karthik Palanisamy 264d3e3b16 HBASE-23263 NPE in Quotas.jsp (#800)
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-08 09:55:57 +08:00
Karthik Palanisamy c348e642d9 HBASE-23262 Cannot load Master UI (#799)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-08 09:49:35 +08:00
lijinbin 02f264321b HBASE-22480 Get block from BlockCache once and return this block to BlockCache twice make ref count error. 2019-11-08 09:34:58 +08:00
Nick Dimiduk 12c19a6e51
HBASE-23230 Enforce member visibility in HRegionServer (#775)
* Clean up a bunch of private variable leakage into other
   classes. Reduces visibility as much as possible, providing getters
   where access remains necessary or making use of getters that
   already exist. There remains an insidious relationship between
   `HRegionServer` and `RSRpcServices`.
 * Rename `fs` to `dataFs`, `rootDir` as `dataRootDir` so as to
   distinguish from the new `walFs`, `walRootDir` (and make it easier
   to spot bugs).
 * Cleanup or delete a bunch of lack-luster javadoc comments.
 * Delete a handful of methods that are unused according to static
   analysis.
 * Reduces the warning count as reported by IntelliJ from 100 to 7.

Signed-off-by: stack <stack@apache.org>
2019-11-07 15:27:02 -08:00
ravowlga123 56e63b106c HBASE-23250 Log message about CleanerChore delegate initialization should be at INFO
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-11-05 20:21:16 +01:00
Viraj Jasani 10cc64a7d6 HBASE-23212 : Dynamically reload configs for Region Recovery chore (#773)
* HBASE-23212 : Dynamically reload configs for Region Recovery chore

* remove redundant volatile
2019-11-04 11:36:38 -08:00
Michael Stack 2f8860b1da HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-04 09:18:09 -08:00
Michael Stack bbfc73789f HBASE-23247 [hbck2] Schedule SCPs for 'Unknown Servers' (#791)
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-04 09:01:56 -08:00
binlijin 90007b7e80
HBASE-23241 TestExecutorService sometimes fail (#782)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-11-04 17:15:50 +08:00
stack 3ccfd50bd9 HBASE-23244 NPEs running Canary (#784)
Addendum to fix findbugs complaint.
2019-11-02 09:35:15 -07:00
Michael Stack c58e80fbe6 HBASE-23244 NPEs running Canary (#784)
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
2019-11-01 21:41:22 -07:00
Wellington Chevreuil b8a4504a26 HBASE-23238 Additional test and checks for null references on ScannerCallableWithReplicas (#780)
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 577db5d7e5 - Test only, removed changes from no more exisiting ScannerCallableWithReplicas class)
2019-11-01 12:15:41 +00:00
Michael Stack e1b4a2a895 HBASE-23221 Polish the WAL interface after HBASE-23181 (#774)
Removes the closeRegion flag added by HBASE-23181 and instead
relies on reading meta WALEdit content. Modified how qualifier is
written when the meta WALEdit is for a RegionEventDescriptor
so the 'type' is added to the qualifer so can figure type
w/o having to deserialize protobuf value content: e.g.
HBASE::REGION_EVENT::REGION_CLOSE

Added doc on WALEdit and tried to formalize the 'meta' WALEdit
type and how it works. Needs complete redo in part as suggested
by HBASE-8457. Meantime, some doc and cleanup.

Also changed the LogRoller constructor to remove redundant param.
Because of constructor change, need to change also
TestFailedAppendAndSync, TestWALLockup, TestAsyncFSWAL &
WALPerformanceEvaluation.java

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-10-31 18:52:04 +08:00
chenxu14 255be63e1d HBASE-23184 The HeapAllocation in WebUI is not accurate (#730)
Signed-off-by: stack <stack@apache.org>
2019-10-31 17:53:24 +08:00
Duo Zhang 2451c2c532 HBASE-23231 Addendum remove redundant metrics.clear in ReplicationSource
This is only a problem on master which was introduced when we merge sync replication feature branch back
2019-10-31 09:40:43 +08:00
binlijin 3152d9981b HBASE-23231 ReplicationSource do not update metrics after refresh (#778)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-31 09:23:59 +08:00
Ankit Singhal 0108e57309 HBASE-23175 Yarn unable to acquire delegation token for HBase Spark jobs 2019-10-30 14:49:04 -07:00
binlijin e808ea1d04 HBASE-22739 ArrayIndexOutOfBoundsException when balance (#729)
Signed-off-by: stack <stack@apache.org>
2019-10-30 13:28:01 -07:00
Michael Stack 54425bf87b
HBASE-23192 CatalogJanitor consistencyCheck does not log problematic row on exception (#734)
Adds logging of row and complaint if consistency check fails during CJ
checking. Adds a few more null checks. Does edit on the 'HBCK Report'
top line.

Signed-off-by: Reid Chan <reidchan@apache.org>
2019-10-30 13:10:19 -07:00
Karthik Palanisamy 0a4c0b2dd6 HBASE-23191 EOFE log spam (#733)
Convert log message added for 2.2.0 from INFO to DEBUG.

Signed-off-by: stack <stack@apache.org>
2019-10-30 12:49:04 -07:00
Ankit Singhal 41bec4b8b1 HBASE-20827 Use backoff on CallQueueTooBigException when reporting region state transition
Signed-off-by: Josh Elser <elserj@apache.org>
2019-10-30 11:32:43 -04:00
Viraj Jasani 7b4dd9587b Revert "HBASE-23194 Remove unused methods from TokenUtil (#737)"
This reverts commit d7b90b3199.
2019-10-29 10:51:32 +01:00
binlijin 9a80618765
HBASE-23187 Update parent region state to SPLIT in meta (#732)
* HBASE-23187 Update parent region state to SPLIT in meta
2019-10-29 11:35:46 +08:00
Karthik Palanisamy 02370911b0 HBASE-23199 Error populating Table-Attribute fields (#741)
Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
2019-10-29 11:31:25 +08:00
Sean Busbey a881678ef4 HBASE-23222 MOB compaction supportability improvements
* better logging on MOB compaction process
* HFileCleanerDelegate to optionally halt removal of mob hfiles
* use archiving when removing committed mob file after bulkload ref failure

closes #763

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2019-10-28 08:59:01 -05:00
Duo Zhang 7b5cd0152f
HBASE-23181 Blocked WAL archive: "LogRoller: Failed to schedule flush of XXXX, because it is not online on us" (#753)
Signed-off-by: Lijin Bin <binlijin@apache.org>
Signed-off-by: stack <stack@apache.org>
2019-10-26 20:37:37 +08:00
Viraj Jasani d7b90b3199 HBASE-23194 Remove unused methods from TokenUtil (#737)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-10-25 10:22:06 +02:00
Karthik Palanisamy 8f92a14cd1 HBASE-23203 NPE in RSGroup info (#747)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-25 08:43:34 +08:00
Pierre Zemb 42d535a57a HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule (#677)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-10-24 08:46:34 +01:00
Andrew Purtell b14ba58c5a
HBASE-23207 Log a region open journal (#751)
Signed-off-by: Abhishek Singh Chouhan <achouhan@apache.org>
2019-10-23 17:17:06 -07:00
Ankit Singhal 59fc163e94 HBASE-15519 Add per-user metrics with lossy counting
Introducing property hbase.regionserver.user.metrics.enabled(Default:true)
to disable user metrics in case it accounts for any performance issues

Close #661

Signed-off-by: Josh Elser <elserj@apache.org>
2019-10-23 11:54:31 -04:00
Viraj Jasani 14dcf1d0c6 HBASE-22460 : Reopen regions with very high Store Ref Counts (#600)
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
2019-10-23 21:16:47 +05:30
Viraj Jasani 2ad62b0162 HBASE-22679 : Revamping CellUtil (#735)
* HBASE-22679 : Revamping CellUtil

* checkstyle fix

* incorporating review

* minor indentation
2019-10-21 23:04:21 -07:00
Caroline Zhou af1910ccf3 HBASE-23172 HBase Canary region success count metrics reflect column family successes, not region successes 2019-10-21 09:02:21 -07:00
meiyi da9a53ed4d
HBASE-23042 Parameters are incorrect in procedures jsp (#728) 2019-10-21 10:09:05 +08:00
Wellington Ramos Chevreuil 4d414020bb
HBASE-23136 (#712)
* HBASE-23136 PartionedMobFileCompactor bulkloaded files shouldn't get replicated (addressing buklload replication related issue raised in HBASE-22380)

Signed-off-by: Josh Elser <elserj@apache.org>
2019-10-18 15:07:11 +01:00
meiyi 946f1e9e25
HBASE-23170 Admin#getRegionServers use ClusterMetrics.Option.SERVERS_NAME (#721) 2019-10-18 09:35:35 +08:00
chenxu14 0043dfebc5 HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite (#678)
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: stack <stack@apache.org>
2019-10-17 09:44:40 +08:00
stack 820a416f04 HBASE-23177 If fail to open reference because FNFE, make it plain it is a Reference
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
2019-10-16 12:32:26 -07:00
binlijin 395cfceb0b HBASE-22370 ByteBuf LEAK ERROR (#720)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-16 20:41:27 +08:00
Guangxu Cheng 17495d812d HBASE-20626 Change the value of "Requests Per Second" on WEBUI 2019-10-16 14:25:14 +08:00
Guanghao Zhang 7924ba39e7
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateCachedLocationOnError (#718) 2019-10-15 11:16:43 +08:00
Duo Zhang 6aec958d66
HBASE-23163 Refactor HStore.getStorefilesSize related methods (#719)
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-10-14 18:09:57 +08:00
Lijin Bin 9e628b715d HBASE-23159 HStore#getStorefilesSize may throw NPE 2019-10-12 19:44:42 -07:00
Andrew Purtell 73d69c6157
HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded (#714)
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-10-12 13:14:13 -07:00
Karthik Palanisamy c0a09ccbbd HBASE-23152 Compaction_switch does not work by RegionServer name (#713)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 Signed-off-by: stack <stack@apache.org>
2019-10-12 09:08:20 -07:00
zbq.dean 5848e149f4 HBASE-23056 Block count is 0 when BucketCache using persistent IOEngine and retrieve from file
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-10-12 14:49:11 +08:00
chenxu14 1aee5f0552 HBASE-23083 Collect Executor status info periodically and report to (#664)
metrics system
Signed-off-by: stack <stack@apache.org>
2019-10-11 12:05:53 -07:00
OlegPt 473816d922 HBASE-23145 Remove out-of-date comments in StoreFlusher.java (#709)
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
2019-10-11 11:23:56 -07:00
Wellington Chevreuil 38b06c7517 Revert "HBASE-23136 PartionedMobFileCompactor bulkloaded files shouldn't get replicated"
This reverts commit fec4c52499.
2019-10-11 14:45:29 +01:00
Viraj Jasani 2f0b3ac91c HBASE-23093 Avoid Optional Anti-Pattern where possible (#673)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-11 15:28:50 +08:00
Baiqiang Zhao 16da123df4 HBASE-23017 Verify the file integrity in persistent IOEngine
Signed-off-by: Anoop Sam John <anoopsamjohn@apacher.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-10-11 14:38:00 +08:00
Wellington Ramos Chevreuil fec4c52499
HBASE-23136 PartionedMobFileCompactor bulkloaded files shouldn't get replicated
Signed-off-by: stack <stack@apache.org>
2019-10-10 10:37:42 +01:00
Karthik Palanisamy fdac2ddc81 HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp) (#682)
Signed-off-by: Toshihiro Suzuki <brfrn169@gmail.com>
2019-10-09 23:30:56 +09:00
haxiaolin 92bf07a98d HBASE-22767 System table RIT STUCK if their RSGroup has no highest version RSes
Signed-off-by: stack <stack@apache.org>
2019-10-08 16:31:22 -07:00
Karthik Palanisamy ff52994076 HBASE-23095 Reuse FileStatus in StoreFileInfo (#674)
Signed-off-by: Anoop Sam John <anoop.hbase@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-08 15:47:12 +08:00
Sanjeet Nishad 10180e232e HBASE-23094 Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-10-07 16:20:51 +02:00
Bharath Vissapragada 06ff478674 HBASE-23116: Fix a load balancer logging nit. (#687)
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.

Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
2019-10-04 18:07:49 +01:00
Rushabh 5aa8d3a20b HBASE-22874 Define a public API for Canary checking and a non-public tool implementation
Closes #580

* Canary is now an IA.Public interface
* CanaryTool is now the implementation

Signed-off-by: Sean Busbey <busbey@apache.org>
2019-10-03 13:45:48 -07:00
stack 2ebdcbc3b0 Revert " HBASE-23055 Alter hbase:meta (#667)"
Revert because new feedback and requested survey of master usage
figuring table state.

This reverts commit 52176184df.
2019-10-01 09:24:10 -07:00
Michael Stack 52176184df
HBASE-23055 Alter hbase:meta (#667)
Make it so hbase:meta can be altered. TableState for hbase:meta
    is kept in Master. State is in-memory transient so if  Master
    fails, hbase:meta is ENABLED again. hbase:meta schema will be
    bootstrapped from the filesystem. Changes to filesystem schema
    are atomic so we should be ok if Master fails mid-edit (TBD)
    Undoes a bunch of guards that prevented our being able to edit
    hbase:meta. At minimmum, need to add in a bunch of WARNING.

    TODO: Tests, more clarity around hbase:meta table state, and undoing
    references to hard-coded hbase:meta regioninfo.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
     Throw illegal access exception if you try to use MetaTableAccessor
     getting state of the hbase:meta table.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
     For table state, go to master rather than go to meta direct. Going
     to meta won't work for hbase;meta state. Puts load on Master.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
     Change isTableDisabled/Enabled implementation to ask the Master instead.
     This will give the Master's TableStateManager's opinion rather than
     client figuring it for themselves reading meta table direct.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
     TODO: Cleanup in here. Go to master for state, not to meta.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKAsyncRegistry.java
     Logging cleanup.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZNodePaths.java
     Shutdown access.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
     Just cleanup.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
     Add state holder for hbase:meta.
     Removed unused methods.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
     Shut down access.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java
     Allow hbase:meta to be disabled.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.java
     Allow hbase:meta to be enabled.

 Signed-off-by: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
2019-09-30 09:29:51 -07:00
Viraj Jasani 944108c38a HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command (#611)
Signed-off-by: huzheng <openinx@gmail.com>
2019-09-30 17:35:22 +08:00
Duo Zhang ca0d9f3cd2
HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure (#672)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-09-30 11:48:50 +08:00
chenxu14 ce0fbc2af9 HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff (#603)
Signed-off-by: huzheng <openinx@gmail.com>
2019-09-30 09:17:07 +08:00
Guanghao Zhang 1170f28122
HBASE-23078 BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment (#663)
Signed-off-by: stack <stack@apache.org>
2019-09-29 17:36:07 +08:00
Duo Zhang c1a476c492
HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConnection (#670)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-09-29 09:26:40 +08:00
Ankit Singhal 836368189a HBASE-23054 Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm 2019-09-28 09:29:17 -07:00
Guanghao Zhang ef79b40e6e
HBASE-23035 Retain region to the last RegionServer make the failover slower (addendum) (#652) 2019-09-28 20:25:05 +08:00
Sanjeet Nishad b45c0d0efa HBASE-23038 Provide consistent and clear logging about disabling chores
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-09-27 15:01:15 -05:00
shardul-cr7 3250a8021a HBASE-22012 Prevent DISABLE quota violation policy from disabling violation policy
Space quotas has a feature which intends to avoid enacting a space quota
violation policy when only a subset of the Regions for that Table have
reported their space usage (under the assumption that we cannot make an
informed decision if we do not include all regions in our calculations).

This had the unintended side-effect, when a table is disabled as a part
of a violation policy, of causing the regions for that table to not be
reported which disables the violation policy and enables the table.

Need to make sure that when a table is disabled because of a violation
policy that the code does not automatically move that table out of
violation because region sizes are not being reported (because those
regions are not open).

Closes #572

Signed-off-by: Josh Elser <elserj@apache.org>
2019-09-26 16:15:16 -04:00
Wellington Chevreuil 277c1cc97f Amend HBASE-22380 break circle replication when doing bulkload
Fixing tests broken by this commit: TestBulkLoadHFilesSplitRecovery and TestSecureBulkLoadHFilesSplitRecovery.
2019-09-26 13:35:35 +01:00
BukrosSzabolcs f0dddd1cc2 HBASE-22982: region server suspend/resume and graceful rolling restart actions (#592)
* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-26 10:07:38 +02:00
zbq.dean a8e3d23cca HBASE-22975 Add read and write QPS metrics at server level and table level (#615)
Signed-off-by Reid Chan <reidchan@apache.org>
2019-09-23 12:51:25 +08:00
Pankaj 537c5f0660 HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads (#585) 2019-09-22 12:25:02 +02:00
Guanghao Zhang cb04c6c1a6
HBASE-23035 Retain region to the last RegionServer make the failover slower (#631)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-21 21:11:05 +08:00
Wellington Ramos Chevreuil 3ae353cbf4
HBASE-22380 break circle replication when doing bulkload (#566)
Signed-off-by: Josh Elser <elserj@apache.org>
2019-09-21 14:02:18 +01:00
wuqiong 44cdf5f4ea HBASE-23058 Should be 'Column Family Name' in table.jsp
Signed-off-by: Guanghao Zhang <zhangguanghao1@xiaomi.com>
2019-09-21 19:24:32 +08:00
shardul-cr7 96a94ac3d0 HBASE-22142 Drop table RegionSizes with namespace quota
There was a bug in which we would not drop the RegionSizes
for a table in a namespace, where the namespace had a quota
on it. This allowed a scenario in which recreation of a table
inside of a namespace would unintentionally move into violation
despite the table being empty. Need to make sure the RegionSizes
are dropped on table deletion if there is _any_ quota applying
to that table.

Closes #598

Signed-off-by: Josh Elser <elserj@apache.org>
2019-09-20 13:50:58 -04:00
shardul-cr7 2b3c9b18dd HBASE-22944 Check for hbase:quota table existence in SpaceQuotaRefresherChore
During startup, it's possible that quotas are enabled but the Master has
not yet created the hbase:quotas table.

Closes #559

Signed-off-by: stack <stack@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2019-09-20 13:50:43 -04:00
Duo Zhang e890776fe0 HBASE-22941 Addendum fix NPE in UT 2019-09-20 14:35:56 +08:00
sreenivasulureddy 49718b8b46
HBASE-22649: Encode StoreFile path URLs in the UI to handle scenarios where CF contains special characters (like # etc.)
Signed-off-by: Sakthi<sakthi@apache.org>
2019-09-19 14:14:15 -07:00
Stig Døssing 0ec0a9403f HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… (#361)
* HBase-22027: Split non-MR related parts of TokenUtil off into a ClientTokenUtil, and move ClientTokenUtil to hbase-client

* Replace uses of deprecated TokenUtil methods with ClientTokenUtil methods. Make methods that don't need to be public package-private

* Don't use reflection where not necessary in TestClientTokenUtil

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: stack <stack@apache.org>
2019-09-19 12:42:04 -07:00
Peter Somogyi 1fec3d1dfd
HBASE-23051 Remove unneeded Mockito.mock invocations (#641)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2019-09-19 19:28:58 +02:00
Wellington Chevreuil a85c6b4867 HBASE-23047 ChecksumUtil.validateChecksum logs an INFO message inside a "if(LOG.isTraceEnabled())" block.
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-19 15:32:03 +01:00
Guanghao Zhang 343a6a7913
HBASE-23049 TableDescriptors#getAll should return the tables ordering by the name which contain namespace (#639)
Signed-off-by: stack <stack@apache.org>
2019-09-19 21:20:42 +08:00
Peter Somogyi 1655360951 Revert "HBASE-22700 refactor isMetaClearingException (#501)"
This reverts commit cb62f73406.
2019-09-19 13:21:22 +02:00
Guanghao Zhang a0e8723b73
HBASE-23041 Should not show split parent regions in HBCK report's unknown server part (#634)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-19 10:59:01 +08:00
Guanghao Zhang 20bfb43db6
HBASE-23044 CatalogJanitor#cleanMergeQualifier may clean wrong parent regions (#637)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-19 08:08:49 +08:00
Guanghao Zhang 25bcc91dab
HBASE-23037 Make the split WAL related log more readable (#632)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-18 21:44:05 +08:00
Sean Busbey ab076b0731 HBASE-23040 give friendly message about unknown server when running unload for RegionMover.
closes #635

Signed-off-by: stack <stack@apache.org>
2019-09-18 06:29:43 -05:00
johnhomsea cb62f73406 HBASE-22700 refactor isMetaClearingException (#501) 2019-09-17 10:02:37 -07:00
Viraj Jasani 0dbae8f0e1 HBASE-23024 Replace initcause with Constructor arg (#627)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-17 13:39:26 +02:00
Caroline Zhou 7da61ff174
HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary
Signed-off-by: Xu Cang <xucang@apache.org>
2019-09-16 11:15:27 -07:00
Yiran Wu f31301dcf8 HBASE-22939 SpaceQuotas - Bulkload from different hdfs failed when space quotas are turned on. (#553)
Signed-off-by: Sakthi <sakthi@apache.org>
2019-09-14 10:46:29 -07:00
ravowlga123 a09c0c88b6 HBASE-22899 logging improvements for snapshot operations w/large manifests (#547)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-09-14 10:16:49 -07:00
Viraj Jasani 1dcc8ee50c HBASE-22760 : Pause/Resume/Query Snapshot Auto Cleanup Activity (#617) 2019-09-13 10:34:01 +05:30
ramkrish86 c0908d4be4
HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram) (#614) 2019-09-13 10:01:46 +05:30
stack 3330e5c2e2 HBASE-22796 [HBCK2] Add fix of overlaps to fixMeta hbck Service
Addendum for branch-2+.

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-12 13:30:43 -07:00
Guanghao Zhang c0e5c15887
HBASE-22993 HBCK report UI showed -1 if hbck chore not running (#610)
Signed-off-by: stack <stack@apache.org>
2019-09-12 09:09:57 +08:00
Guanghao Zhang a58149827b HBASE-23014 Should not show split parent regions in hbck report UI (#609) 2019-09-11 10:07:25 -07:00
Guanghao Zhang 3cfcee9eda HBASE-23005 Table UI showed exception message when table is disabled (#602)
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-09-11 09:53:22 +08:00
stack e9e6202f9c HBASE-22796 [HBCK2] Add fix of overlaps to fixMeta hbck Service
Signed-off-by: Sakthi <sakthi@apache.org>
2019-09-10 17:04:06 -07:00
Duo Zhang c2c9984c35 Revert "HBASE-22662 Move RSGroupInfoManager to hbase-server (#368)"
This reverts commit 3032c713e1.
2019-09-10 11:14:30 +08:00
Duo Zhang 124ac4d6c4 Revert "HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module (#399)"
This reverts commit f7bbdde975.
2019-09-10 11:14:23 +08:00
Duo Zhang 936bb82908 Revert "HBASE-22695 Store the rsgroup of a table in table configuration (#426)"
This reverts commit eab7d3d502.
2019-09-10 11:14:17 +08:00
Duo Zhang 1c150e0947 Revert "HBASE-22809 Allow creating table in group when rs group contains no live servers (#464)"
This reverts commit 928ecfb443.
2019-09-10 11:14:10 +08:00
Duo Zhang 4a22c74b3c Revert "HBASE-22820 Do not need to persist default rs group now (#482)"
This reverts commit 97ec5d53c0.
2019-09-10 11:14:04 +08:00
Duo Zhang 64581fa33b Revert "HBASE-22819 Automatically migrate the rs group config for table after HBASE-22695 (#498)"
This reverts commit 9196a15de9.
2019-09-10 11:13:58 +08:00
Duo Zhang 5a37c98a29 Revert "HBASE-22729 Start RSGroupInfoManager as default (#555)"
This reverts commit 58dee3ea5b.
2019-09-10 11:13:50 +08:00
Guanghao Zhang 58dee3ea5b HBASE-22729 Start RSGroupInfoManager as default (#555)
Amending-Author: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
2019-09-10 10:47:45 +08:00
Duo Zhang 9196a15de9 HBASE-22819 Automatically migrate the rs group config for table after HBASE-22695 (#498)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-09-10 10:47:44 +08:00
linkaline 97ec5d53c0 HBASE-22820 Do not need to persist default rs group now (#482)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-10 10:47:44 +08:00
Duo Zhang 928ecfb443 HBASE-22809 Allow creating table in group when rs group contains no live servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-09-10 10:47:44 +08:00
Duo Zhang eab7d3d502 HBASE-22695 Store the rsgroup of a table in table configuration (#426)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-09-10 10:47:44 +08:00
Duo Zhang f7bbdde975 HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-09-10 10:47:44 +08:00
Duo Zhang 3032c713e1 HBASE-22662 Move RSGroupInfoManager to hbase-server (#368)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-09-10 10:47:44 +08:00
shardul-cr7 93f39a7818 HBASE-22013 Prune replicas when computing the reported number of regions for a table
Closes #570

Signed-off-by: Josh Elser <elserj@apache.org>
2019-09-09 12:24:47 -04:00
stack 018396d84c HBASE-22859 [HBCK2] Fix the orphan regions on filesystem
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Guanghao Zhang <zghao@apache.org>

Add section to the bulk load complete tool on how it can be
used 'adopting' stray 'orphan' data turned up by hbck2 or
the new reporting facility in the Master UI.

Did a cleanup of BulkLoadHFileTool mostly around usage
pointing back to this new documentation.
2019-09-09 08:47:30 -07:00
Peter Somogyi ac8fe1627a
HBASE-22979 Call ChunkCreator.initialize in TestHRegionWithInMemoryFlush (#589)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-09-09 11:50:54 +02:00
chenxu14 fb7230c3f1 HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read (#583) 2019-09-09 17:38:33 +08:00
Viraj Jasani cb976b0306 HBASE-22989 : null check for item2RegionMap while removing LoadQueueItem (#596)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-09 08:28:06 +08:00
Duo Zhang 693f201f3d
HBASE-22963 Netty ByteBuf leak in rpc client implementation (#577)
Signed-off-by: Michael Stack <stack@apache.org>
2019-09-08 21:54:09 +08:00
Guanghao Zhang d8e5c87cf8
HBASE-22964 Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk (#574)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-08 18:46:52 +08:00
stack 0d338a1820 Revert "HBASE-22930 Set unique name to longCompactions/shortCompactions threads (#548)"
This reverts commit 0f0a3a2273.
2019-09-04 09:18:28 -07:00
Pankaj 0f0a3a2273 HBASE-22930 Set unique name to longCompactions/shortCompactions threads (#548) 2019-09-04 08:47:06 -07:00
stack 960a5fdc2a HBASE-22970 split parents show as overlaps in the HBCK Report
Check if overlap is split parent.

Cleaned up the HBCK Report page too with some notes that it is made of
two reports; have the two sections display the same.
2019-09-03 14:48:04 -07:00
stack e50ec76ac4 HBASE-22961 Deprecate hbck1 in core
Adds deprecations on HBaseFsck and on supporting classes such as
the reporting Interface. Provides alternatives in FSUtils for
progress reporting and deprecates methods that use hbck1 facility.

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-03 11:06:37 -07:00
meiyi 1d1813de48
HBASE-22878 Show table throttle quotas in table jsp (#510) 2019-09-03 09:37:49 +08:00
meiyi 9bed419cb0
HBASE-22946 Fix TableNotFound when grant/revoke if AccessController is not loaded (#561) 2019-09-02 14:50:09 +08:00
linkaline 693fa05273 HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky (#551)
* HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky

* delete blank line
2019-09-01 21:44:35 -07:00
meiyi 345c21dbe7 HBASE-22945 Show quota infos in master UI (#560)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-01 22:42:47 +08:00
康智冬 97fbaa658e HBASE-22962 Fix typo in javadoc description (#569)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-09-01 20:14:31 +08:00
stack f6a4c66d13 HBASE-22941 merge operation returns parent regions in random order (#556)
Minor addendum to address checkstyle issue
2019-08-29 12:29:28 -07:00
Istvan Toth 56fd3e9007 HBASE-22941 merge operation returns parent regions in random order (#556)
* HBASE-22941 merge operation returns parent regions in random order

store and return the merge parent regions in ascending order

remove left over check for exactly two merged regions

add unit test

* use SortedMap type to emphasise that the Map is sorted.

* use regionCount consistently and checkstyle fixes

* Delete tests that expect multiregion merges to fail.

Signed-off-by: stack <stack@apache.org>
2019-08-29 12:27:33 -07:00
Sean Busbey 83e77940c5 HBASE-22943 Various procedures should not cache log trace level (#557)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-08-29 13:46:10 -05:00
Guanghao Zhang 56980fb097 Revert "HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush (#495)"
This reverts commit 0b3db5099c.
2019-08-28 11:21:29 +08:00
Aman Poonia 64f88906f7 HBASE-22872 Don't try to create normalization plan unnecesarily when split and merge both are disabled
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-08-28 10:50:09 +08:00
David Manning f2425c74a9
HBASE-22935 Fix false warn of stuck MonitoredRPCHandler MonitoredTask
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-08-27 17:49:56 -07:00
linkaline 3e2cfc1140 HBASE-22883 Duplacate codes of method Threads.newDaemonThreadFactory() and class DaemonThreadFactory (#537)
Signed-off-by: stack <stack@apache.org>
2019-08-27 15:27:22 -07:00
Jan Hentschel 5106f2826e
HBASE-22744 Removed deprecated status and load classes in client module
Signed-off-by: stack <stack@apache.org>
2019-08-27 19:46:08 +02:00
Istvan Toth c88267202a HBASE-22922 Lock all regions to be merged in case of multi region merge (#542)
* HBASE-22922 Lock all regions to be merged in case of multi region merge

* HBASE-22922 Lock all regions to be merged in case of multi region merge
 (addendum)

fix off-by-one error in patch
Signed-off-by: stack <stack@apache.org>
2019-08-26 21:09:18 -07:00
Bing Xiao 1ea5d8be9e HBASE-22894 Move testOpenRegionFailedMemoryLeak to dedicated class
Amending-Author: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-08-25 13:42:23 +08:00
Pankaj 00581ac911 HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init (#529)
* NPE occurs when RS send space quota usage report during HMaster init

* Added the debug log

 Signed-off-by: Sakthi <sakthi@apache.org>
 Signed-off-by: stack <stack@apache.org>
2019-08-24 20:56:20 -07:00
Pankaj ae107bdb96 HBASE-22806 Recreating a deleted column family brings back the deleted cells (#530)
Signed-off-by: stack <stack@apache.org>
2019-08-24 17:46:16 -07:00
Sakthi a12545380b
HBASE-22910 Enable TestMultiVersionConcurrencyControl (#531)
Signed-off-by: Stack <stack@apache.org>
2019-08-24 17:17:52 -07:00
Sakthi 554b2531ca
HBASE-22895 Fix the flakey TestSpaceQuotas (#526)
Break down TestSpaceQuotas(TSQ) into TSQBasicFunctioning, TSQDropTable, TSQIncrease, TSQOnBulkLoad, TSQOnNonExistingTables, TSQRemoval & TSQSwitchPolicies

Signed-off-by: Stack <stack@apache.org>
2019-08-24 02:42:15 -07:00
linkaline ee9d98611b HBASE-22881 Fix non-daemon threads in hbase server implementation (#512)
* address checkstyle issue

* change threadPool threads to daemon in server implementation

 Signed-off-by: Duo Zhang <zhangduo@apache.org>
 Signed-off-by: stack <stack@apache.org>
2019-08-23 17:36:58 -07:00
bsglz a95ee63a70 HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimestamp (#446)
Signed-off-by: Duo Zhang zhangduo@apache.org
Signed-off-by: stack stack@apache.org
2019-08-23 17:19:56 -07:00
Tai-Ying Lee f4ff480387
HBASE-20509 putting List in HashSet directly without using addAll function to improve performance
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-08-24 00:02:27 +02:00
Jan Hentschel 808f051b8a
HBASE-22755 Removed deprecated methods from Mutation
Signed-off-by: stack <stack@apache.org>
2019-08-23 20:56:19 +02:00
openinx 4268774de1
HBASE-22867 The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table (#513)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-08-22 19:42:01 +08:00
Sakthi b329bf0a57 Revert "HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas"
This reverts commit 7af5b30eca.
2019-08-21 23:54:25 -07:00
openinx 84ee378df1
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (addendum - use the old config key) (#517) 2019-08-22 11:33:51 +08:00
Viraj Jasani b8857ec010 HBASE-22863 Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) (#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-08-21 22:06:05 +08:00
shahrs87 61a3a9ffbb HBASE-22601 Misconfigured addition of peers leads to cluster shutdown. (#499)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-08-21 21:52:50 +08:00
shardul-cr7 7af5b30eca HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas
Signed-off-by: Sakthi <sakthi@apache.org>
2019-08-21 00:44:16 -07:00
Andrew Purtell ab28f9d8c7
Revert "HBASE-22823 Mark Canary as Public/Evolving"
This reverts commit edf6f68cb2.

See HBASE-22874
2019-08-20 09:46:37 -07:00
stack 67382809d3 HBASE-22882 TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey)
Addendum; just remove the test altogether

 Signed-off-by:  Nick Dimiduk <ndimiduk@apache.org>
2019-08-19 14:28:30 -07:00
stack 8e488ce9ef HBASE-22882 TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey) 2019-08-19 12:59:04 -07:00
Guanghao Zhang 0b3db5099c HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush (#495)
Signed-off-by: Peter Somogyi psomogyi@apache.org
Signed-off-by: stack stack@apache.org
2019-08-19 12:59:00 -07:00
satanson 7697d48cd7 HBASE-22870 reflection fails to access a private nested class
Signed-off-by Reid Chan <reidchan@apache.org>
2019-08-18 09:47:06 +08:00
Pierre Zemb 836f26976e HBASE-22618 added the possibility to load custom cost functions
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-08-17 15:25:52 -03:00
Duo Zhang 8cb531f207
HBASE-22871 Move the DirScanPool out and do not use static field (#504)
Signed-off-by: Zheng Hu <openinx@gmail.com>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-08-17 23:35:04 +08:00
Huon Wilson 43a0ec80fa HBASE-22841 Add more factory functions to TimeRange
These functions make it easier to possible to use
`org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange`
with more interesting ranges, without being forced to use the
deprecated constructors.

Signed-off-by: huzheng <openinx@gmail.com>
2019-08-17 09:41:34 +08:00
Daisuke Kobayashi 3eb602c7f7 HBASE-22860 Master's webui returns NPE/HTTP 500 under maintenance mode
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-08-16 10:33:38 +01:00
Guanghao Zhang 94af65163b
HBASE-22858 Add HBCK Report to master's header.jsp (#497)
Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
2019-08-16 01:34:40 -05:00
Itsuki Toyota 78f5d8ebb2 HBASE-22833 MultiRowRangeFilter should provide a method for creating… (#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters

* Delete superfluous comments

* Add description for MultiRowRangeFilter constructor

* Add null check for rowKeyPrefixes

* Fix checkstyle

Signed-off-by: huzheng <openinx@gmail.com>
2019-08-16 09:59:01 +08:00
meiyi 60971bee66
HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature (#485) 2019-08-16 09:38:39 +08:00
Caroline Zhou edf6f68cb2
HBASE-22823 Mark Canary as Public/Evolving
Signed-off-by: Xu Cang <xucang@apache.org>
2019-08-15 14:09:06 -07:00
openinx 8ffc45ab8b
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (#486) 2019-08-15 10:57:42 +08:00
Andrew Purtell 27ed2ac071
HBASE-22828 Log a region close journal (#471)
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2019-08-13 15:42:41 -07:00
Jan Hentschel 3867fae04d
HBASE-22829 Removed deprecated methods from SnapshotDescription
Signed-off-by: stack <stack@apache.org>
2019-08-12 08:41:05 +02:00
Jan Hentschel e9382154f3
HBASE-22830 Removed deprecated method from StoreFile
Signed-off-by: stack <stack@apache.org>
2019-08-12 01:06:15 +02:00
syedmurtazahassan 15c903b3f8 HBASE-22725 Remove all remaining Javadoc warnings
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-08-11 21:48:08 +02:00
Geoffrey Jacoby c8f57bf678 HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend (#390)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-08-09 14:27:32 -07:00
Daisuke Kobayashi 0136b9873f HBASE-22543 Revisit HBASE-21207 to make all values fully sortable
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-08-09 14:29:30 +01:00
Guanghao Zhang 989e09a2d5
HBASE-22824 Show filesystem path for the orphans regions on filesystem (#469)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-08-09 02:07:14 -05:00
Sakthi eb92b25652
HBASE-22803 Modify config value range to enable turning off of the hbck chore (#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-08-08 17:33:42 -07:00
Guanghao Zhang 9250977681
HBASE-22808 HBCK Report showed the offline regions which belong to disabled table (#465)
Signed-off-by: Stack <stack@apache.org>
2019-08-08 03:57:17 -05:00
meiyi 0e5dc6d7ce
HBASE-22776 Rename config names in user scan snapshot feature (#440) 2019-08-08 16:01:02 +08:00
Guanghao Zhang 547cec4078
HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem (#461)
Signed-off-by: Sakthi <sakthi@apache.org>
2019-08-07 19:17:26 -05:00
stack 1b168cd6de HBASE-22777 Add a multi-region merge (for fixing overlaps)
Makes MergeTableRegionsProcedure do more than just two regions at a
time. Compatible as MTRP was done considering one day it'd do more than
two at a time.

Changes hardcoded assumption that merge parent regions are named
mergeA and mergeB in a column on the resultant region. Instead
can have N columns on the merged region, one for each parent
merged. Column qualifiers all being with 'merge'.

Most of code below is undoing the assumption that there are two
parents on a merge only.
2019-08-07 15:22:07 -07:00
syedmurtazahassan 49839e4075 HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully… (#462)
Signed-off-by: Stack <stack@apache.org>
Signed-off-by: Sakthi <sakthi@apache.org>
2019-08-07 10:38:09 -07:00
Wellington Chevreuil a9773ec5e8 HBASE-22417 DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache
Signed-off-by: stack <stack@apache.org>
2019-08-07 12:06:12 +01:00
Andor Molnár 07c6bb16e7 HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke 2019-08-07 11:06:30 +02:00
Wellington Chevreuil 3b0013ded9 HBASE-22731 ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-08-06 16:08:04 +01:00
sreenivasulureddy eef8e140c5 HBASE-22793 RPC server connection is logging user as NULL principal
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Pankaj Kumar <pankaj.kr@huawei.com>
2019-08-06 14:40:21 +02:00
stack 08677143e8 HBASE-22771 [HBCK2] fixMeta method and server-side support
This is a first cut at this patch. Implements hold fixing only
currently.

Add a fixMeta method to Hbck Interface.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Bug fix. If hole is on end of last table, I wasn't seeing it.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
 Add a general meta fixer class. Explains up top why this stuff doesn't
 belong inside MetaTableAccessor.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 Break out the filesystem messing so don't have to copy it nor do more
 than is needed doing fixup for Region holes.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 Change behavious slightly. If directory exists, don't fail as we did
 but try and keep going and create .regioninfo file if missing (or
 overwrite if in place). This should make it idempotent. Can rerun
 command. Lets see if any repercussions in test suite.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaFixer.java
 Add test.

Signed-off-by: Zheng Hu <openinx@gmail.com>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-08-05 22:20:29 -07:00
stack 30805be078 HBASE-22771 [HBCK2] fixMeta method and server-side support
This is a first cut at this patch. Implements hold fixing only
currently.

Add a fixMeta method to Hbck Interface.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Bug fix. If hole is on end of last table, I wasn't seeing it.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
 Add a general meta fixer class. Explains up top why this stuff doesn't
 belong inside MetaTableAccessor.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 Break out the filesystem messing so don't have to copy it nor do more
 than is needed doing fixup for Region holes.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 Change behavious slightly. If directory exists, don't fail as we did
 but try and keep going and create .regioninfo file if missing (or
 overwrite if in place). This should make it idempotent. Can rerun
 command. Lets see if any repercussions in test suite.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaFixer.java
 Add test.

Signed-off-by: Zheng Hu <openinx@gmail.com>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-08-05 22:08:31 -07:00
Duo Zhang 66a2fc5d25
HBASE-22539 WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used (#437)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-08-05 16:19:05 +08:00
Wellington Chevreuil 237229cade HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
Signed-off-by: stack <stack@apache.org>
2019-08-01 16:49:57 +01:00
Guanghao Zhang 35acf3cb78
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck chore to run (#425)
Signed-off-by: stack <stack@apache.org>
2019-08-01 08:54:47 +08:00
Jan Hentschel 24b970ec51
Revert "HBASE-22744 Removed deprecated status and load classes in client module"
This reverts commit 4a61c8b10a.
2019-07-31 12:29:19 +02:00
Biju Nair 9a4a8ef274 HBASE-22363 Remove hardcoded number of read cache block buckets
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-31 09:13:17 +02:00
Jan Hentschel 586e177ded HBASE-22753 Removed deprecated ImmutableHRegionInfo (#420)
Signed-off-by: stack <stack@apache.org>
2019-07-31 08:07:31 +02:00
stack 373c2dc13f HBASE-22741 Show catalogjanitor consistency complaints in new 'HBCK Report' page
Signed-off-by: huzheng <openinx@gmail.com>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-30 11:16:45 -07:00
Jan Hentschel 4a61c8b10a
HBASE-22744 Removed deprecated status and load classes in client module
Signed-off-by: stack <stack@apache.org>
2019-07-30 12:40:42 +02:00
Jan Hentschel f9fd5b65fa HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor (#419)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: stack <stack@apache.org>
2019-07-30 12:32:10 +02:00
Jan Hentschel 46a432386e
HBASE-22746 Removed deprecated methods from Delete
Signed-off-by: stack <stack@apache.org>
2019-07-30 08:52:19 +02:00
openinx c286a31590
HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta (#424) 2019-07-30 14:16:08 +08:00
stack 0c80d5b42b HBASE-22723 Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
Refactor of CatalogJanitor so it generates a
Report on the state of hbase:meta when it runs. Also
refactor so CJ runs even if RIT (previous it would
punt on running if RIT) so it can generate a 'Report'
on the interval regardless. If RIT, it just doesn't
go on to do the merge/split GC as it used to.

If report finds an issue, dump as a WARN message
to the master log.

Follow-on is to make the Report actionable/available
for the Master to pull when it goes to draw the hbck
UI page (could also consider shipping the Report as
part of ClusterMetrics?)

Adds new, fatter Visitor to CJ, one that generates
Report on each run keeping around more findings as
it runs.

Moved some methods around so class reads better;
previous methods were randomly ordered in the class.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Make a few handy methods public.

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
 Add utility as defaults on the Inteface; i.e. is this the first region
 in table, is it last, does a passed region come next, or does passed
 region overlap this region (added tests for this new stuff).

M hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
 Bugfix... handle case where buffer passed is null.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Lots of change, reorg., but mostly adding consistency checking
 to the visitor used scanning hbase:meta on a period and the
 generation of a Report on what the scan has found traversing
 hbase:meta. Added a main so could try the CatalogJanitor against
 a running cluster.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java
 Fat ugly test for CatalogJanitor consistency checking.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
 Add tests for new functionality in RI.

M hbase-shell/src/main/ruby/hbase/table.rb
 Bug fix for case where meta has a null regioninfo; scan was aborting.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-29 16:00:57 -07:00
stack f68cda32e1 HBASE-22751 table.jsp fails if ugly regions in table 2019-07-29 09:38:46 -07:00
Venkatesh Sridharan 11f30de2cf HBASE-22313 Add method to FsDelegation token to accept token kind (#199)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-29 11:18:19 +02:00
Jan Hentschel e273d0bc3a
HBASE-22748 Removed deprecated methods from Put
Signed-off-by: stack <stack@apache.org>
2019-07-29 08:50:16 +02:00
meiyi 7294af8b15
HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table (#336) 2019-07-29 09:51:26 +08:00
Guanghao Zhang cf8114a82e
HBASE-22709 Add a chore thread in master to do hbck checking (#404)
Signed-off-by: stack <stack@apache.org>
2019-07-27 18:23:37 +08:00
Guanghao Zhang 1cb37f18aa
HBASE-22742 [HBCK2] Add more log for hbck operations at master side
Signed-off-by: stack <stack@apache.org>
2019-07-27 12:25:11 +08:00
stack fa77c75848 HBASE-22382 Refactor tests in TestFromClientSide; ADDENDUM to fix tests 2019-07-26 13:28:06 -07:00
linkaline 747d000808 HBASE-22733 TestSplitTransactionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor is flakey (#408)
Signed-off-by: stack <stack@apache.org>
2019-07-25 11:09:07 -07:00
Jan Hentschel e28afec9ec HBASE-22594 Clean up for backup examples (#315)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-25 13:35:44 +08:00
Jeongdae Kim a65e72d5da
HBASE-22715 All scan requests should be handled by scan handler threads in RWQueueRpcExecutor (#393)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
2019-07-24 11:57:04 -07:00
meiyi a399a1452b HBASE-22578 HFileCleaner should not delete empty ns/table directories used for user san snapshot feature (#337) 2019-07-24 15:14:56 +08:00
Andor Molnár 542ae47797 HBASE-22382 Refactor tests in TestFromClientSide (#385)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-24 14:08:45 +08:00
Guanghao Zhang 6705d4ffdf
HBASE-22721 Refactor HBaseFsck: move the inner class out
Signed-off-by: stack <stack@apache.org>
2019-07-24 08:02:41 +08:00
syedmurtazahassan d9493c539f HBASE-22603 Javadoc Warnings related to @link tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-23 14:14:12 +02:00
syedmurtazahassan 06f5c43de3 HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize
Signed-off-by: Reid Chan <reidchan@apache.org>
Co-authored-by: Reid Chan <reidchan@apache.org>
2019-07-23 11:27:02 +08:00
Reid Chan 0e34dcbf4b Revert "HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize"
Reason: Deprecated a wrong parameter.

This reverts commit fe450b50c1.
2019-07-23 11:04:13 +08:00
syedmurtazahassan fe450b50c1 HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize
* HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

* HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. Deprecated old attribute and introduced a new one

* HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. Removed unnecessary import

* HBASE-22610 added two import configs and removed one

Signed-off-by: Reid Chan <reidchan@apache.org>
2019-07-23 10:40:32 +08:00
Viraj Jasani 9615c644f5 HBASE-22648 Snapshot TTL (#371)
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-07-22 15:03:44 -07:00
Toshihiro Suzuki 7f68591767 HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+
Signed-off-by: stack <stack@apache.org>
2019-07-22 22:57:33 +09:00
openinx 00075ea4fc
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP (#365) 2019-07-20 23:30:08 +08:00
Geoffrey Jacoby 1ad48c1ebc
HBASE-22622 WALKey Extended Attributes (#352)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-07-19 15:30:38 -07:00
Guanghao 48c623c808
HBASE-22673 Avoid to expose protobuf stuff in Hbck interface
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-19 08:03:06 +08:00
sreenivasulureddy ed2d7e4110 HBASE-22537 Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-18 16:16:15 +01:00
Guanghao Zhang 254dbd07fb HBASE-22527 [hbck2] Add a master web ui to show the problematic regions (addendum) 2019-07-18 17:50:44 +08:00
linkaline e08ac5fafb HBASE-21426 TestEncryptionKeyRotation.testCFKeyRotation is flaky (#375)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-18 09:02:17 +08:00
Guanghao Zhang f0cbdf8beb HBASE-22527 [hbck2] Add a master web ui to show the problematic regions 2019-07-18 08:23:12 +08:00
Guanghao 2b7e33fe52
HBASE-22704 Avoid NPE when access table.jsp and snapshot.jsp but master not finish initialization (#389) 2019-07-18 08:20:36 +08:00
stack 82ea04dbab HBASE-7191 HBCK - Add offline create/fix hbase.version and hbase.id
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-17 07:50:41 -07:00
linkaline 9d5e5adaf0 HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared (#354) 2019-07-17 22:05:36 +08:00
Viraj Jasani cc38de1a39 HBASE-22643 : Delete region without archiving only if regiondir is present
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
2019-07-16 10:25:24 +01:00
Duo Zhang 8f56bee93b
HBASE-22684 The log rolling request maybe canceled immediately in LogRoller due to a race (#378)
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-15 21:35:06 +08:00
syedmurtazahassan 8defea9561 HBASE-22586 Javadoc Warnings related to @param tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 16:46:18 +02:00
Duo Zhang 032c18fbd0
HBASE-22681 The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL (#376)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-07-13 22:11:39 +08:00
syedmurtazahassan 9f343c2efa HBASE-22571 Javadoc Warnings related to @return tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 13:34:48 +02:00
Andrew Purtell 12d7db7078
HBASE-22686 ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of the split work it is capable of (#377)
Signed-off-by: Xu Cang <xcang@apache.org>
2019-07-12 18:10:15 -07:00
Viraj Jasani 9ac9505f2a HBASE-22606 BucketCache additional tests
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
2019-07-09 12:12:19 +01:00
Reid Chan 605f8a15bb HBASE-22656 [Metrics] Table metrics 'BatchPut' and 'BatchDelete' are never updated
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-07 23:21:21 +08:00
openinx ac4e52880b
HBASE-22582 The Compaction writer may access the lastCell whose memory has been released when appending fileInfo in the final (#341) 2019-07-04 14:27:21 +08:00
haxiaolin a4738e5184 HBASE-22403 Balance in RSGroup should consider throttling and a failure affects the whole
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-04 08:47:48 +08:00
Guanghao 64e732dc8b
HBASE-22624 Should sanity check table configuration when clone snapshot to a new table 2019-07-03 11:54:25 +08:00
Mate Szalay-Beko 62c7e73dc0 HBASE-22637 fix flaky test in TestMetaTableMetrics
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
2019-07-02 09:35:43 +02:00
syedmurtazahassan fabf2b8282 HBASE-22572 Javadoc Warnings: @link reference not found (#306)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: stack <stack@apache.org>
2019-07-01 21:15:00 -07:00
Bing Xiao 52eb893bcc HBASE-22169 Open region failed cause memory leak
Signed-off-by: stack <stack@apache.org>
2019-07-01 13:55:00 -07:00
Duo Zhang 94d5419efb
HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-06-27 21:54:53 +08:00
openinx 0198868531
HBASE-20060 Add details of off heap memstore into book. (#334) 2019-06-26 14:58:34 +08:00
Duo Zhang b42614295e
HBASE-22617 Recovered WAL directories not getting cleaned up (#330)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-06-25 16:21:24 +08:00
Andrew Purtell 15ac781057
HBASE-22616 responseTooXXX logging for Multi should characterize the component ops (#329)
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2019-06-24 18:03:17 -07:00
openinx 531d2902cb
HBASE-22612 Address the final overview reviewing comments of HBASE-21879 (#331) 2019-06-24 18:04:40 +08:00
meiyi c1e5350be7
HBASE-21995 Add a coprocessor to set HDFS ACL for hbase granted user 2019-06-24 10:40:38 +08:00