Commit Graph

19358 Commits

Author SHA1 Message Date
Andrew Purtell 9ba868d2ad HBASE-27087 TestQuotaThrottle times out
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 14:09:48 -07:00
Bryan Beaudreault 277058e18d
HBASE-27229 BucketCache statistics should not count evictions by hfile (#4639)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 16:59:57 -04:00
Duo Zhang 8b091c4061
HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone (#4634)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 23:42:37 +08:00
Bryan Beaudreault ebd189157e
HBASE-27225 Add BucketAllocator bucket size statistic logging (#4637)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-07-25 20:54:40 -04:00
Andrew Purtell ca545c4f98
HBASE-27235 Clean up error-prone warnings in hbase-hadoop-compat (#4648)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-25 17:30:15 -07:00
Ramón García Fernández e10c15d030
HBASE-27179 Issues building with OpenJDK 17 (#4594)
Fix test case failures in org.apache.hadoop.hbase.http.log.TestLogLevel under Openjdk 17 because of a missing export of java.security.jgss/sun.security.krb5.
Removed option --illegal-access=permit ignored since Openjdk 17.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-25 19:21:21 +08:00
Wellington Ramos Chevreuil d5ed8f59e5
HBASE-27232 Fix checking for encoded block size when deciding if bloc… (#4640)
Signed-off-by: Andor Molnár <andor@cloudera.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-25 11:17:16 +01:00
Andrew Purtell b1706a8a12
HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642)
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065c.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-24 23:06:31 -07:00
chenglei 0ae42ddaee
HBASE-27230 RegionServer should be aborted when WAL.sync throws Timeo… (#4641)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-24 15:08:03 +08:00
Duo Zhang 31fc97edee
HBASE-27075 TestUpdateRSGroupConfiguration.testCustomOnlineConfigChangeInRSGroup is flaky (#4636)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-07-21 14:26:52 +08:00
Duo Zhang 75a05b5cd0 Revert "HBASE-27152 Under compaction mark may leak (#4568)"
This reverts commit da27a67a1e.
2022-07-21 09:02:40 +08:00
Xiaolin Ha da27a67a1e
HBASE-27152 Under compaction mark may leak (#4568)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-20 08:49:10 +08:00
Minwoo Kang 075b3053cf
HBASE-27219 Change JONI encoding in RegexStringComparator (#4632)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 09:10:38 -07:00
Duo Zhang acf144717b HBASE-27220 Apply the spotless format change in HBASE-27208 to our code base
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 10:00:43 +08:00
Duo Zhang 7484a9163a
HBASE-27208 Use spotless to purge the missing summary warnings from error prone (#4628)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 09:45:06 +08:00
Andrew Purtell 745142adb1
HBASE-27195 Clean up netty worker/thread pool configuration (#4619)
The configuration settings "hbase.netty.worker.count" and
"hbase.netty.eventloop.rpcserver.thread.count" appear to duplicate each
other.

Also, formalizes another setting found in NettyEventLoopGroupConfig,
"hbase.netty.nativetransport".

Also, native epoll is not limited to amd64. aarch64 supports it too.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-18 15:48:40 -07:00
Andrew Purtell 5af4b3d5c8
HBASE-27202 Clean up error-prone findings in hbase-balancer (#4623)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-18 15:35:43 -07:00
Andrew Purtell b7117a443d
HBASE-27200 Clean up error-prone findings in hbase-archetypes (#4621)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-18 15:31:34 -07:00
Duo Zhang 9ab0b1504f
HBASE-27211 Data race in MonitoredTaskImpl could cause split wal failure (#4630)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-07-18 19:25:06 +08:00
SiCheng-Zheng ff8eb59709
HBASE-27144 Add special rpc handlers for bulkload operations (#4558)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-17 21:21:58 +08:00
Bryan Beaudreault 70a2ee1716
HBASE-27053 IOException during caching of uncompressed block to the block cache (#4610)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: wenwj0 <wenweijian2@huawei.com>
2022-07-16 17:30:55 -04:00
chenglei 02f26368e2
HBASE-27207 ConnectionUtils.allOf should be moved to FutureUtils (#4627)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-15 17:04:03 +08:00
Andrew Purtell 01b45e285d Amend HBASE-27194 Add test coverage for SimpleRpcServer (#4616)
When backporting to branch-2 it was discovered that the order of tear
down operations requires the KDC to be torn down first, although on
master branch the original code did not produce the same errors (a NPE
in KDC#stop). Forward port the difference for maintainability.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-13 11:23:07 -07:00
Andrew Purtell 84f0d145d7
HBASE-27194 Add test coverage for SimpleRpcServer (#4616)
Add test coverage for SimpleRpcServer.

Improve the way we test both SimpleRpcServer and NettyRpcServer. Use
LoadTestKVGenerator to generate random values with varying sizes between
1000 bytes and 1M bytes, and also to verify them when reading the values
back.

Add secure test coverage for both SimpleRpcServer and NettyRpcServer.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-13 09:28:30 -07:00
Andrew Purtell ef1641d277
HBASE-27088 IntegrationLoadTestCommonCrawl async load improvements (#4488)
* HBASE-27088 IntegrationLoadTestCommonCrawl async load improvements

- Use an async client and work stealing executor for parallelism during loads.
- Remove the verification read retries, these are not that effective during
  replication lag anyway.
- Increase max task attempts because S3 might throttle.
- Implement a side task that exercises Increments by extracting urls from
  content and updating a cf that tracks referrer counts. These are not
  validated at this time. It could be possible to log the increments, sum
  them with a reducer, and then verify the total, but this is left as a
  future exercise.

Signed-off-by: Viraj Jasani <vjasani@apache.org>

* Sum RPC time for writes (loader) and reads (verifier) and mutation bytes submitted. Expose as job counters.

* Fix an issue with completion chaining

* Pause loading if too many operations are in flight
2022-07-13 09:01:21 -07:00
Duo Zhang 2662607b71
HBASE-27193 TestZooKeeper is flaky (#4615)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2022-07-13 10:32:01 +08:00
Andrew Purtell 7cb7100de5
HBASE-27161 Improve TestMultiRespectsLimits (#4586)
TestMultiRespectLimits submits a put with an empty value. This appears
to not be what was intended. Instead, use a single byte.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-12 11:19:35 -07:00
Andrew Purtell ed32043da0
HBASE-27097 SimpleRpcServer is broken (#4613)
Replace BufferChain#write(channel,int) with a simpler #write(channel)
implementation that does not attempt to "chunk" data to be written. This
method was used exclusively by SimpleRpcServer. The code was unnecessarily
complex and caused short writes when values were large, so was corrected
and simplified. Any difference in performance from this change will be
limited to SimpleRpcServer. Testing under load confirms the fix and does
not show significant regression.

SimpleRpcServer and its related code is now also marked as @Deprecated.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-12 11:07:23 -07:00
Duo Zhang 648bb6d0eb
HBASE-27192 The retry number for TestSeparateClientZKCluster is too small (#4614)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
2022-07-12 19:08:41 +08:00
Bryan Beaudreault 886e31952f
HBASE-27149 Server should close scanner if client times out before results are ready (#4604)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 22:22:00 -04:00
Bryan Beaudreault 6e66e78177
HBASE-27188 Report maxStoreFileCount in jmx (#4609)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 22:11:58 -04:00
Bryan Beaudreault 779c4e2316
HBASE-27186 Report block cache size metrics separately for L1 and L2 (#4608)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 22:00:04 -04:00
Duo Zhang 5bc8670322
HBASE-27189 NettyServerRpcConnection is not properly closed when the netty channel is closed (#4611)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-12 09:40:19 +08:00
Jinhu Wu f3545cd73a
HBASE-27190 Add some docs about exporting and importing snapshots using Aliyun object storage service(OSS) (#4612)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-11 21:07:11 +08:00
Nick Dimiduk a238ed2785
HBASE-27182 Rework tracing configuration
* Take advantage of the fact that OpenTelemetry can read its configuration from environment
  variables and make use of this where possible, only falling back to passing properties into the
  process launch configuration when it's necessary. DRY up tracing configuration and make it
  easier to manage in a container environment.
* Replace `HBASE_TRACE_OPTS`, which used to act as both a feature flag and a baseline for
  configuration shared across processes. Instead, use `HBASE_OTEL_TRACING_ENABLED` as a feature
  flag, and let configuration reuse be handled via the environment variables that otel supports
  naively.
* Add further explanation for how to write your configuration for our different deployment
  modes (standalone, pseudo-distributed, fully distributed) and in different environments.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 14:37:05 +02:00
Norman Maurer 2197b3806b
HBASE-27180 Fix multiple possible buffer leaks (#4597)
* Fix multiple possible buffer leaks

Motivation:

When using ByteBuf you need to be very careful about releasing it as otherwise you might leak data. There were various places in the code-base where such a leak could happen.

Modifications:

- Fix possible buffer leaks
- Ensure we call touch(...) so its easier to debug buffer leaks

Result:

Fix buffer leaks

* Formatting

* Revert some changes as requested

* revert touch

* Also release checksum and header buffers

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-08 08:19:45 +08:00
Narasimha Sharma 22618dadfe
HBASE-18045 Added default SSH connection timeout in Integration tests (#4450) 2022-07-07 10:17:04 -07:00
Bryan Beaudreault 6886d02a91
HBASE-27078 Allow configuring a separate timeout for meta scans (#4557)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-07 10:02:14 -04:00
Duo Zhang 816e919e95
HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation (#4596)
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-07 15:55:26 +08:00
Duo Zhang 1643c45770 HBASE-27157 Addendum fix compile error after revert 2022-07-07 10:26:13 +08:00
Duo Zhang 0116aff9c0 Revert "HBASE-27157 Potential race condition in WorkerAssigner (#4577)"
This reverts commit f76d8554ca.
2022-07-07 08:36:21 +08:00
Ujjawal a31cc931fd
HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level (#4593)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-06 16:32:52 -07:00
Bryan Beaudreault b9706916cc
HBASE-27048 Server side scanner time limit should account for time in queue (#4562)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-06 11:57:37 -04:00
Nick Dimiduk 1b5adbecfc
HBASE-27172 Upgrade OpenTelemetry dependency to 1.15.0
- the agent jar dropped the `-all` classifier after 1.8.0

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-06 13:54:41 +02:00
wenwj0 ad13675db3
HBASE-27101 support commons-crypto version 1.1.0 (#4506)
Co-authored-by: wenwj0 <wenweijian2@huawei.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-06 18:57:15 +08:00
Duo Zhang 6f4a0476f2 HBASE-27148 Addendum uncomment the shutdown code in TestVerifyReplicationCrossDiffHdfs 2022-07-06 14:48:08 +08:00
Duo Zhang 41972cb460
HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-07-06 12:49:47 +08:00
Ruanhui f76d8554ca
HBASE-27157 Potential race condition in WorkerAssigner (#4577)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Lijin Bin <binlijin@apache.org>
2022-07-06 10:59:13 +08:00
tianhang 6031a3a8d4
HBASE-27171 Fix Annotation Error in HRegionFileSystem (#4588)
Co-authored-by: Tang Tianhang <tianhang.tang@shopee.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-06 10:58:34 +08:00
Bryan Beaudreault f3f292fad4
HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse (#4592)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-04 16:18:45 -04:00