Commit Graph

1292 Commits

Author SHA1 Message Date
Jonathan M Hsieh eeaea4aea3 HBASE-17224 Fix lots of spelling errors in HBase logging and exception messages (Grant Sohn) 2016-12-01 08:57:16 -08:00
zhangduo 540ede376b HBASE-16648 [JDK8] Use computeIfAbsent instead of get and putIfAbsent 2016-12-01 21:17:55 +08:00
John Leach 37d7b57128 HBASE-17216 Fields that can safetly be made static 2016-11-30 22:03:35 -08:00
Yu Li 1f3c6f4c07 HBASE-17114 Add an option to set special retry pause when encountering CallQueueTooBigException 2016-12-01 13:38:13 +08:00
Guanghao Zhang ea912478e2 HBASE-17178 Add region balance throttling
Signed-off-by: Phil Yang <yangzhe1991@apache.org>
2016-11-30 18:03:15 +08:00
Ramkrishna 7c43a23c07 HBASE-17012 Handle Offheap cells in CompressedKvEncoder (Ram) 2016-11-29 22:27:45 +05:30
Xiang Li 346e904a21 HBASE-17086: Add comments to explain why Cell#getTagsLength() returns an int, rather than a short
Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
2016-11-29 12:51:57 +05:30
anoopsamjohn bbb81a7ac3 HBASE-17183 Handle ByteBufferCell while making TagRewriteCell. 2016-11-28 16:47:25 +05:30
anoopsamjohn 030054bcce HBASE-17162 Avoid unconditional call to getXXXArray() in write path. 2016-11-26 12:49:01 +05:30
anoopsamjohn 3f7f1c1353 HBASE-17169 Remove Cell variants with ShareableMemory. 2016-11-26 12:20:06 +05:30
anoopsamjohn 86e17858f7 HBASE-15786 Create DBB backed MSLAB pool. 2016-11-24 20:47:41 +05:30
Jingcheng Du 92b494f117 HBASE-17157 Increase the default mergeable threshold for mob compaction 2016-11-22 17:39:10 +08:00
Jan Hentschel 3e9d1a19e2 HBASE-17129 Removed public from methods in DataType interface
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-11-21 14:34:43 -06:00
anoopsamjohn 549c8d835a HBASE-17139 Remove sweep tool related configs from hbase-default.xml. 2016-11-21 15:54:31 +05:30
anoopsamjohn af4e4b6450 HBASE-17126 Expose KeyValue#checkParameters() and checkForTagsLength() to be used by other Cell implementations. (Xiang Li) 2016-11-19 21:13:22 +05:30
anoopsamjohn c3685760f0 HBASE-15788 Use Offheap ByteBuffers from BufferPool to read RPC requests. 2016-11-14 23:05:05 +05:30
Michael Stack 0998af01df Revert "Revert "HBASE-16983 TestMultiTableSnapshotInputFormat failing with Unable to create region directory: /tmp/... (Addendum by Guanghao Zhang)""
This is a revert of a revert, i.e. puts back the change only I added
HBaseCommonTestingUtility#getRandomDir from branch-1 too since
missing in master branch.

This reverts commit 9afcb4366d.
2016-11-08 12:55:48 -08:00
Apekshit Sharma 52241c90e4 HBASE-16982 Better integrate Apache CLI in AbstractHBaseTool.
- processOldArgs() in AbstractHBaseTool will make it possible to change existing tools to use Apache CLI in a backward compatible manner.
- Changes ExportSnapshot tool as a proof-of-concept
- Update version of Apache CLI from 1.2 to 1.3.1

Change-Id: I4bb2e7da4f2ed0e12e28621ab16459309fa36d03
2016-11-08 12:21:29 -08:00
tedyu 76814e8451 HBASE-17010 Serial replication should handle daughter regions being assigned to another RS (Phil Yang) 2016-11-08 06:25:50 -08:00
Lars Hofhansl c12c6ffaec HBASE-16765 Amend: Make SteppingSplitPolicy the default. 2016-11-01 13:34:07 -07:00
zhangduo 6cf9333e97 HBASE-16945 Implement AsyncRegionLocator 2016-11-01 10:18:55 +08:00
anoopsamjohn ba6d952324 HBASE-16747 Track memstore data size and heap overhead separately. 2016-10-30 12:20:46 +05:30
zhangduo 6127753b65 HBASE-16891 Try copying to the Netty ByteBuf directly from the WALEdit 2016-10-29 23:30:52 +08:00
Ramkrishna 1eae9aeeac HBASE-16783 Use ByteBufferPool for the header and message during Rpc
response (Ram)
2016-10-26 14:33:49 +05:30
Ramkrishna 9875c699af HBASE-16880 Correct the javadoc/behaviour of the APIs in ByteBufferUtils
(Ram)
2016-10-25 10:52:57 +05:30
Ramkrishna 3584537b07 HBASE-16463 Improve transparent table/CF encryption with Commons Crypto
(Dapeng Sun)
2016-10-24 16:22:30 +05:30
Ramkrishna 0ae211eb39 HBASE-16414 Improve performance for RPC encryption with Apache Common
Crypto (Colin Ma)
2016-10-21 16:02:39 +05:30
Ramkrishna 1e3d8c8226 HBASE-16792 Reuse KeyValue.KeyOnlyKeyValue in
BufferedDataBlockEncoder.SeekerState (Binlijin)
2016-10-17 12:26:36 +05:30
Ramkrishna bda5fd5a11 HBASE-16792 - reverting to change commit message 2016-10-17 12:25:13 +05:30
Matteo Bertozzi 62c84115ec HBASE-16839 Procedure v2 - Move all protobuf handling to ProcedureUtil 2016-10-14 11:32:28 -07:00
zhangduo 3fe7508295 HBASE-15921 Add first AsyncTable impl and create TableImpl based on it 2016-10-14 22:52:52 +08:00
Ramkrishna 4127fd2a7c iHBASE-16792 Reuse KeyValue.KeyOnlyKeyValue in
BufferedDataBlockEncoder.SeekerState (Binlijin)
2016-10-14 17:52:24 +05:30
Ramkrishna 193e0d6024 revert HBASE-16792 due to test failures 2016-10-13 14:32:02 +05:30
Ramkrishna f11aa4542f HBASE-16792 Reuse KeyValue.KeyOnlyKeyValue in
BufferedDataBlockEncoder.SeekerState (Binlijin)
2016-10-13 10:11:27 +05:30
Ramkrishna b76b75142d HBASE-16784 Make use of ExtendedCell#write(OutputStream os) for the
default HFileWriter#append() (Ram)
2016-10-12 10:40:10 +05:30
anoopsamjohn f77ff9f96f HBASE-16809 Save one cell length calculation in HeapMemStoreLAB#copyCellInto. (binlijin) 2016-10-12 09:57:23 +05:30
Gary Helmling 7b0acc292e HBASE-16146 Remove thread local usage in Counter 2016-10-11 14:29:56 -07:00
anoopsamjohn 912ed17286 HBASE-15721 Optimization in cloning cells into MSLAB. 2016-10-06 14:48:03 +05:30
Ramkrishna 58e843dae2 HBASE-16372 References to previous cell in read path should be avoided
(Ram)
2016-10-06 14:19:12 +05:30
anoopsamjohn 6a9b57b395 HBASE-16760 Deprecate ByteString related methods in Bytes.java. 2016-10-05 11:19:37 +05:30
tedyu b952e64751 HBASE-15560 TinyLFU-based BlockCache - revert pending performance verification 2016-10-04 08:37:29 -07:00
tedyu 9e0c2562a9 HBASE-15560 TinyLFU-based BlockCache (Ben Manes) 2016-10-04 05:15:51 -07:00
stack 95c1dc93fb HBASE-15638 Shade protobuf
Which includes

    HBASE-16742 Add chapter for devs on how we do protobufs going forward

    HBASE-16741 Amend the generate protobufs out-of-band build step
    to include shade, pulling in protobuf source and a hook for patching protobuf

    Removed ByteStringer from hbase-protocol-shaded. Use the protobuf-3.1.0
    trick directly instead. Makes stuff cleaner. All under 'shaded' dir is
    now generated.

    HBASE-16567 Upgrade to protobuf-3.1.x
    Regenerate all protos in this module with protoc3.
    Redo ByteStringer to use new pb3.1.0 unsafebytesutil
    instead of HBaseZeroCopyByteString

    HBASE-16264 Figure how to deal with endpoints and shaded pb Shade our protobufs.
    Do it in a manner that makes it so we can still have in our API references to
    com.google.protobuf (and in REST). The c.g.p in API is for Coprocessor Endpoints (CPEP)

            This patch is Tactic #4 from Shading Doc attached to the referenced issue.
            Figuring an appoach took a while because we have Coprocessor Endpoints
            mixed in with the core of HBase that are tough to untangle (FIX).

            Tactic #4 (the fourth attempt at addressing this issue) is COPY all but
            the CPEP .proto files currently in hbase-protocol to a new module named
            hbase-protocol-shaded. Generate .protos again in the new location and
            then relocate/shade the generated files. Let CPEPs keep on with the
            old references at com.google.protobuf.* and
            org.apache.hadoop.hbase.protobuf.* but change the hbase core so all
            instead refer to the relocated files in their new location at
            org.apache.hadoop.hbase.shaded.com.google.protobuf.*.

            Let the new module also shade protobufs themselves and change hbase
            core to pick up this shaded protobuf rather than directly reference
            com.google.protobuf.

            This approach allows us to explicitly refer to either the shaded or
            non-shaded version of a protobuf class in any particular context (though
            usually context dictates one or the other). Core runs on shaded protobuf.
            CPEPs continue to use whatever is on the classpath with
            com.google.protobuf.* which is pb2.5.0 for the near future at least.

            See above cited doc for follow-ons and downsides. In short, IDEs will complain
            about not being able to find the shaded protobufs since shading happens at package
            time; will fix by checking in all generated classes and relocated protobuf in
            a follow-on. Also, CPEPs currently suffer an extra-copy as marshalled from
            non-shaded to shaded. To fix. Finally, our .protos are duplicated; once
            shaded, and once not. Pain, but how else to reveal our protos to CPEPs or
            C++ client that wants to talk with HBase AND shade protobuf.

            Details:

            Add a new hbase-protocol-shaded module. It is a copy of hbase-protocol
    i       with all relocated offset from o.a.h.h. to o.a.h.h.shaded. The new module
            also includes the relocated pb. It does not include CPEPs. They stay in
            their old location.

            Add another module hbase-endpoint which has in it all the endpoints
            that ship as part of hbase -- at least the ones that are not
            entangled with core such as AccessControl and Auth. Move all protos
            for these CPEPs here as well as their unit tests (mostly moving a
            bunch of stuff out of hbase-server module)

            Much of the change looks like this:

                 -import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
                 -import org.apache.hadoop.hbase.protobuf.generated.ClusterIdProtos;
                 +import org.apache.hadoop.hbase.protobuf.shaded.ProtobufUtil;
                 +import org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterIdProtos;

            In HTable and in HBaseAdmin, regularize the way Callables are used and also hide
            protobuf usage as much as possible moving it up into Callable super classes or out
            to utility classes. Still TODO is adding in of retries, etc., but can wait on
            procedure which will redo all this.

            Also in HTable and HBaseAdmin as well as in HRegionServer and Server, be explicit
            when using non-shaded protobuf. Do the full-path so it is clear. This is around
            endpoint coprocessors registration of services and execution of CPEP methods.

            Shrunk ProtobufUtil by moving methods used by one CPEP only back to the CPEP either
            into Client class or as new Util class; e.g. AccessControlUtil.

            There are actually two versions of ProtobufUtil now; a shaded one and a subset
            that is used by CPEPs doing non-shaded work.

            Made it so hbase-common no longer depends on hbase-protocol (with Matteo's help)

            R*Converter classes got moved down under shaded package -- they are for internal
            use only. There are no non-shaded versions of these classes.

            D hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable
            D RetryingCallableBase
             Not used anymore and we have too many tiers of Callables so removed/cleaned-up.

            A ClientServicecallable
             Had to add this one. RegionServerCallable was made generic so it could be used
             for a few Interfaces (Client and Admin). Then added ClientServiceCallable to
             implement RegionServerCallable with the Client Interface.
2016-10-03 21:37:32 -07:00
anoopsamjohn b644e0fb8d HBASE-16134 Introduce Cell extension for server side. 2016-09-27 22:55:45 +05:30
anoopsamjohn 43f47a8e73 HBASE-16704 Scan will be broken while working with DBE and KeyValueCodecWithTags. 2016-09-26 22:32:24 +05:30
tedyu 3896d9ed0a HBASE-16692 Make ByteBufferUtils#equals safer and correct (binlijin) 2016-09-25 06:37:40 -07:00
chenheng 21969f5159 HBASE-16665 Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy 2016-09-25 14:06:55 +08:00
Jerry He 50b051ade1 HBASE-16257 Move staging dir to be under hbase root dir 2016-09-23 10:07:58 -07:00
Jonathan M Hsieh c9d0d11e18 HBASE-12088 Addendum - fix spacing 2016-09-21 20:59:42 -07:00
Jonathan M Hsieh a90d433a2c HBASE-12088 Remove unused hadoop-1.0, hadoop-1.1 profiles from non-root poms 2016-09-21 20:45:03 -07:00
tedyu 6624c676fe HBASE-16658 Optimize UTF8 string/byte conversions (binlijin) 2016-09-20 13:08:04 -07:00
zhangduo 6eb6225456 HBASE-7612 [JDK8] Replace use of high-scale-lib counters with intrinsic facilities 2016-09-19 13:37:24 +08:00
Jerry He edc0ef3fe4 HBASE-16598 Enable zookeeper useMulti always and clean up in HBase code 2016-09-17 16:51:26 -07:00
Phil Yang 8ef6c76344 HBASE-16388 Prevent client threads being blocked by only one slow region server
Signed-off-by: stack <stack@apache.org>
2016-09-14 09:08:20 -07:00
tedyu 981200bf13 HBASE-16612 Use array to cache Types for KeyValue.Type.codeToType (Phil Yang) 2016-09-13 09:54:27 -07:00
anoopsamjohn 77b327320a HBASE-16229 Cleaning up size and heapSize calculation. 2016-09-12 23:23:38 -07:00
tedyu 8855670cd7 HBASE-16616 Rpc handlers stuck on ThreadLocalMap.expungeStaleEntry (Tomu Tsuruhara) 2016-09-12 15:49:23 -07:00
tedyu 8290b2c8fa HBASE-16609 Fake cells EmptyByteBufferedCell created in read path not implementing SettableSequenceId (Yu Sun) 2016-09-12 08:53:22 -07:00
binlijin fc224ed0ed HBASE-16530 Reduce DBE code duplication
Signed-off-by: Yu Li <liyu@apache.org>
2016-09-08 13:48:27 +08:00
Andrew Purtell 520c3cc4e9 Amend HBASE-16538 Changes the way version information is stored during build
Generated Version class needs an interface audience annotation
2016-09-02 19:54:05 -07:00
Apekshit Sharma 2fcc691b16 HBASE-16538 Changes the way version information is stored during build.
Instead of writing package-info.java with VersionAnnotation, saveVersion.sh now writes Version.java with static members.

Change-Id: I009f440fa049f409e10cb3f1c3afb483bc2aa876
2016-09-02 16:06:41 -07:00
tedyu 7b95ac117d HBASE-16502 Reduce garbage in BufferedDataBlockEncoder - addendum adopts Hiroshi's suggestion (binlijin) 2016-08-30 18:04:34 -07:00
Matteo Bertozzi af33f94513 HBASE-16522 Procedure v2 - Cache system user and avoid IOException 2016-08-30 15:39:49 -07:00
Apekshit Sharma c66bb48ce8 HBASE-16101 Tool to microbenchmark procedure WAL performance.
Change-Id: I8ec158319395d2ec8e36641a3beab2694f7b6aef
2016-08-30 13:31:58 -07:00
Matteo Bertozzi 2acd788dce HBASE-16082 Procedure v2 - Move out helpers from MasterProcedureScheduler 2016-08-30 09:44:35 -07:00
Matteo Bertozzi 1b9af2a2fa HBASE-16508 Move UnexpectedStateException to common 2016-08-26 16:40:30 -07:00
anoopsamjohn e0aee7c74f Revert "HBASE-14882 Provide a Put API that adds the provided family, qualifier, value without copying. (Xiang Li)"
This reverts commit a63ba09c99.
2016-08-26 18:01:59 +05:30
anoopsamjohn a63ba09c99 HBASE-14882 Provide a Put API that adds the provided family, qualifier, value without copying. (Xiang Li) 2016-08-26 17:59:48 +05:30
anoopsamjohn 0d99e827b2 HBASE-16213 A new HFileBlock structure for fast random get. (binlijin) 2016-08-26 10:50:36 +05:30
tedyu b1ee8a88c3 HBASE-16502 Reduce garbage in BufferedDataBlockEncoder (binlijin) 2016-08-25 20:35:30 -07:00
anoopsamjohn 32c21f4594 HBASE-14921 In-Memory MemStore Flush and Compaction : Memory optimizations. (Anastasia) 2016-08-24 09:25:21 +05:30
Ramkrishna 2f7b9b5423 HBASE-16444 - Remove white space 2016-08-23 12:32:26 +05:30
Ramkrishna 2aae923c32 HBASE-16444 CellUtil#estimatedSerializedSizeOfKey() should consider
KEY_INFRASTRUCTURE_SIZ (Ram)
2016-08-23 10:53:33 +05:30
Apekshit Sharma ae42a934d8 HBASE-16467 Move AbstractHBaseTool to hbase-common.
Change-Id: I64775f875f6900520e66c22c007704a067e8c2a4
2016-08-22 16:06:17 -07:00
anoopsamjohn 5f61f9cc5c HBASE-16405 Change read path Bloom check to work with Cells with out any copy. 2016-08-19 11:25:35 +05:30
Matteo Bertozzi e637a61e26 HBASE-16378 Procedure v2 - Make ProcedureException extend HBaseException 2016-08-17 14:31:08 -07:00
Ramkrishna 285e104176 HBASE-15554 - StoreFile$Writer.appendGeneralBloomFilter generates extra KV
(Ram)
2016-08-12 10:21:41 +05:30
stack 7e32510513 HBASE-16363 Correct javadoc for qualifier length and value (Xiang Li) 2016-08-10 17:53:13 -07:00
stack 45bb6180a3 REVERT of revert of "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This is a revert of a revert; i.e. we are adding back the change only adding
back with fixes for the broken unit test; was a real issue on a test that
went in just at same time as this commit; I was getting a new nonce on each
retry rather than getting one for the mutation.

Other changes since revert are more hiding of RpcController. Use
accessor method rather than always pass in a RpcController

Walked back retrying operations that used to be single-shot (though
code comment said need a retry) because it opens a can of worms where
we retry stuff like bad column family when we shouldn't (needs
work adding in DoNotRetryIOEs)

Changed name of class from PayloadCarryingServerCallable to
CancellableRegionServerCallable.

Fix javadoc and findbugs warnings.

Fix case of not initializing the ScannerCallable RpcController.

Below is original commit message:

 Remove mention of ServiceException and other protobuf classes from all over the codebase.
 Purge TimeLimitedRpcController. Lets just have one override of RpcController.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup
    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.
    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added
2016-08-10 10:12:06 -07:00
Phil Yang 5cadcd59aa HBASE-9465 Push entries to peer clusters serially
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-09 15:25:50 +08:00
Vivek 30d7eeaefe HBASE-15866 Split hbase.rpc.timeout into *.read.timeout and *.write.timeout
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
2016-08-06 16:55:09 -07:00
stack 0206dc67d6 Revert "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This reverts commit ed87a81b4b.
2016-08-05 15:18:48 -07:00
stack ed87a81b4b HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base.
Purge ServiceException from Callable subclasses by pushing SE handling
up into the parent Callable class (varies by context but this is basic
patten). Allows us remove a bunch of boilerplate.
Do this in the public facing classes in particular (though if
an API has SE in it -- which a few do, this patch leaves these
untouched -- for now.) Make it so HBaseAdmin and HTable have no
direct pb imports (except for endpoint processor API).

Change a few of the HBaseAdmin calls to be retrying where comments
ask that we do retry rather than one time.

Purge TimeLimitedRpcController. Lets just have one override of RpcController.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup

    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.

    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added

Signed-off-by: stack <stack@apache.org>
2016-08-05 10:13:58 -07:00
Sean Busbey 60b79e2daa HBASE-16321 ensure no findbugs-jsr305
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-08-05 10:16:29 -05:00
zhangduo b35cf8f93a HBASE-16225 Refactor ScanQueryMatcher 2016-08-02 14:01:28 +08:00
stack c29024c017 HBASE-16256 Purpose of EnvironmentEdge, EnvironmentEdgeManager (Sai Teja Ranuva) 2016-07-29 16:34:22 -07:00
anoopsjohn 00c2a5da7b HBASE-16286 When TagRewriteCell are not copied to MSLAB, deep clone it while adding to Memstore. 2016-07-27 22:29:26 +05:30
zhangduo bcf409e11f HBASE-16280 Use hash based map in SequenceIdAccounting 2016-07-26 11:31:32 +08:00
anoopsjohn 2df0ef549a HBASE-16205 When Cells are not copied to MSLAB, deep clone it while adding to Memstore. 2016-07-25 22:58:32 +05:30
Matteo Bertozzi cc766df28b HBASE-16272 Overflow in ServerName's compareTo method (Huaxiang Sun) 2016-07-22 15:28:04 -07:00
Jerry He 70f330dc84 Consolidate SecureBulkLoadEndpoint into HBase core as default for bulk load 2016-07-19 19:53:10 -07:00
Jerry He 632969787a HBASE-14548 Expand how table coprocessor jar and dependency path can be specified (Xiang Li) 2016-07-09 18:01:49 -07:00
stack 496fd9837a HBASE-16176 Bug fixes/improvements on HBASE-15650 Remove
TimeRangeTracker as point of contention when many threads reading a StoreFile
 Fixes HBASE-16074 ITBLL fails, reports lost big or tiny families broken
 scanning because of a side effect of a clean up in  HBASE-15650 to make
 TimeRange construction consistent exposed a latent issue in
 TimeRange#compare. See HBASE-16074 for more detail.

Also change HFile Writer constructor so we pass in the TimeRangeTracker, if one,
on construction rather than set later (the flag and reference were not volatile
so could have made for issues in concurrent case). And make sure the construction
of a TimeRange from a TimeRangeTracer on open of an HFile Reader never makes a
bad minimum value, one that would preclude us reading any values from a file
(set min to 0)

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
 Call through to next constructor (if minStamp was 0, we'd skip setting
 allTime=true). Add asserts that timestamps are not < 0 cos it messes
 us up if they are (we already were checking for < 0 on construction but
 assert passed in timestamps are not < 0).

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
 Add constructor override that takes a TimeRangeTracker (set when flushing
 but not when compacting)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
 Add override creating an HFile in tmp that takes a TimeRangeTracker

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
 Add override for HFile Writer that takes a TimeRangeTracker Take it on
 construction instead of having it passed by a setter later (flags and
 reference set by the setter were not volatile... could have been prob
 in concurrent case)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
 Log WARN if bad initial TimeRange value (and then 'fix' it)

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTimeRangeTracker.java
 A few tests to prove serialization works as expected and that we'll get a bad min if not constructed properly.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
 Handle OLDEST_TIMESTAMP explictly. Don't expect TimeRange to do it.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
 Refactor from junit3 to junit4 and add test for this weird case.
2016-07-08 18:20:31 -07:00
Andrew Purtell 318751cfd6 HBASE-16091 Canary takes lot more time when there are delete markers in the table (Vishal Khandelwal) 2016-07-05 11:13:48 -07:00
stack d1d8cc71c9 HBASE-16150 Remove ConcurrentIndex (Hiroshi Ikeda) 2016-06-30 15:03:32 -07:00
tedyu 6fb0dd07a8 HBASE-16139 Use CellUtil instead of KeyValueUtil in Import (NIDHI GAMBHIR) 2016-06-29 02:45:00 -07:00
chenheng 68c1b34dbc HBASE-16040 Remove configuration "hbase.replication" 2016-06-24 10:41:35 +08:00
Elliott Clark 65a8d77433 HBASE-16061 Allow logging to a buffered console 2016-06-17 17:06:12 -07:00
Ashu Pachauri 3abd52bdc6 HBASE-15429 Add split policy for busy regions
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-16 17:36:54 -07:00
Enis Soztutar bff35d6387 HBASE-15950 Fix memstore size estimates to be more tighter 2016-06-15 13:34:39 -07:00
anoopsjohn 17bcf14fea HBASE-15525 OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts. 2016-06-14 19:03:54 +05:30
Matteo Bertozzi d9463bcce0 HBASE-15989 Remove hbase.online.schema.update.enable 2016-06-08 13:09:31 -07:00
Ramkrishna b21c56e795 HBASE-15174 Client Public API should not have PB objects in 2.0 (Ram) 2016-06-06 10:11:38 +05:30
Lars Hofhansl fc890a2ecb HBASE-15881 Allow BZIP2 compression. 2016-06-02 12:19:02 -07:00
Apekshit 1a27278624 HBASE-15915 Set timeouts on hanging tests. Tests run: 8, Time elapsed: 94.191 sec - in org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures Tests run: 103, Time elapsed: 69.057 sec - in org.apache.hadoop.hbase.regionserver.TestHRegion Tests run: 103, Time elapsed: 67.957 sec - in org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush Tests run: 5, Time elapsed: 34.629 sec - in org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster Tests run: 9, Time elapsed: 82.913 sec - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient Tests run: 9, Time elapsed: 80.458 sec - in org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient (Apekshit)
Change-Id: Ia7b986ca6276ff5498f588c0b1b9c570e2a9d798

Signed-off-by: stack <stack@apache.org>
2016-05-30 21:13:55 -07:00
Youngjoon Kim 47176049f8 HBASE-15897 Fix a wrong comment about QOS order
Signed-off-by: stack <stack@apache.org>
2016-05-29 14:35:35 -07:00
Sean Mackrory f4470af95d HBASE-15891. Closeable resources potentially not getting closed if exception is thrown.
Signed-off-by: stack <stack@apache.org>
2016-05-28 21:32:22 -07:00
Sean Mackrory 3b6e6e6c25 HBASE-15889. String case conversions are locale-sensitive, used without locale
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-28 10:41:31 -07:00
tedyu 838c306c0a HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig) 2016-05-17 11:01:26 -07:00
Sean Busbey e0aff10901 HBASE-15780 Make AuthUtil public and rely on it for talking to secure HBase.
Signed-off-by: Gary Helmling <garyh@apache.org>
Signed-off-by: Mikhail Antonov <antonov@apache.org>
Signed-off-by: stack <stack@apache.org>
2016-05-16 00:50:14 -05:00
anoopsjohn c9ebcd4e29 HBASE-15785 Unnecessary lock in ByteBufferArray. 2016-05-11 15:56:41 +05:30
Jonathan M Hsieh 541d1da5fe HBASE-15791 Improve javadoc around ScheduledChore 2016-05-09 08:41:28 -07:00
Ramkrishna 97ad33c691 HBASE-15609 Remove PB references from Result, DoubleColumnInterpreter and
any such public facing class for 2.0 (Ram)
2016-05-09 14:56:00 +05:30
Junegunn Choi 0e37063345 HBASE-15528 Clean up outdated entries in hbase-default.xml
Signed-off-by: Enis Soztutar <enis@apache.org>
2016-05-03 19:09:19 -07:00
anoopsjohn d1130582d5 HBASE-15735 Tightening of the CP contract. 2016-05-02 09:48:51 +05:30
anoopsjohn 4706303186 HBASE-15706 HFilePrettyPrinter should print out nicely formatted tags. (huaxiang sun) 2016-04-29 09:23:57 +05:30
tedyu 8a28c23431 HBASE-15686 Add override mechanism for the exempt classes when dynamically loading table coprocessor 2016-04-28 09:19:12 -07:00
Phil Yang 53d7316075 HBASE-15645 hbase.rpc.timeout is not used in operations of HTable
Signed-off-by: stack <stack@apache.org>
2016-04-26 10:51:29 -07:00
Enis Soztutar 9ba9cdeb47 HBASE-15683 Min latency in latency histograms are emitted as Long.MAX_VALUE 2016-04-21 10:44:03 -07:00
stack d815211f5a HBASE-15650 Remove TimeRangeTracker as point of contention when many threads reading a StoreFile
Refactor so we use the immutable, unsynchronized TimeRange when doing
    time-based checks at read time rather than use heavily synchronized
    TimeRangeTracker; let TimeRangeTracker be for write-time only.

    While in here, changed the Segment stuff so that when an immutable
    segment, it uses TimeRange rather than TimeRangeTracker too.

    M hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
      Make allTime final.
      Add a includesTimeRange method copied from TimeRangeTracker.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
      Change name of a few methods so they match TimeRange methods that do
      same thing.
      (getTimeRangeTracker, getTimeRange, toTimeRange) add utility methods

    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java
      Change ImmutableSegment so it uses a TimeRange rather than
      TimeRangeTracker.. it is read-only. Redo shouldSeek, getMinTimestamp,
      updateMetaInfo, and getTimeRangeTracker so we use TimeRange-based
      implementations instead of TimeRangeTracker implementations.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MutableSegment.java
      Implement shouldSeek, getMinTimestamp, updateMetaInfo, and
      getTimeRangeTracker using TimeRangeTracker.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java
      Make methods that were using TimeRangeTracker abstract and instead
      have the implementations do these methods how they want either using
      TimeRangeTracker when a mutable segment or TimeRange when an immutable
      segment.

    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
      Change Reader to use TimeRange-based checks instead of
      TimeRangeTracker.

    Signed-off-by: stack <stack@apache.org>
2016-04-15 10:13:42 -07:00
tedyu 6930da781b HBASE-15187 Integrate CSRF prevention filter to REST gateway 2016-04-15 09:38:31 -07:00
tedyu ff9c92e168 HBASE-14985 TimeRange constructors should set allTime when appropriate (Geoffrey Jacoby) 2016-04-11 16:59:45 -07:00
Junegunn Choi ff6a339582 HBASE-15569 Make Bytes.toStringBinary faster
Signed-off-by: stack <stack@apache.org>
2016-03-31 21:23:44 -07:00
stack d7a4499dfc HBASE-15392 Single Cell Get reads two HFileBlocks
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
moreRowsMayExistAfterCell Exploit the fact a Scan is a Get Scan. Also save compares
if no non-default stopRow.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
optimize Add doc on what is being optimized. Also, if a Get Scan, do not
optimize else we'll keep going after our row is DONE.
Another place to make use of the Get Scan fact is when we are DONE.. if
Get Scan, we can close out the scan.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
Add tests for Get Scans and optimize around block loading.
2016-03-23 14:37:14 -07:00
anoopsjohn cadfb21f4b HBASE-15064 BufferUnderflowException after last Cell fetched from an HFile Block served from L2 offheap cache - Addendum. 2016-03-23 15:03:50 +05:30
stack 12f66e3060 HBASE-15477 Purge 'next block header' from cached blocks
When we read from HDFS, we overread to pick up the next blocks header.
Doing this saves a seek as we move through the hfile; we save having to
do an explicit seek just to read the block header every time we need to
read the body.  We used to read in the next header as part of the
current blocks buffer. This buffer was then what got persisted to
blockcache; so we were over-persisting: our block plus the next blocks'
header (33 bytes).

This patch undoes this over-persisting.

Removes support for version 1 blocks (0.2 was added in hbase-0.92.0).
Not needed any more.

There is an open question on whether checksums should be persisted
when caching. The code seems to say no but if cache is SSD backed or
backed by anything that does not do error correction, we'll want
checksums.

Adds loads of documentation.

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockType.java
  (write) Add writing from a ByteBuff.

M hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
  (toString) Add one so ByteBuff looks like ByteBuffer when you click on
  it in IDE

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
  Remove support for version 1 blocks.

  Cleaned up handling of metadata added when we serialize a block to
  caches. Metadata is smaller now.

  When we serialize (used when caching), do not persist the next blocks
  header if present.

  Removed a bunch of methods, a few of which had overlapping
  functionality and others that exposed too much of our internals.
  Also removed a bunch of constructors and unified the constructors we
  had left over making them share a common init method.
  Shutdown access to defines that should only be used internally here.

  Renamed all to do w/ 'EXTRA' and 'extraSerialization' to instead talk
  about metadata saved to caches; was unclear previously what EXTRA was
  about.

  Renamed static final declarations as all uppercase.

  (readBlockDataInternal): Redid. Couldn't make sense of it previously.
  Undid heavy-duty parse of header by constructing HFileBlock. Other
  cleanups. Its 1/3rd the length it used to be. More to do in here.
2016-03-22 18:45:17 -07:00
stack a13d6e000d Revert "HBASE-15392 Single Cell Get reads two HFileBlocks M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java moreRowsMayExistAfterCell Exploit the fact a Scan is a Get Scan. Also save compares if no non-default stopRow."
Revert mistaken commit

This reverts commit 7073f69993.
2016-03-22 18:39:22 -07:00
stack 54a543de22 Revert "HBASE-15477 Purge 'next block header' from cached blocks"
Overcommit. Revert to fix.

This reverts commit 000117ad9f.
2016-03-22 18:37:25 -07:00
stack 000117ad9f HBASE-15477 Purge 'next block header' from cached blocks
When we read from HDFS, we overread to pick up the next blocks header.
Doing this saves a seek as we move through the hfile; we save having to
do an explicit seek just to read the block header every time we need to
read the body.  We used to read in the next header as part of the
current blocks buffer. This buffer was then what got persisted to
blockcache; so we were over-persisting: our block plus the next blocks'
header (33 bytes).

This patch undoes this over-persisting.

Removes support for version 1 blocks (0.2 was added in hbase-0.92.0).
Not needed any more.

There is an open question on whether checksums should be persisted
when caching. The code seems to say no but if cache is SSD backed or
backed by anything that does not do error correction, we'll want
checksums.

Adds loads of documentation.

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockType.java
  (write) Add writing from a ByteBuff.

M hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
  (toString) Add one so ByteBuff looks like ByteBuffer when you click on
  it in IDE

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
  Remove support for version 1 blocks.

  Cleaned up handling of metadata added when we serialize a block to
  caches. Metadata is smaller now.

  When we serialize (used when caching), do not persist the next blocks
  header if present.

  Removed a bunch of methods, a few of which had overlapping
  functionality and others that exposed too much of our internals.
  Also removed a bunch of constructors and unified the constructors we
  had left over making them share a common init method.
  Shutdown access to defines that should only be used internally here.

  Renamed all to do w/ 'EXTRA' and 'extraSerialization' to instead talk
  about metadata saved to caches; was unclear previously what EXTRA was
  about.

  Renamed static final declarations as all uppercase.

  (readBlockDataInternal): Redid. Couldn't make sense of it previously.
  Undid heavy-duty parse of header by constructing HFileBlock. Other
  cleanups. Its 1/3rd the length it used to be. More to do in here.
2016-03-22 13:42:38 -07:00
stack 7073f69993 HBASE-15392 Single Cell Get reads two HFileBlocks M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java moreRowsMayExistAfterCell Exploit the fact a Scan is a Get Scan. Also save compares if no non-default stopRow.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
optimize Add doc on what is being optimized. Also, if a Get Scan, do not
optimize else we'll keep going after our row is DONE.
Another place to make use of the Get Scan fact is when we are DONE.. if
Get Scan, we can close out the scan.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
Add tests for Get Scans and optimize around block loading.
2016-03-22 13:00:41 -07:00
Elliott Clark 75252af3a9 HBASE-15460 Fix infer issues in hbase-common
Summary: Fix issues found by static analysis

Test Plan: Unit test pass

Differential Revision: https://reviews.facebook.net/D55551
2016-03-21 11:51:50 -07:00
tedyu fbf58f330b HBASE-15325 ResultScanner allowing partial result will miss the rest of the row if the region is moved between two rpc requests (Phil Yang) 2016-03-17 11:03:29 -07:00
Enis Soztutar ca816f0780 HBASE-6721 RegionServer Group based Assignment (Francis Liu) 2016-03-14 18:28:50 -07:00
tedyu 122e6f5793 HBASE-15439 getMaximumAllowedTimeBetweenRuns in ScheduledChore ignores the TimeUnit (Jingcheng Du) 2016-03-14 07:09:58 -07:00
anoopsjohn 88ca84f685 HBASE-15379 Fake cells created in read path not implementing SettableSequenceId. (Amal Joshy) 2016-03-13 22:05:05 +05:30
Andrew Purtell b6b9910e2c Amend HBASE-15322 Operations using Unsafe path broken for platforms not having sun.misc.Unsafe
"Object cannot be cast to boolean" in UnsafeAvailChecker
2016-03-11 17:39:52 -08:00
anoopsjohn eea8b38dfa HBASE-15180 Reduce garbage created while reading Cells from Codec Decoder. 2016-03-11 13:58:41 +05:30
anoopsjohn 6628d2df11 HBASE-15322 Operations using Unsafe path broken for platforms not having sun.misc.Unsafe. 2016-03-11 09:37:00 +05:30
Matteo Bertozzi 9e967e5c1d HBASE-15113 Procedure v2 - Speedup eviction of sys operation results 2016-03-08 19:47:15 -08:00
Stephen Yuan Jiang 1c6beb3dc1 HBASE-15413 Procedure-V2: print out ProcedureInfo during trace (Stephen Yuan Jiang) 2016-03-07 20:28:45 -08:00
Jonathan M Hsieh f658f3ef83 HBASE-15356 Remove unused imports (Youngjoon Kim) 2016-03-03 11:42:38 -08:00
stack 8ace5bbfce HBASE-15366 Add doc, trace-level logging, and test around hfileblock
M hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
 Make it emit its toString in format that matches the way we log
 elsewhere

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
 Capitalize statics.

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
 Verify and cleanup documentation of hfileblock format at head of class.
 Explain what 'EXTRA_SERIALIZATION_SPACE' is all about.
 Connect how we serialize and deserialize... done in different places
 and one way when pulling from HDFS and another when pulling from cache
 (TO BE FIXED). Shut down a load of public access.

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
 Add trace-level logging

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
 Make it Closeable
2016-03-03 09:16:30 -08:00
zhangduo 69e442efe4 HBASE-15365 Do not write to '/tmp' in TestHBaseConfiguration 2016-03-02 11:05:36 +08:00
stack 8f6e29785a HBASE-15351 Fix description of hbase.bucketcache.size in hbase-default.xml 2016-02-26 13:49:26 -08:00
Elliott Clark 77133fd225 HBASE-15222 Addendum - Use less contended classes for metrics 2016-02-25 09:08:11 -08:00
Mikhail Antonov 43f99def67 HBASE-15136 Explore different queuing behaviors while busy 2016-02-24 20:41:30 -08:00
Elliott Clark 630a65825e HBASE-15222 Use less contended classes for metrics
Summary:
Use less contended things for metrics.
For histogram which was the largest culprit we use FastLongHistogram
For atomic long where possible we now use counter.

Test Plan: unit tests

Reviewers:

Subscribers:

Differential Revision: https://reviews.facebook.net/D54381
2016-02-24 14:34:05 -08:00
eshcar 876a6ab73e HBASE-15016 Services a Store needs from a Region
Signed-off-by: stack <stack@apache.org>
2016-02-24 07:07:07 -08:00
ramkrishna 3ba1a7fd23 HBASE-13259 mmap() based BucketCache IOEngine (Zee Chen & Ram) 2016-02-23 17:03:38 +05:30
stack 6f8c7dca13 HBASE-15279 OrderedBytes.isEncodedValue does not check for int8 and int16 types (Robert Yokota) 2016-02-17 22:10:15 -08:00
Matteo Bertozzi e0fa176f0b HBASE-15100 ProcedureInfo constructor should be InterfaceAudience.Private (addendum) 2016-02-17 12:14:01 -08:00
ramkrishna a975408b7c HBASE-15253 Small bug in CellUtil.matchingRow(Cell, byte[]) (Ram) 2016-02-11 21:51:19 +05:30
Enis Soztutar a69272efe1 HBASE-15177 Reduce garbage created under high load 2016-02-04 13:27:00 -08:00
Enis Soztutar 2f5767376f HBASE-15129 Set default value for hbase.fs.tmp.dir rather than fully depend on hbase-default.xml (Yu Li) 2016-02-02 17:10:19 -08:00
stack ed46591f30 HBASE-15196 HBASE-15158 Preamble 2 of 2:Add Increment tests 2016-02-02 11:27:03 -08:00
stack 2cc48e039d HBASE-15158 HBASE-15158 Preamble 1 of 2: fix findbugs, add javadoc, change Region#getReadpoint to #getReadPoint, and some util 2016-01-31 20:21:48 -08:00
ramkrishna 0de221a19d HBASE-14841 Allow Dictionary to work with BytebufferedCells (Ram) 2016-01-29 10:06:20 +05:30
Misty Stanley-Jones 4ca27a68ef HBASE-15184 Fix broken links found via LinkLint 2016-01-26 10:02:53 -08:00
Matteo Bertozzi 772f30fe2a HBASE-15100 Master WALProcs are deleted out of order ending up with older wals not removed 2016-01-22 15:57:12 -08:00
stack bd9906736e HBASE-15098 Normalizer switch in configuration is not used 2016-01-20 09:32:38 -08:00
Gary Helmling df36178062 HBASE-15111 hbase version should write to stdout
Signed-off-by: Sean Busbey <busbey@cloudera.com>
2016-01-19 22:06:57 -06:00
Matteo Bertozzi 18a48af242 HBASE-14837 Procedure v2 - Procedure Queue Improvement 2016-01-14 09:24:42 -08:00
stack 83c506d9d4 HBASE-15087 Fix hbase-common findbugs complaints 2016-01-12 00:30:42 -08:00
anoopsjohn da932ee38d HBASE-15077 Support OffheapKV write in compaction with out copying data on heap. 2016-01-12 10:02:39 +05:30
anoopsjohn a9b671b31f HBASE-12593 Tags to work with ByteBuffer. 2016-01-06 21:28:06 +05:30
anoopsjohn 7cd09bfb91 HBASE-15064 BufferUnderflowException after last Cell fetched from an HFile Block served from L2 offheap cache. 2016-01-06 10:25:32 +05:30
stack 46303dfd75 HBASE-14888 ClusterSchema: Add Namespace Operations 2016-01-05 14:35:27 -08:00
anoopsjohn 9997e4ee52 HBASE-14524 Short-circuit comparison of rows in CellComparator. (Lars Francke) 2016-01-05 08:47:23 +05:30
stack a82f7fc94a Revert "HBASE-14888 ClusterSchema: Add Namespace Operations"
This reverts commit c5f3d17ae3.
2016-01-03 07:15:18 -08:00
stack c5f3d17ae3 HBASE-14888 ClusterSchema: Add Namespace Operations 2016-01-02 16:16:56 -08:00
anoopsjohn f01a388a35 HBASE-15063 Bug in MultiByteBuf#toBytes. (deepankar) 2016-01-01 23:11:59 +05:30
tedyu 449fb81286 HBASE-14030 Revert due to pending review comments 2015-12-28 01:08:02 -08:00
tedyu de69f0df34 HBASE-14030 HBase Backup/Restore Phase 1 (Vladimir Rodionov) 2015-12-27 10:02:09 -08:00
tedyu f53542c47d HBASE-15026 The default value of "hbase.regions.slop" in docs is obsolete 2015-12-25 15:37:31 -08:00
Jonathan M Hsieh 3de0b0417c HBASE-15035 bulkloading hfiles with tags that require splits do not preserve tags 2015-12-25 09:51:34 -08:00
anoopsjohn 6fc2596ab3 HBASE-14940 Make our unsafe based ops more safe. 2015-12-24 07:54:13 +05:30
Enis Soztutar 95a13b51ee HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues 2015-12-22 02:04:09 -08:00
anoopsjohn cf458d3023 HBASE-14999 Remove ref to org.mortbay.log.Log. 2015-12-17 18:01:16 +05:30
Enis Soztutar a4bbc461e3 HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException (Vladimir Rodionov) 2015-12-15 12:29:43 -08:00
stack c15e0af84a HBASE-14906 Improvements on FlushLargeStoresPolicy (Yu Li) 2015-12-10 16:49:23 -08:00
ramkrishna 26ac60b03f HBASE-13153 Bulk Loaded HFile Replication (Ashish Singhi) 2015-12-10 13:07:46 +05:30
Gary Helmling c1e0fcc26d HBASE-14866 VerifyReplication and ReplicationAdmin should use full peer configuration for peer connection 2015-12-09 15:52:27 -08:00
stack 8bf70144e4 Revert "Revert "HBASE-14922 Delayed flush doesn't work causing flush storms; addendum by Lars Hofhansl""
Push again but with right JIRA number this time.

This reverts commit 9fb53d07c4.
2015-12-05 14:30:25 -08:00
stack 9fb53d07c4 Revert "HBASE-1422 Delayed flush doesn't work causing flush storms; addendum by Lars Hofhansl"
Revert because pushed with wrong JIRA number

This reverts commit b1462679e1.
2015-12-05 14:30:05 -08:00
stack b1462679e1 HBASE-1422 Delayed flush doesn't work causing flush storms; addendum by Lars Hofhansl 2015-12-05 11:39:34 -08:00
Elliott Clark 46198bb9a4 HBASE-14922 Delayed flush doesn't work causing flush storms. -- ADD 2015-12-04 18:37:29 -08:00
Elliott Clark cd5ddc5fec HBASE-14922 Delayed flush doesn't work causing flush storms. 2015-12-04 16:54:01 -08:00
Enis Soztutar b3260423b1 HBASE-14904 Mark Base[En|De]coder LimitedPrivate and fix binary compat issue 2015-12-03 18:18:20 -08:00
ramkrishna aa41232a87 HBASE-14832 Ensure write paths work with ByteBufferedCells in case of
compaction (Ram)
2015-12-02 10:28:30 +05:30
Apekshit 3bac31b2a4 HBASE-14890 Fix broken checkstyle tool. Some javadocs had parsing errors because of wrongly formatted HTML tags. (Apekshit)
Signed-off-by: stack <stack@apache.org>
2015-11-28 21:57:52 -08:00
tedyu 2317ec583d HBASE-14894 Fix misspellings of threshold in log4j.properties files for tests (Youngjoon Kim) 2015-11-28 10:08:38 -08:00
stack 5898b95329 HBASE-14860 Improve BoundedByteBufferPool; make lockless 2015-11-24 17:06:46 -08:00
Daniel Vimont 6a493ddff7 Commit for HBASE-14825 -- corrections of typos, misspellings, and mangled links
Commit for HBASE-14825 -- corrections of typos, misspellings, and mangled links - addition commit for line lengths
2015-11-25 07:12:36 +10:00
Gary Helmling 8b67df6948 HBASE-14821 Allow configuration overrides in TableOutputFormat 2015-11-24 12:13:51 -08:00
stack d8f2ac3e6e HBASE-14860 Improve BoundedByteBufferPool; make lockless (Hiroshi Ikeda) 2015-11-21 20:32:13 -08:00
Enis Soztutar cf81b45f37 HBASE-14468 Compaction improvements: FIFO compaction policy (Vladimir Rodionov) 2015-11-18 19:33:11 -08:00
Elliott Clark a591df1073 HBASE-14708 Use copy on write Map for region location cache
Summary:
Create and use a copy on write map for region location.

  - Create a copy on write map backed by a sorted array.
  - Create a test for both comparing each with a jdk provided map.
  - Change MetaCache to use the new map.

Test Plan:
  - org.apache.hadoop.hbase.client.TestFromClientSide
  - TestHCM

Differential Revision: https://reviews.facebook.net/D49545
2015-11-17 10:52:43 -08:00
zhangduo db42fc64f1 HBASE-14806 Missing sources.jar for several modules when building HBase 2015-11-17 08:54:13 +08:00
stack 290ecbe829 HBASE-14355 Scan different TimeRange for each column family (Churro Morales) 2015-11-12 10:54:16 -10:00
Elliott Clark 86da57f498 HBASE-14765 Remove snappy profile 2015-11-05 10:20:40 -08:00
Misty Stanley-Jones e8d6bf7d46 HBASE-14532 Add dfs shortcircuit configs to hbase-default.xml, fix anchor to Compaction subsection 2015-11-02 13:55:57 +10:00
Gary Helmling 683f84e6a2 HBASE-14700 Support a permissive mode for secure clusters to allow SIMPLE auth clients 2015-10-30 19:45:46 -07:00
anoopsjohn b0ad82191c HBASE-14557 MapReduce WALPlayer issue with NoTagsKeyValue. 2015-10-30 21:18:09 +05:30
Andrew Purtell dfa05284cf HBASE-14705 Javadoc for KeyValue constructor is not correct (Jean-Marc Spaggiari) 2015-10-27 14:40:28 -07:00
Enis Soztutar 16ff57bea9 HBASE-14680 Two configs for snapshot timeout and better defaults (Heng Chen) 2015-10-27 14:01:01 -07:00
stack 996866d3ae HBASE-14266 RegionServers have a lock contention of Configuration.getProps 2015-10-24 14:43:53 -07:00
stack c21e8ed1d8 HBASE-14657 Remove unneeded API from EncodedSeeker (Heng Chen) 2015-10-22 14:20:28 -07:00
Matteo Bertozzi 36a196722c HBASE-14669 remove unused import and fix javadoc 2015-10-22 09:25:26 -07:00
Misty Stanley-Jones c4fa88420f HBASE-14326 Clarify that ExploringCompactionPolicy evaluates a selection of StoreFiles, not a single StoreFile 2015-10-22 19:09:38 +10:00
Misty Stanley-Jones fd50b5c033 Revert "HBASE-14326 Clarify that ExploringCompactionPolicy evaluates a selection of StoreFiles, not a single StoreFile"
This reverts commit 6a90e7b43b.
2015-10-22 19:08:31 +10:00
Misty Stanley-Jones 6a90e7b43b HBASE-14326 Clarify that ExploringCompactionPolicy evaluates a selection of StoreFiles, not a single StoreFile 2015-10-22 15:37:37 +10:00
stack 71b38d60bb HBASE-14637 Loosen TestChoreService assert AND have TestDataBlockEncoders do less work (and add timeouts) 2015-10-17 16:14:45 -07:00
Elliott Clark 0ed8b0e5d5 HBASE-14597 Fix Groups cache in multi-threaded env 2015-10-16 15:15:26 -07:00
tedyu 8c69b0f751 HBASE-14594 Use new DNS API introduced in HADOOP-12437 (Josh Elser) 2015-10-14 14:17:36 -07:00
stack 940e5404df HBASE-14598 ByteBufferOutputStream grows its HeapByteBuffer beyond JVM limitations (Ian Friedman) 2015-10-14 13:13:01 -07:00
stack 118ef8b6e5 HBASE-14268 Improve KeyLocker; ADDENDUM: FIX JAVADOC WARNING 2015-10-14 09:26:59 -07:00
Nicolas Liochon b63155eac7 HBASE-14268 Improve KeyLocker - add missing files 2015-10-13 11:22:28 +02:00
stack 99e99f3b54 HBASE-14268 Improve KeyLocker (Hiroshi Ikeda) 2015-10-12 23:13:56 -07:00
Enis Soztutar 2ff6d0fe47 HBASE-14501 NPE in replication with TDE 2015-10-12 20:37:34 -07:00
anoopsjohn 6143b7694c HBASE-13819 Make RPC layer CellBlock buffer a DirectByteBuffer. 2015-10-13 07:57:53 +05:30
stack b9639d1e82 HBASE-14590 Shorten ByteBufferedCell#getXXXPositionInByteBuffer method name (Anoop Sam John) 2015-10-12 12:33:28 -07:00
stack 4e876c59f4 HBASE-14573 Edit on the ByteBufferedCell javadoc 2015-10-07 11:31:15 -07:00
Misty Stanley-Jones 5e60166eac HBASE-14424 Document that DisabledRegionSplitPolicy blocks manual splits 2015-10-07 12:08:22 +10:00
Stephen Yuan Jiang ed4c734b15 HBASE-14432 Procedure V2 - enforce ACL on procedure admin tasks (Stephen Yuan Jiang 2015-10-05 20:07:21 -07:00
Matteo Bertozzi 715e8b0de1 HBASE-14347 Add a switch to DynamicClassLoader to disable it (huaxiang sun) 2015-10-05 16:17:07 -07:00
anoopsjohn b014ba1243 HBASE-14480 Small optimization in SingleByteBuff. 2015-10-05 12:00:19 +05:30
smaddineni 44b8809726 HBASE-13770 Programmatic JAAS configuration option for secure zookeeper may be broken
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-10-02 17:50:54 -07:00
Elliott Clark a463984945 HBASE-14512 Cache UGI groups
Summary:
Don't create a user for every call. Instead create one user per connection.
Then inside of SecureHadoopUser cache the groupNames. This allows HBase to cache
empty groups.  This is needed since it's much more likely that HBase will be accessed
by a user that's not present on the posix /etc/group file.

Test Plan: Unit Tests

Differential Revision: https://reviews.facebook.net/D47751
2015-09-30 12:46:12 -07:00
ramkrishna d5768d4a50 HBASE-14398 - Create the fake keys required in the scan path to avoid copy
to byte[] (Ram)
2015-09-29 16:39:57 +05:30
Apekshit(Appy) Sharma dff86542d5 HBASE-14469 Fix comment, validation and logging in HeapMemorySizeUtil.getGlobalMemStoreLowerMark 2015-09-24 19:12:44 -07:00
Stephen Yuan Jiang 5b7894f92b HBASE-14107 Administrative Task: Provide an API to List all procedures (Stephen Yuan Jiang) 2015-09-23 21:48:32 -07:00
stack 2c83d8a263 HBASE-12751 Allow RowLock to be reader writer 2015-09-22 17:23:07 -07:00
ramkrishna d81fba59cf HBASE-12298 Support BB usage in PrefixTree (Ram) 2015-09-18 10:44:02 +05:30
anoopsjohn ae3176b9c0 HBASE-14395 Short circuit last byte check in CellUtil#matchingXXX methods for ByteBufferedCells. 2015-09-11 10:29:30 +05:30
Nick Dimiduk a11bb2a933 HBASE-14382 TestInterfaceAudienceAnnotations should hadoop-compt module resources 2015-09-09 11:08:28 -07:00
Lars Hofhansl 6a8ba22c16 HBASE-12988 [Replication]Parallel apply edits across regions. 2015-09-04 13:22:14 -07:00
stack d0873f5a8c HBASE-14224 Fix coprocessor handling of duplicate classes 2015-08-24 13:47:19 -07:00
stack d31aedb998 HBASE-13127 Add timeouts on all tests so less zombie sightings 2015-08-24 12:49:55 -07:00
Andrew Purtell 902cd172f8 HBASE-13996 Add write sniffing in canary (Liu Shaohui) 2015-08-21 22:45:48 -07:00
Sean Busbey 720f2a8815 HBASE-14251 ensure javadoc jars have LICENSE/NOTICE that match content. 2015-08-20 10:52:41 -05:00
ramkrishna f2a9dab30e HBASE-14144 - Bloomfilter path to work with Byte buffered cells (Ram) 2015-08-14 12:04:34 +05:30
Misty Stanley-Jones a78e6e9499 HBASE-13483 onheap is not a valid bucket cacne IO engine 2015-08-12 09:28:17 +10:00
Elliott Clark 38b94709ee HBASE-14208 Remove yarn dependencies on -common and -client 2015-08-11 13:00:13 -07:00
anoopsjohn d49b1f60f4 HBASE-14202 Reduce garbage we create. 2015-08-11 21:51:17 +05:30
Misty Stanley-Jones c7065c4c40 HBASE-13924 Description for hbase.dynamic.jars.dir is wrong 2015-08-10 14:08:15 +10:00
Jerry He f1c1692d51 HBASE-13706 CoprocessorClassLoader should not exempt Hive classes 2015-08-07 12:12:39 -07:00
Gábor Lipták 7417835853 HBASE-13865 Increase the default value for hbase.hregion.memstore.block.multipler from 2 to 4 (part 2) 2015-08-06 10:03:23 -07:00
ramkrishna 7a9e10dc11 HBASE-14188 - Read path optimizations after HBASE-11425 profiling (Ram) 2015-08-06 16:49:49 +05:30
Sean Busbey 1b0b67fb7c HBASE-14085 Update LICENSE and NOTICE files.
* corrects license/notice for source distribution
* adds inception year to correct copyright in generated NOTICE files for jars
* updates project names in poms to use "Apache HBase" instead of "HBase" so jar NOTICE files will be correct
* uses append-resources to include supplemental info on jars with 3rd party works in source
* adds an hbase specific resource bundle for jars that include 3rd party works for binaries
** uses supplemental-model to fill in license gaps
** uses the above and a shade plugin transformation to build proper files for shaded jars.
** uses the above and the assembly plugin to build the proper files for bin assembly
* adds a NOTICE item for things copied out of Hadoop (TODO legal-discuss)
2015-08-04 17:16:56 -05:00
tedyu 598cfeb775 HBASE-13965 Stochastic Load Balancer JMX Metrics (Lei Chen) 2015-08-03 12:46:01 -07:00
tedyu 4b6598e394 HBASE-13864 HColumnDescriptor should parse the output from master and from describe for TTL (Ashu Pachauri) 2015-08-01 02:15:02 -07:00
Andrew Purtell 5f1129c799 HBASE-14155 StackOverflowError in reverse scan (Ramkrishna S. Vasudevan) 2015-07-29 18:14:31 -07:00
Sean Busbey 4ce6f486d0 HBASE-14087 Ensure correct ASF headers for docs/code
* adds missing headers
* corrects some old-form headers to current
* restores proper header for guava copied LimitInputStream
* adds proper header for protobuf copied read/writeRawVarint
2015-07-29 14:25:43 -05:00
Srikanth Srungarapu 1d4c2452e7 HBASE-14057 HBase shell user_permission should list super users defined on hbase-site.xml 2015-07-28 11:33:52 -07:00
ramkrishna 3f80e0ea4f HBASE-14063 Use BufferBackedCell in read path after HBASE-12213 and
HBASE-12295 (ram)
2015-07-27 16:55:46 +05:30
Jonathan M Hsieh 493f36c899 HBASE-11339 Merge remote-tracking branch 'apache/hbase-11339' (Jingcheng Du) 2015-07-22 12:51:11 -07:00
ramkrishna ccb22bd80d HBASE-12295 Prevent block eviction under us if reads are in progress from
the BBs (Ram)
2015-07-21 21:15:32 +05:30
anoopsjohn cceee1b0c3 HBASE-14116 Change ByteBuff.getXXXStrictlyForward to relative position based reads. 2015-07-21 09:01:20 +05:30
anoopsjohn 0f614a1c44 HBASE-12374 Change DBEs to work with new BB based cell. 2015-07-20 23:28:45 +05:30
ramkrishna 7e4cd59820 HBASE-14099 StoreFile.passesKeyRangeFilter need not create Cells from the
Scan's start and stop Row (Ram)
2015-07-20 22:10:10 +05:30
anoopsjohn 88038cf473 HBASE-14120 ByteBufferUtils#compareTo small optimization. 2015-07-20 16:49:51 +05:30
ramkrishna 834f87b23d HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) 2015-07-17 13:27:29 +05:30
anoopsjohn ebdac4b52e HBASE-12296 Filters should work with ByteBufferedCell. 2015-07-16 09:36:05 +05:30
ramkrishna a3d30892b4 HBASE-14047 - Cleanup deprecated APIs from Cell class (Ashish Singhi) 2015-07-13 22:06:16 +05:30
Matteo Bertozzi 951ec7a0b7 HBASE-13415 Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-07-13 11:02:30 -05:00
Sean Busbey 60d6435ad8 Revert "Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)"
This reverts commit 87ee37ceb8.
2015-07-13 11:01:45 -05:00
stack 66082c7224 HBASE-14052 Mark a few methods in CellUtil audience private since only make sense internally to hbase 2015-07-10 10:44:38 -07:00
anoopsjohn bff911a8e8 HBASE-13387 Add ByteBufferedCell an extension to Cell - addendum. 2015-07-10 15:03:07 +05:30
stack ff122f80b9 HBASE-14053 Disable DLR in branch-1+ 2015-07-09 16:46:17 -07:00
Matteo Bertozzi 87ee37ceb8 Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang) 2015-07-09 07:44:36 -07:00
anoopsjohn d07ff5ec5a HBASE-13387 Add ByteBufferedCell an extension to Cell. 2015-07-09 15:35:24 +05:30
anoopsjohn 7d3456d8fd HBASE-14020 Unsafe based optimized write in ByteBufferOutputStream. 2015-07-06 10:44:38 +05:30
anoopsjohn 215290eb76 HBASE-13998 Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength)- Addendum to fix javadoc warn 2015-07-06 00:15:13 +05:30
ramkrishna 74e82c64e5 HBASE-13977 - Convert getKey and related APIs to Cell (Ram) 2015-07-03 22:59:58 +05:30
ramkrishna 1b75fd2bd6 HBASE-14011 - MultiByteBuffer position based reads does not work correctly
(Ram)
2015-07-03 07:58:48 +05:30
anoopsjohn 62f5694491 HBASE-13998 Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength). 2015-07-02 11:58:25 +05:30
Matteo Bertozzi 5ee11840f6 HBASE-13995 ServerName is not fully case insensitive 2015-07-01 09:26:15 -07:00
anoopsjohn a1060d1390 HBASE-13670 [HBase MOB] ExpiredMobFileCleaner tool deletes mob files later for one more day after they are expired. (Jingcheng) 2015-07-01 11:26:24 +05:30
anoopsjohn 42d5ef017d HBASE-13943 Get rid of KeyValue#heapSizeWithoutTags. 2015-06-30 23:09:09 +05:30
Lars Hofhansl f8bd578b80 HBASE-13959 Region splitting uses a single thread in most common cases. (Hari Krishna Dara) 2015-06-29 18:08:46 -07:00
anoopsjohn 3eee730284 HBASE-12345 Unsafe based ByteBuffer Comparator. 2015-06-29 22:50:33 +05:30
ramkrishna 130817b559 HBASE-13939 - Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
(Ram)
2015-06-26 20:47:30 +05:30
Gábor Lipták 5826bf2a7c HBASE-13963 Do not leak jdk.tools dependency from hbase-annotations
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-26 08:48:02 -05:00
ramkrishna d7356667be HBASE-13945 - Prefix_Tree seekBefore() does not work correctly (Ram) 2015-06-24 09:11:05 +05:30
Gábor Lipták b636c6b1cd HBASE-13898 AMMENDMENT Correct Javadoc errors in site
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-23 00:05:56 -05:00
Mikhail Antonov fd37ccb63c HBASE-13103 [ergonomics] add region size balancing as a feature of master 2015-06-22 15:52:07 -07:00
ramkrishna f9b17bfd37 HBASE-13614 - Avoid temp KeyOnlyKeyValue temp objects creations in read
hot path (Ram)
2015-06-22 12:30:46 +05:30
anoopsjohn a4bd2b784e HBASE-13448 New Cell implementation with cached component offsets/lengths. 2015-06-22 11:02:45 +05:30
anoopsjohn 04c25e0f35 HBASE-13931 Move Unsafe based operations to UnsafeAccess. 2015-06-20 20:52:06 +05:30
Nick Dimiduk db08013ebe HBASE-13933 DBE's seekBefore with tags corrupts the tag's offset information thus leading to incorrect results (ramkrishna.s.vasudevan) 2015-06-19 14:41:06 -07:00
anoopsjohn 8ae4b374e3 HBASE-13916 Create MultiByteBuffer an aggregation of ByteBuffers. 2015-06-18 22:38:10 +05:30
Misty Stanley-Jones b16293b5e2 HBASE-13898 correct additional javadoc failures under java 8 <Gabor Liptak> 2015-06-16 14:18:09 +10:00
Misty Stanley-Jones 5e6373e8ec Revert "Correct Javadoc generation errors"
This reverts commit 0a227b79d6.
2015-06-16 14:18:09 +10:00
Gábor Lipták 0a227b79d6 Correct Javadoc generation errors 2015-06-16 13:27:45 +10:00
Matteo Bertozzi dd086bb22f HBASE-13894 Avoid visitor alloc each call of ByteBufferArray get/putMultiple() 2015-06-15 09:19:50 -07:00
Gábor Lipták 682b8ab8a5 HBASE-13569 Correct Javadoc (for Java8)
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-06-13 01:10:37 -05:00
Dave Latham 293506c7cd HBASE-13639 SyncTable - rsync for HBase tables
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-12 16:00:00 -07:00
Srikanth Srungarapu 7595bdfb1a HBASE-13755 Provide single super user check implementation (Mikhail Antonov) 2015-06-11 20:51:05 -07:00
anoopsjohn bf3924ed05 HBASE-13871 Change RegionScannerImpl to deal with Cell instead of byte[], int, int. 2015-06-10 18:40:51 +05:30
ramkrishna 487e4aa74f HBASE-13451 - Make the HFileBlockIndex blockKeys to Cells so that it could
be easy to use in the CellComparators (Ram)
2015-06-09 12:03:01 +05:30
stack c1be65ecf0 HBASE-13729 Old hbase.regionserver.global.memstore.upperLimit and lowerLimit properties are ignored if present (Esteban Guitierrez) 2015-06-05 13:22:35 -07:00
anoopsjohn bb62d5b2e8 HBASE-13817 ByteBufferOuputStream - add writeInt support. 2015-06-04 10:22:33 +05:30
Andrey Stepachev 56166b669e HBASE-13647 Default value for hbase.client.operation.timeout is too high 2015-06-02 10:58:59 +01:00
Enis Soztutar e0cf811b33 Revert "HBASE-13647 Default value for hbase.client.operation.timeout is too high"
This reverts commit f7c3a3dd55.
2015-05-29 12:54:12 -07:00
stack 325614220f HBASE-13616 Move ServerShutdownHandler to Pv2 2015-05-28 20:45:38 -07:00
Nick Dimiduk f0a1ca4a6f HBASE-13761 Optimize FuzzyRowFilter (Vladimir Rodionov) 2015-05-28 10:12:21 -07:00
anoopsjohn b31a6acf4c HBASE-13763 Handle the rename, annotation and typo stuff in MOB. (Jingcheng) 2015-05-28 13:43:12 +05:30
anoopsjohn 81b9abab0c HBASE-13778 BoundedByteBufferPool incorrectly increasing runningAverage buffer length. 2015-05-28 11:52:41 +05:30
ramkrishna cd9c6de023 HBASE-13393 - Addendum for trunk deprecating KeyValue.isCreate() (Ram) 2015-05-28 11:29:36 +05:30
anoopsjohn 7de4881e3a HBASE-13754 Allow non KeyValue Cell types also to oswrite. 2015-05-28 11:12:37 +05:30
Sean Busbey 353b046d6c HBASE-13710 Remove dependency on Hadoop's ReflectionUtil.
* copies ReflectionUtils.logThreadInfo and needed private methods from Hadoop
  branch-2, fixes minor issues specific to our use.
* updates HttpServer's use of RU.newInstance to use the HBase version.
  Side effect: previously, FilterInitializer instances that happened to also
  implement Configurable would have setConfiguration called. Such uses should
  instead rely on the mandatory FilterInitializer.initFilter method call.
2015-05-27 23:51:11 -05:00
ramkrishna eeb11b5327 HBASE-13393 - Optimize memstore flushing to avoid writing tag information
to hfiles when no tags are present. (Ram)
2015-05-28 10:00:59 +05:30
Enis Soztutar ef18d75d00 HBASE-13732 TestHBaseFsck#testParallelWithRetriesHbck fails intermittently (Stephen Yuan Jiang) 2015-05-27 17:06:58 -07:00
Andrew Purtell 4070770243 HBASE-13780 Default to 700 for HDFS root dir permissions for secure deployments (Enis Soztutar) 2015-05-27 13:15:32 -07:00
anoopsjohn 5098f365b4 HBASE-13736 Add delay for the first execution of ExpiredMobFileCleanerChore and MobFileCompactorChore.(Jingcheng) 2015-05-21 13:40:25 +05:30
Lars Francke 1fcee86978 HBASE-13636 Remove deprecation for HBASE-4072 (Reading of zoo.cfg)
Signed-off-by: stack <stack@apache.org>
2015-05-19 16:32:32 -07:00
Jonathan M Hsieh 09a00efc0b Merge remote-tracking branch 'apache/master' (5/19/15) into hbase-11339
Patches that caused deltas:
HBASE-10810 - around HColumnDescriptor 'should' vs 'is' api.
HBASE-11677 - LOG was made private
HBASE-11927 - Checksum constant changed
HBASE-10800 - CellComparator instead of KVComparator

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
2015-05-19 16:30:21 -07:00
Lars Francke ed5ac65f22 HBASE-13713: See about dropping ClassLoaderBase#getClassLoadingLock
Signed-off-by: stack <stack@apache.org>
2015-05-19 15:52:27 -07:00
Apekshit(Appy) Sharma 988593857f HBASE-11927 Use Native Hadoop Library for HFile checksum. (Apekshit)
Signed-off-by: stack <stack@apache.org>
2015-05-15 11:40:23 -07:00
Andrey Stepachev f7c3a3dd55 HBASE-13647 Default value for hbase.client.operation.timeout is too high 2015-05-14 13:08:04 +01:00
Enis Soztutar 59a6e031fb HBASE-13661 Correct binary compatibility issues discovered in 1.1.0RC0 2015-05-11 18:28:29 -07:00
Dave Latham bbae9f3826 HBASE-13649 correct javadoc for compareTimestamps
Signed-off-by: stack <stack@apache.org>
2015-05-08 21:32:06 -07:00
ramkrishna 52f635df00 HBASE-13630 - Remove dead code in BufferedDataEncoder (Ram) 2015-05-08 09:15:46 +05:30
tedyu a93ba89b5b HBASE-13625 Use HDFS for HFileOutputFormat2 partitioner's path (Stephen Yuan Jiang) 2015-05-06 07:31:15 -07:00
ramkrishna 977f867439 HBASE-10800 - Use CellComparator instead of KVComparator (Ram) 2015-05-05 11:38:10 +05:30
Andrew Purtell 1c4b47f856 HBASE-12415 Add add(byte[][] arrays) to Bytes (Jean-Marc Spaggiari) 2015-05-01 18:12:36 -07:00
Jonathan M Hsieh 0e20bbf6a3 Merge branch 'apache/master' (4/16/15) into hbase-11339
API conflicts and test fixes
Update LoadTestTool.COLUMN_FAMILY -> DEFAULT_COLUMN_FAMILY due HBASE-11842
Use new 1.0+ api in some tests
Use updated Scanners internal api
Fix to take into account  HBASE-13203 - procedure v2 table delete

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
2015-05-01 08:18:51 -07:00
anoopsjohn d88a4180f7 HBASE-13595 Fix Javadoc warn induced in Bytes.java. 2015-04-30 20:58:25 +05:30
ramkrishna 3a9c2b0c55 HBASE-13579 Avoid isCellTTLExpired() for NO-TAG cases (Ram) 2015-04-30 15:14:41 +05:30
Devaraj Das b27e9e70be HBASE-13351. Annotate internal MasterRpcServices methods with admin priority (Josh Elser) 2015-04-28 23:38:28 -07:00
Usha Kuchibhotla 94a00bea07 HBASE-11677 Making Logger instance modifiers consistent.
* IA.Public accessible logger instances deprecated
* logger instances modified by tests left in place
* all others made private static final

Signed-off-by: Sean Busbey <busbey@apache.org>
2015-04-28 09:20:34 -05:00
stack 2759fd0cdb HBASE-13575 TestChoreService has to make sure that the opened ChoreService is closed for each unit test (Stephen Yuan Jiang) 2015-04-27 14:23:57 -07:00
stack 0415649f3d HBASE-13552 ChoreService shutdown message could be more informative (Jonathan Lawlor) 2015-04-24 13:42:03 -07:00
ramkrishna a4fa930843 HBASE-13450 - Purge RawBytescomparator from the writers and readers for
HBASE-10800 (Ram)
2015-04-24 16:01:38 +05:30
anoopsjohn a4202879ad HBASE-13496 Make Bytes::compareTo inlineable. 2015-04-23 10:36:08 +05:30
ramkrishna 2396020752 HBASE-13502 - Deprecate/remove getRowComparator() in TableName (Ram) 2015-04-22 09:24:00 +05:30
Devaraj Das 14261bc9e5 HBASE-13453. Master should not bind to region server ports (Srikanth Srungarapu) 2015-04-15 11:02:08 -07:00
zhangduo fe9180d79e HBASE-13499 AsyncRpcClient test cases failure in powerpc 2015-04-14 23:00:07 +08:00
Sean Busbey 702aea5b38 HBASE-13498 Add more docs and a basic check for storage policy handling. 2015-04-20 10:45:14 -05:00
Jonathan Lawlor abe3796a99 HBASE-13090 Progress heartbeats for long running scanners
Signed-off-by: stack <stack@apache.org>
2015-04-17 15:42:46 -07:00
stack 92af695ea1 HBASE-13307 Making methods under ScannerV2#next inlineable, faster 2015-04-17 08:15:07 -07:00
anoopsjohn 71536bdcc7 HBASE-13447 Bypass logic in TimeRange.compare. 2015-04-14 11:37:48 +05:30
Matteo Bertozzi b5f1f98a25 HBASE-13203 Procedure v2 - master create/delete table 2015-04-10 18:53:42 +01:00
Matteo Bertozzi 04246c6c3d HBASE-13202 Procedure v2 - core framework 2015-04-10 18:53:37 +01:00
Apekshit(Appy) Sharma d20c08ea58 HBASE-13423 Remove old duplicate entry for hbase.regionserver.regionSplitLimit. 2015-04-10 20:40:15 +10:00
Andrew Purtell ed703762ae HBASE-13275 Setting hbase.security.authorization to false does not disable authorization 2015-04-09 14:47:21 -07:00
anoopsjohn 6eeb5b38e1 HBASE-13429 Remove deprecated seek/reseek methods from HFileScanner. 2015-04-09 22:42:57 +05:30
Lars Hofhansl 80dbf06651 HBASE-13362 Set max result size from client only (like scanner caching). 2015-04-08 21:43:01 -07:00
stack 8cd3001f81 Revert "HBASE-11544 [Ergonomics] hbase.client.scanner.caching is dogged and will try to return batch even if it means OOME"
References the wrong JIRA above so revert; also an addendum is on the
way.

This reverts commit 26ba621e47.
2015-04-08 09:32:09 -07:00
Jonathan Lawlor 26ba621e47 HBASE-11544 [Ergonomics] hbase.client.scanner.caching is dogged and will try to return batch even if it means OOME
Added in some check-style fixes to bring us back under the limit

Signed-off-by: stack <stack@apache.org>
2015-04-08 08:16:54 -07:00
unknown 57f9c82128 HBASE-13410 - Bug in KeyValueUtil.oswrite() for non Keyvalue cases 2015-04-07 10:29:12 +05:30
Apekshit(Appy) Sharma e252c30645 HBASE-6919 Remove unnecessary throws IOException from Bytes.readVLong.
Added readAsVLong() to deprecate readVLong() which was throwing IOException. Added test for readAsVLong().

Signed-off-by: Sean Busbey <busbey@apache.org>
2015-04-03 21:25:37 -05:00
Mikhail Antonov 578df6dfc0 HBASE-13252 Get rid of managed connections and connection caching
Signed-off-by: stack <stack@apache.org>
2015-04-02 12:00:42 -07:00
unknown c8e1177dd2 HBASE-13368 - Hash.java is declared as public Interface - but it should be
Private (Ram)
2015-04-02 10:21:48 +05:30
tedyu 874aa9eb85 HBASE-12954 Ability impaired using HBase on multihomed hosts 2015-04-01 06:49:09 -07:00
Andrew Purtell f1f4b66183 HBASE-12972 Region, a supportable public/evolving subset of HRegion 2015-03-30 18:01:11 -07:00
Elliott Clark 55a5a3be33 HBASE-13364 Make error prone off by default 2015-03-30 16:03:53 -07:00
tedyu bd837d47f7 HBASE-12413 Mismatch in the equals and hashcode methods of KeyValue (Jingcheng Du and Gariel Reid) 2015-03-28 06:31:28 -07:00
zhangduo 6e9ded51fb HBASE-13310 Fix high priority findbugs warnings 2015-03-24 06:50:04 +08:00
Andrew Purtell 8dfed5dc88 HBASE-13303 Fix size calculation of results on the region server 2015-03-20 17:24:50 -07:00
Matteo Bertozzi 0915191167 HBASE-13282 Fix the minor issues of running Canary on kerberized environment (Srikanth Srungarapu) 2015-03-20 21:26:53 +00:00
stack f57dca5e1b HBASE-13198 Remove HConnectionManager (Mikhail Antonov) 2015-03-20 09:41:48 -07:00
Lars Hofhansl 0d76654416 Reapply "HBASE-12976 Set default value for hbase.client.scanner.max.result.size." in 1.1 and 2.0 only
This reverts commit 64589abe99.
2015-03-19 15:07:15 -07:00
Lars Hofhansl 64589abe99 Revert "HBASE-12976 Set default value for hbase.client.scanner.max.result.size."
This reverts commit 2583e8de57.
2015-03-19 14:19:41 -07:00
Matteo Bertozzi 535ebbfde9 HBASE-13235 Revisit the security auditing semantics (Srikanth Srungarapu) 2015-03-19 07:01:21 +00:00
tedyu 75b627c8ec HBASE-13256 HBaseConfiguration#checkDefaultsVersion(Configuration) has spelling error (Josh Elser) 2015-03-17 07:24:01 -07:00
Josh Elser 72855c584e HBASE-13236 Add addt'l lifecycle-mapping executions.
Adds a number of lifecycle-mapping entries which
prevent errors from showing up in Eclipse on a fresh
import of HBase. For plugins defined in the top-level
pom, the mapping is added there; otherwise, the mapping
is pushed down to the child pom.

Signed-off-by: Sean Busbey <busbey@apache.org>
2015-03-13 22:35:52 -05:00
stack 29104da013 HBASE-13188 java.lang.ArithmeticException issue in BoundedByteBufferPool.putBuffer 2015-03-10 08:42:32 -07:00
Daisuke 0654d13403 HBASE-13185 Document hbase.regionserver.thrift.framed.max_frame_size_in_mb more clearly
just added 'in MB'

Signed-off-by: stack <stack@apache.org>
2015-03-09 21:43:16 -07:00
Andrew Purtell 9aa8f0672e HBASE-13183 Make ZK tickTime configurable in standalone HBase (Alex Araujo) 2015-03-09 18:34:49 -07:00
stack 9159c82fbf HBASE-13142 [PERF] Reuse the IPCUtil#buildCellBlock buffer 2015-03-06 14:35:08 -08:00
Jonathan M Hsieh 47ed5cd7ed HBASE-13012 Add shell commands to trigger the mob file compactor (Jingcheng Du and Jiajia Li) 2015-03-04 23:47:05 -08:00
stack 74837d9b1f Revert " HBASE-13142 [PERF] Reuse the IPCUtil#buildCellBlock buffer"
OVERCOMMIT. REVERT.

This reverts commit 55f8f56ad2.
2015-03-04 22:58:02 -08:00
stack 55f8f56ad2 HBASE-13142 [PERF] Reuse the IPCUtil#buildCellBlock buffer
Rename ByteBufferReservoir as BoundedByteBufferPool
2015-03-04 22:44:20 -08:00
Jonathan Lawlor de9791e91e HBASE-11544: [Ergonomics] hbase.client.scanner.caching is dogged and will try to return batch even if it means OOME
Signed-off-by: stack <stack@apache.org>
2015-03-04 17:34:48 -08:00
Misty Stanley-Jones 39425a8558 HBASE-11670 Generate PDF of Reference Guide 2015-03-05 09:31:11 +10:00
Lars Hofhansl 464e7ce685 HBASE-13109 Make better SEEK vs SKIP decisions during scanning. 2015-03-04 14:03:47 -08:00
Enis Soztutar 9899aab12b HBASE-11580 Failover handling for secondary region replicas 2015-03-03 11:48:12 -08:00
zhangduo ce1b81cdfd HBASE-13146 Race Condition in ScheduledChore and ChoreService
Signed-off-by: stack <stack@apache.org>
2015-03-03 11:31:51 -08:00
Jonathan M Hsieh fe335b683c Merge branch 'master' (2/11/15) into hbase-11339
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
	hbase-client/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
	hbase-common/src/main/resources/hbase-default.xml
	hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
	hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestAcidGuarantees.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotReferenceUtil.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java
	pom.xml
	src/main/docbkx/book.xml
	src/main/docbkx/ops_mgt.xml
	src/main/docbkx/schema_design.xml
2015-02-22 12:54:45 -08:00
Ashish Singhi 31f17b17f0 HBASE-13002 Make encryption cipher configurable
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-02-18 11:42:20 -08:00
Abhishek Kumar 7b045d143a HBASE-13050 Empty Namespace validation
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2015-02-18 08:33:19 +01:00
Andrew Purtell 9b2e4ed064 HBASE-13044 Configuration option for disabling coprocessor loading 2015-02-15 11:02:40 -08:00
stack 3babad30e6 HBASE-13030 [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc., addColumn 2015-02-13 15:24:38 -08:00
Enis Soztutar 3e10e6e1a6 HBASE-11569 Flush / Compaction handling from secondary region replicas 2015-02-13 11:08:24 -08:00
Ashish Singhi cfc131e437 HBASE-13038 Fix the java doc continuously reported by Hadoop QA 2015-02-13 09:30:29 -06:00
Andrew Purtell fc2e849cd3 HBASE-13008 Better default for hbase.regionserver.regionSplitLimit parameter (Srikanth Srungarapu) 2015-02-12 10:13:38 -08:00
Bhupendra 02759f2d8c HBASE-13026: Wrong error message in case incorrect snapshot name OR Incorrect table name
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2015-02-12 15:25:35 +01:00
stack 8aa4eeb1c8 HBASE-13007 Fix the test timeouts being caused by ChoreService (Jonathan Lawlor); ADDENDUM 2015-02-11 20:46:41 -08:00
stack a8d325eed8 HBASE-13007 Fix the test timeouts being caused by ChoreService (Jonathan Lawlor) 2015-02-10 21:19:14 -08:00
stack 9c66afbae7 HBASE-12978 Region goes permanently offline (WAS: hbase:meta has a row missing hregioninfo and it causes my long-running job to fail) 2015-02-10 17:03:29 -08:00
stack fa852c4ce6 HBASE-12035 Keep table state in META (Andrey Stepachev) 2015-02-10 14:20:47 -08:00
tedyu ede20aa288 HBASE-13004 Addendum fixes timeout value in message (Andrey Stepachev) 2015-02-10 09:43:31 -08:00
tedyu a3f495f20d HBASE-13004 Make possible to explain why HBaseTestingUtility.waitFor fails (Andrey Stepachev) 2015-02-10 07:33:52 -08:00
tedyu 9d6b237ae8 HBASE-12992 TestChoreService doesn't close services, that can break test on slow virtual hosts (Andrey Stepachev) 2015-02-09 12:15:23 -08:00
stack ac175b1bd9 HBASE-12982 Adding timeouts to TestChoreService 2015-02-06 19:45:39 -08:00
stack 1426f85b15 HBASE-12897 Minimum memstore size is a percentage (Churro Morales) 2015-02-06 16:15:29 -08:00
Jonathan M Hsieh 2c4934eda6 HBASE-11861 Native MOB Compaction mechanisms (Jingcheng Du) 2015-02-06 05:37:13 -08:00
Lars Hofhansl 2583e8de57 HBASE-12976 Set default value for hbase.client.scanner.max.result.size. 2015-02-05 13:29:23 -08:00
Aniket Bhatnagar c812d13a47 HBASE-12108 | Setting classloader so that HBase resources resolve even when HBaseConfiguration is loaded from a different class loader
Signed-off-by: stack <stack@apache.org>
2015-02-03 08:25:07 -08:00