Commit Graph

945 Commits

Author SHA1 Message Date
stack 82554e2750 HBASE-14433 Set down the client executor core thread count from 256 in tests: REAPPLY AGAIN (WAS MISSING JIRA) 2015-09-16 10:15:00 -07:00
stack b6549007b3 Revert "Set down the client executor core thread count from 256 in tests: REAPPLY"
Missing JIRA. Will reapply in a sec with commit log fixed.

This reverts commit c100fb835a.
2015-09-16 10:14:32 -07:00
stack c100fb835a Set down the client executor core thread count from 256 in tests: REAPPLY 2015-09-16 08:57:39 -07:00
Apekshit(Appy) Sharma 1517deee67 HBASE-14400 Fix HBase RPC protection documentation
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
2015-09-15 18:30:24 -07:00
stack 8354ed69ec HBASE-14421 TestFastFail* are flakey; ADDENDUM 2 DISABLE testInterceptorIntercept50Times 2015-09-13 10:33:26 -07:00
stack 37badc04ae HBASE-14421 TestFastFail* are flakey 2015-09-12 22:36:10 -07:00
tedyu 6c90507314 HBASE-14397 PrefixFilter doesn't filter all remaining rows if the prefix is longer than rowkey being compared (Jianwei Cui) 2015-09-11 16:07:49 -07:00
Srikanth Srungarapu e2250e71f8 HBASE-14385 Close the sockets that is missing in connection closure. 2015-09-09 23:39:05 -07:00
Nick Dimiduk 364b977269 HBASE-14382 TestInterfaceAudienceAnnotations should hadoop-compt module resources 2015-09-09 11:11:08 -07:00
stack 30752d5815 HBASE-14308 HTableDescriptor WARN is not actionable (Lars Francke) 2015-09-04 22:44:53 -07:00
Andrew Purtell 513b37603d HBASE-14359 HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction (Victor Xu) 2015-09-03 17:49:06 -07:00
Stephen Yuan Jiang 90b8a3c894 HBASE-14108 Procedure V2 - Administrative Task: provide an API to abort a procedure (Stephen Yuan Jiang) 2015-09-03 07:01:30 -07:00
tedyu d3a7222bfc HBASE-14309 Allow load balancer to operate when there is region in transition by adding force flag 2015-08-29 17:08:40 -07:00
Elliott Clark ab47cb9569 HBASE-14313 After a Connection sees ConnectionClosingException it never recovers -- ADDENDUM 2015-08-27 15:24:15 -07:00
Elliott Clark 886542bd1b HBASE-14313 After a Connection sees ConnectionClosingException on a connection it never recovers 2015-08-27 15:24:10 -07:00
tedyu b8c7a08a9e HBASE-14269 FuzzyRowFilter omits certain rows when multiple fuzzy keys exist (hongbin ma) 2015-08-26 20:49:43 -07:00
stack c127577862 HBASE-14290 Spin up less threads in tests
Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
2015-08-25 16:32:06 -07:00
stack 64f9d43d01 HBASE-13480 ShortCircuitConnection doesn't short-circuit all calls as expected (Jingcheng Du) 2015-08-25 08:01:00 -07:00
stack 5dcb3d85a1 HBASE-14224 Fix coprocessor handling of duplicate classes 2015-08-24 14:12:57 -07:00
tedyu 558aec84e8 HBASE-14241 Fix deadlock during cluster shutdown due to concurrent connection close 2015-08-19 08:56:44 -07:00
Enis Soztutar c9b3d837a0 HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
2015-08-17 16:12:18 -07:00
Enis Soztutar c619e0c76f HBASE-14122 Client API for determining if server side supports cell level security - ADDENDUM for javadoc fix 2015-08-17 14:34:25 -07:00
Andrew Purtell ba4cc6321b HBASE-14122 Client API for determining if server side supports cell level security 2015-08-12 13:27:51 -07:00
tedyu 90b8cc89bd HBASE-14206 MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges (Anton Nazaruk) 2015-08-11 10:01:55 -07:00
Andrew Purtell 68cb53d151 HBASE-12865 WALs may be deleted before they are replicated to peers (He Liangliang) 2015-08-07 15:08:29 -07:00
Andrew Purtell b194052ec0 HBASE-13825 Use ProtobufUtil#mergeFrom and ProtobufUtil#mergeDelimitedFrom in place of builder methods of same name
Incorporates HBASE-14076
2015-08-06 21:48:04 -07:00
Sean Busbey a45651c2cf HBASE-14085 Update LICENSE and NOTICE files.
* corrects license/notice for source distribution
* adds inception year to correct copyright in generated NOTICE files for jars
* updates project names in poms to use "Apache HBase" instead of "HBase" so jar NOTICE files will be correct
* uses append-resources to include supplemental info on jars with 3rd party works in source
* adds an hbase specific resource bundle for jars that include 3rd party works for binaries
** uses supplemental-model to fill in license gaps
** uses the above and a shade plugin transformation to build proper files for shaded jars.
** uses the above and the assembly plugin to build the proper files for bin assembly
* adds a NOTICE item for things copied out of Hadoop (TODO legal-discuss)

Conflicts:
	NOTICE.txt
	hbase-checkstyle/pom.xml
	hbase-resource-bundle/pom.xml
	hbase-server/pom.xml
	hbase-thrift/pom.xml
	pom.xml
2015-08-05 14:52:33 -07:00
Ashish Singhi f274796941 HBASE-14154 DFS Replication should be configurable at column family level
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
	hbase-client/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java
2015-07-31 18:19:07 -07:00
Sean Busbey 9091409800 HBASE-14087 Ensure correct ASF headers for docs/code
* adds missing headers
* corrects some old-form headers to current
* restores proper header for guava copied LimitInputStream
* adds proper header for protobuf copied read/writeRawVarint

Conflicts:
	bin/considerAsDead.sh
	dev-support/rebase_all_git_branches.sh
2015-07-31 11:22:50 -07:00
Srikanth Srungarapu d1ff4cb2c1 HBASE-14097 Log link to client scan troubleshooting section when scanner exceptions happen. 2015-07-28 15:15:45 -07:00
Srikanth Srungarapu da811332cf HBASE-14057 HBase shell user_permission should list super users defined on hbase-site.xml 2015-07-28 11:43:24 -07:00
tedyu 48b968e323 HBASE-13881 Bug in HTable#incrementColumnValue implementation (Gabor Liptak) 2015-07-21 02:37:02 -07:00
Andrew Purtell c42fc1dd56 HBASE-14089 Remove unnecessary draw of system entropy from RecoverableZooKeeper 2015-07-15 18:41:45 -07:00
Ashish Singhi 789d2a94b7 HBASE-8642 [Snapshot] List and delete snapshot by table
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-07-15 15:56:08 -07:00
terence.yoo 173f343aea HBASE-14041 Do not clear MetaCache if a ThrottlingException is thrown
Amending-Author: Sean Busbey <busbey@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
2015-07-15 03:27:05 -05:00
Enis Soztutar 426bd09777 HBASE-13997 ScannerCallableWithReplicas cause Infinitely blocking (Zephyr Guo and Enis)
Conflicts:
	hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
2015-07-13 12:24:54 -07:00
Matteo Bertozzi b62f134545 HBASE-13415 Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-07-13 11:19:02 -05:00
Sean Busbey 88ff206c57 Revert "Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang)"
This reverts commit 4eb84651a2.
2015-07-13 11:16:21 -05:00
stack a81b3c5afe HBASE-14052 Mark a few methods in CellUtil audience private since only make sense internally to hbase 2015-07-10 10:44:08 -07:00
Matteo Bertozzi 4eb84651a2 Procedure v2 - Use nonces for double submits from client (Stephen Yuan Jiang) 2015-07-09 08:13:32 -07:00
stack 24cf287df4 HBASE-13337 Table regions are not assigning back, after restarting all regionservers at once (Samir Ahmic) 2015-07-08 17:20:23 -07:00
Andrey Stepachev 8d71d283b9 HBASE-13646 HRegion#execService should not try to build incomplete messages
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-07-06 10:36:13 -05:00
Ashish Singhi ab9a0b80af HBASE-13925 Use zookeeper multi to clear znodes in ZKProcedureUtil
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
2015-07-03 12:29:55 -07:00
stack 09846ff81a HBASE-13895 DATALOSS: Region assigned before WAL replay when abort (Enis Soztutar) -- ADDENDUM 2015-07-02 10:05:58 -07:00
stack 0f17b76796 HBASE-13895 DATALOSS: Region assigned before WAL replay when abort (Enis Soztutar) 2015-07-01 17:30:16 -07:00
stack 93b0b41603 HBASE-13983 Doc how the oddball HTable methods getStartKey, getEndKey, etc. will be removed in 2.0.0 2015-07-01 13:05:25 -07:00
Matteo Bertozzi 7ece46a607 HBASE-13995 ServerName is not fully case insensitive 2015-07-01 09:40:11 -07:00
Sean Busbey a58848507a HBASE-13990 make maven site generation work with jdk8
* includes additiona branch-1 specific fixes to javadocs
* includes rollback of 2 changes from HBASE-13898 that didn't apply to branch-1

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
2015-07-01 08:00:15 -05:00
Gábor Lipták 8e6fb569c5 HBASE-13963 Do not leak jdk.tools dependency from hbase-annotations
Signed-off-by: Sean Busbey <busbey@apache.org>

Conflicts:
	hbase-common/pom.xml
2015-06-26 08:56:14 -05:00
Nick Dimiduk 5a24d16f4c HBASE-13938 Deletes done during the region merge transaction may get eclipsed (ddas, enis, ndimiduk) 2015-06-23 11:08:48 -07:00
Mikhail Antonov 7d778e892c HBASE-13906 Improve handling of NeedUnmanagedConnectionException 2015-06-22 23:36:04 -07:00
Misty Stanley-Jones 9ac6539f6a HBASE-13898 correct additional javadoc failures under java 8 <Gabor Liptak>
Ammending-Author: Sean Busbey <busbey@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/JMXJsonServlet.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterChunk.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
2015-06-23 01:14:15 -05:00
Mikhail Antonov 84675ef615 HBASE-13103 [ergonomics] add region size balancing as a feature of master 2015-06-22 22:48:19 -07:00
Sean Busbey f2f19ddb5c HBASE-13909 update branch-1 poms to 1.3.0-SNAPSHOT 2015-06-15 22:30:56 -05:00
Ashish Singhi e949f0c6b0 HBASE-13901 Error while calling watcher on creating and deleting an HBase table
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-15 11:28:16 -07:00
Gábor Lipták 0a0ff3354a HBASE-13569 Correct Javadoc (for Java8)
Signed-off-by: Sean Busbey <busbey@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/ConstraintException.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MiniBatchOperationInProgress.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterWriter.java
2015-06-13 22:23:53 -05:00
tedyu 4468f3ce95 HBASE-13829 Add more ThrottleType (Guanghao Zhang) 2015-06-13 06:30:26 -07:00
Josh Elser e78572a985 HBASE-13892 NPE in ClientScanner on null results array
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-06-11 19:27:06 -07:00
tedyu 254de0c451 HBASE-13875 Clock skew between master and region server may render restored region without server address 2015-06-09 18:26:56 -07:00
ramkrishna d34e9c5c5c HBASE-13686 - Fail to limit rate in RateLimiter (Ashish Singhi) 2015-06-07 22:25:32 +05:30
Enis Soztutar deca3930b9 HBASE-13851 RpcClientImpl.close() can hang with cancelled replica RPCs 2015-06-06 14:02:00 -07:00
Changgeng Li 93148719ba HBASE-13638 Put copy constructor is shallow
Deep copy the cell list

Signed-off-by: Elliott Clark <eclark@apache.org>
2015-06-01 13:57:19 -07:00
Matteo Bertozzi adbc3dd097 HBASE-13779 Calling table.exists() before table.get() end up with an empty Result (addendum) 2015-05-29 17:42:11 -07:00
stack 32f4a6ad8f HBASE-13799 javadoc how Scan gets polluted when used; if you set attributes or ask for scan metrics 2015-05-29 11:32:17 -07:00
Matteo Bertozzi 5b67c7a0da HBASE-13779 Calling table.exists() before table.get() end up with an empty Result 2015-05-29 16:44:39 +01:00
Geoffrey ffcd4d424f HBASE 13796 - Fixed ZKUtil's cleaning of the zookeeper quorum setting
Signed-off-by: stack <stack@apache.org>
2015-05-28 20:07:46 -07:00
stack 94f0ee7ee3 HBASE-13616 Move ServerShutdownHandler to Pv2 2015-05-28 15:04:27 -07:00
Nick Dimiduk 2f9851af26 HBASE-13761 Optimize FuzzyRowFilter (Vladimir Rodionov) 2015-05-28 10:17:46 -07:00
Andrew Purtell a035baab46 HBASE-13768 ZooKeeper znodes are bootstrapped with insecure ACLs in a secure configuration (Enis Soztutar) 2015-05-27 12:32:45 -07:00
Matteo Bertozzi cb7675c57f HBASE-13767 Allow ZKAclReset to set and not just clear ZK ACLs 2015-05-27 18:34:17 +01:00
stack a9e2f4cf31 HBASE-5980 Scanner responses from RS should include metrics on rows/KVs filtered; ADDENDUM -- ADD MISSING FILES 2015-05-21 11:11:06 -07:00
stack 078a9a97c3 HBASE-5980 Scanner responses from RS should include metrics on rows/KVs filtered 2015-05-21 11:09:14 -07:00
Enis Soztutar 420baa42ce HBASE-13709 Updates to meta table server columns may be eclipsed
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenMetaHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
2015-05-20 19:19:52 -07:00
Nick Dimiduk 49fc6c817d HBASE-13711 Provide an API to set min and max versions in HColumnDescriptor (Stephen Yuan Jiang) 2015-05-20 11:41:23 -07:00
tedyu 181ec60510 HBASE-13704 Hbase throws OutOfOrderScannerNextException when MultiRowRangeFilter is used (Aleksandr Maksymenko) 2015-05-19 20:21:08 -07:00
ted malaska 00636cc998 HBASE-13677 changed RecoverableZooKeeper logs about retries from info and warn to debug
Signed-off-by: Sean Busbey <busbey@cloudera.com>
2015-05-18 10:31:40 -05:00
Enis Soztutar 77b155858f HBASE-13661 Correct binary compatibility issues discovered in 1.1.0RC0 2015-05-11 18:33:44 -07:00
Sean Busbey 6213fa2fce HBASE-13611 update clover profile to work with clover 4.x and maven 3.
* change pom to use a maven 3 compat version of clover
* add clover to javadoc plugin deps so that instrumented doclet works
* modify IA annotation test to filter out clover instrumentation
* make splitlog counters check for atomiclong before casting
2015-05-11 01:23:35 -05:00
tedyu ec3d7189ad HBASE-13625 Use HDFS for HFileOutputFormat2 partitioner's path (Stephen Yuan Jiang) 2015-05-06 07:29:57 -07:00
Lars Hofhansl 0e76cf5be4 HBASE-13333 Renew Scanner Lease without advancing the RegionScanner. 2015-05-02 17:52:27 -07:00
Andrew Purtell 60b356a853 HBASE-13312 SmallScannerCallable does not increment scan metrics 2015-05-01 16:33:11 -07:00
Elliott Clark d16c8ab71b HBASE-13325 Protocol Buffers 2.5 no longer available for download on code.google.com 2015-05-01 13:31:40 -07:00
Matt Warhaftig 5a87c3910e HBASE-13358 - Update VisibilityClient to accept Connection objects.
Signed-off-by: Srikanth Srungarapu <ssrungarapu@cloudera.com>
2015-04-30 21:21:41 -07:00
tedyu 20b6c31880 HBASE-13594 MultiRowRangeFilter shouldn't call HBaseZeroCopyByteString.wrap() directly 2015-04-29 10:35:45 -07:00
Nick Dimiduk cc5a0f361a HBASE-13417 batchCoprocessorService() does not handle NULL keys (Abhishek Singh Chouhan) 2015-04-28 16:39:56 -07:00
Usha Kuchibhotla 0dbbc8b8de HBASE-11677 Making Logger instance modifiers consistent.
* IA.Public accessible logger instances deprecated
* logger instances modified by tests left in place
* all others made private static final

Signed-off-by: Sean Busbey <busbey@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientIdGenerator.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java
	hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java
	hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/TestTableDescriptor.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
2015-04-28 10:10:21 -05:00
Nick Dimiduk c678a28fca HBASE-13518 Typo in hbase.hconnection.meta.lookup.threads.core parameter (Devaraj Das) 2015-04-27 23:06:51 -07:00
Nick Dimiduk 566dfda5b7 HBASE-13466 Document deprecations in 1.x - Part 1 (Lars Francke) 2015-04-26 13:11:35 -07:00
Sean Busbey 1a0c61c974 HBASE-13546 handle nulls in MasterAddressTracker when there is no master active. 2015-04-24 13:54:36 -05:00
Jonathan Lawlor c8d8499da8 HBASE-13527 The default value for hbase.client.scanner.max.result.size is never actually set on Scans
Signed-off-by: stack <stack@apache.org>
2015-04-22 13:29:48 -07:00
ramkrishna 385b5fa1f6 HBASE-13502 - Deprecate/remove getRowComparator() in TableName (Ram) 2015-04-22 09:34:10 +05:30
zhangduo ca7efc183a HBASE-13499 AsyncRpcClient test cases failure in powerpc 2015-04-14 23:00:17 +08:00
Enis Soztutar 60c30c707c HBASE-13491 Issue in FuzzyRowFilter#getNextForFuzzyRule (Anoop Sam John) 2015-04-17 21:56:04 -07:00
Jonathan Lawlor a4f77d49a5 HBASE-13090 Progress heartbeats for long running scanners
Signed-off-by: stack <stack@apache.org>
2015-04-17 15:43:13 -07:00
Nick Dimiduk cf45c8d30a Bump pom version to 1.2.0-SNAPSHOT 2015-04-16 17:30:48 -07:00
Devaraj Das fe8658ce35 HBASE-13460. Revise the MetaLookupPool executor-related defaults (introduced in HBASE-13036). 2015-04-15 07:56:58 -07:00
Matteo Bertozzi 7c5ae63850 HBASE-13290 Procedure v2 - client enable/disable table sync (Stephen Yuan Jiang) 2015-04-15 11:05:49 +01:00
Matteo Bertozzi 67149d253b HBASE-13204 Procedure v2 - client create/delete table sync 2015-04-15 11:02:26 +01:00
Matteo Bertozzi 58b1598b44 HBASE-13203 Procedure v2 - master create/delete table 2015-04-15 11:01:36 +01:00
Matteo Bertozzi 4fc39fd7c9 HBASE-13457 SnapshotExistsException doesn't honor the DoNotRetry 2015-04-13 23:22:28 +01:00