Commit Graph

620 Commits

Author SHA1 Message Date
zhangduo d9f18c7f03 HBASE-16793 Exclude shaded protobuf files from rat check 2016-10-11 14:00:36 +08:00
Dima Spivak 3c35a722d9 Revert "HBASE-16750 hbase compilation failed on power system (Saravanan Krishnamoorthy)"
This reverts commit d1e40bf0bd.
2016-10-10 10:08:41 -05:00
tedyu d1e40bf0bd HBASE-16750 hbase compilation failed on power system (Saravanan Krishnamoorthy) 2016-10-06 06:48:40 -07:00
tedyu 34ad9652ae HBASE-16750 hbase compilation failed on power system - revert due to failure in mvn site 2016-10-04 09:24:47 -07:00
tedyu b952e64751 HBASE-15560 TinyLFU-based BlockCache - revert pending performance verification 2016-10-04 08:37:29 -07:00
tedyu 9e0c2562a9 HBASE-15560 TinyLFU-based BlockCache (Ben Manes) 2016-10-04 05:15:51 -07:00
stack 95c1dc93fb HBASE-15638 Shade protobuf
Which includes

    HBASE-16742 Add chapter for devs on how we do protobufs going forward

    HBASE-16741 Amend the generate protobufs out-of-band build step
    to include shade, pulling in protobuf source and a hook for patching protobuf

    Removed ByteStringer from hbase-protocol-shaded. Use the protobuf-3.1.0
    trick directly instead. Makes stuff cleaner. All under 'shaded' dir is
    now generated.

    HBASE-16567 Upgrade to protobuf-3.1.x
    Regenerate all protos in this module with protoc3.
    Redo ByteStringer to use new pb3.1.0 unsafebytesutil
    instead of HBaseZeroCopyByteString

    HBASE-16264 Figure how to deal with endpoints and shaded pb Shade our protobufs.
    Do it in a manner that makes it so we can still have in our API references to
    com.google.protobuf (and in REST). The c.g.p in API is for Coprocessor Endpoints (CPEP)

            This patch is Tactic #4 from Shading Doc attached to the referenced issue.
            Figuring an appoach took a while because we have Coprocessor Endpoints
            mixed in with the core of HBase that are tough to untangle (FIX).

            Tactic #4 (the fourth attempt at addressing this issue) is COPY all but
            the CPEP .proto files currently in hbase-protocol to a new module named
            hbase-protocol-shaded. Generate .protos again in the new location and
            then relocate/shade the generated files. Let CPEPs keep on with the
            old references at com.google.protobuf.* and
            org.apache.hadoop.hbase.protobuf.* but change the hbase core so all
            instead refer to the relocated files in their new location at
            org.apache.hadoop.hbase.shaded.com.google.protobuf.*.

            Let the new module also shade protobufs themselves and change hbase
            core to pick up this shaded protobuf rather than directly reference
            com.google.protobuf.

            This approach allows us to explicitly refer to either the shaded or
            non-shaded version of a protobuf class in any particular context (though
            usually context dictates one or the other). Core runs on shaded protobuf.
            CPEPs continue to use whatever is on the classpath with
            com.google.protobuf.* which is pb2.5.0 for the near future at least.

            See above cited doc for follow-ons and downsides. In short, IDEs will complain
            about not being able to find the shaded protobufs since shading happens at package
            time; will fix by checking in all generated classes and relocated protobuf in
            a follow-on. Also, CPEPs currently suffer an extra-copy as marshalled from
            non-shaded to shaded. To fix. Finally, our .protos are duplicated; once
            shaded, and once not. Pain, but how else to reveal our protos to CPEPs or
            C++ client that wants to talk with HBase AND shade protobuf.

            Details:

            Add a new hbase-protocol-shaded module. It is a copy of hbase-protocol
    i       with all relocated offset from o.a.h.h. to o.a.h.h.shaded. The new module
            also includes the relocated pb. It does not include CPEPs. They stay in
            their old location.

            Add another module hbase-endpoint which has in it all the endpoints
            that ship as part of hbase -- at least the ones that are not
            entangled with core such as AccessControl and Auth. Move all protos
            for these CPEPs here as well as their unit tests (mostly moving a
            bunch of stuff out of hbase-server module)

            Much of the change looks like this:

                 -import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
                 -import org.apache.hadoop.hbase.protobuf.generated.ClusterIdProtos;
                 +import org.apache.hadoop.hbase.protobuf.shaded.ProtobufUtil;
                 +import org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterIdProtos;

            In HTable and in HBaseAdmin, regularize the way Callables are used and also hide
            protobuf usage as much as possible moving it up into Callable super classes or out
            to utility classes. Still TODO is adding in of retries, etc., but can wait on
            procedure which will redo all this.

            Also in HTable and HBaseAdmin as well as in HRegionServer and Server, be explicit
            when using non-shaded protobuf. Do the full-path so it is clear. This is around
            endpoint coprocessors registration of services and execution of CPEP methods.

            Shrunk ProtobufUtil by moving methods used by one CPEP only back to the CPEP either
            into Client class or as new Util class; e.g. AccessControlUtil.

            There are actually two versions of ProtobufUtil now; a shaded one and a subset
            that is used by CPEPs doing non-shaded work.

            Made it so hbase-common no longer depends on hbase-protocol (with Matteo's help)

            R*Converter classes got moved down under shaded package -- they are for internal
            use only. There are no non-shaded versions of these classes.

            D hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable
            D RetryingCallableBase
             Not used anymore and we have too many tiers of Callables so removed/cleaned-up.

            A ClientServicecallable
             Had to add this one. RegionServerCallable was made generic so it could be used
             for a few Interfaces (Client and Admin). Then added ClientServiceCallable to
             implement RegionServerCallable with the Client Interface.
2016-10-03 21:37:32 -07:00
tedyu cc237c4b78 HBASE-16750 hbase compilation failed on power system (Saravanan Krishnamoorthy) 2016-10-03 15:59:09 -07:00
Jerry He 2765b9d9d9 HBASE-16667 Building with JDK 8: ignoring option MaxPermSize=256m (Niels Basjes) 2016-09-24 16:07:25 -07:00
zhangduo 105bfc7d7c HBASE-15624 Move master branch/hbase-2.0.0 to jdk-8 only 2016-09-12 21:54:52 +08:00
Dima Spivak fe22208f09 Add Dima Spivak as developer 2016-08-31 20:19:29 -07:00
Misty Stanley-Jones e60a4302fd HBASE-16426 Remove organization affiliations from developer list
(cherry picked from commit 293e3a96305c8675168c4d0b80334f25dae3f539)
2016-08-17 18:38:12 -07:00
Sean Busbey cc12be39e5 HBASE-16318 consistently use the correct name for 'Apache License, Version 2.0'
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-08-17 12:51:22 -07:00
tedyu fb668a0d3f HBASE-16267 Remove commons-httpclient dependency from hbase-rest module 2016-08-10 21:28:45 -07:00
tedyu 4e08a8bec9 HBASE-16267 Revert due to failure of TestLogLevel 2016-08-06 09:27:54 -07:00
Sean Busbey c59f76485e HBASE-16340 exclude Xerces iplementation jars from coming in transitively.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-08-05 10:16:29 -05:00
Sean Busbey 60b79e2daa HBASE-16321 ensure no findbugs-jsr305
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-08-05 10:16:29 -05:00
Nick Dimiduk 209b6f74c7 HBASE-16317 revert all ESAPI changes
Revert "HBASE-15270 Use appropriate encoding for "filter" field in TaskMonitorTmpl.jamon."

This reverts commit bba4f107c1.

Revert "HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic)"

This reverts commit 68b300173f.

 Conflicts:
	hbase-server/pom.xml

Revert "HBASE-15329 Cross-Site Scripting: Reflected in table.jsp (Samir Ahmic)"

This reverts commit 4b3e38705c.

 Conflicts:
	hbase-server/src/main/resources/hbase-webapps/master/table.jsp

Revert "HBASE-15369 Handle NPE in region.jsp (Samir Ahmic)"

This reverts commit 3826894f89.
2016-08-03 20:47:02 -07:00
tedyu 379b86c5df HBASE-16267 Remove commons-httpclient dependency from hbase-rest module 2016-08-02 10:53:57 -07:00
Francis Liu e9f5db7213 add Francis Liu to dev list 2016-07-07 14:15:47 -07:00
Jingcheng Du 3e0602be16 Add jingchengdu to pom.xml 2016-06-22 19:21:21 +08:00
Apekshit Sharma 9bb492f987 Add Appy to devs list.
Change-Id: Iab44f9bdd3b803664431cd2a5b751e2ee45433f3
2016-06-20 01:10:41 -07:00
tedyu ae5fe1e616 HBASE-5291 Add Kerberos HTTP SPNEGO authentication support to HBase web consoles (Josh Elser) 2016-06-15 09:26:44 -07:00
Jurriaan Mous bd45cf3476 HBASE-16004 Update to Netty 4.1.1
Signed-off-by: stack <stack@apache.org>
2016-06-10 12:14:05 -07:00
Sean Busbey 108d39a727 HBASE-15925 provide default values for hadoop compat module related properties that match default hadoop profile.
Signed-off-by: Mikhail Antonov <antonov@apache.org>
2016-06-09 16:29:28 -05:00
zhangduo 224b03b2a5 HBASE-15801 Upgrade checkstyle for all branches 2016-05-10 09:33:46 +08:00
tedyu c716a75416 HBASE-15767 upgrade httpclient to 4.3.6
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-05 15:41:26 -05:00
Enis Soztutar 91291e3780 HBASE-15732 hbase-rsgroups should be in the assembly 2016-04-28 17:14:54 -07:00
Apekshit a56b374c52 HBASE-15644 Use org.scala-tools:mave-scala-plugin for scaladocs.
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-04-18 01:53:43 -05:00
Ashish Singhi f1fc5208aa Add ashishsinghi to pom.xml
Change-Id: Ib0709d92622350c50bee7e8a0bae0554d40df882
2016-03-30 11:09:30 +05:30
tedyu 95e6d2276b HBASE-15300 Upgrade to zookeeper 3.4.8 2016-03-23 13:05:17 -07:00
stack 64204b96c1 HBASE-15349 Update surefire version to 2.19.1; Trying a REVERT to see if this responsible for plethora of test timeouts on hadoopqa 2016-03-20 11:22:22 -07:00
Yu Li abc27c6061 Add liyu to pom.xml 2016-03-17 13:05:16 +08:00
Enis Soztutar ca816f0780 HBASE-6721 RegionServer Group based Assignment (Francis Liu) 2016-03-14 18:28:50 -07:00
Apekshit 3c660e2a0f HBASE-15349 Update surefire version to 2.19.1. (Apekshit)
Signed-off-by: stack <stack@apache.org>
2016-02-26 12:26:40 -08:00
Jonathan M Hsieh afa63a91d6 HBASE-14877 maven archetype: client application (Daniel Vimont) 2016-02-19 06:39:43 -08:00
chenheng 68b300173f HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic) 2016-02-15 13:53:47 +08:00
stack d82ae42126 Revert "HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic)"
Revert mistaken commit.

This reverts commit efc7a0d347.
2016-02-06 05:17:29 -08:00
stack efc7a0d347 HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic) 2016-02-05 21:28:46 -08:00
zhangduo bb71446e15 update zhangduo affiliation 2016-02-05 15:47:29 +08:00
zhangduo 46ea5494a5 update zhangduo affiliation 2016-01-15 11:53:59 +08:00
Sean Busbey 164aeb5399 HBASE-13525 replace test-patch with customizations needed to use yetus
Signed-off-by: stack <stack@apache.org>
2016-01-08 07:39:40 -06:00
Sean Busbey 822fead744 HBASE-15011 turn off the jdk8 javadoc linter. 2015-12-29 11:00:00 -06:00
stack eb59d4d769 Revert "HBASE-14979 Update to the newest Zookeeper release"
This reverts commit ef92a6a067.
2015-12-18 12:48:49 -08:00
Mikhail Antonov abe30b52a8 HBASE-14534 Bump yammer/coda/dropwizard metrics dependency version 2015-12-15 12:11:27 -08:00
Elliott Clark ef92a6a067 HBASE-14979 Update to the newest Zookeeper release 2015-12-14 21:07:20 -08:00
Elliott Clark abb2e95f66 HBASE-14745 Shade the last few dependencies in hbase-shaded-client 2015-12-10 18:44:12 -08:00
Mikhail Antonov b449b0f1ce Updated affiliation for Mikhail Antonov 2015-12-08 12:10:25 -08:00
Andrew Purtell f553bcf469 HBASE-14799 Commons-collections object deserialization remote command execution vulnerability 2015-11-23 15:40:30 -08:00
stack 62aba61bea HBASE-14829 Add more checkstyles (appy) 2015-11-19 21:33:14 -08:00