Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add TODOs for code that needs looking at 

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1604892 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2014-06-23 17:46:29 +00:00
parent a80b4533b3
commit 4006d7e4f2
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java vendored
View File

@ -6049,7 +6049,7 @@ public class TestProtocolRequirements extends AbstractProtocolTest {
// received-by // received-by
if (!Pattern.matches(tokenRegexp, parts[1])) { if (!Pattern.matches(tokenRegexp, parts[1])) {
// host : port // host : port
new HttpHost(parts[1]); new HttpHost(parts[1]); // TODO - unused - is this a test bug? else use Assert.assertNotNull
} }
// comment // comment

2
httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
View File

@ -177,7 +177,7 @@ public class HttpAuthenticator {
final HttpContext context) throws HttpException, IOException { final HttpContext context) throws HttpException, IOException {
AuthScheme authScheme = authState.getAuthScheme(); AuthScheme authScheme = authState.getAuthScheme();
Credentials creds = authState.getCredentials(); Credentials creds = authState.getCredentials();
switch (authState.getState()) { switch (authState.getState()) { // TODO add UNCHALLENGED and HANDSHAKE cases
case FAILURE: case FAILURE:
return; return;
case SUCCESS: case SUCCESS:

1
httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
View File

@ -176,6 +176,7 @@ public class TestSSLSocketFactory {
@Test @Test
public void testClientAuthSSLAliasChoice() throws Exception { public void testClientAuthSSLAliasChoice() throws Exception {
// TODO unused - is there a bug in the test?
final PrivateKeyStrategy aliasStrategy = new PrivateKeyStrategy() { final PrivateKeyStrategy aliasStrategy = new PrivateKeyStrategy() {
@Override @Override