Apache/httpcomponents-client
1
0
Fork 0
mirror of https://github.com/apache/httpcomponents-client.git synced 2025-02-17 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

BasicExpiresHandler is annotated as immutable but is not. (#240)

Browse Source
This commit is contained in:
Gary Gregory 2020-07-10 08:57:24 -04:00 committed by GitHub
parent 9866865357
commit 66f8ca1f09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java
View File

@ -46,11 +46,11 @@
public class BasicExpiresHandler extends AbstractCookieAttributeHandler implements CommonCookieAttributeHandler { public class BasicExpiresHandler extends AbstractCookieAttributeHandler implements CommonCookieAttributeHandler {
/** Valid date patterns */ /** Valid date patterns */
private final String[] datepatterns; private final String[] datePatterns;
public BasicExpiresHandler(final String[] datepatterns) { public BasicExpiresHandler(final String[] datePatterns) {
Args.notNull(datepatterns, "Array of date patterns"); Args.notNull(datePatterns, "Array of date patterns");
this.datepatterns = datepatterns; this.datePatterns = datePatterns.clone();
} }
@Override @Override
@ -60,7 +60,7 @@ public void parse(final SetCookie cookie, final String value)
if (value == null) { if (value == null) {
throw new MalformedCookieException("Missing value for 'expires' attribute"); throw new MalformedCookieException("Missing value for 'expires' attribute");
} }
final Date expiry = DateUtils.parseDate(value, this.datepatterns); final Date expiry = DateUtils.parseDate(value, this.datePatterns);
if (expiry == null) { if (expiry == null) {
throw new MalformedCookieException("Invalid 'expires' attribute: " throw new MalformedCookieException("Invalid 'expires' attribute: "
+ value); + value);