HTTPCLIENT-1609: Stale connection check in PoolingHttpClientConnectionManager has no effect

Contributed by Charles Lip <rene1 at singnet.com.sg>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1658897 13f79535-47bb-0310-9956-ffa450edef68

RELEASE_NOTES.txt

@@ -1,3 +1,12 @@
+Changes since 4.4
+-------------------
+
+* [HTTPCLIENT-1609] Stale connection check in PoolingHttpClientConnectionManager has no effect.
+  Internal connection pool does not correctly implement connection validation.
+  Contributed by Charles Lip <rene1 at singnet.com.sg>
+
+
+
 Release 4.4 Final
 -------------------
 

httpclient/src/main/java/org/apache/http/impl/conn/CPool.java

@@ -64,4 +64,9 @@ class CPool extends AbstractConnPool<HttpRoute, ManagedHttpClientConnection, CPo
         return new CPoolEntry(this.log, id, route, conn, this.timeToLive, this.tunit);
     }
 
+    @Override
+    protected boolean validate(final CPoolEntry entry) {
+        return !entry.getConnection().isStale();
+    }
+
 }