Address error-prone CheckReturnValue errors

Found via Guava 20.0.
This commit is contained in:
Andrew Gaul 2016-04-28 13:31:58 -07:00
parent ab3a6f003b
commit 0af3380a60
2 changed files with 9 additions and 9 deletions

View File

@ -74,9 +74,9 @@ public class NovaImageExtensionExpectTest extends BaseNovaComputeServiceExpectTe
public void testCreateImage() { public void testCreateImage() {
Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder(); Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder();
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(serverDetail, serverDetailResponse).build(); requestResponseMap.put(serverDetail, serverDetailResponse);
requestResponseMap.put(createImage, createImageResponse).build(); requestResponseMap.put(createImage, createImageResponse);
requestResponseMap.put(getImage, getImageResponse).build(); requestResponseMap.put(getImage, getImageResponse);
ImageExtension apiThatCreatesImage = requestsSendResponses(requestResponseMap.build()).getImageExtension().get(); ImageExtension apiThatCreatesImage = requestsSendResponses(requestResponseMap.build()).getImageExtension().get();

View File

@ -69,7 +69,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder(); Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder();
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(list, listResponse).build(); requestResponseMap.put(list, listResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();
@ -90,7 +90,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder(); Builder<HttpRequest, HttpResponse> requestResponseMap = ImmutableMap.<HttpRequest, HttpResponse> builder();
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(list, listResponse).build(); requestResponseMap.put(list, listResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();
@ -125,7 +125,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(serverReq, serverResponse); requestResponseMap.put(serverReq, serverResponse);
requestResponseMap.put(list, listResponse).build(); requestResponseMap.put(list, listResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();
@ -146,7 +146,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse); requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse);
requestResponseMap.put(list, listResponse).build(); requestResponseMap.put(list, listResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();
@ -188,7 +188,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(create, createResponse); requestResponseMap.put(create, createResponse);
requestResponseMap.put(list, listResponse); requestResponseMap.put(list, listResponse);
requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse).build(); requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();
@ -221,7 +221,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService
requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess);
requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse);
requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse); requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse);
requestResponseMap.put(delete, deleteResponse).build(); requestResponseMap.put(delete, deleteResponse);
SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();