Andrew Gaul
e058973abc
Ensure SOME_CONSTANTS are static final
...
Found via error-prone.
2017-03-17 16:59:41 -07:00
Andrew Gaul
3c9f66b8e9
Avoid lower-case l literal suffix
...
Readers can confuse this with 1. Found via error-prone. Fixed via:
find -name \*.java | xargs sed -i 's/\( [0-9][0-9]*\)l/\1L/g'
find -name \*.java | xargs sed -i 's/\(([0-9][0-9]*\)l/\1L/g'
2016-10-23 14:24:35 -07:00
Andrew Gaul
e423bc949e
Avoid use of primitive wrapper constructors
...
Deprecated in Java 9.
2016-05-09 22:47:27 -07:00
Andrew Gaul
3cf4e3d79c
JCLOUDS-1101: Correct generics wildcard errors
...
Always incorrect but previously broken on Java 9. Reference:
https://bugs.openjdk.java.net/browse/JDK-8075793
2016-04-18 09:49:58 -07:00
Andrew Gaul
b47c50b7a5
Correct malformed format strings
...
Found via error-prone.
2015-12-12 08:53:08 +08:00
Stuart Hendren
ada17d3e47
[elasticstack] fix for incorrect logging message
...
Was logging when it was present rather than when it had failed to find it.
2015-10-24 21:39:40 -07:00
Oliver Gondža
edde721937
JCLOUDS-962: Make all @Provider methods final
2015-09-02 23:54:44 +02:00
Andrew Gaul
4f566d3b6e
Address and suppress FindBugs warnings
2015-03-30 20:40:10 -07:00
Jeremy Daggett
d3c1e2eab4
Use AutoService to generate service loader metadata
2015-01-09 11:22:12 -08:00
Adrian Cole
0012e6f950
JCLOUDS-534 Avoid runtime incompatibility introduced by Guava's closeQuietly.
2014-10-29 17:01:26 -07:00
Ignasi Barrera
c73ed64fd0
JCLOUDS-761: Delete disk if image operation fails in ElasticStack
2014-10-27 16:58:03 +01:00
Adrian Cole
3980cd791b
Revert "JCLOUDS-653: Address Guava 18 deprecations"
...
This reverts commit 95cfc0d950
.
Many conflicts due to duration between above commit and now
2014-10-24 10:45:58 -07:00
Adrian Cole
99e217b720
Move off confusing test names.
2014-10-05 17:22:18 -07:00
Adrian Cole
1b2cee0700
JCLOUDS-40 Replaced incorrect use of @ConfiguresRestClient and deleted old rest client modules.
2014-10-05 16:21:16 -07:00
Andrew Gaul
5399cb6877
Avoid unnecessary boxing
...
Found with FindBugs.
2014-08-30 14:30:47 -07:00
Andrew Gaul
63d43f236e
Correct unusual equals implementations
...
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Jeremy Daggett
e711275fb1
Prefer isEmpty() for collections rather than size()
2014-08-20 11:07:48 -07:00
Andrew Gaul
95cfc0d950
JCLOUDS-653: Address Guava 18 deprecations
...
Mostly renaming Objects.toStringHelper to MoreObjects.toStringHelper.
2014-08-08 11:12:21 -07:00
Andrew Gaul
fb60d76704
JCLOUDS-622: Remove most vestiges of InputSupplier
...
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-07-16 16:07:59 -07:00
Ignasi Barrera
eb884e7c09
JCLOUDS-618: Allow servers without boot device in ElasticStack
2014-06-27 19:19:42 +02:00
Andrew Gaul
9cdd53b0b7
JCLOUDS-546: Remove Javadoc @author annotations
...
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
Ignasi Barrera
a7e342422c
JCLOUDS-517: New ElasticHosts images and regions
...
Added the new ElasticHosts regions.
Updated the ElasticStack api to get the list of standard
drives using an API call. All providers except ServerLove
support the new API call, so the old logic in the ElasticStack
api has been moved to that provider. The rest of providers will now
extract all the OperatingSystem information by parsing the name of the
StandardDrive.
A unit test has been added to the ElasticStack api with all the images
that were hardcoded, to make sure all names are still parsed as expected
and all information in the existing providers is kept.
Modified the default template for all ElasticHosts providers to
match newer Ubuntu images and updated the Template*Live tests
accordingly.
Also refactored the WellKnownImage map to a supplier to lazy load it
when needed and avoid unexpected errors when building the Guice injector
if there are authentication errors or similar.
2014-06-02 16:57:44 +02:00
Andrew Gaul
70cf3e1f7c
Make constants final classes instead of interfaces
...
This commit prohibits implementation of the empty interface and
instantiation of the class. Refer to _Effective Java_ item 19 for
more background.
2014-05-16 09:45:52 -07:00
Audrius Butkevicius
05c2986d08
JCLOUDS-426. Update Elasticstack vnc password key
2014-01-17 12:50:24 +01:00
Andrew Gaul
c7b0f66544
Replace calls to Closeables.closeQuietly
...
Guava 16 removes this API. Replace with Closeables2.closeQuietly.
References JCLOUDS-413 and JCLOUDS-415.
2013-12-21 12:30:59 -08:00
Andrew Gaul
828d8790c2
Enforce no unused imports via Checkstyle
...
Removed with:
mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
2013-12-11 17:27:43 -08:00
Andrew Gaul
4cef85d1cd
Address Checkstyle violations in tests
2013-12-09 14:40:07 -08:00
Andrew Bayer
23e43b2c8d
JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions.
2013-11-21 10:15:25 -08:00
Andrew Gaul
d8490f872d
Enable some Xlint warnings
...
Also address a handful of warnings.
2013-09-04 19:45:44 -07:00
Andrew Bayer
a2af31c419
Removed async from elasticstack
2013-08-02 07:57:41 -07:00
adriancole
ed2f18a1af
JCLOUDS-31. updated to ASF headers via mvn com.mycila.maven-license-plugin:maven-license-plugin:format
2013-05-16 21:30:37 -07:00
adriancole
053197fe61
deprecated all top-level Async apis and clients
2013-04-09 10:18:31 -07:00
adriancole
36dd831b84
moved all code off use of RestContext except CloudStackContext, which will use it until 1.7
2013-04-09 09:23:31 -07:00
Adrian Cole
33745cdeb1
Merge pull request #1502 from abayer/listnodesdetails-work
...
Adding listNodesByIds across the board.
2013-04-08 20:00:18 -07:00
Andrew Bayer
c566418d87
Adding listNodesByIds across the board.
...
Adding to both ListNodesStrategy and ComputeServiceAdapter. When
possible, does a query explicitly for the specified IDs. When not,
falls back on either listDetailsOnNodesMatching (for ListNodesStrategy
implementations and in BaseComputeService) or filters listNodes output
itself (in ComputeServiceAdapter).
2013-04-08 17:21:01 -07:00
adriancole
88871c9fe9
issue #1501 : add Closeable annotation to all top-level apis
2013-04-08 16:13:09 -07:00
Andrew Gaul
371db8d18f
Address Xlint warnings
2013-03-13 22:23:19 -07:00
Andrew Gaul
ff42fdfa13
Address FindBugs warnings
2013-02-24 20:17:50 -08:00
Andrew Gaul
1f995879d6
Address FindBugs errors
2013-02-22 20:59:29 -08:00
adriancole
a51e6a8323
issue #1089 removed default timeout values so that those not using async will have simpler debugging
2013-01-29 04:19:00 -08:00
Adrian Cole
21ab1ae836
switched to use SocketOpen from guice
2013-01-19 20:06:18 -08:00
Adrian Cole
37e587ee51
changes related to centralizing construction of invokables
2013-01-19 17:17:30 -08:00
Adrian Cole
4980367991
centralize TypeToken creation
2013-01-19 11:31:55 -08:00
Adrian Cole
a49a060152
There can be only one retryable predicate; use Predicates2.retry decorator
2013-01-13 20:30:34 -08:00
Adrian Cole
3962b30808
updated to use standard guava Futures and ListenableFuture
2013-01-13 09:31:10 -08:00
Adrian Cole
47c215c63c
removed custom guava code for scoped binding and type params
2013-01-08 22:48:10 -08:00
Adrian Cole
2480481835
dependent changes on tests and internal classes
2013-01-08 00:32:45 -08:00
Adrian Cole
74c633f90a
moved all providers and test cases from j.l.r.Method -> Invokable
2013-01-05 18:51:38 -08:00
Adrian Cole
42c7037a59
removed unused code or duplicated code; moved code only used once to where its used
2013-01-01 00:08:34 -08:00
Adrian Cole
e1afa8c516
transitioned from FindResourceInSet to FluentIterable
2012-12-31 22:11:34 -08:00