d82868cc47
Replace embedded and repackaged GSON library
...
Replace substituted GSON package names with those provided from the vendor.
Reduce OSGi-metadata declaration of core-module because the artificial package org.jclouds.json.gson.internal was removed.
Remove the Gson module its children Gson bundle, and Gson shaded.
Remove duplication conflict and check-style rules due to the removal of the internal Gson module.
Add maven repository where a custom version of the Gson library gets hosted, which exports all packages.
Remove particular repository
Remove the declaration of the repository that serves a custom build GSON version. The build uses GSON in its original form of the vendor, which gets distributed through the standard distribution channel. The identifiers for group, artifact, and version correspond to the latest stable release of GSON.
Integrate GSON library in Clouds Core Bundle
The change contained in the commit puts the GSON library into the classpath of the JClouds core module.
After several tests with Karaf and Karaf JClouds, especially if the Maven identifier matches the original GSON library, there are only a limited number of ways to keep the deployment effort low.
Specifically, Karaf has a set of predefined Maven repositories that can be easily customized. The order in which a particular repository is resolved into the customized GSON library is more difficult. In normal OSGi applications, which do not have such a management function, I imagine this configuration to be more complicated. Sure, a unique identifier would help, but then we are back to step 1.
Although I honestly don't like to see this kind of approach in a codebase I'm working with, there are not many alternatives to the main aspect of deployment mentioned above.
Maybe the approach can still ease the problem in the short term. In a further mid-term step, however, this problem must be addressed in general.
2020-10-26 19:58:41 +09:00
b8606a10dd
JCLOUDS-1166: Relocate the gson internal packge to be able to keep using it ( #35 )
...
* JCLOUDS-1166: Relocate the gson internal packge to be able to keep using it
* Fixes
* Fix import order and shaded jar
* More fixes
* Proper dependency configuration
* Fix typos
* Bring back duplicate exclusions
2019-06-17 17:43:29 +02:00
92a3c68838
JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs ( #27 )
...
* Fix NoWhitespaceBefore Checkstyle Violation
* checkstyle updates: remove suppressionsfilter from checkstyle.xml
* suppressions now done in maven-checkstyle-plugin
2019-05-07 11:49:54 +02:00
d51d6e44bc
JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility ( #25 )
...
* JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility
* increase maven-compiler-plugin version
* A space change to trigger jenkins again
* Another space change to trigger jenkins again
2019-04-24 16:12:45 +02:00
7787b50067
Enforce no illegal testng imports
...
Follow on to 46493ed3b5
2015-06-25 13:34:10 -07:00
d804e73467
Avoid AutoValue shaded imports
2015-06-10 13:11:35 +02:00
efd4aa8bcf
Ensures files generated on Windows while building are not checked.
2015-04-21 17:23:54 -05:00
56e687f497
Do not allow Windows line endings
2015-03-31 18:25:54 -07:00
1eb9cd245d
Aligning indents in checkstyle config file
2014-10-03 08:38:09 -05:00
2d70087bfa
Add modernizer-maven-plugin to build
...
This plugin finds uses of legacy APIs:
https://github.com/andrewgaul/modernizer-maven-plugin
2014-09-22 21:57:55 -07:00
b9f54a3301
Enforce that interfaces are types via Checkstyle
2014-09-20 18:48:40 -07:00
18046cd3c7
Whitespace fix.
2014-09-15 17:11:40 -05:00
816e70ea7b
jclouds has to use git core.autocrlf false (or LF line endings) to pass tests. Without this checkstyle setting, checkstyle fails on windows (looking for CRLF).
2014-09-15 13:41:35 -05:00
34cfdbe266
Enforce Override annotation via Checkstyle
...
Also remove bogus inheritDoc on base and static methods.
2014-08-31 19:37:50 -07:00
df94527056
Ensure no calls to primitive wrapper constructors
2014-08-26 17:51:29 -07:00
92d5091845
Enforce no redundant modifiers via Checkstyle
...
This check also helps find utility classes which should not allow
instantiation.
2014-08-26 17:38:21 -07:00
967f55c2e4
Enforce type naming via Checkstyle
2014-08-26 11:29:25 -07:00
bf678edb97
Enforce no leading or trailing spurious whitespace
2014-08-26 11:16:24 -07:00
8b16bf0e47
Enforce whitespace after semicolon
2014-08-26 11:06:16 -07:00
192785dbae
Move checkstyle copyright header into checkstyle.xml
2014-08-18 18:55:52 -06:00
4e166e3a20
Enforce ASF copyright header via Checkstyle
2014-08-11 10:26:43 -07:00
322ea1cbb3
Allow Javadoc to reference imports
...
These style errors continue to creep in due to IDE misconfiguration so
we might as well stop checking for it.
2014-07-26 11:03:58 -07:00
4c74b49754
JCLOUDS-546: Enforce no Javadoc @author annotation
2014-06-07 21:44:58 -07:00
67c2b5f6b9
Enable whitespace around Checkstyle rule
2014-05-08 18:31:47 -07:00
2d88f5164e
Enforce that all commas have trailing whitespace
2014-05-08 18:28:08 -07:00
0398276be3
Remove redundant imports
...
Also enforce no new ones via Checkstyle
2013-12-12 18:23:43 -08:00
828d8790c2
Enforce no unused imports via Checkstyle
...
Removed with:
mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
2013-12-11 17:27:43 -08:00
17ce72794c
Enable RedundantModifier for Checkstyle
2013-10-31 10:23:30 -07:00
335f5943f4
JCLOUDS-149: Reuse checkstyle configuration
2013-07-02 18:02:03 +02:00
8aeed868f4
Move license header after opening <?xml... in Checkstyle config
2013-05-24 17:08:52 -04:00
f1b8ca1ff2
JCLOUDS-31. manually adjusted license header on checkstyle and terremark xml files
2013-05-16 21:30:32 -07:00
7923009eb5
JCLOUDS-37. Fix RAT violations in incubator-jclouds, master branch
2013-05-13 19:17:50 -07:00
fff2fa6e05
Address Checkstyle violations
...
This commit requires temporarily disabling some checks.
2013-04-17 16:21:21 -07:00
878ec1bcab
undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false
2012-11-18 09:23:44 -08:00
b9e4543cdb
Enforce no use of star imports via Checkstyle
2012-11-13 20:51:59 -08:00
d7380114a6
Enforce use of Atomics.newReference via Checkstyle
...
Avoids duplicating types.
2012-11-12 11:56:48 -08:00
42a3f4a3f9
Enforce use of StringBuilder via Checkstyle
...
Callers usually do not intend to use a synchronized StringBuffer.
EasyMock requires use of StringBuffer in some situations.
2012-11-12 08:24:36 -08:00
3ad36d25d5
Enforce no unnecessary parentheses via Checkstyle
2012-11-10 13:22:12 -08:00
a601f63a9a
Disable Checkstyle line length checks
...
While we would like to enforce this, we have too many violations to do
this in the near-term.
2012-11-10 13:07:02 -08:00
de82496aae
Ensure simple boolean expressions via Checkstyle
2012-11-05 11:41:16 -08:00
64a8fd0cbb
Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
...
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
3d191253ec
Enforce use of Collection helpers via Checkstyle
...
This ensures that we do not repeat the type name. Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
9d643b569a
Enforce a single variable declaration per line
2012-11-04 17:37:16 -08:00
41154d552c
Enforce no illegal throws via Checkstyle
...
Also remove a stray unused import.
2012-11-04 15:48:44 -08:00
08b9982384
Enforce modifier order via Checkstyle
...
Also fix violations, via:
find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
88d53b8792
Enforce no empty statements via Checkstyle
2012-11-01 18:59:18 -07:00
93d69ece2b
Enforce newline at end of file via Checkstyle
...
Also address all warnings, via:
find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
709ca69a2d
Enforce that all imports are used via Checkstyle
...
Also remove all unused imports, via:
mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
44f6318759
Add Checkstyle configuration for line length
...
Enforces line length of 120 characters, which fails due to many
violations.
2012-10-26 10:11:42 -07:00
gurkerl83
Ignasi Barrera
Olaf Flebbe
Andrew Gaul
Zack Shoylev
Andrew Phillips
Chris Custine
Ignasi Barrera
Andrew Phillips
adriancole
Andrew Bayer
Andrew Gaul
Adrian Cole
Adrian Cole