Commit Graph

7127 Commits

Author SHA1 Message Date
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Adrian Cole 760824800e Merge pull request #959 from andrewgaul/checkstyle-multiple-variable-declarations
Enforce a single variable declaration per line
2012-11-05 11:36:32 -08:00
Adrian Cole 6eb0cd197f Merge pull request #945 from nacx/scriptbuilder-install
Improved setupPublicCurl script
2012-11-05 11:30:44 -08:00
Adrian Cole 1ff91e508d Merge pull request #960 from andrewgaul/filesystem-blobkeys-container
Ensure that callers get a well-behaving Set
2012-11-05 11:26:59 -08:00
Adrian Cole 63602feb2c refactored cloudstack expect tests and added CloudStackComputeServiceAdapterExpectTest 2012-11-05 11:28:01 -03:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul ffc2fb0eb4 Ensure that callers get a well-behaving Set
Returning a container with a custom add method could confuse callers.
Provide same functionality via Function.
2012-11-04 19:31:31 -08:00
Andrew Gaul 9d643b569a Enforce a single variable declaration per line 2012-11-04 17:37:16 -08:00
Adrian Cole 55025c0764 Merge pull request #954 from andrewgaul/specific-asserts
Prefer specific asserts where possible
2012-11-04 17:24:47 -08:00
Adrian Cole c00ef4c941 Merge pull request #956 from andrewgaul/checkstyle-illegal-throws
Enforce no illegal throws via Checkstyle
2012-11-04 17:14:14 -08:00
Adrian Cole f1333801dd Merge pull request #953 from aledsage/Setting-RunScriptOnNode.Factory
Setting RunScriptOnNode.factory
2012-11-04 17:12:18 -08:00
Andrew Gaul b7bd46282b Merge pull request #955 from jclouds/base64-urlsafe
Issue 1120: support base64 encode/decode for url applications
2012-11-04 16:39:54 -08:00
Andrew Gaul 41154d552c Enforce no illegal throws via Checkstyle
Also remove a stray unused import.
2012-11-04 15:48:44 -08:00
Adrian Cole 2c900d1bab Issue 1120: support base64 encode/decode for url applications 2012-11-04 15:38:13 -08:00
Adrian Cole f4333157b9 make tests that decode credentials use valid base64 encoded strings 2012-11-04 15:37:49 -08:00
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Aled Sage 43d6155341 Set EC2 windows-template image id for testing
- Identify the windows-template AMI using id rather than name-matching
2012-11-04 22:29:52 +00:00
Aled Sage 3f3037c729 Support for setting RunScriptOnNode.Factory
- Set default RunScriptOnNode.Factory impl using @ImplementedBy,
  rather than hardcoding the binding
2012-11-04 22:29:52 +00:00
Ignasi Barrera 652bc2f75e Improved setupPublicCurl script
With this changes, apt and yum helper functions can be used to install
many packages at one as follows:
ensure_cmd_or_install_package_apt git git-core build-essentials <...>
2012-11-04 19:43:39 +01:00
Adrian Cole 9212d4ff26 Merge pull request #952 from jclouds/remote-resources-plugin-version
update and centralize plugin version for maven-remote-resources-plugin
2012-11-04 09:11:49 -08:00
Adrian Cole beb36eac75 Merge pull request #940 from andrewgaul/checkstyle-misc
Miscellaneous Checkstyle fixes
2012-11-04 08:50:47 -08:00
Adrian Cole 7bc40e7fd5 Merge pull request #949 from andrewgaul/assert-fail
Prefer Assert.fail over assert
2012-11-04 08:45:03 -08:00
Adrian Cole 1c2f550600 Merge pull request #951 from andrewgaul/java-7-gogrid
Implement Comparable in GoGrid ErrorResponse
2012-11-04 08:43:45 -08:00
Adrian Cole a63f927deb Issue 1116: update and centralize plugin version for maven-remote-resources-plugin 2012-11-04 08:32:56 -08:00
Adrian Cole 14c056a077 Merge pull request #944 from andrewgaul/sshj-remove-commons-io
Remove commons-io dependency from sshj
2012-11-04 07:30:29 -08:00
Adrian Cole d0b83b88d5 Merge pull request #928 from andrewgaul/maven-plugins
Upgrade Maven plugins
2012-11-04 07:28:31 -08:00
Andrew Gaul b4eaa4330e Upgrade Maven plugins
Also specify minimum Maven version.

Test with mvn versions:display-plugin-updates
2012-11-03 18:17:03 -07:00
Andrew Gaul 0e35b3f623 Implement Comparable in GoGrid ErrorResponse
Gson collects errors in a TreeMap which requires a well-behaved
Comparable method.  This addresses a Java 7 GoGrid failure seen in
GridServerClientExpectTest.testGetServerCredentialsWhenNotFoundThrowsResourceNotFoundExceptionWithNiceMessage:

java.lang.ClassCastException: org.jclouds.gogrid.domain.internal.ErrorResponse cannot be cast to java.lang.Comparable
2012-11-03 17:08:43 -07:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Adrian Cole 10ab929097 Merge pull request #947 from andrewgaul/virtualbox-remove-commons-io
Remove commons-io dependency from virtualbox
2012-11-03 11:47:43 -07:00
Andrew Gaul 281172e637 Remove commons-io dependency from virtualbox 2012-11-03 11:03:58 -07:00
Adrian Cole 6d0071401c Merge pull request #946 from andrewgaul/jsch-remove-commons-io
Remove commons-io dependency from jsch
2012-11-03 10:43:19 -07:00
Andrew Gaul 981b0d047f Remove commons-io dependency from jsch
FilterInputStream suffices since we only override close and we can get
away with using java.io.ByteArrayOutputStream.
2012-11-03 10:29:48 -07:00
Andrew Gaul f94ee03626 Remove commons-io dependency from sshj
FilterInputStream suffices since we only override close.
2012-11-02 16:07:36 -07:00
Adrian Cole ea75c96560 Merge pull request #938 from andrewgaul/clear-container-cancel-futures
Cancel Futures in clearContainer
2012-11-02 09:56:50 -07:00
Adrian Cole bce3b0f2e6 Merge pull request #941 from andrewgaul/checkstyle-modifier-order
Enforce modifier order via Checkstyle
2012-11-02 09:55:23 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Adrian Cole d4c01e6c2e Merge pull request #939 from andrewgaul/checkstyle-empty-statement
Enforce no empty statements via Checkstyle
2012-11-01 19:49:34 -07:00
Andrew Gaul 38b95f5ad9 Miscellaneous Checkstyle fixes
Nothing can extend a byte[] and remove a previous hidden unused import.
2012-11-01 19:11:59 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 76a5538229 Cancel Futures in clearContainer
This prevents Futures from hanging around on exceptional code paths like
interrupts and timeouts.
2012-11-01 17:18:38 -07:00
Adrian Cole ddbb41130d Merge pull request #935 from andrewgaul/spelling
Correct typos
2012-11-01 15:23:34 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole d4eb847a55 Merge pull request #936 from abiquo/cleanup-strategies
Cleanup unnecessary strategies
2012-11-01 13:12:32 -07:00
Adrian Cole 5dad12764e Merge pull request #937 from andrewgaul/mailmap
.mailmap updates
2012-11-01 13:12:21 -07:00
Adrian Cole 4c72c5c803 Merge pull request #927 from iocanel/jclouds-osgi-fixes
Jclouds osgi fixes
2012-11-01 13:12:01 -07:00
Andrew Gaul dc2f60fd17 .mailmap updates 2012-10-31 15:08:04 -07:00
Ignasi Barrera f39c1add89 Removed all unnecessary interfaces from strategies
Removed all interfaces from the strategy classes that only have one
implementation.
2012-10-31 19:00:32 +01:00
Adrian Cole 308416b7b2 Merge pull request #934 from andrewgaul/filesystem-remove-ioutils
Remove filesystem dependency on Apache commons-io
2012-10-31 10:54:59 -07:00
Ignasi Barrera 5ba08d8448 Cleanup unnecessary strategies
Removed all over engineering introduced by strategies that did
not perform anything else than a simple api call.
2012-10-31 18:46:16 +01:00